Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
>> It is ONLY required when the runtime is Java 8 or lower AND you need to >> read the module descriptors. thx for clarifying. Am i right if I say that it would happen with J9/Toolchain used in Compiler but J8 in the Maven build? Is it realistic? Maybe some people would do it due to some other

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Robert Scholte
On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau wrote: Le sam. 12 oct. 2019 à 13:33, Robert Scholte a écrit : As far as I know, surefire won't touch the Plexus Java code that requires ASM. It is ONLY required when the runtime is Java 8 or lower AND you need to read the module

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
Because i understood you talking about relocating ASM within Surefire here in this thread. It did not make sense for me since the ASM always has to adapt to a new bytecode. So you mean relocating ASM in the m-shade-p, right? User's dependencies are loaded in a separate classloader, no need to

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Romain Manni-Bucau
Not sure what you meant Tibor, just completed that relocation can need asm upgrade in shade plugin - if we dont want users to do it in the pom which is ok/needed if they use new java versions. Le sam. 12 oct. 2019 à 20:24, Tibor Digana a écrit : > Relocation is useless. The ASM is changed

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
Relocation is useless. The ASM is changed because of the bytecode compatibility. We always had to upgrade plexus-java in the past; otherwise the users reported a bug directly or in the Stackoverflow. On Sat, Oct 12, 2019 at 1:45 PM Romain Manni-Bucau wrote: > Le sam. 12 oct. 2019 à 13:33,

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Romain Manni-Bucau
Le sam. 12 oct. 2019 à 13:33, Robert Scholte a écrit : > As far as I know, surefire won't touch the Plexus Java code that requires > ASM. > It is ONLY required when the runtime is Java 8 or lower AND you need to > read the module descriptors. > > Maven Shade is a different case: it must parse

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Robert Scholte
As far as I know, surefire won't touch the Plexus Java code that requires ASM. It is ONLY required when the runtime is Java 8 or lower AND you need to read the module descriptors. Maven Shade is a different case: it must parse the Java bytecode (and only when using minifyJar), hence it

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Romain Manni-Bucau
Have to admit I dont know, clearly a different load though. Feel free to ask Joel on the ticket. Le sam. 12 oct. 2019 à 12:49, Tibor Digana a écrit : > I have noticed this happening only with snapshot versions. The snapshot and > release repos have different h/w?! > > On Sat, Oct 12, 2019 at

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
I have noticed this happening only with snapshot versions. The snapshot and release repos have different h/w?! On Sat, Oct 12, 2019 at 12:44 PM Romain Manni-Bucau wrote: > They work on it with some rate limiting until it gets resolved. > They had some abnormal load. > > Le sam. 12 oct. 2019 à

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Romain Manni-Bucau
They work on it with some rate limiting until it gets resolved. They had some abnormal load. Le sam. 12 oct. 2019 à 12:24, Tibor Digana a écrit : > Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT. > I want to know if the bug OSSRH-51220 is fixed. > >

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT. I want to know if the bug OSSRH-51220 is fixed. https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/ On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana wrote: > Here is the pull request >

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
Here is the pull request https://github.com/codehaus-plexus/plexus-languages/pull/29 On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau wrote: > I understand and if we can we must do but not a blocker - was my point > Also keep in mind we could do the update automatically with asm versioning >

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Romain Manni-Bucau
I understand and if we can we must do but not a blocker - was my point Also keep in mind we could do the update automatically with asm versioning scheme using our resolver in the mojo. So let's fix issues for most users - once again j > 11 is a play area, not for prod today - and maybe enhance our

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
all bad, see the stackoverflow. It happens that the users argue that they have to update our dependencies which is our responsibility! On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau wrote: > Dont think there is an api version upgrade between 7.0 and 7.2 so can be > upgraded in user pom so

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Romain Manni-Bucau
Dont think there is an api version upgrade between 7.0 and 7.2 so can be upgraded in user pom so not a blocker for a milestone release IMHOj13 and j14 are still not adopted too so all good. Le sam. 12 oct. 2019 à 11:35, Tibor Digana a écrit : > We still use plexus-java:1.0.3 which depends

Re: Surefire 3.0.0-M4 release?

2019-10-12 Thread Tibor Digana
We still use plexus-java:1.0.3 which depends on ASM 7.0. The support for JDk 13 and 14 is in the version 7.2. We have similar upgrade in https://github.com/apache/maven-shade-plugin/pull/29 On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy wrote: > Hi, > It's now almost 10 months since last and