Because i understood you talking about relocating ASM within Surefire here in this thread. It did not make sense for me since the ASM always has to adapt to a new bytecode. So you mean relocating ASM in the m-shade-p, right?
User's dependencies are loaded in a separate classloader, no need to relocate (plugin's dependency) ASM in Surefire plugin because it is used only in MOJO and the plugin's dependency is not loaded to user's tests. On Sat, Oct 12, 2019 at 11:42 PM Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Not sure what you meant Tibor, just completed that relocation can need asm > upgrade in shade plugin - if we dont want users to do it in the pom which > is ok/needed if they use new java versions. > > Le sam. 12 oct. 2019 à 20:24, Tibor Digana <tibordig...@apache.org> a > écrit : > > > Relocation is useless. The ASM is changed because of the bytecode > > compatibility. We always had to upgrade plexus-java in the past; > otherwise > > the users reported a bug directly or in the Stackoverflow. > > > > On Sat, Oct 12, 2019 at 1:45 PM Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > > > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rfscho...@apache.org> a > > > écrit : > > > > > > > As far as I know, surefire won't touch the Plexus Java code that > > requires > > > > ASM. > > > > It is ONLY required when the runtime is Java 8 or lower AND you need > to > > > > read the module descriptors. > > > > > > > > Maven Shade is a different case: it must parse the Java bytecode (and > > > > only > > > > when using minifyJar), hence it needs the latest ASM. > > > > > > > > > > + Relocation ;) > > > > > > > > > > Robert > > > > > > > > On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana < > > tibordig...@apache.org > > > > > > > > > > > > wrote: > > > > > > > > > We still use plexus-java:1.0.3 which depends on ASM 7.0. > > > > > The support for JDk 13 and 14 is in the version 7.2. > > > > > We have similar upgrade in > > > > > https://github.com/apache/maven-shade-plugin/pull/29 > > > > > > > > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> > > wrote: > > > > > > > > > >> Hi, > > > > >> It's now almost 10 months since last and around 30 issues fixed. > > > > >> Maybe time for a new release? > > > > >> Moving issues still open to 3.0.0-M5? > > > > >> > > > > >> cheers > > > > >> -- > > > > >> Olivier Lamy > > > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > >
