>> It is ONLY required when the runtime is Java 8 or lower AND you need to >> read the module descriptors.
thx for clarifying. Am i right if I say that it would happen with J9/Toolchain used in Compiler but J8 in the Maven build? Is it realistic? Maybe some people would do it due to some other plugins unreliable on J9+ WDYT? On Sun, Oct 13, 2019 at 12:20 AM Robert Scholte <rfscho...@apache.org> wrote: > On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau > <rmannibu...@gmail.com> wrote: > > > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <rfscho...@apache.org> a > > écrit : > > > >> As far as I know, surefire won't touch the Plexus Java code that > >> requires > >> ASM. > >> It is ONLY required when the runtime is Java 8 or lower AND you need to > >> read the module descriptors. > >> > >> Maven Shade is a different case: it must parse the Java bytecode (and > >> only > >> when using minifyJar), hence it needs the latest ASM. > >> > > > > + Relocation ;) > > Well, the unexpected answer is actually No, see > > > https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java > > (but it might be better to do so...) > > > > > > >> Robert > >> > >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana > >> <tibordig...@apache.org> > >> > >> wrote: > >> > >> > We still use plexus-java:1.0.3 which depends on ASM 7.0. > >> > The support for JDk 13 and 14 is in the version 7.2. > >> > We have similar upgrade in > >> > https://github.com/apache/maven-shade-plugin/pull/29 > >> > > >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <ol...@apache.org> > wrote: > >> > > >> >> Hi, > >> >> It's now almost 10 months since last and around 30 issues fixed. > >> >> Maybe time for a new release? > >> >> Moving issues still open to 3.0.0-M5? > >> >> > >> >> cheers > >> >> -- > >> >> Olivier Lamy > >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
