as discusses in the Jira issue, the cache on Version Range is simple and very
efficient
can someone review and second for merge to master?
Regards,
Hervé
Le mercredi 23 janvier 2019, 11:07:43 CET Hervé BOUTEMY a écrit :
> Hi,
>
> Interesting.
> I created MNG-6571 to track this issue: please
I'm still computing the retained references but the first results look great.
Dump file once reactor is computed moved from 14Gb to 7.4Gb (I didn't let the
build run to the end).
Instances of VersionRange moved from 5 million to 6525. The cache has a
positive impact on the String instances,
Hi,
Interesting.
I created MNG-6571 to track this issue: please move the memory dump on this
issue.
Then I created MNG-6571 branch [2] with a cache on VersionRange: this class is
currently immutable, then caching it is trivial. I don't know if it's the best
location, or if there are not other
Hi,
I'm working on a huge project with plenty modules and we are facing a memory
consumption issue. We observed it when Maven computes the reactor and then
during the build itself.
Quick summary of our situation (as we can't share the POMs)
* We have a dedicated POM to manage all
Hi Igor,
On 6/3/16 5:27 AM, Igor Fedorenko wrote:
I wonder if this fix also solves "remote shared parent" memory
inefficiency described in https://issues.apache.org/jira/browse/MNG-5669
So doing some research...
The DefaultProjectBuilder contains a method:
private ModelData readParent(
That sounds good to. Its awesome that this has been done and merged and will go
out with the next release.
Manfred
Jason Dillon wrote on 2016-06-02 21:05:
> If its on by default I would expect folks to set
> MAVEN_OPTS=-Dmaven.logging=plain instead of magically making —batch do that.
>
> If
colors for Linux are not exactly the same as the screen dump: yellow from the
screen dump is bold white on Linux. This is ok for me
Terminals can render whatever colors they want for the ANSI colors and many
have this configurable.
To be clear my terminal env has bold color rendering as yellow
If its on by default I would expect folks to set
MAVEN_OPTS=-Dmaven.logging=plain instead of magically making —batch do that.
If we mutate the cli api slightly to expose more details about the cli
configuration to the Slf4jConfiguration then regular -Dmaven.logging=plain on
command line would
On June 2, 2016 at 3:15:35 PM, Hervé BOUTEMY (herve.bout...@free.fr) wrote:
I merged the PR in the slf4j-gossip branch (and added a little improvement)
core ITs are ok (notice: ran without activating colors)
The testsuite certainly will not be very happy with color enabled as many tests
are
Somewhat related, Jason convinced me to opensource better logging
support for multithreaded builds I implemented some time ago.
https://github.com/takari/concurrent-build-logger
--
Regards,
Igor
On Thu, Jun 2, 2016, at 11:37 PM, Manfred Moser wrote:
> If we plan to switch it to on be default
If we plan to switch it to on be default at a later stage we could
automatically disable it in batch mode. And tell people to run in batch mode on
a CI server.
Just a thought..
Manfred
Jason van Zyl wrote on 2016-06-02 19:52:
> If the output comes out decently in color in CI consoles then
I wonder if this fix also solves "remote shared parent" memory
inefficiency described in https://issues.apache.org/jira/browse/MNG-5669
--
Regards,
Igor
On Tue, May 31, 2016, at 06:14 PM, Karl Heinz Marbaise wrote:
> Hi,
>
> tested without the patch (-Xmx6g) ...run time for the test project
If the output comes out decently in color in CI consoles then it’s probably not
an issue putting the color on by default. But I haven’t checked and suggested
that the color be off by default to start with.
> On Jun 2, 2016, at 5:15 PM, Hervé BOUTEMY wrote:
>
> I merged
I merged the PR in the slf4j-gossip branch (and added a little improvement)
core ITs are ok (notice: ran without activating colors)
colors for Linux are not exactly the same as the screen dump: yellow from the
screen dump is bold white on Linux. This is ok for me
Now, what's annoying is that:
-
Olivier, if you refer to the slf4j-gossip branch, that IMHO Jason's PR
supersedes it.
Will drop that branch.
On Thu, Jun 2, 2016 at 8:38 AM Olivier Lamy wrote:
> well I think this color stuff has already been done differently but never
> accepted..
>
> On 2 June 2016 at
well I think this color stuff has already been done differently but never
accepted..
On 2 June 2016 at 16:28, Hervé BOUTEMY wrote:
> another feature that would be great for this release:
> https://github.com/apache/maven/pull/81
>
> I still didn't have time to work on
another feature that would be great for this release:
https://github.com/apache/maven/pull/81
I still didn't have time to work on it, but I like the screenshot
The only thing that I'd like to check is: is tty detection working? ie does
color automatically disappear if there is no tty?
Regards,
+1
this is something that was often seen: this is great that it is fixed!
For example, the last time I published Maven core site, the build simply
failed because of PermgenSpace: now it is working like a charm...
This release will be a must!
Regards,
Hervé
Le mercredi 1 juin 2016 20:12:33
Hi Manfred,
On 6/1/16 12:24 AM, Manfred Moser wrote:
I can feel your excitement coming through in the emails.. ;-)
Of course I'm excited ;-)
...cause it's very important...I have had heard many customers saying
they will not upgrade to newer versions of Maven exactly based on such
I somehow assume the original patch that caused this behaviour was created
due to memory leaks in embedded mode. Do de have any way to handle both ?
(I'm wondering if we have any scope that is bound to the current embedsed
execution)
(I'm all i favour of this change no matter what...)
I can feel your excitement coming through in the emails.. ;-)
Karl Heinz Marbaise wrote on 2016-05-31 15:14:
> Hi,
>
> tested without the patch (-Xmx6g) ...run time for the test project more
> than two 2 Minutes
>
> running with the patch (-Xmx1g):
>
> Run time ca. 27 seconds...
>
>
Hi,
tested without the patch (-Xmx6g) ...run time for the test project more
than two 2 Minutes
running with the patch (-Xmx1g):
Run time ca. 27 seconds...
also worked with -Xmx768m ...ca. 30 seconds...
so looks very good...
Let us wait what the IT's say...
Kind regards
Karl Heinz
Hi,
after more investigation and an extremly good tip of Andriy...(see
MNG-6030) and in the end the solution:
Using test project with 5000 modules just doing:
mvn clean
using the patch now in master (41144e7ecf52e7ec3850f3e78d81f42f505f4af8)
extremely reduces the memory footprint...
Hi,
i started a little bit more detailed analysis..
very simple via JConsole and running the different versions...
I have summarized this here:
https://github.com/khmarbaise/maven-test-project-generator
Kind regards
Karl Heinz Marbaise
On 4/17/16 5:50 PM, Karl Heinz Marbaise wrote:
Hi to
Am 04/18/16 um 01:39 schrieb Christian Schulte:
> Am 04/17/16 um 18:08 schrieb Bernd Eckenfels:
>> Hello,
>>
>> I wondered about that as well. It was discussed 2012 on maven-dev. The
>> statement looks like this:
>>
>> # Runtime r = Runtime.getRuntime();
>> # long MB = 1024 * 1024;
>> # "Final
Am 04/17/16 um 18:08 schrieb Bernd Eckenfels:
> Hello,
>
> I wondered about that as well. It was discussed 2012 on maven-dev. The
> statement looks like this:
>
> # Runtime r = Runtime.getRuntime();
> # long MB = 1024 * 1024;
> # "Final Memory: " + ( r.totalMemory() - r.freeMemory() ) / MB +
Hello,
I wondered about that as well. It was discussed 2012 on maven-dev. The
statement looks like this:
# Runtime r = Runtime.getRuntime();
# long MB = 1024 * 1024;
# "Final Memory: " + ( r.totalMemory() - r.freeMemory() ) / MB + "M/" +
r.totalMemory() / MB + "M"
So this basically prints the
Hi to all,
i have a question concerning the memory consumption...
If i run maven with the same JDK and the same reactor and build with the
same parameter and plugins...
will the printout at the end of the build (Final Memory) something
realiable about the consumption of the JVM during the
28 matches
Mail list logo