Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

Le jeudi 23 juin 2016 21:39:02 Robert Scholte a écrit : > >> > - move code to maven-shared-utils: the drawback here is to add jansi > >> > dependency to the artifact. > >> > >> That would pull in maven-shared-utils next to plexus-utils, which are > >> comparable and shouldn't be mixed due to

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

On Thu, 23 Jun 2016 21:27:57 +0200, Hervé BOUTEMY wrote: Le jeudi 23 juin 2016 19:54:58 Robert Scholte a écrit : > thinking more about it. > Yes, having Maven core depending on maven-project-utils, which dependes > on > maven-core, will cause issues: I already had

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

Le jeudi 23 juin 2016 19:54:58 Robert Scholte a écrit : > > thinking more about it. > > Yes, having Maven core depending on maven-project-utils, which dependes > > on > > maven-core, will cause issues: I already had to add an exclusion to > > avoid a > > build tests failure... > > > > Where to

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

thinking more about it. Yes, having Maven core depending on maven-project-utils, which dependes on maven-core, will cause issues: I already had to add an exclusion to avoid a build tests failure... Where to put AnsiUtils? I see multiple options: - a new Maven core module: the drawback I see

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

Am 06/22/16 um 23:41 schrieb Hervé BOUTEMY: > - move code to maven-shared-utils: the drawback here is to add jansi > dependency to the artifact. +1 Just flag it 'optional' so that people not using the Ansi related classes do not get it on the classpath and do not need to exclude it everywhere.

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

thinking more about it. Yes, having Maven core depending on maven-project-utils, which dependes on maven-core, will cause issues: I already had to add an exclusion to avoid a build tests failure... Where to put AnsiUtils? I see multiple options: - a new Maven core module: the drawback I see is

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

Le lundi 20 juin 2016 20:33:26 Christian Schulte a écrit : > Am 06/20/16 um 19:15 schrieb Robert Scholte: > > Hi Christian, > > > > when I introduced the maven-project-utils I had a library in mind with > > helpful MavenProject related methods for multiple plugins. For that reason > > I didn't

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

Am 06/20/16 um 19:15 schrieb Robert Scholte: > Hi Christian, > > when I introduced the maven-project-utils I had a library in mind with > helpful MavenProject related methods for multiple plugins. For that reason > I didn't make it part of the Maven distribution. > With this commit the

Re: [2/5] maven git commit: [MNG-3507] use AnsiUtils API to use colors consistently

Hi Christian, when I introduced the maven-project-utils I had a library in mind with helpful MavenProject related methods for multiple plugins. For that reason I didn't make it part of the Maven distribution. With this commit the library suddenly is required. Instead I think you should use