[CANCELLED] Re: [VOTE] Maven 3.3.5

2015-07-27 Thread Jason van Zyl
On Jul 20, 2015, at 3:23 PM, Jason van Zyl ja...@takari.io wrote: Hi, Time to release Maven 3.3.5! Here is a link to the issues resolved: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922version=12333058 Staging repo:

Re: [VOTE] Maven 3.3.5

2015-07-27 Thread Jason van Zyl
On Jul 27, 2015, at 6:55 AM, Stephen Connolly stephen.alan.conno...@gmail.com wrote: Igor found an issue, and added an IT test to catch the issue. I fixed the issue with a hack and added an IT test to fail for the hack... Then I superceded the hack with a fuller fix:

Re: [VOTE] Maven 3.3.5

2015-07-27 Thread Stephen Connolly
Igor found an issue, and added an IT test to catch the issue. I fixed the issue with a hack and added an IT test to fail for the hack... Then I superceded the hack with a fuller fix: https://github.com/apache/maven/commit/bd87258629db8e3fcc7aa04777afc16314c3cde0 Long term I am not 100% happy

Re: [VOTE] Maven 3.3.5

2015-07-27 Thread Stephen Connolly
Here is the TL;DR 3.3.5 is dead. 3.3.6 is ready to roll On 27 July 2015 at 11:55, Stephen Connolly stephen.alan.conno...@gmail.com wrote: Igor found an issue, and added an IT test to catch the issue. I fixed the issue with a hack and added an IT test to fail for the hack... Then I

Re: [VOTE] Maven 3.3.5

2015-07-26 Thread Jason van Zyl
So where did we get with this? Igor reported an issue but I had spotty internet where I was and I can’t see the message. Should I cancel this release? Stephen is there something you need to fix or is it done, and then shall I re-roll? On Jul 20, 2015, at 3:25 PM, Jason van Zyl ja...@takari.io

Re: [VOTE] Maven 3.3.5

2015-07-24 Thread Jörg Schaible
Hi Karl Heinz, Karl Heinz Marbaise wrote: Hi, = % = $ MAVEN_OPTS=-Xmx4096m mvn validate Why are you setting to 4 GiB ? but for Maven 3.0.5 you only setting to 1.5 GiB ? Because with M305 I *can* build the project with just 1.5 GB, but M33x

Re: [VOTE] Maven 3.3.5

2015-07-24 Thread Jörg Schaible
Hi Igor, Igor Fedorenko wrote: I am pretty sure somebody provided an example project that showed memory increase in Maven 3.2.x some time last year iirc. That was me. I've provided everything to run mvn validate on the project tree. I have that archive still around. Could have been direct

Re: [VOTE] Maven 3.3.5

2015-07-24 Thread Jörg Schaible
Hi Christian, Kristian Rosenvold wrote: You still do not have any publicly available project to reproduce this ? Unfortunately it is not public. But I have (still) an archive with a project tree containing anything required to run mvn validate (incl. the remote repos and the local repo).

Re: [VOTE] Maven 3.3.5

2015-07-24 Thread Mirko Friedenhagen
Hello Jörg, this seems to be a really big project. We have a similar situation (department-pom, which manages a lot of external dependencies and internal dependencies as well as plugin versions and even executions). And of course the internal dependencies use different versions of this department

Re: [VOTE] Maven 3.3.5

2015-07-24 Thread Jörg Schaible
Hi Karl Heinz, Karl Heinz Marbaise wrote: Hi, On 7/24/15 9:35 AM, Jörg Schaible wrote: Hi Karl Heinz, Karl Heinz Marbaise wrote: Hi, = % = $ MAVEN_OPTS=-Xmx4096m mvn validate Why are you setting to 4 GiB ? but for Maven 3.0.5 you only

Re: [VOTE] Maven 3.3.5

2015-07-24 Thread Karl Heinz Marbaise
Hi, On 7/24/15 9:35 AM, Jörg Schaible wrote: Hi Karl Heinz, Karl Heinz Marbaise wrote: Hi, = % = $ MAVEN_OPTS=-Xmx4096m mvn validate Why are you setting to 4 GiB ? but for Maven 3.0.5 you only setting to 1.5 GiB ? Because with M305 I *can* build

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Igor Fedorenko
I am pretty sure somebody provided an example project that showed memory increase in Maven 3.2.x some time last year iirc. Could have been direct email, not 100% sure. From what I remember, the problem was triggered by specific way to reference parent pom, this is why only few projects are

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Anton Tanasenko
Hi Jörg, The error message you posted says that java is unable to allocate 500mb of heap. The machine you were running it on didn't have that much available at the time. 2015-07-23 15:47 GMT+03:00 Jörg Schaible joerg.schai...@swisspost.com: Hi folks, M335 needs even more memory (see also

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Jörg Schaible
Hi folks, M335 needs even more memory (see also http://thread.gmane.org/gmane.comp.jakarta.turbine.maven.devel/116287). Maven 3.3.x is for me now simply unusable at all: = % = $ MAVEN_OPTS=-Xmx4096m mvn validate [INFO] Scanning for projects... Downloading:

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Jörg Schaible
Hi Anton, Anton Tanasenko wrote: Hi Jörg, The error message you posted says that java is unable to allocate 500mb of heap. The machine you were running it on didn't have that much available at the time. If you think it is normal that I have to close Eclipse just to call mvn validate ...

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Jörg Schaible
Jörg Schaible wrote: Hi Anton, Anton Tanasenko wrote: Hi Jörg, The error message you posted says that java is unable to allocate 500mb of heap. The machine you were running it on didn't have that much available at the time. If you think it is normal that I have to close Eclipse

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Karl Heinz Marbaise
Hi, = % = $ MAVEN_OPTS=-Xmx4096m mvn validate Why are you setting to 4 GiB ? but for Maven 3.0.5 you only setting to 1.5 GiB ? Back to M305 now, -Xmx1500m is enough ... Kind regards Karl Heinz Marbaise

Re: [VOTE] Maven 3.3.5

2015-07-23 Thread Kristian Rosenvold
You still do not have any publicly available project to reproduce this ? Every time you complain about this I have compared 3.0.5 and 3.3.3, and every time I get the same result; 3.3.3 might have about 10% more allocated objects overall when compared to 3.0.5. There is something about your

Re: [VOTE] Maven 3.3.5

2015-07-22 Thread Stephen Connolly
OK so MNG-2199 introduced the regression MNG-5840 There was a claim in the introduction of MNG-2199 that there was some validation in the workspace resolver:

Re: [VOTE] Maven 3.3.5

2015-07-22 Thread Stephen Connolly
Igor, Seems that we are missing integration tests for that feature. I suspect that this is a regression introduced in fixing the MNG-5840 regression. I have committed a partial fix (i.e. fixes MNG-5840 for non-version ranges) and I have some integration tests for with version ranges to see if

Re: [VOTE] Maven 3.3.5

2015-07-22 Thread Mark Derricutt
On 22 Jul 2015, at 11:57, Igor Fedorenko wrote: There is a regression with parent pom version range support (see MNG-2199 [1]) when locating locally-available parent pom. I've pushed MavenITmng2199ParentVersionRangeTest#testValidLocalParentVersionRange regression test [2] to demonstrate the

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Stephen Connolly
FYI Tibor, that is not a regression against 3.3.3 from my understanding On 21 July 2015 at 14:30, Tibor Digana tibordig...@apache.org wrote: +0 (non-binding) The IntelliJ IDEA does not launch Maven build. It looks like the reason is that we changed file name from bin/mvn.bat to bin/mvn.cmd.

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Karl Heinz Marbaise
+1 from me... Docs updated. http://maven.apache.org/ref/3-LATEST/ Kind regards Karl Heinz Marbaise On 7/20/15 9:23 PM, Jason van Zyl wrote: Hi, Time to release Maven 3.3.5! Here is a link to the issues resolved:

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Tibor Digana
+1 non-binding from me. Now my IDEA works fine with 3.3.5. On Tue, Jul 21, 2015 at 4:58 PM, stephenconnolly [via Maven] ml-node+s40175n5840520...@n5.nabble.com wrote: FYI Tibor, that is not a regression against 3.3.3 from my understanding On 21 July 2015 at 14:30, Tibor Digana [hidden email]

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread jieryn
+1 non binding, works for me and a ton of projects internally; no funky parent resolution going on here though On Tue, Jul 21, 2015 at 7:57 PM, Igor Fedorenko i...@ifedorenko.com wrote: -1 FWIW There is a regression with parent pom version range support (see MNG-2199 [1]) when locating

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Igor Fedorenko
-1 FWIW There is a regression with parent pom version range support (see MNG-2199 [1]) when locating locally-available parent pom. I've pushed MavenITmng2199ParentVersionRangeTest#testValidLocalParentVersionRange regression test [2] to demonstrate the issue. The test works with Maven 3.3.3 but

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Tamas Cservenak
+1 retested with same set of projects as last time --  Thanks, ~t~ On 20 Jul 2015 at 21:26:08, Jason van Zyl (ja...@takari.io) wrote: +1 Analyzing release validity... stagingUrl: https://repository.apache.org/content/repositories/maven-1200 groupId: org.apache.maven artifactId:

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Stephen Connolly
rat:check passes works on my test projects builds from source bundle visual inspection found no issues +1 (binding) -Stephen On 21 July 2015 at 01:07, Mark Derricutt m...@talios.com wrote: On 21 Jul 2015, at 9:15, Mirko Friedenhagen wrote: +1 non-binding. -- Mark Derricutt

Re: [VOTE] Maven 3.3.5

2015-07-21 Thread Tibor Digana
+0 (non-binding) The IntelliJ IDEA does not launch Maven build. It looks like the reason is that we changed file name from bin/mvn.bat to bin/mvn.cmd. Is it only me who has this problem in IDEA, can you check it out as well? On Mon, Jul 20, 2015 at 9:23 PM, Jason van Zyl ja...@takari.io wrote:

Re: [VOTE] Maven 3.3.5

2015-07-20 Thread Mirko Friedenhagen
+1 (non-binding), checked mojo-parent, extra-enforcer-rules, our company pom which has 6 invoker tests and another small project. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/

Re: [VOTE] Maven 3.3.5

2015-07-20 Thread Jason van Zyl
+1 Analyzing release validity... stagingUrl: https://repository.apache.org/content/repositories/maven-1200 groupId: org.apache.maven artifactId: apache-maven version: 3.3.5 Source ZIP url exists.

Re: [VOTE] Maven 3.3.5

2015-07-20 Thread Mark Derricutt
On 21 Jul 2015, at 9:15, Mirko Friedenhagen wrote: +1 non-binding. -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt signature.asc Description: OpenPGP digital