Re: Apache Maven JDeps Plugin

2015-04-13 Thread Stephen Connolly
Or maybe just integrate http://www.graphdracula.net/showcase/ into the html report and let people drag the graph to their needs. Note that the site also lists similar projects providing similar functionality, so worth checking out either way On 13 April 2015 at 08:59, Alan Bateman wrote: > On 13

Re: Apache Maven JDeps Plugin

2015-04-13 Thread Alan Bateman
On 13/04/2015 03:46, Hervé BOUTEMY wrote: last week, during DevoxxFR, Arnaud and I showed maven-jdeps-plugin: as expected, a lot of users didn't know about this tool So for sure, having this plugin and a report would help Then there is the question of: what should the report look like? Should it

Re: Apache Maven JDeps Plugin

2015-04-12 Thread Hervé BOUTEMY
notice: I made some tests, and animal-sniffer detects internals API use then failOnWarning will not be useful for people already using animal sniffer Regards, Hervé Le mardi 17 février 2015 00:04:37 Robert Scholte a écrit : > Hi Alan, > > I've added a flag called failOnWarning (default:true), a

Re: Apache Maven JDeps Plugin

2015-04-12 Thread Hervé BOUTEMY
last week, during DevoxxFR, Arnaud and I showed maven-jdeps-plugin: as expected, a lot of users didn't know about this tool So for sure, having this plugin and a report would help Then there is the question of: what should the report look like? Should it be a simple stdout dump of command line re

Re: Apache Maven JDeps Plugin

2015-02-21 Thread Mandy Chung
Thanks I'll check it out. Mandy On 2/19/2015 12:10 PM, Robert Scholte wrote: Hi Mandy, based on your proposal I've added 2 parameters: dependenciesToAnalyzeIncludes and dependenciesToAnalyzeExcludes This way it's not an All-Or-Nothing option, but instead you have full control over the depende

Re: Apache Maven JDeps Plugin

2015-02-21 Thread Robert Scholte
Op Fri, 20 Feb 2015 04:48:54 +0100 schreef Hervé BOUTEMY : ok, I just updated the index page to try to improve explanations about this unusual/new toolchains use case (ie not trying to be consistent across plugins) notice that if you use ToolchainManagerPrivate like maven-toolchains-plugi

Re: Apache Maven JDeps Plugin

2015-02-20 Thread Martijn Verburg
>From my standpoint that would be amazing - we'd always struggled with how we're going to try and educate millions of developers about running this on their code base. Having it as a core report is a great start! Cheers, Martijn On 20 February 2015 at 03:55, Hervé BOUTEMY wrote: > regarding fa

Re: Apache Maven JDeps Plugin

2015-02-19 Thread Hervé BOUTEMY
regarding failing or not failing (that's the question): IMHO, it would be useful to create Maven reports: as a first step, adding maven-jdeps-report as report will help people be aware of the state of their code and publishing it inside their site without taking any fix action at the moment co

Re: Apache Maven JDeps Plugin

2015-02-19 Thread Hervé BOUTEMY
ok, I just updated the index page to try to improve explanations about this unusual/new toolchains use case (ie not trying to be consistent across plugins) notice that if you use ToolchainManagerPrivate like maven-toolchains-plugin does, you even don't require Maven 3.2.6 to do that Regards,

Re: Apache Maven JDeps Plugin

2015-02-19 Thread Robert Scholte
Hi Mandy, based on your proposal I've added 2 parameters: dependenciesToAnalyzeIncludes and dependenciesToAnalyzeExcludes This way it's not an All-Or-Nothing option, but instead you have full control over the dependencies to include. You can select the dependencies by using the pattern groupI

Re: Apache Maven JDeps Plugin

2015-02-18 Thread Robert Scholte
Hi Anders, AFAIK the majority of goals is dash-based and not camelCaseBased. I'd prefer not to guess the name of the goal, so I'd like to follow the dash-based goal convention. Maybe we should add/rename the goals for the m-compiler-p and m-resources-p. thanks, Robert Op Wed, 18 Feb 2015 0

Re: Apache Maven JDeps Plugin

2015-02-18 Thread Anders Hammar
Robert, Wrt to the goal names, do we want the "test-xxx" syntax instead of "testXxx" (used in m-compiler-p and m-resources-p)? "test-xxx" is used in some other core plugins as well. /Anders On Sat, Feb 14, 2015 at 4:32 PM, Robert Scholte wrote: > Hi, > > during FOSDEM 2015 a few members of the

Re: Apache Maven JDeps Plugin

2015-02-17 Thread Robert Scholte
Hi Tibor, the plugin is just a thin wrapper around the jdeps executable to make it easier to integrate it with your Maven project. So for the Apache Maven JDeps plugin it is out of scope. However, you could share your idea with the jigsaw project[1] thanks, Robert [1] http://mail.openjdk

Re: Apache Maven JDeps Plugin

2015-02-17 Thread Tibor Digana
Hi Robert, It would be great to launch the JDeps within Javac compiler. Do you think it would be possible for JDeps? I like the way how my annotation processor (AP) is wired with the compiler. I don't think that JDeps use annotations. I am not sure if compiler has other kinds of processor interfac

Re: Apache Maven JDeps Plugin

2015-02-16 Thread Robert Scholte
Hi Alan, I've added a flag called failOnWarning (default:true), assuming that the usage of jdkinternals is considered a warning and not an error. With the following configuration you'll be able to run jdeps multiple times within the same build. org.apache.maven.plugins

Re: Apache Maven JDeps Plugin

2015-02-16 Thread Robert Scholte
Hi Alan, if you are referring to the -R / -recursive option of the jdeps tool, then yes you can. See http://maven.apache.org/plugins-archives/maven-jdeps-plugin-LATEST/maven-jdeps-plugin/jdkinternals-mojo.html#recursive I think jdeps is first of all interesting for the classes of the current

Re: Apache Maven JDeps Plugin

2015-02-15 Thread Robert Scholte
That's exactly the reason why I hadn't started it. Ordering based on version is simple, but you probably need to respect the other requirements as well. I see some challenges here: how to switch between the two without changing the pom.xml or toolchains.xml? I have some ideas: let me work

Re: Apache Maven JDeps Plugin

2015-02-15 Thread Hervé BOUTEMY
generic toolchain ordering doesn't seem feasible jdk toolchain ordering, since we know fields, can be done: version is the easiest one to order. But then there are other properties: how to order them, since they are full open? it will be the same if you implement order in jdeps plugin: how to o

Re: Apache Maven JDeps Plugin

2015-02-15 Thread Robert Scholte
Op Sun, 15 Feb 2015 07:09:37 +0100 schreef Hervé BOUTEMY : another topic: "When using Apache Maven 3.2.6 you don't need to include the <<>>; the <<>> can pick up..." looking at the code, IIUC: the plugin doesn't use the jdk toolchain configured (or not) for the whole build with maven-toolc

Re: Apache Maven JDeps Plugin

2015-02-15 Thread Robert Scholte
Hi Hervé, yes, you are right, it is indeed the last one specified in the toolchains with type 'jdk'. I'm still wondering if I should make Toolchains Comparable, so we can indeed order them. In that case it would really be the latest. thanks, Robert Op Sun, 15 Feb 2015 07:05:05 +0100 schree

Re: Apache Maven JDeps Plugin

2015-02-15 Thread Hervé BOUTEMY
another topic: "When using Apache Maven 3.2.6 you don't need to include the <<>>; the <<>> can pick up..." looking at the code, IIUC: the plugin doesn't use the jdk toolchain configured (or not) for the whole build with maven-toolchain-plugin but will select a jdk toolchain based on its own pre

Re: Apache Maven JDeps Plugin

2015-02-15 Thread Hervé BOUTEMY
Hi Robert, I just had a look at jdeps doc, and was suprosed by "the maven-jdeps-plugin can pick up the latest jdk toolchain": latest, really? Then I had a look at the code: IIUC, it uses *the last one* declared in toolchains.xml, but not really the latest since there is no sort on version in c