Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

+1 > On Apr 25, 2016, at 7:59 AM, Michael Osipov wrote: > > Am 2016-04-15 um 22:34 schrieb Michael Osipov: >> Hi folks, >> >> we all know that people once in a while complain that my JAVA_HOME is >> not properly discovered on $PLATFORM, etc. Surprisingly, we require >>

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-15 um 22:34 schrieb Michael Osipov: Hi folks, we all know that people once in a while complain that my JAVA_HOME is not properly discovered on $PLATFORM, etc. Surprisingly, we require JAVA_HOME to be set in the installation documentation, yet we discover it anyway. This is a

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Hi, >> FYI, Hudson 3.2.2 (in use for most builds at the Eclipse Foundation) >> does use the mvn script: BTW, this is the same with the latest Hudson (version 3.3.3) as well, so this seems to be a place where it diverged from Jenkins. >>> [INFO] Using Maven 3 installation: apache-maven-latest

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-17 um 20:53 schrieb Andreas Sewe: Hi, Please go ahead and test it. Jenkins does not use the script as it seems: [maven-3.x] $ /home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java -Xmx2g -Xms256m -XX:MaxPermSize=512m -cp

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

> > Please go ahead and test it. > I'll do it on my side but not before 1 week > > Jenkins does not use the script as it seems: > [maven-3.x] $ > /home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java > -Xmx2g -Xms256m -XX:MaxPermSize=512m -cp >

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Hi, > Please go ahead and test it. > > Jenkins does not use the script as it seems: > [maven-3.x] $ > /home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java > -Xmx2g -Xms256m -XX:MaxPermSize=512m -cp >

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-17 um 18:19 schrieb Jason van Zyl: You answered with a condition and an assumption. I’ll be more specific. On a Mac where discovery works well, a new user installs Java, brew installs Maven and it works. Does this still work? I have requested everyone to test the branch as I do not

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

You answered with a condition and an assumption. I’ll be more specific. On a Mac where discovery works well, a new user installs Java, brew installs Maven and it works. Does this still work? I will check our CI servers, but if those stop working after an upgrade I would be an unhappy user as

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-17 um 17:24 schrieb Jason van Zyl: So will the proposed behavior be I upgrade Maven, I don’t have JAVA_HOME set manually and Maven will error out? No, if Java in PATH is a JDK, it will continue to work as usual. This is probably the case on most dev machines. Michael On Apr

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

So will the proposed behavior be I upgrade Maven, I don’t have JAVA_HOME set manually and Maven will error out? > On Apr 15, 2016, at 1:34 PM, Michael Osipov wrote: > > Hi folks, > > we all know that people once in a while complain that my JAVA_HOME is not > properly

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

On MacOS I'using JENV which wraps tools calls like maven to setup accordingly the JAVA_HOME based on the global/local/session setting http://www.jenv.be As a developper I have exactly the liberty I need and I can switch to any version of java On Sat, Apr 16, 2016 at 8:55 PM, Michael Osipov

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-16 um 17:07 schrieb Robert Scholte: On Sat, 16 Apr 2016 16:48:42 +0200, Michael Osipov wrote: Am 2016-04-16 um 14:38 schrieb Robert Scholte: Hi, Maybe this is also the right moment to introduce a Maven specific JAVA_HOME, e.g. maven.JAVA_HOME The reason:

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

On Sat, 16 Apr 2016 16:48:42 +0200, Michael Osipov wrote: Am 2016-04-16 um 14:38 schrieb Robert Scholte: Hi, Maybe this is also the right moment to introduce a Maven specific JAVA_HOME, e.g. maven.JAVA_HOME The reason: there are other tools which depend on the

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-16 um 14:38 schrieb Robert Scholte: Hi, Maybe this is also the right moment to introduce a Maven specific JAVA_HOME, e.g. maven.JAVA_HOME The reason: there are other tools which depend on the JAVA_HOME variable as well, but that's not necessary the same JAVA_HOME you want to use for

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Hi, Maybe this is also the right moment to introduce a Maven specific JAVA_HOME, e.g. maven.JAVA_HOME The reason: there are other tools which depend on the JAVA_HOME variable as well, but that's not necessary the same JAVA_HOME you want to use for Maven. Robert On Fri, 15 Apr 2016

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-15 um 22:34 schrieb Michael Osipov: Hi folks, we all know that people once in a while complain that my JAVA_HOME is not properly discovered on $PLATFORM, etc. Surprisingly, we require JAVA_HOME to be set in the installation documentation, yet we discover it anyway. This is a

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-16 um 02:42 schrieb Dan Tran: the discovery of java home at Linux is a fantastic feature. There is too much magic involved and there are too many distros to make it right. - To unsubscribe, e-mail:

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-16 um 01:43 schrieb Christian Schulte: And I do have seen systems installing some shell script at '/usr/bin/java' not even beeing a Java launcher at all. This is the case with FreeBSD. +1 for the branch -∞ for `which java` Still no problem if you point to a JDK in PATH.

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 2016-04-16 um 01:27 schrieb Christian Schulte: Am 04/15/16 um 22:34 schrieb Michael Osipov: In MNG-6003 [1], I propose to throw away all of this code and solely rely on the dev's input. If he/she it not able to set it properly, he/she shouldn't write code at all. Most of the time, on

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 04/16/16 um 02:42 schrieb Dan Tran: > the discovery of java home at Linux is a fantastic feature. Depends on what packages you install. Install a JRE and a JDK and things get messed up. Gave up on all Linux almost a decade ago. So maybe things have changed recently. So +1 for the discovery

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

the discovery of java home at Linux is a fantastic feature. On Fri, Apr 15, 2016 at 4:43 PM, Christian Schulte wrote: > And I do have seen systems installing some shell script at > '/usr/bin/java' not even beeing a Java launcher at all. > > So, > > +1 for the branch > -∞ for

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

And I do have seen systems installing some shell script at '/usr/bin/java' not even beeing a Java launcher at all. So, +1 for the branch -∞ for `which java` Regards, - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

Re: RFC on MNG-6003: Drastically reduce JAVA_HOME discovery code

Am 04/15/16 um 22:34 schrieb Michael Osipov: > In MNG-6003 [1], I propose to throw away all of this code and solely > rely on the dev's input. If he/she it not able to set it properly, > he/she shouldn't write code at all. Most of the time, on Unix/Linux, > this isn't even necessary because a