[VOTE] Release Apache Maven Artifact Plugin version 3.2.0

2021-11-27 Thread Hervé BOUTEMY
Hi, We solved 11 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12324322=12350180=Text Staging repo: https://repository.apache.org/content/repositories/maven-1674/

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980639933 the issue you have is only with SNAPSHOTs or maven-wrapper, that are obvioulsy not published to central But with releases, there won't be any problem for normal

[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980641749 but for sure, there is the question: what should be the default? current `script`or `bin` as it was in Takari? I kept the `script` default value that Robert

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980641749 but for sure, there is the question: what should be the default? current `script`or `bin`? I kept the `script` default value that Robert chose previously, changing

Re: Maven Code Style and imports layouts

2021-11-27 Thread Hervé BOUTEMY
no objection, PR merged for enforcing, it can be a future enhancement if someone contributes Regards, Hervé Le samedi 13 novembre 2021, 19:49:09 CET Romain Manni-Bucau a écrit : > While enforced at mvn package +1 from me > > Le sam. 13 nov. 2021 à 15:04, Hervé BOUTEMY a > > écrit : > > I

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Falko Modler
Hi, what also works in many cases is a profile with file activation, e.g. if there is src/main/kotlin add the kotlin plugin. You can even use flagfiles to control this, which isn't pretty but sometimes it makes sense Cheers, Falko

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Romain Manni-Bucau
Hi Just to answer to the 2 proposals: 1. Profiles dont work by design since they must be activated and have the same issue that plugin flag 2. Tiles plugin is not bad and relates to the issue i mentionned about custom lifecycles in an old thread but it is not really related to this particular

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Falko Modler
Am 27.11.2021 um 20:25 schrieb Romain Manni-Bucau: 1. Profiles dont work by design since they must be activated and have the same issue that plugin flag In what I proposed the activation happens automatically via ... activation, so I don't get your point. Sure, if you don't have a suitable

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980644191 thinking at default type more in depth, I think that I now understand the logic = making `script` the default is not sufficient, because if

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Romain Manni-Bucau
Hi Sławomir, Ok, finally got the trick, it is a good one actually and even if a bit more verbose than mine it is more "buit-in", thanks a lot and probleme solved! Romain Manni-Bucau @rmannibucau | Blog | Old Blog

[GitHub] [maven-site] hboutemy merged pull request #269: [MNGSITE-465] Java Code Convention - import layouts

2021-11-27 Thread GitBox
hboutemy merged pull request #269: URL: https://github.com/apache/maven-site/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[VOTE] Release Apache Maven Fuildo Skin version 1.10.0

2021-11-27 Thread Hervé BOUTEMY
Hi, We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926=12348442=Text Staging repo: https://repository.apache.org/content/repositories/maven-1673]/

[VOTE] Release Maven Doxia version 1.11

2021-11-27 Thread Michael Osipov
Hi, We solved 10 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317230=12350341 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20DOXIA%20AND%20resolution%20%3D%20Unresolved Staging repo:

[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980639933 the issue you have is only with SNAPSHOTs of maven-wrapper, that are obviously not published to central But with releases, there won't be any problem for

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Frederik Boster
For frontend development with Maven I found it to be easiest to define a custom lifecycle for a custom artifact type / packaging, e.g. "angular-app", "angular-lib", "webpack-app" etc. This way it is possible to specify a build flow which is more appropriate for frontend development than the

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578 @hboutemy great job. I've tested by: - build project - unit and IT test are executed, plugin and artifacts are installed - use in another project

[GitHub] [maven-wrapper-plugin] slawekjaranowski edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578 @hboutemy great job. I've tested by: - build project - unit and IT test are executed, plugin and artifacts are installed - use in another

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
jvanzyl commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980613922 I run the following in the clone repository itself: ``` mvn clean install mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper ./mvnw

[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
jvanzyl edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980613922 I run the following in the cloned repository itself: ``` mvn clean install mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980632912 in `maven-wrapper` ``` mvn clean install -P run-its ``` and in other project ``` mvn

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
jvanzyl commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136 I think that's a poor default behavior, and the `type=bin` should be the default. That's not how the current released wrapper work, no one will read the docs and the

[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
jvanzyl edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136 @hboutemy I think that's poor default behavior, the `type=bin` should be the default. That's not how the current released wrapper works. No one will read the

[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
jvanzyl edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136 @hboutemy I think that's poor default behavior, the `type=bin` should be the default. That's not how the current released wrapper works. No one will read the

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633392 Of course, `wrapperUrl` in properties is wrong, but release (even staging) should resolve it ```

[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
jvanzyl commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980635194 I'm not sure why the slight change was made, but the latest published instructions put the JAR in there by default. Just a warning that it's asking for potential

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980543639 last try: - code = https://github.com/hboutemy/maven-wrapper = the initial wrapper donation with 4 commits to switch to Apache, replace provisio to assembly, add

[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-11-27 Thread GitBox
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980543639 last try: - code = https://github.com/hboutemy/maven-wrapper = the initial wrapper donation with 4 commits to switch to Apache, replace provisio to assembly,