Re: Enable Travis on Maven Scripting Plugin
Fair enough. If its just for outside contributor PRs I am agree with not owning the risk ;-) Stephen Connolly wrote on 2019-01-04 16:06: > On Fri 4 Jan 2019 at 22:00, Tibor Digana wrote: > >> @Stephen Connolly >> After such a big investment, especially made on your side, in Jenkins >> plugin you developed you do not want to support the GitHub PRs and you just >> let be to go with TravisCI just like that? I do not think so! > > > I want to add GitHub support to ASF Jenkins too, but PR verification should > be layers. No harm in having one layer provided by Travis/Codeship/etc and > the second layer by Jenkins. > > The other point is even if I add PR support to the ASF Jenkins, it’s not > going to be automatic build for non-committers (which is the group of PRs > that need the CI feedback most, and with least delay... ie before they walk > away) as we simply do not have throw-away infra for building PRs that could > contain bitcoin miners triggered by a unit test, etc. > > Now if infra wants to set up a dedicated “safe space” for untrusted PRs to > be built... super... but until that happens, we’ll need something like > Travis to take that risk for us. > > >> T >> >> >> On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < >> stephen.alan.conno...@gmail.com> wrote: >> >> > +1 from me >> > >> > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: >> > >> > > Hi, >> > > I would like to try out Travis on this small plugin: >> > > https://github.com/apache/maven-scripting-plugin >> > > >> > > I have pushed a minimal configuration file >> > > I need to ask to Infra, but I need approval from the community and >> > PMCs... >> > > >> > > Can I proceed ? >> > > >> > > Enrico >> > > >> > > - >> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> > > For additional commands, e-mail: dev-h...@maven.apache.org >> > > >> > > -- >> > Sent from my phone >> > >> > -- > Sent from my phone > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
Il dom 6 gen 2019, 21:04 Sylwester Lachiewicz ha scritto: > In Maven Resolver we have a sample Travis configuration, so someone can > test with the forked repo. > If we go with Travis CI I would be good to have a common configuration for > all projects (ie to run run-it etc and have .travis.yml excluded from RAT). > You don't need to skip that file, see the one I put in maven-scripting-plugin, you can add the license header I saw in one Apache project (don't remember now name) where they have a > separate script to merge PR but prerequisite was to PR from forked repo has > successful Travis build. > See Calcite and Bookkeeper for instance This way we do not use "our" Apache accounts to run builds and developers > are free to configure anything (and be responsible) in its own Travis > accounts. > Enrico > > BR > Sylwester > > pt., 4 sty 2019 o 19:21 Enrico Olivelli napisał(a): > > > Hi, > > I would like to try out Travis on this small plugin: > > https://github.com/apache/maven-scripting-plugin > > > > I have pushed a minimal configuration file > > I need to ask to Infra, but I need approval from the community and > PMCs... > > > > Can I proceed ? > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- -- Enrico Olivelli
Re: Enable Travis on Maven Scripting Plugin
I believe my employer also offers free build services for OSS projects via our CodeShip offering. If people are concerned about tying PR validation exclusively to one vendor we should inspect the CloudBees CodeShip capabilities (includes Docker build agents, which can be very nice... though I confess I have not tried CodeShip yet, despite it being a product of my employer) I think CircleCI also provides some stuff in that line. We could also investigate GitHub Actions for build validation... but further down the road that may require getting Microsoft/GitHub to provide CPU time donations. On Sun 6 Jan 2019 at 20:04, Sylwester Lachiewicz wrote: > In Maven Resolver we have a sample Travis configuration, so someone can > test with the forked repo. > If we go with Travis CI I would be good to have a common configuration for > all projects (ie to run run-it etc and have .travis.yml excluded from RAT). > I saw in one Apache project (don't remember now name) where they have a > separate script to merge PR but prerequisite was to PR from forked repo has > successful Travis build. > This way we do not use "our" Apache accounts to run builds and developers > are free to configure anything (and be responsible) in its own Travis > accounts. > > BR > Sylwester > > pt., 4 sty 2019 o 19:21 Enrico Olivelli napisał(a): > > > Hi, > > I would like to try out Travis on this small plugin: > > https://github.com/apache/maven-scripting-plugin > > > > I have pushed a minimal configuration file > > I need to ask to Infra, but I need approval from the community and > PMCs... > > > > Can I proceed ? > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Sent from my phone
Re: For 3.6.1 - MNG-5995 and MNG-6069
Am 2019-01-06 um 20:41 schrieb Sylwester Lachiewicz: Hi, a small reminder - anyone to second MNG-5995 and MNG-6069? I'd like to include both in next release. I am fine with both, but for some comments on the MNG-6069 PR. Michael pt., 30 lis 2018 o 00:21 Sylwester Lachiewicz napisał(a): Hi, branches for MNG-5995 and MNG-6069 ready in maven core - build passed https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5995/ https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/ Please review. BR Sylwester czw., 8 lis 2018 o 20:52 Karl Heinz Marbaise napisał(a): Hi, On 08/11/18 20:33, Sylwester Lachiewicz wrote: Hi Karl, today i removed my branches with fixes and proposals from gitbox and leave only PR in Github for easier commenting. As I mentioned already ...create the branches on maven-core (gitbox url). The branches will be mirrored to github as well...otherwise we have no check with our CI which is vital... Apart from that you can comment the commit on branches in GitHub...we don't loose anything (maybe some convenience..)...But it might be good thing to check with INFRA if that can be improved more ... Kind regards Karl Heinz Marbaise Sylwester czw., 8 lis 2018 o 20:18 użytkownik Karl Heinz Marbaise < khmarba...@gmx.de> napisał: Hi Sylwester, On 08/11/18 20:00, Sylwester Lachiewicz wrote: Hi, I have 2 fixes (leftovers from 3.6.0) ready to merge - anyone to review? [MNG-6069] https://github.com/apache/maven/pull/153 I can't see the code in the branch MNG-6069 ...(Ok..was originally mine but you can simply push (force) that code on that branch). hijack that branch ... Furthermore if I check the old branch (If this is the correct one): https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/slach-build8/ That contains test failures... So -1 to merge... [MNG-5995] https://github.com/apache/maven/pull/185 Unfortunately I don't see a branch here as well which has been built on CI ... https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/ whch job? It would be great if you could create an appropriate branch on Maven Core named by the issue which is built on CI ... so I have to say -1 here as well... Kind regards Karl Heinz Marbaise Sylwester - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
In Maven Resolver we have a sample Travis configuration, so someone can test with the forked repo. If we go with Travis CI I would be good to have a common configuration for all projects (ie to run run-it etc and have .travis.yml excluded from RAT). I saw in one Apache project (don't remember now name) where they have a separate script to merge PR but prerequisite was to PR from forked repo has successful Travis build. This way we do not use "our" Apache accounts to run builds and developers are free to configure anything (and be responsible) in its own Travis accounts. BR Sylwester pt., 4 sty 2019 o 19:21 Enrico Olivelli napisał(a): > Hi, > I would like to try out Travis on this small plugin: > https://github.com/apache/maven-scripting-plugin > > I have pushed a minimal configuration file > I need to ask to Infra, but I need approval from the community and PMCs... > > Can I proceed ? > > Enrico > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Jenkins ASF + Pull Requests + webhooks
disabled logs, workspace and artifacts for anonymous Jenkins users, but available for PMC and Maven committers. On Sun, Jan 6, 2019 at 8:41 PM Mickael Istria wrote: > On Sun, Jan 6, 2019 at 8:32 PM Tibor Digana > wrote: > > > I meant Bitcoins. Without network access bitcoins can be loaded but > nobody > > can use them. An access to Workspace and archived artifacts should be > > disabled for users. > > > That would be sad since those are actually super helpful when trying to > debug issues that are only happening in some environments and CI reproduces > when they can hardly reproduce them locally. >
Re: Maven Core Release 3.6.1
Hi Karl, I would like to include more [1[ in 3.6.1 MNG-6543, MNG-6522, MNG-6520, MNG-6506, MNG-6294, MNG-6071, MNG-6069, MNG-5995, MNG-5693 please review and approve before I can merge. BR Sylwester [1] https://jira.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%203.6.1 sob., 29 gru 2018 o 21:04 Karl Heinz Marbaise napisał(a): > Hi to all, > > I want to cut a Core Release within two weeks (about 14.01.2019) if that > is Ok for everyone? If any objections please raise your hand. > > currently I see in the JIRA the following issues open: > > MNG-6530[1] which should be part of it (critical!) > MNG-6533[2] > MNG-6538[3] Upgrade to Maven Resolver version 1.3.2 (which is not yet > released; I will take care of that) > > Do we have other issue which should be made it into the possible new > release ? > > Kind regards > Karl Heinz Marbaise > > [1]: https://issues.apache.org/jira/browse/MNG-6530 > [2]: https://issues.apache.org/jira/browse/MNG-6533 > [3]: https://issues.apache.org/jira/browse/MNG-6538 > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: For 3.6.1 - MNG-5995 and MNG-6069
Hi, a small reminder - anyone to second MNG-5995 and MNG-6069? I'd like to include both in next release. Sylwester pt., 30 lis 2018 o 00:21 Sylwester Lachiewicz napisał(a): > Hi, > branches for MNG-5995 and MNG-6069 ready in maven core - build passed > > > https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5995/ > > https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/ > > Please review. > > BR > Sylwester > > czw., 8 lis 2018 o 20:52 Karl Heinz Marbaise > napisał(a): > >> Hi, >> >> On 08/11/18 20:33, Sylwester Lachiewicz wrote: >> > Hi Karl, today i removed my branches with fixes and proposals from >> gitbox >> > and leave only PR in Github for easier commenting. >> >> As I mentioned already ...create the branches on maven-core (gitbox >> url). The branches will be mirrored to github as well...otherwise we >> have no check with our CI which is vital... >> >> Apart from that you can comment the commit on branches in GitHub...we >> don't loose anything (maybe some convenience..)...But it might be good >> thing to check with INFRA if that can be improved more ... >> >> Kind regards >> Karl Heinz Marbaise >> >> > >> > Sylwester >> > >> > czw., 8 lis 2018 o 20:18 użytkownik Karl Heinz Marbaise < >> khmarba...@gmx.de> >> > napisał: >> > >> >> Hi Sylwester, >> >> >> >> On 08/11/18 20:00, Sylwester Lachiewicz wrote: >> >>> Hi, I have 2 fixes (leftovers from 3.6.0) ready to merge - anyone to >> >> review? >> >>> >> >>> [MNG-6069] https://github.com/apache/maven/pull/153 >> >> >> >> I can't see the code in the branch MNG-6069 ...(Ok..was originally mine >> >> but you can simply push (force) that code on that branch). hijack >> >> that branch ... >> >> >> >> Furthermore if I check the old branch (If this is the correct one): >> >> >> >> >> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/slach-build8/ >> >> >> >> That contains test failures... >> >> >> >> So -1 to merge... >> >> >> >> >> >>> [MNG-5995] https://github.com/apache/maven/pull/185 >> >> >> >> Unfortunately I don't see a branch here as well which has been built on >> >> CI ... >> >> >> >> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/ >> >> whch job? >> >> >> >> It would be great if you could create an appropriate branch on Maven >> >> Core named by the issue which is built on CI ... >> >> >> >> so I have to say -1 here as well... >> >> >> >> >> >> Kind regards >> >> Karl Heinz Marbaise >> >> >> >>> >> >>> Sylwester >> >>> >> >> >> > >> >
Re: Jenkins ASF + Pull Requests + webhooks
On Sun, Jan 6, 2019 at 8:32 PM Tibor Digana wrote: > I meant Bitcoins. Without network access bitcoins can be loaded but nobody > can use them. An access to Workspace and archived artifacts should be > disabled for users. That would be sad since those are actually super helpful when trying to debug issues that are only happening in some environments and CI reproduces when they can hardly reproduce them locally.
Re: Jenkins ASF + Pull Requests + webhooks
@Stephen Connolly I meant Bitcoins. Without network access bitcoins can be loaded but nobody can use them. An access to Workspace and archived artifacts should be disabled for users. On Sun, Jan 6, 2019 at 5:51 PM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > That is not the problem you think it is. Bitcoin mining is the current > issue. And through Jenkinsfile or Process.exec you can bypass JVM > permissions > > On Sun 6 Jan 2019 at 16:44, Tibor Digana wrote: > > > Regarding "pull/1234/head" refs and the security, I think allowing only > the > > permission to Maven Central IP address is needed and nowhere else. > > This can be accomplished by the java policy in JRE. > > WDYT? > > > > On Sun, Jan 6, 2019 at 11:09 AM Hervé BOUTEMY > > wrote: > > > > > I didn't know about these special "pull/1234/head" refs, that are not > > real > > > branches: if these pseudo-branches were synchronized to Gitbox like any > > > branch, the Gitpubsub mechanism could happen at Apache > > > of course, the security implications of running code from these PR > > > branches > > > would still have to be managed... > > > > > > notice: there is a discussion on this on builds@apache [1] > > > > > > Regards, > > > > > > Hervé > > > > > > [1] https://lists.apache.org/list.html?bui...@apache.org > > > > > > Le samedi 5 janvier 2019, 12:34:24 CET Enrico Olivelli a écrit : > > > > Hi Stephen, > > > > I am not a Jenkins expert, but I want to share this idea, maybe it > can > > > help. > > > > Can we use GitHub webhooks in order to trigger the creation of a Job > > > inside > > > > Maven-Box ? > > > > This way we don't have to continuously use Github API. > > > > When an user creates/updates a PR we can import the PR and create the > > > > Job, having as repository not gitbox.apache.org but github.com > > > > > > > > In github you have this special refs "pull/1234/head" which points to > > > > the branch on remote fork > > > > > > > > just an idea > > > > > > > > Enrico > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > -- > Sent from my phone >
Re: Enable Travis on Maven Scripting Plugin
Il dom 6 gen 2019, 18:03 Hervé BOUTEMY ha scritto: > you mean this directory is not involved in the seed job [2]? > I meant only that the name of such directory was not special, it works as you described when I look into this job, I see a "Process Job DSLs" step that looks on > filesystem ".test-infra/jenkins/job_*.groovy" > > in Maven, the "maven-box" seed job [3] is created with the ASF's Gitpubsub > Jenkins plugin that creates the mutlibranch pipeline jobs, that's really > the > same idea, no? > I didn't know. I will double check but I think you are right. I never used multibranch pipelines and I don't use Jenkinsfiles which I thought it was a different approach from the Jenkins DSL/seed job one Enrico > > Regards, > > Hervé > > [2] https://builds.apache.org/job/bookkeeper-seed/ > > [3] https://builds.apache.org/job/maven-box/ > > Le dimanche 6 janvier 2019, 11:48:29 CET Enrico Olivelli a écrit : > > It is not a special directory, we are using Je kins DSL, and there is a > > 'seed job' which parses these files and creates/updates the jobs. > > This way committers without direct access to Jenkins can operate on > > configuration and we can work with review then commit. > > Therefore it is easy to reconstruct every job in case of disaster > > > > > > Enrico > > > > Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha > scritto: > > > interesting > > > > > > I suppose this is enabled by the content of .test-infra/jenkins > directory > > > [1] > > > even if I don't really understand the content and how we could add > > > something > > > like this in our configuration > > > > > > Regards, > > > > > > Hervé > > > > > > [1] > https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins > > > > > > Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > > > > > > scritto: > > > > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana < > tibordig...@apache.org> > > > > > > > > > > wrote: > > > > > > > Manfred, did you see my comment on Slack? > > > > > > > Shortly, let's have dedicated machines just only for Maven > project > > > > > > > with > > > > > > > Infra support and one person from our team with Infra > permissions > > > > > > just > > > > > > > > on > > > > > > > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu > for > > > > > > us. > > > > > > > > > > all: WDYT? > > > > > > > > > > > > No way. Apache Infrastructure is a shared infrastructure. There > are > > > > > > NO > > > > > > > > > dedicated machine for any projects. > > > > > > The infra budget is shared between project. I'm pretty sure you > will > > > > > > > > > > never > > > > > > > > > > > convince infra of your idea... > > > > > > If you have time to waste maybe you can try but .. :) > > > > > > > > > > +1 > > > > > > > > > > Enrico, you wrote > > > > > "I see the same setup in Zookeeper and Bookkeeper and github pr > plugin > > > > > works > > > > > like a charm (and I partecipated in setting it up)" > > > > > > > > > > but you never gave any pointer, any demo of what Zookeeper and > > > > > > Bookkeeper > > > > > > > > do > > > > > with PRs (or I overlooked the email: that may happen...) > > > > > can you show us, please? > > > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 > checks > > > > triggered by github, one on travis which validates the build, without > > > > tests, on every supported java version, then you have many ASF > jenkins > > > > > > jobs > > > > > > > for tests and integration tests > > > > Bookkeeper tests are huge and so we split the test suite in 5 parts, > so > > > > that it is easier to restart a single job and not to re run the full > > > > > > suite > > > > > > > (we still have some flakes) > > > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > > > If you create a PR you will see that the user has the ability to > 'skip' > > > > some jobs, maybe because his change is only about the website or > about > > > > > > some > > > > > > > specific parts. > > > > In Bookkeeper we have very strict review-then-commit rules so every > one > > > > uses PRs in his every day activity on BK. > > > > > > > > On Zookeeper we have a single precommit job which builds PRs and now > we > > > > > > are > > > > > > > also enabling Travis this month (the project is migrating from Ant to > > > > > > Maven > > > > > > > and so Travis will be easy to use and most usable for non committers) > > > > > > > > In both of the two projects we have configured the 'trigger phrase' > and > > > > > > we > > > > > > > have whitelisted the apache committers github group for such trigger. > > > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > > > > enable > > > > > > > only the trigger phrase. > > > > As already said this is not possible with
Re: Enable Travis on Maven Scripting Plugin
you mean this directory is not involved in the seed job [2]? when I look into this job, I see a "Process Job DSLs" step that looks on filesystem ".test-infra/jenkins/job_*.groovy" in Maven, the "maven-box" seed job [3] is created with the ASF's Gitpubsub Jenkins plugin that creates the mutlibranch pipeline jobs, that's really the same idea, no? Regards, Hervé [2] https://builds.apache.org/job/bookkeeper-seed/ [3] https://builds.apache.org/job/maven-box/ Le dimanche 6 janvier 2019, 11:48:29 CET Enrico Olivelli a écrit : > It is not a special directory, we are using Je kins DSL, and there is a > 'seed job' which parses these files and creates/updates the jobs. > This way committers without direct access to Jenkins can operate on > configuration and we can work with review then commit. > Therefore it is easy to reconstruct every job in case of disaster > > > Enrico > > Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha scritto: > > interesting > > > > I suppose this is enabled by the content of .test-infra/jenkins directory > > [1] > > even if I don't really understand the content and how we could add > > something > > like this in our configuration > > > > Regards, > > > > Hervé > > > > [1] https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins > > > > Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > > > > scritto: > > > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > > > > > > > > wrote: > > > > > > Manfred, did you see my comment on Slack? > > > > > > Shortly, let's have dedicated machines just only for Maven project > > > > > > with > > > > > > Infra support and one person from our team with Infra permissions > > > > just > > > > > > on > > > > > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > > > > us. > > > > > > > > all: WDYT? > > > > > > > > > > No way. Apache Infrastructure is a shared infrastructure. There are > > > > NO > > > > > > > dedicated machine for any projects. > > > > > The infra budget is shared between project. I'm pretty sure you will > > > > > > > > never > > > > > > > > > convince infra of your idea... > > > > > If you have time to waste maybe you can try but .. :) > > > > > > > > +1 > > > > > > > > Enrico, you wrote > > > > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > > > works > > > > like a charm (and I partecipated in setting it up)" > > > > > > > > but you never gave any pointer, any demo of what Zookeeper and > > > > Bookkeeper > > > > > > do > > > > with PRs (or I overlooked the email: that may happen...) > > > > can you show us, please? > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > > triggered by github, one on travis which validates the build, without > > > tests, on every supported java version, then you have many ASF jenkins > > > > jobs > > > > > for tests and integration tests > > > Bookkeeper tests are huge and so we split the test suite in 5 parts, so > > > that it is easier to restart a single job and not to re run the full > > > > suite > > > > > (we still have some flakes) > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > If you create a PR you will see that the user has the ability to 'skip' > > > some jobs, maybe because his change is only about the website or about > > > > some > > > > > specific parts. > > > In Bookkeeper we have very strict review-then-commit rules so every one > > > uses PRs in his every day activity on BK. > > > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > > > are > > > > > also enabling Travis this month (the project is migrating from Ant to > > > > Maven > > > > > and so Travis will be easy to use and most usable for non committers) > > > > > > In both of the two projects we have configured the 'trigger phrase' and > > > > we > > > > > have whitelisted the apache committers github group for such trigger. > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > > enable > > > > > only the trigger phrase. > > > As already said this is not possible with current maven-box plugin > > > > > > Enrico > > > > > > > Regards, > > > > > > > > Hervé > > > > > > > > > > Cheers > > > > > > Tibor > > > > > > > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > > > > > > > > manf...@simpligility.com> > > > > > > > > > > wrote: > > > > > > > I agree with Tibor. I would rather not have to deal with two > > > > > > > > different > > > > > > > > > > > CI > > > > > > > systems... > > > > > > > > > > > > > > Manfred > > > > > > > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > > > > @Stephen Connolly > > > > > > > > After such a big investment, especially made on your
Re: Jenkins ASF + Pull Requests + webhooks
That is not the problem you think it is. Bitcoin mining is the current issue. And through Jenkinsfile or Process.exec you can bypass JVM permissions On Sun 6 Jan 2019 at 16:44, Tibor Digana wrote: > Regarding "pull/1234/head" refs and the security, I think allowing only the > permission to Maven Central IP address is needed and nowhere else. > This can be accomplished by the java policy in JRE. > WDYT? > > On Sun, Jan 6, 2019 at 11:09 AM Hervé BOUTEMY > wrote: > > > I didn't know about these special "pull/1234/head" refs, that are not > real > > branches: if these pseudo-branches were synchronized to Gitbox like any > > branch, the Gitpubsub mechanism could happen at Apache > > of course, the security implications of running code from these PR > > branches > > would still have to be managed... > > > > notice: there is a discussion on this on builds@apache [1] > > > > Regards, > > > > Hervé > > > > [1] https://lists.apache.org/list.html?bui...@apache.org > > > > Le samedi 5 janvier 2019, 12:34:24 CET Enrico Olivelli a écrit : > > > Hi Stephen, > > > I am not a Jenkins expert, but I want to share this idea, maybe it can > > help. > > > Can we use GitHub webhooks in order to trigger the creation of a Job > > inside > > > Maven-Box ? > > > This way we don't have to continuously use Github API. > > > When an user creates/updates a PR we can import the PR and create the > > > Job, having as repository not gitbox.apache.org but github.com > > > > > > In github you have this special refs "pull/1234/head" which points to > > > the branch on remote fork > > > > > > just an idea > > > > > > Enrico > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Sent from my phone
Re: Jenkins ASF + Pull Requests + webhooks
Regarding "pull/1234/head" refs and the security, I think allowing only the permission to Maven Central IP address is needed and nowhere else. This can be accomplished by the java policy in JRE. WDYT? On Sun, Jan 6, 2019 at 11:09 AM Hervé BOUTEMY wrote: > I didn't know about these special "pull/1234/head" refs, that are not real > branches: if these pseudo-branches were synchronized to Gitbox like any > branch, the Gitpubsub mechanism could happen at Apache > of course, the security implications of running code from these PR > branches > would still have to be managed... > > notice: there is a discussion on this on builds@apache [1] > > Regards, > > Hervé > > [1] https://lists.apache.org/list.html?bui...@apache.org > > Le samedi 5 janvier 2019, 12:34:24 CET Enrico Olivelli a écrit : > > Hi Stephen, > > I am not a Jenkins expert, but I want to share this idea, maybe it can > help. > > Can we use GitHub webhooks in order to trigger the creation of a Job > inside > > Maven-Box ? > > This way we don't have to continuously use Github API. > > When an user creates/updates a PR we can import the PR and create the > > Job, having as repository not gitbox.apache.org but github.com > > > > In github you have this special refs "pull/1234/head" which points to > > the branch on remote fork > > > > just an idea > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
[ANN] Apache Maven Wagon 3.3.1 released
The Apache Maven team is pleased to announce the release of the Apache Maven Wagon, version 3.3.1. https://maven.apache.org/wagon/ Release Notes - Maven Wagon - Version 3.3.1 ** Bug * [WAGON-538] - Basic authentication fails if the password contains non-ASCII characters * [WAGON-543] - wagon-ssh download hangs ** Improvement * [WAGON-537] - Maven transfer speed of large artifacts is slow due to unsuitable buffer strategy * [WAGON-539] - Explicitly register only supported auth schemes * [WAGON-540] - Switch to modern-day encoding (UTF-8) of auth credentials ** Task * [WAGON-544] - Work around JSch issue #122 Enjoy, -The Apache Maven team - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven exclusions of dependency
Can support regex expression for maven exclusions of dependency? I wish ingore multi dependency that has same regex , instead of write multi exclusion. Example: I want to exclude all springframework dependency like as org.springframework* * then this equivalent to below way org.springframework * org.springframework.boot * org.springframework.cloud * …… 李翌 15850741084 1483554...@qq.com 南京市雨花台区软件大道66号华通科技园3层 210012 http://www.sudytech.com
[RESULT] [VOTE] Release Maven Wagon version 3.3.1
Hi, The vote has passed with the following result: +1: Michael Osipov, Dan Tran, Tibor Digana, Robert Scholte PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release the board report. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Maven Wagon version 3.3.1
+1 On Thu, Jan 3, 2019 at 2:28 PM Michael Osipov wrote: > Hi, > > We solved 6 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318122=12344772 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20WAGON%20AND%20resolution%20%3D%20Unresolved > > Staging repo: > https://repository.apache.org/content/repositories/maven-1483/ > > https://repository.apache.org/content/repositories/maven-1483/org/apache/maven/wagon/wagon/3.3.1/wagon-3.3.1-source-release.zip > > Source release checksum(s): > wagon-3.3.1-source-release.zip > sha512: > > 398d8d028cbaff4fdc6380a105af8c2111915931db9c46f404e96c6de82b713995f3842ffd32b61e1a0b6c4249973af69a6256c160babf2d3acf7cff5417a649 > > Staging site: > https://maven.apache.org/wagon-archives/wagon-LATEST/ > > Guide to testing staged releases: > http://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: [VOTE] Release Maven Wagon version 3.3.1
+1 On Thu, 03 Jan 2019 14:28:13 +0100, Michael Osipov wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318122=12344772 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20WAGON%20AND%20resolution%20%3D%20Unresolved Staging repo: https://repository.apache.org/content/repositories/maven-1483/ https://repository.apache.org/content/repositories/maven-1483/org/apache/maven/wagon/wagon/3.3.1/wagon-3.3.1-source-release.zip Source release checksum(s): wagon-3.3.1-source-release.zip sha512: 398d8d028cbaff4fdc6380a105af8c2111915931db9c46f404e96c6de82b713995f3842ffd32b61e1a0b6c4249973af69a6256c160babf2d3acf7cff5417a649 Staging site: https://maven.apache.org/wagon-archives/wagon-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Create JIRA project for Maven Scripting Plugin
Brian, can you pick this up? thanks, Robert On Sat, 05 Jan 2019 12:11:41 +0100, Enrico Olivelli wrote: Can any admin create this project ? for Maven Scripting Plugin https://issues.apache.org/jira/browse/MSCRIPTING Regards Enrico - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
Enrico> limited to linux and osx, not windows. Windows can be tested via AppVeyor. The configuration is the same: one adds appveyor.yml (e.g. https://github.com/apache/calcite/blob/master/appveyor.yml ) and asks Infra team to enable AppVeyo-GitHub integration. Vladimir - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
It is not a special directory, we are using Je kins DSL, and there is a 'seed job' which parses these files and creates/updates the jobs. This way committers without direct access to Jenkins can operate on configuration and we can work with review then commit. Therefore it is easy to reconstruct every job in case of disaster Enrico Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha scritto: > interesting > > I suppose this is enabled by the content of .test-infra/jenkins directory > [1] > even if I don't really understand the content and how we could add > something > like this in our configuration > > Regards, > > Hervé > > [1] https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins > > Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > scritto: > > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > > > > > > wrote: > > > > > Manfred, did you see my comment on Slack? > > > > > Shortly, let's have dedicated machines just only for Maven project > > > > > with > > > > > Infra support and one person from our team with Infra permissions > just > > > > > > on > > > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > us. > > > > > all: WDYT? > > > > > > > > No way. Apache Infrastructure is a shared infrastructure. There are > NO > > > > dedicated machine for any projects. > > > > The infra budget is shared between project. I'm pretty sure you will > > > > > > never > > > > > > > convince infra of your idea... > > > > If you have time to waste maybe you can try but .. :) > > > > > > +1 > > > > > > Enrico, you wrote > > > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > > works > > > like a charm (and I partecipated in setting it up)" > > > > > > but you never gave any pointer, any demo of what Zookeeper and > Bookkeeper > > > do > > > with PRs (or I overlooked the email: that may happen...) > > > can you show us, please? > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > triggered by github, one on travis which validates the build, without > > tests, on every supported java version, then you have many ASF jenkins > jobs > > for tests and integration tests > > Bookkeeper tests are huge and so we split the test suite in 5 parts, so > > that it is easier to restart a single job and not to re run the full > suite > > (we still have some flakes) > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > If you create a PR you will see that the user has the ability to 'skip' > > some jobs, maybe because his change is only about the website or about > some > > specific parts. > > In Bookkeeper we have very strict review-then-commit rules so every one > > uses PRs in his every day activity on BK. > > > > On Zookeeper we have a single precommit job which builds PRs and now we > are > > also enabling Travis this month (the project is migrating from Ant to > Maven > > and so Travis will be easy to use and most usable for non committers) > > > > In both of the two projects we have configured the 'trigger phrase' and > we > > have whitelisted the apache committers github group for such trigger. > > > > Currently all of the jobs are triggered even at PR creation and at > > close/reopen, this can be dangerous. We can skip this for Maven and > enable > > only the trigger phrase. > > As already said this is not possible with current maven-box plugin > > > > Enrico > > > > > Regards, > > > > > > Hervé > > > > > > > > Cheers > > > > > Tibor > > > > > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > > > > > > manf...@simpligility.com> > > > > > > > > wrote: > > > > > > I agree with Tibor. I would rather not have to deal with two > > > > > > different > > > > > > > > > CI > > > > > > systems... > > > > > > > > > > > > Manfred > > > > > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > > > @Stephen Connolly > > > > > > > After such a big investment, especially made on your side, in > > > > > > Jenkins > > > > > > > > > > plugin you developed you do not want to support the GitHub PRs > and > > > > > > you > > > > > > > > > just > > > > > > > > > > > > > let be to go with TravisCI just like that? I do not think so! > > > > > > > T > > > > > > > > > > > > > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > > > > > > > > > > > > stephen.alan.conno...@gmail.com> wrote: > > > > > > >> +1 from me > > > > > > >> > > > > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli < > eolive...@gmail.com> > > > > > > > > > > > > wrote: > > > > > > >> > Hi, > > > > > > >> > I would like to try out Travis on this small plugin: > > > > > > >> > https://github.com/apache/maven-scripting-plugin > > > > > > >> > > > > > > > >> > I have pushed a minimal configuration file > > > > > > >> > I need to ask to Infra, but I need approval from the > community > > > > > > and > > > > > > > > >
Re: Enable Travis on Maven Scripting Plugin
Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha scritto: > Le samedi 5 janvier 2019, 12:34:30 CET Enrico Olivelli a écrit : > > Travis up and running on Maven Scripting Plugin > > this is the first build with integration tests > > > > mvn verify -Prun-its > > https://travis-ci.org/apache/maven-scripting-plugin/builds/475666300 > > > > This is how the PR looks like: > > https://github.com/apache/maven-scripting-plugin/pull/2 > > > > I think it is a great step forward for contributors > +1 > such a basic setup is sufficient for 90% of our plugins, which have basic > "mvn > -Prun-its verify" requirement > > is it just about the addition of the .travis.yml on any git repository? > You have to add travis configuration file and you have to ask infra to enable it, every committer ( at least I can and I am not special) will be able to change the configuration using Travis Web Ui but only infra can activate the service. Beware that it is not only running 'verify' but also it is implicit in Travis to run mvn install -DskipTests -Djavadoc.skip.. See [1] We could enable multiple java versions and maven version but you are limited to linux and osx, not windows. I think that in our case linux + latest jdk (11 currently) is enough, as the committer will anyway test the patch on maven-box Enrico [1] https://docs.travis-ci.com/user/languages/java/#projects-using-maven > Regards, > > Hervé > > > > > Il giorno sab 5 gen 2019 alle ore 10:35 Enrico Olivelli > > > > ha scritto: > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > scritto: > > >> Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > >> > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > wrote: > > >> > > Manfred, did you see my comment on Slack? > > >> > > Shortly, let's have dedicated machines just only for Maven project > > >> > > with > > >> > > Infra support and one person from our team with Infra permissions > > >> > > just on > > >> > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > us. > > >> > > all: WDYT? > > >> > > > >> > No way. Apache Infrastructure is a shared infrastructure. There are > NO > > >> > dedicated machine for any projects. > > >> > The infra budget is shared between project. I'm pretty sure you will > > >> > never > > >> > convince infra of your idea... > > >> > If you have time to waste maybe you can try but .. :) > > >> > > >> +1 > > >> > > >> Enrico, you wrote > > >> "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > >> works like a charm (and I partecipated in setting it up)" > > >> > > >> but you never gave any pointer, any demo of what Zookeeper and > Bookkeeper > > >> do with PRs (or I overlooked the email: that may happen...) > > >> can you show us, please? > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > > triggered by github, one on travis which validates the build, without > > > tests, on every supported java version, then you have many ASF jenkins > > > jobs for tests and integration tests Bookkeeper tests are huge and so > we > > > split the test suite in 5 parts, so that it is easier to restart a > single > > > job and not to re run the full suite (we still have some flakes) > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > If you create a PR you will see that the user has the ability to 'skip' > > > some jobs, maybe because his change is only about the website or about > > > some specific parts. In Bookkeeper we have very strict > review-then-commit > > > rules so every one uses PRs in his every day activity on BK. > > > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > > are also enabling Travis this month (the project is migrating from Ant > to > > > Maven and so Travis will be easy to use and most usable for non > > > committers) > > > > > > In both of the two projects we have configured the 'trigger phrase' > and we > > > have whitelisted the apache committers github group for such trigger. > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > enable only the trigger phrase. As already said this is not possible > with > > > current maven-box plugin > > > > > > Enrico > > > > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > Cheers > > >> > > Tibor > > >> > > > > >> > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > > >> > > > > >> > > > > >> > > wrote: > > >> > > > I agree with Tibor. I would rather not have to deal with two > > >> > > > different > > >> > > > CI > > >> > > > systems... > > >> > > > > > >> > > > Manfred > > >> > > > > > >> > > > Tibor Digana wrote on 2019-01-04 14:00: > > >> > > > > @Stephen Connolly > > >> > > > > After such a big investment, especially made on your side, in > > >> > > > > Jenkins > > >> > > > > plugin you developed you do not want to support the GitHub PRs > > >> > > > > and you > > >> > > > > > >> > > > just > > >> > > > > >
Re: Jenkins ASF + Pull Requests + webhooks
I didn't know about these special "pull/1234/head" refs, that are not real branches: if these pseudo-branches were synchronized to Gitbox like any branch, the Gitpubsub mechanism could happen at Apache of course, the security implications of running code from these PR branches would still have to be managed... notice: there is a discussion on this on builds@apache [1] Regards, Hervé [1] https://lists.apache.org/list.html?bui...@apache.org Le samedi 5 janvier 2019, 12:34:24 CET Enrico Olivelli a écrit : > Hi Stephen, > I am not a Jenkins expert, but I want to share this idea, maybe it can help. > Can we use GitHub webhooks in order to trigger the creation of a Job inside > Maven-Box ? > This way we don't have to continuously use Github API. > When an user creates/updates a PR we can import the PR and create the > Job, having as repository not gitbox.apache.org but github.com > > In github you have this special refs "pull/1234/head" which points to > the branch on remote fork > > just an idea > > Enrico > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
Le samedi 5 janvier 2019, 12:34:30 CET Enrico Olivelli a écrit : > Travis up and running on Maven Scripting Plugin > this is the first build with integration tests > > mvn verify -Prun-its > https://travis-ci.org/apache/maven-scripting-plugin/builds/475666300 > > This is how the PR looks like: > https://github.com/apache/maven-scripting-plugin/pull/2 > > I think it is a great step forward for contributors +1 such a basic setup is sufficient for 90% of our plugins, which have basic "mvn -Prun-its verify" requirement is it just about the addition of the .travis.yml on any git repository? Regards, Hervé > > Il giorno sab 5 gen 2019 alle ore 10:35 Enrico Olivelli > > ha scritto: > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha scritto: > >> Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > >> > On Sat, 5 Jan 2019 at 12:39, Tibor Digana wrote: > >> > > Manfred, did you see my comment on Slack? > >> > > Shortly, let's have dedicated machines just only for Maven project > >> > > with > >> > > Infra support and one person from our team with Infra permissions > >> > > just on > >> > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > >> > > all: WDYT? > >> > > >> > No way. Apache Infrastructure is a shared infrastructure. There are NO > >> > dedicated machine for any projects. > >> > The infra budget is shared between project. I'm pretty sure you will > >> > never > >> > convince infra of your idea... > >> > If you have time to waste maybe you can try but .. :) > >> > >> +1 > >> > >> Enrico, you wrote > >> "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > >> works like a charm (and I partecipated in setting it up)" > >> > >> but you never gave any pointer, any demo of what Zookeeper and Bookkeeper > >> do with PRs (or I overlooked the email: that may happen...) > >> can you show us, please? > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > triggered by github, one on travis which validates the build, without > > tests, on every supported java version, then you have many ASF jenkins > > jobs for tests and integration tests Bookkeeper tests are huge and so we > > split the test suite in 5 parts, so that it is easier to restart a single > > job and not to re run the full suite (we still have some flakes) > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > If you create a PR you will see that the user has the ability to 'skip' > > some jobs, maybe because his change is only about the website or about > > some specific parts. In Bookkeeper we have very strict review-then-commit > > rules so every one uses PRs in his every day activity on BK. > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > are also enabling Travis this month (the project is migrating from Ant to > > Maven and so Travis will be easy to use and most usable for non > > committers) > > > > In both of the two projects we have configured the 'trigger phrase' and we > > have whitelisted the apache committers github group for such trigger. > > > > Currently all of the jobs are triggered even at PR creation and at > > close/reopen, this can be dangerous. We can skip this for Maven and > > enable only the trigger phrase. As already said this is not possible with > > current maven-box plugin > > > > Enrico > > > >> Regards, > >> > >> Hervé > >> > >> > > Cheers > >> > > Tibor > >> > > > >> > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > >> > > > >> > > > >> > > wrote: > >> > > > I agree with Tibor. I would rather not have to deal with two > >> > > > different > >> > > > CI > >> > > > systems... > >> > > > > >> > > > Manfred > >> > > > > >> > > > Tibor Digana wrote on 2019-01-04 14:00: > >> > > > > @Stephen Connolly > >> > > > > After such a big investment, especially made on your side, in > >> > > > > Jenkins > >> > > > > plugin you developed you do not want to support the GitHub PRs > >> > > > > and you > >> > > > > >> > > > just > >> > > > > >> > > > > let be to go with TravisCI just like that? I do not think so! > >> > > > > T > >> > > > > > >> > > > > > >> > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > >> > > > > > >> > > > > stephen.alan.conno...@gmail.com> wrote: > >> > > > >> +1 from me > >> > > > >> > >> > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > >> > > > >> > >> > > > > >> > > > wrote: > >> > > > >> > Hi, > >> > > > >> > I would like to try out Travis on this small plugin: > >> > > > >> > https://github.com/apache/maven-scripting-plugin > >> > > > >> > > >> > > > >> > I have pushed a minimal configuration file > >> > > > >> > I need to ask to Infra, but I need approval from the community > >> > > > >> > and > >> > > > >> > >> > > > >> PMCs... > >> > > > >> > >> > > > >> > Can I proceed ? > >> > > > >> > > >> > > > >> > Enrico > >> > > > >> > > - > >> > > > >> > > > >> > To
Re: Enable Travis on Maven Scripting Plugin
interesting I suppose this is enabled by the content of .test-infra/jenkins directory [1] even if I don't really understand the content and how we could add something like this in our configuration Regards, Hervé [1] https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha scritto: > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > > > > wrote: > > > > Manfred, did you see my comment on Slack? > > > > Shortly, let's have dedicated machines just only for Maven project > > > > with > > > > Infra support and one person from our team with Infra permissions just > > > > on > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > > > > all: WDYT? > > > > > > No way. Apache Infrastructure is a shared infrastructure. There are NO > > > dedicated machine for any projects. > > > The infra budget is shared between project. I'm pretty sure you will > > > > never > > > > > convince infra of your idea... > > > If you have time to waste maybe you can try but .. :) > > > > +1 > > > > Enrico, you wrote > > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > works > > like a charm (and I partecipated in setting it up)" > > > > but you never gave any pointer, any demo of what Zookeeper and Bookkeeper > > do > > with PRs (or I overlooked the email: that may happen...) > > can you show us, please? > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > triggered by github, one on travis which validates the build, without > tests, on every supported java version, then you have many ASF jenkins jobs > for tests and integration tests > Bookkeeper tests are huge and so we split the test suite in 5 parts, so > that it is easier to restart a single job and not to re run the full suite > (we still have some flakes) > > https://github.com/apache/bookkeeper/pull/1572 > > If you create a PR you will see that the user has the ability to 'skip' > some jobs, maybe because his change is only about the website or about some > specific parts. > In Bookkeeper we have very strict review-then-commit rules so every one > uses PRs in his every day activity on BK. > > On Zookeeper we have a single precommit job which builds PRs and now we are > also enabling Travis this month (the project is migrating from Ant to Maven > and so Travis will be easy to use and most usable for non committers) > > In both of the two projects we have configured the 'trigger phrase' and we > have whitelisted the apache committers github group for such trigger. > > Currently all of the jobs are triggered even at PR creation and at > close/reopen, this can be dangerous. We can skip this for Maven and enable > only the trigger phrase. > As already said this is not possible with current maven-box plugin > > Enrico > > > Regards, > > > > Hervé > > > > > > Cheers > > > > Tibor > > > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > > > > manf...@simpligility.com> > > > > > > wrote: > > > > > I agree with Tibor. I would rather not have to deal with two > > > > different > > > > > > > CI > > > > > systems... > > > > > > > > > > Manfred > > > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > > @Stephen Connolly > > > > > > After such a big investment, especially made on your side, in > > > > Jenkins > > > > > > > > plugin you developed you do not want to support the GitHub PRs and > > > > you > > > > > > > just > > > > > > > > > > > let be to go with TravisCI just like that? I do not think so! > > > > > > T > > > > > > > > > > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > > > > > > > > > > stephen.alan.conno...@gmail.com> wrote: > > > > > >> +1 from me > > > > > >> > > > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > > > > > > > > > wrote: > > > > > >> > Hi, > > > > > >> > I would like to try out Travis on this small plugin: > > > > > >> > https://github.com/apache/maven-scripting-plugin > > > > > >> > > > > > > >> > I have pushed a minimal configuration file > > > > > >> > I need to ask to Infra, but I need approval from the community > > > > and > > > > > > > >> PMCs... > > > > > >> > > > > > >> > Can I proceed ? > > > > > >> > > > > > > >> > Enrico > > > > > > > > - > > > > > > > > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > >> > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >> > > > > > > >> > -- > > > > > >> > > > > > >> Sent from my phone > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > >
