Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260270
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java
---
@@ -0,0 +1,65
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121256322
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -1399,12 +1400,22 @@ private static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121256320
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -1399,12 +1400,22 @@ private static
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@britter
I think the version is not mandatory right now. I have to anyway replay
each commit and squash in one on the top of future origin master.
---
If your project is set up
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/141
No worries about the commit if it is messy.
I will pick up every single commit, make a patch and apply to master.
On Mon, Jun 5, 2017 at 10:30 AM, Benedikt Ritter <notific
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/146
@britter
@mgreau
Done.
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=70c8843e935882b0a78916894cb9f042964f2717
---
If your project is set up for it, you
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/146
@mgreau
@britter
Hey guys, let's utilize your power and complete `AbstractSurefireMojo` with
`ProviderInfo`, some tests are still in progress.
Meanwhile Apache Maven
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@britter
We have to finish 2.20.1 but we can finish the junit5 provider. Where did
we finish last time?
---
If your project is set up for it, you can reply to this email and have your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/152
@michaldo
Version 3.0 will have configurable via Java interface in pom.xml.
This way you can turn the behavior to file system.
Please check Jira [1] with version 3.0. Maybe we
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/151
Thx for contributing. Pls close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/151
@Tunaki
Good catch. Would you create Jira ticket in
https://issues.apache.org/jira/browse/SUREFIRE ?
---
If your project is set up for it, you can reply to this email and have your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/149
DOCTYPE is old.
Do you mean report XML e.g. `surefire-reports/TEST-MyTest.xml`?
```
http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation="
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
IIYC you mean test-methods by "children".
The classes and suites are under our control mean ParallelComputer only? Is
it under Spock control as well?
On Wed, May 10,
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
hm, I am not sure creating runners is possible and even if it is how this
could work with us because we create JUnitCore instance and put PC in to if
and intercept JUnit builder
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
Makes sense.
Why, what is the purpose in your f/w to schedule empty runner?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
There is one occasion when you set Filter to ParentRunner all children
could be filtered out.
On Fri, May 5, 2017 at 9:52 AM, Fedor Bobin <notificati...@github.com>
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
Question.
Could it happen that a runner has no children, as e.g. JUnit's runner
builder creates runners?
It does not make sense to allocate a thread for empty runner because
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
The release would not be that fast. Maybe next month. There is quite a lot
to do.
I need to find spare time to see if the changes in
ParallelComputerBuilder.java
<ht
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/147
I hope we will release 2.20.1 soon, EO April - BO May.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/147
@jerrinot
Thx for contributing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/147
@jerrinot
Pls close this PR. I created a branch
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=9c0025ed53d70c06279fef6c0fc30a54aeeab27b
---
If your project
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/147
I am just discussing with ASF colleagues rewriting `StatelessXmlReporter`
to JAXB.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/147#discussion_r111644325
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
---
@@ -292,15 +293,15 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/147#discussion_r111643377
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
---
@@ -91,7 +93,7 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/147#discussion_r111643120
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
---
@@ -91,7 +93,7 @@ public
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/146
Not on the same version. It's not legal to introduce incomplete feature.
The acceptable way would be to introduce junit5 in 3.0-alpha-1.
---
If your project is set up for it, you can reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/146
@mgreau
The time has not yet come for 3.0 and junit5.
We are in progress. Both branches are not mergable. I should cherry pick
changes and fix a failing IT in 3.0-rc1. First of all
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/145
@flungo
Thank You for the fix and let them coming more.
Your fix has been merged to master.
Please close this pull request.
https://issues.apache.org/jira/browse/SUREFIRE-1355
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/143#discussion_r108780826
--- Diff:
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
---
@@ -196,7 +196,8 @@ else
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/143#discussion_r108779823
--- Diff:
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java
---
@@ -156,6 +158,15 @@ public boolean
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/144
But most of these changes are not related to communication between JVMs.
I spoke with Michael-O and we know the root cause. The problem is that the
JVM does not receive data via std
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103107177
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -236,13 +236,17 @@ private static void exit( int
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103107040
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
---
@@ -69,8 +69,8 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103106957
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -236,13 +236,17 @@ private static void exit( int
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103106853
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
---
@@ -240,6 +240,10 @@ public
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@sbrannen
It looks like we will rename 2.19.2 to 2.20.0, but this is not official yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter
@marcphilipp
Done. We are preparing a new release version of Maven and Surefire was
examined last days. We still investigate some issues.
---
If your project is set up
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter
Sure I will do it, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/142
@britter
LGTM
We have to wait for release 2.19.2.
After that I will squash previous changes into one and commit to master
which will be 3.0 RC1.
Meanwhile we can continue
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/110
@jonenst you can have a look in this branch if you want to
* [new branch]SUREFIRE-1322 -> apache/SUREFIRE-1322
---
If your project is set up for it, you can re
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/110
@jonenst I am still recovering the plugin. I would like to invite you to
make code review if you like.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/110
@jonenst
I was about to finish the last one and suddenly we had internal collision
and now we reverted 11 commits. I am going to fix them but the procedure will
be that we have
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
We had an internal collision and I tried to recover from this and reverted
11 commits and now trying to fix them and add the last jira fix and then cut
the release version. Please
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/140
Sorry but what you mean by this PR?
On Wed, Jan 18, 2017 at 3:37 AM, xiaoguangma <notificati...@github.com>
wrote:
> é
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
I have this PR in my mind, do not worry. The problem is that we may cleanup
our codeline and I do not want to loose your path in master after we
revert. Pls wait few days
Github user Tibor17 closed the pull request at:
https://github.com/apache/maven-surefire/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/139
@britter
@ChristianSchulte
If you have no objections to this I will push it to master. Thx.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/139
[SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing
resources.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/137
@jsdima
Thx for contributing. Pls close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/137
@jsdima
Long time I was thinking about deleting the class `ThreadedStreamConsumer`.
It looks like old mechanism where data was populated from multiple
`ForkStarter`s
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/137
@jsdima
The constructor of `BlockingQueue` takes capacity of 2xE09 which
practically means no limitation.
The only operation which can block is `queue.take()`. What call sequences
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/137
@jsdima
I am interested in this problem because as you said the plugin hangs. Why
the plugin hanged, do you have explanation?
Did you run the build with your patch? It means `mvn -P
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/138
@sverhagen
Thx for contributing. This PR was merged. Pls close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
You mean this PR does not pass on Win or the master origin?
Please see our Jenkins on Windows. It passed
https://builds.apache.org/job/maven-surefire-windows
---
If your
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91498487
--- Diff:
surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java
---
@@ -32,15
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@szpak @Fuud
Pls post the test result `mvn install -P run-its`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91397951
--- Diff:
surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java
---
@@ -428,10
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/110
@jonenst
Next week on Friday it should be already in Maven Central.
See the raod map [1]. We have last issue in good progress with 100%
coverage of stream encoder and the only
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/135
@britter
I will push it to the branch junit5.
Afterwards can you provide one more PR to merge junit5 branch from
origin/master?
---
If your project is set up for it, you can reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/130
@michaeltandy
Thx for contributing. I committed your sources and included you github name
in the IT class. Please close this PR.
---
If your project is set up for it, you can reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/135
@britter
I think no user would like to specify `` in plugin in POM and
he would not specify whether junit4 or junit5 as a duplicate to provider
dependency.
Basically all we need
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/135
@britter
It is not the right way to detect the presents of the JUnit annotations in
classpath because the test classes may initialize static context yet in Maven
process like we do
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/135
@britter
Yes, Let's use profiles for our testing purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/132
@britter
Done. Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/132
@britter
I have fixed the issue but it is JUnit 4.7 issue.
This is useless `.addGoal( "-Dprovider=surefire-junit4" )` and
`.setJUnitVersion( "4.7" )` ditto
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/134
@britter
Done. Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/136
@michaeltandy
I will use your test but meanwhile I would like to avoid channelId used in
ForckClient because channelId is obsolete and ForkClient is used per for/thread
and therefore
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/130
@michaeltandy
I was inspired by your PR. Can you make a code review
https://github.com/apache/maven-surefire/pull/136?
I would like to run all IT tests and include yours
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/136
[SUREFIRE-1295] Attribute JVM crashes to tests
I have 4 tests ATest.java .. DTest.java, and CTest fails like this:
```
@Test
public void x
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/110
@justinharringa
Yes fixing the critical issues is never ending story.
I will release 2.19.2 and 2.19.3 later.
---
If your project is set up for it, you can reply to this email
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/133
@britter
>If this i going into the right direction, we can create a parent pom file
with the profiles and adopt this to more of the existing tests.
Activating Maven profi
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/133
@britter
Here in GitHub are a lots of commits. Which one should I have a look? It
seems you merged origin/master from junit5 branch to master again.
---
If your project is set up
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/132
@britter
The JUnit should be stable. Do you see in stacktrace why it fails with 4.7?
Is it our problem or JUnit problem?
---
If your project is set up for it, you can reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/112
@cardil
`-DrunOrder=random:123456` I meant as well.
The enums are only some model representation of real world but it does not
mean that we cannot change it.
What we should
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@michael-o
I will merge it no problem. The only problem on IT is my spare time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@michael-o
Any objections to merget this or do we need to test it with specific use
case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@rpatrick00
LGTM
I have tested the change on Win7 and Fedora23.
I will merge your PR with master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/122
@vaimr
I had to change more things. See this diff and close the issue. Thx for
contributing.
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commitdiff;h
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/122
@vaimr
Pls create Jira ticket [1] for this issue with the same title.
[1] https://issues.apache.org/jira/browse/SUREFIRE
---
If your project is set up for it, you can reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/122
@vaimr
I would prefer a single commit. You was too fast :)
Are you able to squash the commits finally?
Pls update the project and merge.
---
If your project is set up
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/122#discussion_r85649207
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -70,33 +54,25 @@
import
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/122#discussion_r85649125
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -2014,7 +2022,7 @@ private Artifact
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/129
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/122
We have such feature in Surefire. It is called "runorder". Makes sense
since the second run.
On Thu, Oct 13, 2016 at 9:04 AM, Denis Saponenko <notificati...@github.c
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@britter No big problem. Can you always run build locally? AFAIK your PC is
running the build two hours. Normally 45 minutes in Jenkins and my PC Intel i7
4Core 3GHz SSD disk.
---
If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@britter
Finally please merge master to junit5 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/122
@vaimr How it could happen that several parallel Surefire plugins run in
parallel within the same Maven module? Maven does not allow this.
---
If your project is set up for it, you can
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
I fixed this issue where I removed [1]. The reason behind is the
`IsolatedClassLoader` in plugin process which did not have shaded
`commons-lang3` in original jar file of `surefire-common
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@britter
After using one integration tests only
`org/apache/**/JUnit47ParallelIT.java`
I got same errors as in Jenkins.
I think the dependency `commons-lang3
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
Try to clone Surefire master and just run "mvn test"
Caused by: java.lang.NoClassDefFoundError:
org/apache/commons/lang3/O
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@britter
It seems you forgot to add `ASF commons` dependency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@britter
The build failed [1]. Did you run a local build on your side?
[1] https://builds.apache.org/job/maven-surefire/1638/console
---
If your project is set up for it, you can
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
@britter
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/125
@britter
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
After we are done with all commits, would you be able to safely squash them
in one single commit?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82700832
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
---
@@ -76,7 +76,7 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699845
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
---
@@ -76,7 +76,7 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699554
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleReporter.java
---
@@ -33,7 +33,10 @@
class
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699403
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleOutputReceiver.java
---
@@ -31,7 +31,13
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/126
@britter
The only problem is with workspace for the `Junit4VersionsIT` which is
`/target/Junit4VersionsIT_testJunit` same for all parameters. Therefore we
should not take the only
101 - 200 of 507 matches
Mail list logo
