Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-06 Thread Hervé BOUTEMY
Le jeudi 5 janvier 2017, 22:40:10 CET Robert Scholte a écrit :
> Hervé Boutemy:
> It seems that all issues have to do with expanding URLs and connections.
yes, calculating effective values for each pom

> Right now there's business logic in the ModelBuilder to calculate such
> values. We already had some discussions about this :) My question is: is
> this really necessary for the effective pom or are the related plugins
> (m-site-p, m-release-p, etc) capable to calculate it?
a lot of things can be done independently by plugins: that's a fact. When you 
look at it, report plugins configuration and execution is now in maven-report-
exec, which does a lot of things similar to what Maven core does to run Mojos.
It makes things really complex for plugins, to redo something that was until 
now done centrally by Maven core.
Then honestly, is it necessary? it's a question of choice.

> For the SCM
> connections it is quite clear for that the SCM provider should
> (re)-calculate the connection, and don't use the SVN concept as done right
> now (in fact, you can find scm-specific hacks in the code)
no, it's not that clear: yes, we can make something very open (more open than 
url(child) = url(parent) + / + artifactId), then complex, then require to 
delegate, then don't have the effective value in effective pom and force 
plugins to calculate effective value when they need it.
or we can consider that the little improvement I did on the algorithm (be able 
to use a path instead of artifactId, or not add anything) is sufficient, since 
adding a path is really something you expect from url semantics

I'm convinced of the second solution, and we both know didn't convince you yet 
:)

> I really hope it is not necessary to introduce these special properties.
they are the minimum to have something a little bit configurable but yet 
standardized

> I
> have more hope in the distribution-pom or leave the responsibility to the
> plugins using these values. For that reason no 3.5.0 for me.
I don't like to postpone such work done for one year, but since 3.5.0 is on 
convergence and mutual understanding, it's clear I'll need to accept to 
postpone...
I'll prepare a branch and we'll have a discussion, probably after 3.5.0

Regards,

Hervé

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-05 Thread Robert Scholte

Regarding the proposed changes:

Stephen Connolly:
MNG-5823 - mvnDebug doesn't work with M2_HOME with spaces - missing quotes

is this one superseded by MNG-5607?

MNG-5837 - Syntax error in bin/mvn on Solaris SPARC

Cannot confirm

MNG-5904 - Remove the whole Ant Build

I'd say 3.5.1

MNG-5967 - Dependency updates.
There's no list, so it's unclear which have been updated (and if some  
are for a specific fix)

MNG-5968 - Default plugin version updates.

 We've starting moving these versions to there matching packaging plugin

MNG-6150 - Javadoc improvements for 3.5.0

This one is fine for 3.5.0


Christian Schulte:
All have comments from Stephen, which I agree on

Guillaume Boué:
None issues left

Michael Osipov:
MNG-5457 - Show repository id when downloading or uploading from/to a  
remote repository
Based on some commits it seems like some build.log files are verified  
on these lines. Will require a bit more work, so 3.5.1 for me

MNG-5567 - Zip files are not included in classpaths at all
True according to specs, but hardly ever seen this as an issue. I'd  
like to push this to 5.0.0 and combine it with the PDT files. I have  
some more usecases

MNG-6136 - Upgrade Maven Wagon to 2.11
I don't see critical issues and IMHO the period is too short that 2.11  
has proven itself
MNG-6137 - Clean up duplicate dependencies caused by incomplete Wagon HTTP  
Provider exclusions

depends on MNG-6136


Hervé Boutemy:
It seems that all issues have to do with expanding URLs and connections.  
Right now there's business logic in the ModelBuilder to calculate such  
values. We already had some discussions about this :) My question is: is  
this really necessary for the effective pom or are the related plugins  
(m-site-p, m-release-p, etc) capable to calculate it? For the SCM  
connections it is quite clear for that the SCM provider should  
(re)-calculate the connection, and don't use the SVN concept as done right  
now (in fact, you can find scm-specific hacks in the code)
I really hope it is not necessary to introduce these special properties. I  
have more hope in the distribution-pom or leave the responsibility to the  
plugins using these values. For that reason no 3.5.0 for me.


Robert Scholte
Agree on all, just waiting for others to confirm ;)

Robert

On Sat, 31 Dec 2016 21:10:47 +0100, Stephen Connolly  
 wrote:


Here are the changes in current master since 3.3.9 (with some minor  
changes

omitted)

Issue ID   Target Version   Summary
   ==   
MNG-1577   WONTFIX  dependencyManagement does not work for
transitive dependencies
MNG-2199   WONTFIX  Support version ranges in parent elements
MNG-2478   WONTFIX  add "resources-filtered" filtered resource
directories to super POM
MNG-3507   WONTFIX  added support for multi-lines error message
with color
MNG-3507   WONTFIX  ANSI Color logging for improved output
visibility.
MNG-3705   WONTFIX  fixed mojo execution id color display
MNG-3825   WONTFIX  Dependencies with classifier should not
always require a version.
MNG-4345   WONTFIX  [regression] Plugin executions contributed
by default lifecycle mapping execute after
other plugin executions bound to the same
phase"
MNG-4347   WONTFIX  import-scoped dependencies of direct
dependencies are not resolved using profile
modifications from settings.xml
MNG-4463   WONTFIX  Dependency management import should support
version ranges.
MNG-4645   WONTFIX  Move central repo definition out of Maven's
core so it can be more easily changed.
MNG-5227   WONTFIX  The 'optional' flag of a dependency should
be manageable.
MNG-5297   WONTFIX  improved explanations on prerequisites.maven
in Maven 3
MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
to lifecycle (regression)
MNG-5368   WONTFIX  UnsupportedOperationException thrown when
version range is not correct in
dependencyManagement definitions
MNG-5457   WONTFIX  Show repository id when downloading or
uploading from/to a remote repository
MNG-5527   WONTFIX  Relocation does not work for imported poms
MNG-5538   WONTFIX  mvn start script causes cygwin warning
MNG-5567   WONTFIX  Zip files are not included in classpaths at
all
MNG-5600   WONTFIX  Dependency management import should support
   

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-04 Thread Michael Osipov

Am 2017-01-04 um 10:06 schrieb Stephen Connolly:

On 31 December 2016 at 20:10, Stephen Connolly
I have updated the tracking of these issues previously without a JIRA:

MNG-   WONTFIX  Removing redundant test


This is part of MNG-5977


MNG-   WONTFIX  updated code to match API change after
Michael's feedback
MNG-   WONTFIX  updated code to match MessageBuilder API
change


Both commits are part of Hervé's work on MNG-3507 and alike.

Michael





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-04 Thread Stephen Connolly
On 31 December 2016 at 20:10, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> MNG-   WONTFIX  Add a ProjectArtifactsCache similar to
> PluginArtifactsCache
> MNG-   WONTFIX  added core extensions documentation
> MNG-   WONTFIX  added slf4j-api and jansi dependencies
> MNG-   WONTFIX  Added some docs in CLIReporting Utils
> MNG-   WONTFIX  Avoid implicit conversions of int to long
> MNG-   WONTFIX  Cleaned up code using the ComparableVersion
> class prevents warnings in IDE about raw
> types.
> MNG-   WONTFIX  cleanup previous installation before
> installing
> the new one
> MNG-   WONTFIX  Code polishing  o Replaced
> Collections.unmodifiableList() with
> google ImmutableSet to keep the original Set
> type.
> MNG-   WONTFIX  Code polishing  o Replaced static initializer
> block with unmodifiableList()
> list to make sure the list itself will
> never being changed.
> MNG-   WONTFIX  Fixing misspellings in test names
> MNG-   WONTFIX  Increased memory for forked JVM from 256 to
> 385m.
> MNG-   WONTFIX  Build plugin updates.
> MNG-   WONTFIX  Updated 'DefaultSettingsDecrypter' to allow
> configuration to be set programmatically.
> MNG-   WONTFIX  Updated to remove deprecated 
> element causing a warning.
> MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
> #testGetMissingJarForced()
> MNG-   WONTFIX  Remove ancient Subversion keywords
> MNG-   WONTFIX  Removing redundant test
> MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
> to 2.10
> MNG-   WONTFIX  updated code to match API change after
> Michael's feedback
> MNG-   WONTFIX  updated code to match MessageBuilder API
> change
> MNG-   WONTFIX  Updated doap_Maven.rdf file
> MNG-   WONTFIX  updated parent pom
> MNG-   WONTFIX  Updated to correct '[ERROR] src/main/java
> /org/apache/maven/execution/
> MavenExecutionRequest.java[31:8] (imports)
> UnusedImports: Unused import -
> org.apache.maven.lifecycle.internal.
> builder.Builder.'.
> MNG-   WONTFIX  Updated to correct '[ERROR] src/main/java
> /org/apache/maven/execution/
> MavenExecutionRequest.java[391] (sizes)
> LineLength: Line is longer than 120
> characters (found 131).
> [ERROR] src/main/java/org/apache/maven/
> execution/MavenExecutionRequest.java[398]
> (sizes) LineLength: Line is longer than
> 120 characters (found 130).'.
> MNG-   WONTFIX  Updated to ensure 'MavenProject.
> getManagedVersionMap()' consistently
> returns an immutable map.
> MNG-   WONTFIX  Updated to ensure collections are immutable
> consistently.
> MNG-   WONTFIX  Updated to get rid of some Javadoc warnings.
> MNG-   WONTFIX  Updated to make the
> 'JavaDependencyContextRefiner' part of the
> dependency graph transformer lost in
> commit
> 3916201b985c281a2b073b9b764bbb554584f5a7.
> MNG-   WONTFIX  Updated to remove various Javadoc warnings.
> MNG-   WONTFIX  Updated to use the try-with-resources
> statement.
> MNG-   WONTFIX  upgrade m-assembly-p to 3.0.0
> MNG-   WONTFIX  Use proper spelling of "e.g."
> MNG-   WONTFIX  Use the proper term for char U+002D (-)
> hyphen(-minus) instead of dash
> MNG-   WONTFIX  Work around a rounding bug existed upto
> Java 7
>

I have updated the tracking of these issues previously without a JIRA:

MNG-   WONTFIX  Add a ProjectArtifactsCache similar to
PluginArtifactsCache
MNG-6150   WONTFIX  added core extensions documentation
MNG-3507   WONTFIX  added slf4j-api and jansi dependencies
MNG-6150   WONTFIX

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Stephen Connolly
Seconded on both

I'll update the wiki page tomorrow

On Tue 3 Jan 2017 at 21:44, Michael Osipov  wrote:

> Am 2017-01-02 um 21:34 schrieb Stephen Connolly:
>
> > On 2 January 2017 at 20:15, Michael Osipov  wrote:
>
> >
>
>  MNG-6029,
>
> >
>
> > I'd second this for 3.5.1
>
> > I have concerns with introducing for 3.5.0 as it affects how the
>
> > classpath
>
> > gets built and could cause behaviour differences between 3.3.9 and
> 3.5.0
>
> > (as it causes the test classpath to actually get resolved)
>
> >
>
> > -1 for 3.5.0 but I am open to change my position
>
> >
>
> >
>
>  It is actually two-fold, duplicate code and wrong scope. Fix has been
>
>  there for seven months without causing any IT failures. I think is is
> a
>
>  safe bet for an RC.
>
> 
>
> >>>
>
> >>>
>
> >>> But it breaks my goal for 3.5.0... the duplicate code part is OK for
>
> >>> 3.5.0... but the fixing the scope bug is why I remain -1. Perfectly
> fine
>
> >>> for 3.5.1
>
> >>>
>
> >>
>
> >> Let's split it! What do you think?
>
> >
>
> >
>
> > I am fine on the duplicate code removal for 3.5.0 as it should be a
> no-op.
>
> >
>
> > Create a new JIRA for the test scope change then and we can include that
> in
>
> > for 3.5.1?
>
>
>
> Here are the splitted issues:
>
> > [MNG-6147] MetadataResolutionResult#getGraph() contains duplicate if
> clause
>
>
>
> FIX-3.5.0
>
>
>
> > [MNG-6149] MetadataResolutionResult#getGraph() never resolves request
> type 'test'
>
>
>
> FIX-3.5.1
>
>
>
> Is that ok for you?
>
>
>
> Michael
>
>
>
> -
>
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
> --
Sent from my phone


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Christian Schulte
Am 01/03/17 um 14:55 schrieb Robert Scholte:
> Unscrubbed:
> MNG-5670 - ConcurrentModificationException during  
> DefaultMaven.newRepositorySession

This is related to MNG-6053 and MNG-6105. You can see that there is a
commit @MNG-6105 touching 'MavenRepositorySystemUtils' as well.  Should
be part of 3.5.0, IMHO. Maybe already is part of 3.5.0 due to MNG-6105
having the final fix to this.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Michael Osipov

Am 2017-01-02 um 21:34 schrieb Stephen Connolly:

On 2 January 2017 at 20:15, Michael Osipov  wrote:


MNG-6029,


I'd second this for 3.5.1
I have concerns with introducing for 3.5.0 as it affects how the
classpath
gets built and could cause behaviour differences between 3.3.9 and 3.5.0
(as it causes the test classpath to actually get resolved)

-1 for 3.5.0 but I am open to change my position



It is actually two-fold, duplicate code and wrong scope. Fix has been
there for seven months without causing any IT failures. I think is is a
safe bet for an RC.




But it breaks my goal for 3.5.0... the duplicate code part is OK for
3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
for 3.5.1



Let's split it! What do you think?



I am fine on the duplicate code removal for 3.5.0 as it should be a no-op.

Create a new JIRA for the test scope change then and we can include that in
for 3.5.1?


Here are the splitted issues:

[MNG-6147] MetadataResolutionResult#getGraph() contains duplicate if clause


FIX-3.5.0


[MNG-6149] MetadataResolutionResult#getGraph() never resolves request type 
'test'


FIX-3.5.1

Is that ok for you?

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Robert Scholte

MNG-   WONTFIX  upgrade m-assembly-p to 3.0.0

Created MNG-6148 for this. There are more plugins effected by this, but I  
guess these were updated in the general "update plugins" ticket.

IMO we should bind all plugin updates required for Java9 to this issue.

For me M3.5.1 is good enough as target, I've seen it working with Java9.

Robert

On Tue, 03 Jan 2017 15:19:06 +0100, Stephen Connolly  
 wrote:



https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017 is updated
with these scope changes.

We still have 24 JIRAs under consideration... plus we need to decide on  
the

commits that do not have a JIRA

On Tue, 3 Jan 2017 at 13:55 Robert Scholte  wrote:


Just to confirm: I agree on the "Agreed changes" too

I'd like to add for 3.5.0:

By Stephen:
MNG-5824 - Support MAVEN_ARGS environment variable as a way of supplying
default command line arguments
MNG-5836 - logging config is overwritten by $M2_HOME/lib/ext/*.jar
MNG-5946 - Fix links etc. in README.txt which is part of the delivery

By Christian:
MNG-6023 - Upgrade of slf4j-simple to a version later than 1.7.16  
blocked

by upstream issue.

By Guillaume:
MNG-6117 - ${session.parallel} not correctly set

By Michael:
MNG-5954 - Remove outdated
maven-embedder/src/main/resources/META-INF/MANIFEST.MF
MNG-6102 - Introduce ${maven.conf} in m2.conf

 From Hervé:
MNG-6088 - after forked execution success, add an empty line
MNG-6092 - warn if prerequisites.maven is used for non-plugin projects

Unscrubbed:
MNG-5670 - ConcurrentModificationException during
DefaultMaven.newRepositorySession
MNG-6078 - Can't overwrite properties which have been defined in
.mvn/maven.config
MNG-6109   PluginDescriptor doesn't read since value of parameter


thanks,
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Michael Osipov

Am 2017-01-03 um 15:19 schrieb Stephen Connolly:

https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017 is updated
with these scope changes.

We still have 24 JIRAs under consideration... plus we need to decide on the
commits that do not have a JIRA


For my issue-less commits:

4f4690cb9ab2ed6e7ad421c28c05c27994e57800 Avoid implicit conversions of int to 
long
d99f9ef8c7ffe56966945d6f1b66f0280866ded5 Fix checkstyle error
1c9362be4328713386bd23b01f9e2c87674cb952 Use static final values instead of 
literals
8d16c2256d591d0a567dbadec9cc933f15a53fcc Fix Checkstyle error
5a3332ca347628605bec7d3e9f9309081aaba46c Remove ancient Subversion keywords
52945a679ec8f3f571d77658eda2fce06d637aa7 Use proper spelling of "e.g."
a26cc1b9636e19c28cd32ed1c844fec64dec55b6 Use the proper term for char U+002D 
(-) hyphen(-minus) instead of dash


Will be squashed into one commit/issue: MNG-6146


0eb1e937bf377b1c81193da3d9fca7ef344511b6 Remove trailing whitespace
9ea4ef4b609199e2207bc5638a14a44f6697072a Update Maven Dependency Plugin in 
Super POM to 2.10


Drop them.


65a928462d4b0ff30c49f619abd341069aefcb98 Pass force=true to 
DefaultWagonManagerTest#testGetMissingJarForced()


MNG-6144


f1c9f3fa859a3e2fe4c30d7c067735af93edb37e Remove non-existent m2 include in 
component.xml


MNG-6145


96a75579567efd52927f559ce811528c3e4429fc Language style improvements for commit 
5dab4940c9a7d3b362bd2a8b078b183e4eb521bb


Already agreed with Hervé to squash this into MNG-3507, please note that.


6518f1f364d9085d21a711ef31e2d43cdf4fa443 Added some docs in CLIReporting Utils


Trivial.


0a5351340df0df48c4c1d95c021bdf3f4f278ee6 Work around a rounding bug existed 
upto Java 7
cfaee84adf44c53e7a169ddaf11e16308708cb88 Removing redundant test


Will be squashed into one commit/issue: MNG-5977

Michael




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Stephen Connolly
https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017 is updated
with these scope changes.

We still have 24 JIRAs under consideration... plus we need to decide on the
commits that do not have a JIRA

On Tue, 3 Jan 2017 at 13:55 Robert Scholte  wrote:

> Just to confirm: I agree on the "Agreed changes" too
>
> I'd like to add for 3.5.0:
>
> By Stephen:
> MNG-5824 - Support MAVEN_ARGS environment variable as a way of supplying
> default command line arguments
> MNG-5836 - logging config is overwritten by $M2_HOME/lib/ext/*.jar
> MNG-5946 - Fix links etc. in README.txt which is part of the delivery
>
> By Christian:
> MNG-6023 - Upgrade of slf4j-simple to a version later than 1.7.16 blocked
> by upstream issue.
>
> By Guillaume:
> MNG-6117 - ${session.parallel} not correctly set
>
> By Michael:
> MNG-5954 - Remove outdated
> maven-embedder/src/main/resources/META-INF/MANIFEST.MF
> MNG-6102 - Introduce ${maven.conf} in m2.conf
>
>  From Hervé:
> MNG-6088 - after forked execution success, add an empty line
> MNG-6092 - warn if prerequisites.maven is used for non-plugin projects
>
> Unscrubbed:
> MNG-5670 - ConcurrentModificationException during
> DefaultMaven.newRepositorySession
> MNG-6078 - Can't overwrite properties which have been defined in
> .mvn/maven.config
> MNG-6109   PluginDescriptor doesn't read since value of parameter
>
>
> thanks,
> Robert
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-03 Thread Robert Scholte

Just to confirm: I agree on the "Agreed changes" too

I'd like to add for 3.5.0:

By Stephen:
MNG-5824 - Support MAVEN_ARGS environment variable as a way of supplying  
default command line arguments

MNG-5836 - logging config is overwritten by $M2_HOME/lib/ext/*.jar
MNG-5946 - Fix links etc. in README.txt which is part of the delivery

By Christian:
MNG-6023 - Upgrade of slf4j-simple to a version later than 1.7.16 blocked  
by upstream issue.


By Guillaume:
MNG-6117 - ${session.parallel} not correctly set

By Michael:
MNG-5954 - Remove outdated  
maven-embedder/src/main/resources/META-INF/MANIFEST.MF

MNG-6102 - Introduce ${maven.conf} in m2.conf

From Hervé:
MNG-6088 - after forked execution success, add an empty line
MNG-6092 - warn if prerequisites.maven is used for non-plugin projects

Unscrubbed:
MNG-5670 - ConcurrentModificationException during  
DefaultMaven.newRepositorySession
MNG-6078 - Can't overwrite properties which have been defined in  
.mvn/maven.config

MNG-6109   PluginDescriptor doesn't read since value of parameter


thanks,
Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Hervé BOUTEMY
FIX-3.5.0: MNG-5889   .mvn directory should be picked when using --file

seconded

Regards,

Hervé


Le samedi 31 décembre 2016, 21:14:59 CET Stephen Connolly a écrit :
> FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
> MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
> MNG-6003, MNG-6078
> 
> I think colourised logging probably should be 3.5.x but I am open to the
> idea of making it 3.5.0 as it *should* not affect the build behaviour.
> 
> Do we have and seconders for the above?
> 
> Do we have anyone else proposing issues for 3.5.0?
> 
> - Stephen
> 
> 
> On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
> 
> stephen.alan.conno...@gmail.com> wrote:
> > Here are the changes in current master since 3.3.9 (with some minor
> > changes omitted)
> > 
> > Issue ID   Target Version   Summary
> >    ==   
> > MNG-1577   WONTFIX  dependencyManagement does not work for
> > 
> > transitive dependencies
> > 
> > MNG-2199   WONTFIX  Support version ranges in parent elements
> > MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> > 
> > directories to super POM
> > 
> > MNG-3507   WONTFIX  added support for multi-lines error message
> > 
> > with color
> > 
> > MNG-3507   WONTFIX  ANSI Color logging for improved output
> > 
> > visibility.
> > 
> > MNG-3705   WONTFIX  fixed mojo execution id color display
> > MNG-3825   WONTFIX  Dependencies with classifier should not
> > 
> > always require a version.
> > 
> > MNG-4345   WONTFIX  [regression] Plugin executions contributed
> > 
> > by default lifecycle mapping execute after
> > other plugin executions bound to the same
> > phase"
> > 
> > MNG-4347   WONTFIX  import-scoped dependencies of direct
> > 
> > dependencies are not resolved using profile
> > modifications from settings.xml
> > 
> > MNG-4463   WONTFIX  Dependency management import should support
> > 
> > version ranges.
> > 
> > MNG-4645   WONTFIX  Move central repo definition out of Maven's
> > 
> > core so it can be more easily changed.
> > 
> > MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> > 
> > be manageable.
> > 
> > MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> > 
> > in Maven 3
> > 
> > MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> > 
> > to lifecycle (regression)
> > 
> > MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> > 
> > version range is not correct in
> > dependencyManagement definitions
> > 
> > MNG-5457   WONTFIX  Show repository id when downloading or
> > 
> > uploading from/to a remote repository
> > 
> > MNG-5527   WONTFIX  Relocation does not work for imported poms
> > MNG-5538   WONTFIX  mvn start script causes cygwin warning
> > MNG-5567   WONTFIX  Zip files are not included in classpaths at
> > 
> > all
> > 
> > MNG-5600   WONTFIX  Dependency management import should support
> > 
> > exclusions.
> > 
> > MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> > 
> > scripts anymore
> > 
> > MNG-5629   WONTFIX  ClosedChannelException from
> > 
> > DefaultUpdateCheckManager.read
> > 
> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> > 
> > from Repo that contains a ${parameter}
> > 
> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> > 
> > from Repo that contains a ${parameter}
> > 
> > MNG-5661   WONTFIX  Make MavenProject instances immutable after
> > 
> > initial construction
> > 
> > MNG-5670   WONTFIX  guard against
> > 
> > ConcurrentModificationException
> > 
> > MNG-5761   WONTFIX  Dependency management is not transitive.
> > MNG-5761   WONTFIX  Dependency management is not transitive.
> > MNG-5761   WONTFIX  Dependency management is not transitive.
> > MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> > 
> > properly when using "&&"
> > 
> > MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> > 
> > spaces - missing 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Hervé BOUTEMY
looking for seconds on new features related to site url calculations:

MNG-4508 - No way to avoid adding artifactId to site urls
MNG-5878 - add support for module name != artifactId in every calculated URLs 
(project, SCM, site): special project.directory property
MNG-5951 - add an option to avoid path addition to inherited URLs
MNG-6059 - Important use cases not covered, as child.inherit.append.path 
affects all children

AFAIK, completely safe

Regards,

Hervé

Le samedi 31 décembre 2016, 20:10:47 CET Stephen Connolly a écrit :
> Here are the changes in current master since 3.3.9 (with some minor changes
> omitted)
> 
> Issue ID   Target Version   Summary
>    ==   
> MNG-1577   WONTFIX  dependencyManagement does not work for
> transitive dependencies
> MNG-2199   WONTFIX  Support version ranges in parent elements
> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> directories to super POM
> MNG-3507   WONTFIX  added support for multi-lines error message
> with color
> MNG-3507   WONTFIX  ANSI Color logging for improved output
> visibility.
> MNG-3705   WONTFIX  fixed mojo execution id color display
> MNG-3825   WONTFIX  Dependencies with classifier should not
> always require a version.
> MNG-4345   WONTFIX  [regression] Plugin executions contributed
> by default lifecycle mapping execute after
> other plugin executions bound to the same
> phase"
> MNG-4347   WONTFIX  import-scoped dependencies of direct
> dependencies are not resolved using profile
> modifications from settings.xml
> MNG-4463   WONTFIX  Dependency management import should support
> version ranges.
> MNG-4645   WONTFIX  Move central repo definition out of Maven's
> core so it can be more easily changed.
> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> be manageable.
> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> in Maven 3
> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> to lifecycle (regression)
> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> version range is not correct in
> dependencyManagement definitions
> MNG-5457   WONTFIX  Show repository id when downloading or
> uploading from/to a remote repository
> MNG-5527   WONTFIX  Relocation does not work for imported poms
> MNG-5538   WONTFIX  mvn start script causes cygwin warning
> MNG-5567   WONTFIX  Zip files are not included in classpaths at
> all
> MNG-5600   WONTFIX  Dependency management import should support
> exclusions.
> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> scripts anymore
> MNG-5629   WONTFIX  ClosedChannelException from
> DefaultUpdateCheckManager.read
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5661   WONTFIX  Make MavenProject instances immutable after
> initial construction
> MNG-5670   WONTFIX  guard against
> ConcurrentModificationException
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> properly when using "&&"
> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> spaces - missing quotes
> MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
> implemented in other ways in the meantime.
> MNG-5836   WONTFIX  put $maven.home/conf/logging first in
> classpath to avoid extension jar overriding
> logging config
> MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
> /bin/bash functions Submitted by: Joseph
> Walton 
> 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Hervé BOUTEMY
in general, I completely agree

in this specific case, where there were changes in 1.1.0 and 1.2.0-SNAPSHOT 
that we won't integrate yet, Aether 1.0.2 followed by Artifact Resolver 1.0.3 
with only coordinate changes (but not code) seems easier to understand

Regards,

Hervé

Le lundi 2 janvier 2017, 22:08:43 CET Michael Osipov a écrit :
> > Hervé will be adding the coordinate changes to that branch and then will
> > cut a 1.0.3 release which we will then change MNG-6110's title to
> > reference
> > 
> > So you see the change in 3.5.0 should be a no-op from 3.3.9
> 
> I sew what you are after. It makes sense. Though, I dislike to change
> coordinates in a patch release. This deserves a minor release (at least)
> for the relocation. Next release, with real changes, can be 2.0. 3.0
> will likely include new package names.
> 
> Michael
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Stephen Connolly
On Monday, 2 January 2017, Michael Osipov  wrote:

> Am 2017-01-02 um 21:34 schrieb Stephen Connolly:
>
>> On 2 January 2017 at 20:15, Michael Osipov  wrote:
>>
>> Am 2017-01-02 um 20:35 schrieb Stephen Connolly:
>>>
>>> On 2 January 2017 at 18:49, Michael Osipov  wrote:

 Am 2017-01-01 um 15:51 schrieb Stephen Connolly:

>
> On 1 January 2017 at 00:55, Michael Osipov 
> wrote:
>
>>
>> I just went through the list my issues. Here is a safe list I would
>>
>> merge/cherry-pick into new master:
>>>
>>> FIX-3.5.0:
>>> MNG-5567,
>>>
>>>
>>>
>> Affects behaviour, I recommend 3.5.1 but I will not object if others
>> feel
>> 3.5.0
>>
>>
>> This indeed changes behavior but behavioral changes should not be in a
> patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP
> files
> first-class citizens, we simply failed/forgot this here.
>
>
> Well that is why I see this as a patch fix. Changing behaviour where
 the
 original behaviour was a bug or a regression does not mean we have to
 bump
 a minor version.

 I think this and the plugin classpath building *bugs/regressions* are
 both
 perfectly valid to fix in a patch.


 I still think that 3.5.0 is appropriate.
>
>

 I still think that it raises the risk of marking the "no-op" change from
 aether to resolver as breaking existing builds.

 My plan is 3.5.0 in the next two weeks and 3.5.1, etc at a 6 week
 cadence
 thereafter. If you want I am happy to do 3.5.0 and 3.5.1 in more rapid
 sequence, but I really would like to keep dependency and classpath
 changes
 out of 3.5.0 and push them for 3.5.1 (where they are bugs / regressions)
 or
 3.6.0 (which should be as soon as we think we are ready, not a year or
 two's time


>>> Agreed.
>>>
>>>
>>>
> MNG-5954,
>
>
>>
>>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is
>> low
>> risk to drop-in replacement with 3.3.9
>>
>>
>> Do not share, it is never read. I even asked on dev list and Jason
> replied, it is safe to be nuked.
>
>

 If somebody else seconds, then it is agreed (unless we have an
 objector)...
 just I'm not going to second it for 3.5.0


>>> Anyone else?
>>>
>>>
>>>
> MNG-6029,
>
>>
>>
>>>
>>>
>> I'd second this for 3.5.1
>> I have concerns with introducing for 3.5.0 as it affects how the
>> classpath
>> gets built and could cause behaviour differences between 3.3.9 and
>> 3.5.0
>> (as it causes the test classpath to actually get resolved)
>>
>> -1 for 3.5.0 but I am open to change my position
>>
>>
>> It is actually two-fold, duplicate code and wrong scope. Fix has been
> there for seven months without causing any IT failures. I think is is a
> safe bet for an RC.
>
>

 But it breaks my goal for 3.5.0... the duplicate code part is OK for
 3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
 for 3.5.1


>>> Let's split it! What do you think?
>>>
>>
>>
>> I am fine on the duplicate code removal for 3.5.0 as it should be a no-op.
>>
>> Create a new JIRA for the test scope change then and we can include that
>> in
>> for 3.5.1?
>>
>
> Agreed. Will do tomorrow.
>
> MNG-6102,
>>>

>
>>
>>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is
>> low
>> risk to drop-in replacement with 3.3.9
>>
>>
>> This is change in behavior and not subject to a bugfix. The default
> behaves like before.
>
>

 This does not affect dependency / classpath resolution, but we are
 growing
 changes for 3.5.0 and I would like to try and keep the non
 s/aether/resolver/g changes to a minimum. If you can find another
 seconder
 it's in.


>>> Anyone else?
>>>
>>> MNG-6106,
>>>

>
>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is
>> low
>> risk to drop-in replacement with 3.3.9
>>
>>
>> This is actually a bug because maven.home can never be user.home/.m2
>
>


 This does not affect dependency / classpath resolution, but we are
 growing
 changes for 3.5.0 and I would like to try and keep the non
 s/aether/resolver/g changes to a minimum. If you can find another
 seconder
 it's in.


>>> Anyone else?
>>>
>>> MNG-6115,
>>>

>
>>
>>>
>> We need to decide on colourised logs for 3.5.0 or 3.5.1
>>
>>
>> Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could
> also
> be squashed into MNG-3507.
>
>

 It's a new 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Michael Osipov

Am 2017-01-02 um 21:34 schrieb Stephen Connolly:

On 2 January 2017 at 20:15, Michael Osipov  wrote:


Am 2017-01-02 um 20:35 schrieb Stephen Connolly:


On 2 January 2017 at 18:49, Michael Osipov  wrote:

Am 2017-01-01 um 15:51 schrieb Stephen Connolly:


On 1 January 2017 at 00:55, Michael Osipov  wrote:


I just went through the list my issues. Here is a safe list I would


merge/cherry-pick into new master:

FIX-3.5.0:
MNG-5567,




Affects behaviour, I recommend 3.5.1 but I will not object if others
feel
3.5.0



This indeed changes behavior but behavioral changes should not be in a
patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP
files
first-class citizens, we simply failed/forgot this here.



Well that is why I see this as a patch fix. Changing behaviour where the
original behaviour was a bug or a regression does not mean we have to bump
a minor version.

I think this and the plugin classpath building *bugs/regressions* are both
perfectly valid to fix in a patch.



I still think that 3.5.0 is appropriate.




I still think that it raises the risk of marking the "no-op" change from
aether to resolver as breaking existing builds.

My plan is 3.5.0 in the next two weeks and 3.5.1, etc at a 6 week cadence
thereafter. If you want I am happy to do 3.5.0 and 3.5.1 in more rapid
sequence, but I really would like to keep dependency and classpath changes
out of 3.5.0 and push them for 3.5.1 (where they are bugs / regressions)
or
3.6.0 (which should be as soon as we think we are ready, not a year or
two's time



Agreed.




MNG-5954,







I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



Do not share, it is never read. I even asked on dev list and Jason
replied, it is safe to be nuked.




If somebody else seconds, then it is agreed (unless we have an
objector)...
just I'm not going to second it for 3.5.0



Anyone else?




MNG-6029,







I'd second this for 3.5.1
I have concerns with introducing for 3.5.0 as it affects how the
classpath
gets built and could cause behaviour differences between 3.3.9 and 3.5.0
(as it causes the test classpath to actually get resolved)

-1 for 3.5.0 but I am open to change my position



It is actually two-fold, duplicate code and wrong scope. Fix has been
there for seven months without causing any IT failures. I think is is a
safe bet for an RC.




But it breaks my goal for 3.5.0... the duplicate code part is OK for
3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
for 3.5.1



Let's split it! What do you think?



I am fine on the duplicate code removal for 3.5.0 as it should be a no-op.

Create a new JIRA for the test scope change then and we can include that in
for 3.5.1?


Agreed. Will do tomorrow.


MNG-6102,








I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



This is change in behavior and not subject to a bugfix. The default
behaves like before.




This does not affect dependency / classpath resolution, but we are growing
changes for 3.5.0 and I would like to try and keep the non
s/aether/resolver/g changes to a minimum. If you can find another seconder
it's in.



Anyone else?

MNG-6106,





I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



This is actually a bug because maven.home can never be user.home/.m2





This does not affect dependency / classpath resolution, but we are growing
changes for 3.5.0 and I would like to try and keep the non
s/aether/resolver/g changes to a minimum. If you can find another seconder
it's in.



Anyone else?

MNG-6115,








We need to decide on colourised logs for 3.5.0 or 3.5.1



Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could
also
be squashed into MNG-3507.




It's a new feature for logging, but it doesn't add new APIs to the *core*
of maven. So I think we could put it in 3.5.1 if we decided our version
policy was "effects on plugin API / dependency resolution"

The squashed diff should be quite small, so I am fine with us adding it
for
3.5.0... I just am not stepping up to sponsor it



I'd like to handle over this to Hervé and make it his decision. I will
ping him in the ticket.

MNG-6136,








I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9

MNG-6137,






I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



Rather 3.5 or 3.6, consider that the last Wagon release is quite old and
currently, there duplicate dependencies on Maven's classpath as layed out
in MNG-6137.




I don't see this being something that needs to wait for 3.6.0... 3.5.1
seems perfectly ok to me



Why not 3.5 then? We update Resolver, why not Wagon? At last, Resolver
requires Wagon too as its 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Stephen Connolly
On 2 January 2017 at 20:34, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

>
>
> On 2 January 2017 at 20:15, Michael Osipov  wrote:
>
>> Am 2017-01-02 um 20:35 schrieb Stephen Connolly:
>>
>>> On 2 January 2017 at 18:49, Michael Osipov  wrote:
>>>
>>> Am 2017-01-01 um 15:51 schrieb Stephen Connolly:

 On 1 January 2017 at 00:55, Michael Osipov  wrote:
>
> I just went through the list my issues. Here is a safe list I would
>
>> merge/cherry-pick into new master:
>>
>> FIX-3.5.0:
>> MNG-5567,
>>
>>
>
> Affects behaviour, I recommend 3.5.1 but I will not object if others
> feel
> 3.5.0
>
>
 This indeed changes behavior but behavioral changes should not be in a
 patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP
 files
 first-class citizens, we simply failed/forgot this here.


>>> Well that is why I see this as a patch fix. Changing behaviour where the
>>> original behaviour was a bug or a regression does not mean we have to
>>> bump
>>> a minor version.
>>>
>>> I think this and the plugin classpath building *bugs/regressions* are
>>> both
>>> perfectly valid to fix in a patch.
>>>
>>>
 I still think that 3.5.0 is appropriate.

>>>
>>>
>>> I still think that it raises the risk of marking the "no-op" change from
>>> aether to resolver as breaking existing builds.
>>>
>>> My plan is 3.5.0 in the next two weeks and 3.5.1, etc at a 6 week cadence
>>> thereafter. If you want I am happy to do 3.5.0 and 3.5.1 in more rapid
>>> sequence, but I really would like to keep dependency and classpath
>>> changes
>>> out of 3.5.0 and push them for 3.5.1 (where they are bugs / regressions)
>>> or
>>> 3.6.0 (which should be as soon as we think we are ready, not a year or
>>> two's time
>>>
>>
>> Agreed.
>>
>>

 MNG-5954,

>
>>
>
> I'd second this for 3.5.1 but I'm not objecting if others feel it is
> low
> risk to drop-in replacement with 3.3.9
>
>
 Do not share, it is never read. I even asked on dev list and Jason
 replied, it is safe to be nuked.

>>>
>>>
>>> If somebody else seconds, then it is agreed (unless we have an
>>> objector)...
>>> just I'm not going to second it for 3.5.0
>>>
>>
>> Anyone else?
>>
>>

 MNG-6029,
>
>>
>>
>
> I'd second this for 3.5.1
> I have concerns with introducing for 3.5.0 as it affects how the
> classpath
> gets built and could cause behaviour differences between 3.3.9 and
> 3.5.0
> (as it causes the test classpath to actually get resolved)
>
> -1 for 3.5.0 but I am open to change my position
>
>
 It is actually two-fold, duplicate code and wrong scope. Fix has been
 there for seven months without causing any IT failures. I think is is a
 safe bet for an RC.

>>>
>>>
>>> But it breaks my goal for 3.5.0... the duplicate code part is OK for
>>> 3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
>>> for 3.5.1
>>>
>>
>> Let's split it! What do you think?
>
>
> I am fine on the duplicate code removal for 3.5.0 as it should be a no-op.
>
> Create a new JIRA for the test scope change then and we can include that
> in for 3.5.1?
>
>
>>
>>
>> MNG-6102,

>
>>
>
> I'd second this for 3.5.1 but I'm not objecting if others feel it is
> low
> risk to drop-in replacement with 3.3.9
>
>
 This is change in behavior and not subject to a bugfix. The default
 behaves like before.

>>>
>>>
>>> This does not affect dependency / classpath resolution, but we are
>>> growing
>>> changes for 3.5.0 and I would like to try and keep the non
>>> s/aether/resolver/g changes to a minimum. If you can find another
>>> seconder
>>> it's in.
>>>
>>
>> Anyone else?
>>
>> MNG-6106,

>
>
> I'd second this for 3.5.1 but I'm not objecting if others feel it is
> low
> risk to drop-in replacement with 3.3.9
>
>
 This is actually a bug because maven.home can never be user.home/.m2

>>>
>>>
>>>
>>> This does not affect dependency / classpath resolution, but we are
>>> growing
>>> changes for 3.5.0 and I would like to try and keep the non
>>> s/aether/resolver/g changes to a minimum. If you can find another
>>> seconder
>>> it's in.
>>>
>>
>> Anyone else?
>>
>> MNG-6115,

>
>>
>
> We need to decide on colourised logs for 3.5.0 or 3.5.1
>
>
 Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could
 also
 be squashed into MNG-3507.

>>>
>>>
>>> It's a new feature for logging, but it doesn't add new APIs to the *core*
>>> of maven. So I think we could put it in 3.5.1 if we decided our version
>>> policy was "effects on plugin API / dependency resolution"
>>>
>>> The squashed diff should be quite small, so I am fine with us adding it
>>> for
>>> 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Stephen Connolly
On 2 January 2017 at 20:15, Michael Osipov  wrote:

> Am 2017-01-02 um 20:35 schrieb Stephen Connolly:
>
>> On 2 January 2017 at 18:49, Michael Osipov  wrote:
>>
>> Am 2017-01-01 um 15:51 schrieb Stephen Connolly:
>>>
>>> On 1 January 2017 at 00:55, Michael Osipov  wrote:

 I just went through the list my issues. Here is a safe list I would

> merge/cherry-pick into new master:
>
> FIX-3.5.0:
> MNG-5567,
>
>

 Affects behaviour, I recommend 3.5.1 but I will not object if others
 feel
 3.5.0


>>> This indeed changes behavior but behavioral changes should not be in a
>>> patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP
>>> files
>>> first-class citizens, we simply failed/forgot this here.
>>>
>>>
>> Well that is why I see this as a patch fix. Changing behaviour where the
>> original behaviour was a bug or a regression does not mean we have to bump
>> a minor version.
>>
>> I think this and the plugin classpath building *bugs/regressions* are both
>> perfectly valid to fix in a patch.
>>
>>
>>> I still think that 3.5.0 is appropriate.
>>>
>>
>>
>> I still think that it raises the risk of marking the "no-op" change from
>> aether to resolver as breaking existing builds.
>>
>> My plan is 3.5.0 in the next two weeks and 3.5.1, etc at a 6 week cadence
>> thereafter. If you want I am happy to do 3.5.0 and 3.5.1 in more rapid
>> sequence, but I really would like to keep dependency and classpath changes
>> out of 3.5.0 and push them for 3.5.1 (where they are bugs / regressions)
>> or
>> 3.6.0 (which should be as soon as we think we are ready, not a year or
>> two's time
>>
>
> Agreed.
>
>
>>>
>>> MNG-5954,
>>>

>

 I'd second this for 3.5.1 but I'm not objecting if others feel it is low
 risk to drop-in replacement with 3.3.9


>>> Do not share, it is never read. I even asked on dev list and Jason
>>> replied, it is safe to be nuked.
>>>
>>
>>
>> If somebody else seconds, then it is agreed (unless we have an
>> objector)...
>> just I'm not going to second it for 3.5.0
>>
>
> Anyone else?
>
>
>>>
>>> MNG-6029,

>
>

 I'd second this for 3.5.1
 I have concerns with introducing for 3.5.0 as it affects how the
 classpath
 gets built and could cause behaviour differences between 3.3.9 and 3.5.0
 (as it causes the test classpath to actually get resolved)

 -1 for 3.5.0 but I am open to change my position


>>> It is actually two-fold, duplicate code and wrong scope. Fix has been
>>> there for seven months without causing any IT failures. I think is is a
>>> safe bet for an RC.
>>>
>>
>>
>> But it breaks my goal for 3.5.0... the duplicate code part is OK for
>> 3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
>> for 3.5.1
>>
>
> Let's split it! What do you think?


I am fine on the duplicate code removal for 3.5.0 as it should be a no-op.

Create a new JIRA for the test scope change then and we can include that in
for 3.5.1?


>
>
> MNG-6102,
>>>

>

 I'd second this for 3.5.1 but I'm not objecting if others feel it is low
 risk to drop-in replacement with 3.3.9


>>> This is change in behavior and not subject to a bugfix. The default
>>> behaves like before.
>>>
>>
>>
>> This does not affect dependency / classpath resolution, but we are growing
>> changes for 3.5.0 and I would like to try and keep the non
>> s/aether/resolver/g changes to a minimum. If you can find another seconder
>> it's in.
>>
>
> Anyone else?
>
> MNG-6106,
>>>


 I'd second this for 3.5.1 but I'm not objecting if others feel it is low
 risk to drop-in replacement with 3.3.9


>>> This is actually a bug because maven.home can never be user.home/.m2
>>>
>>
>>
>>
>> This does not affect dependency / classpath resolution, but we are growing
>> changes for 3.5.0 and I would like to try and keep the non
>> s/aether/resolver/g changes to a minimum. If you can find another seconder
>> it's in.
>>
>
> Anyone else?
>
> MNG-6115,
>>>

>

 We need to decide on colourised logs for 3.5.0 or 3.5.1


>>> Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could
>>> also
>>> be squashed into MNG-3507.
>>>
>>
>>
>> It's a new feature for logging, but it doesn't add new APIs to the *core*
>> of maven. So I think we could put it in 3.5.1 if we decided our version
>> policy was "effects on plugin API / dependency resolution"
>>
>> The squashed diff should be quite small, so I am fine with us adding it
>> for
>> 3.5.0... I just am not stepping up to sponsor it
>>
>
> I'd like to handle over this to Hervé and make it his decision. I will
> ping him in the ticket.
>
> MNG-6136,
>>>

>

 I'd second this for 3.5.1 but I'm not objecting if others feel it is low
 risk to drop-in replacement with 3.3.9

 MNG-6137,


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Robert Scholte
On Mon, 02 Jan 2017 21:04:57 +0100, Stephen Connolly  
 wrote:



On 31 December 2016 at 20:10, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:


Here are the changes in current master since 3.3.9 (with some minor
changes omitted)

Issue ID   Target Version   Summary
   ==   
MNG-6110   WONTFIX  Upgrade Aether to Maven Resolver 1.2



^ This should be 3.5.0 (though the version number may need updating in  
the

JIRA title first)







MNG-6110 should be part of M3.5.0

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Michael Osipov

Am 2017-01-02 um 20:35 schrieb Stephen Connolly:

On 2 January 2017 at 18:49, Michael Osipov  wrote:


Am 2017-01-01 um 15:51 schrieb Stephen Connolly:


On 1 January 2017 at 00:55, Michael Osipov  wrote:

I just went through the list my issues. Here is a safe list I would

merge/cherry-pick into new master:

FIX-3.5.0:
MNG-5567,




Affects behaviour, I recommend 3.5.1 but I will not object if others feel
3.5.0



This indeed changes behavior but behavioral changes should not be in a
patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP files
first-class citizens, we simply failed/forgot this here.



Well that is why I see this as a patch fix. Changing behaviour where the
original behaviour was a bug or a regression does not mean we have to bump
a minor version.

I think this and the plugin classpath building *bugs/regressions* are both
perfectly valid to fix in a patch.



I still think that 3.5.0 is appropriate.



I still think that it raises the risk of marking the "no-op" change from
aether to resolver as breaking existing builds.

My plan is 3.5.0 in the next two weeks and 3.5.1, etc at a 6 week cadence
thereafter. If you want I am happy to do 3.5.0 and 3.5.1 in more rapid
sequence, but I really would like to keep dependency and classpath changes
out of 3.5.0 and push them for 3.5.1 (where they are bugs / regressions) or
3.6.0 (which should be as soon as we think we are ready, not a year or
two's time


Agreed.




MNG-5954,





I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



Do not share, it is never read. I even asked on dev list and Jason
replied, it is safe to be nuked.



If somebody else seconds, then it is agreed (unless we have an objector)...
just I'm not going to second it for 3.5.0


Anyone else?





MNG-6029,





I'd second this for 3.5.1
I have concerns with introducing for 3.5.0 as it affects how the classpath
gets built and could cause behaviour differences between 3.3.9 and 3.5.0
(as it causes the test classpath to actually get resolved)

-1 for 3.5.0 but I am open to change my position



It is actually two-fold, duplicate code and wrong scope. Fix has been
there for seven months without causing any IT failures. I think is is a
safe bet for an RC.



But it breaks my goal for 3.5.0... the duplicate code part is OK for
3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
for 3.5.1


Let's split it! What do you think?


MNG-6102,





I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



This is change in behavior and not subject to a bugfix. The default
behaves like before.



This does not affect dependency / classpath resolution, but we are growing
changes for 3.5.0 and I would like to try and keep the non
s/aether/resolver/g changes to a minimum. If you can find another seconder
it's in.


Anyone else?


MNG-6106,



I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



This is actually a bug because maven.home can never be user.home/.m2




This does not affect dependency / classpath resolution, but we are growing
changes for 3.5.0 and I would like to try and keep the non
s/aether/resolver/g changes to a minimum. If you can find another seconder
it's in.


Anyone else?


MNG-6115,





We need to decide on colourised logs for 3.5.0 or 3.5.1



Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could also
be squashed into MNG-3507.



It's a new feature for logging, but it doesn't add new APIs to the *core*
of maven. So I think we could put it in 3.5.1 if we decided our version
policy was "effects on plugin API / dependency resolution"

The squashed diff should be quite small, so I am fine with us adding it for
3.5.0... I just am not stepping up to sponsor it


I'd like to handle over this to Hervé and make it his decision. I will 
ping him in the ticket.



MNG-6136,





I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9

MNG-6137,





I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9



Rather 3.5 or 3.6, consider that the last Wagon release is quite old and
currently, there duplicate dependencies on Maven's classpath as layed out
in MNG-6137.



I don't see this being something that needs to wait for 3.6.0... 3.5.1
seems perfectly ok to me


Why not 3.5 then? We update Resolver, why not Wagon? At last, Resolver 
requires Wagon too as its transport...


Michael



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Stephen Connolly
On 31 December 2016 at 20:10, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> Here are the changes in current master since 3.3.9 (with some minor
> changes omitted)
>
> Issue ID   Target Version   Summary
>    ==   
> MNG-6110   WONTFIX  Upgrade Aether to Maven Resolver 1.2
>

^ This should be 3.5.0 (though the version number may need updating in the
JIRA title first)


>
>


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Stephen Connolly
On 2 January 2017 at 18:49, Michael Osipov  wrote:

> Am 2017-01-01 um 15:51 schrieb Stephen Connolly:
>
>> On 1 January 2017 at 00:55, Michael Osipov  wrote:
>>
>> I just went through the list my issues. Here is a safe list I would
>>> merge/cherry-pick into new master:
>>>
>>> FIX-3.5.0:
>>> MNG-5567,
>>>
>>
>>
>> Affects behaviour, I recommend 3.5.1 but I will not object if others feel
>> 3.5.0
>>
>
> This indeed changes behavior but behavioral changes should not be in a
> patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP files
> first-class citizens, we simply failed/forgot this here.
>

Well that is why I see this as a patch fix. Changing behaviour where the
original behaviour was a bug or a regression does not mean we have to bump
a minor version.

I think this and the plugin classpath building *bugs/regressions* are both
perfectly valid to fix in a patch.

>
> I still think that 3.5.0 is appropriate.


I still think that it raises the risk of marking the "no-op" change from
aether to resolver as breaking existing builds.

My plan is 3.5.0 in the next two weeks and 3.5.1, etc at a 6 week cadence
thereafter. If you want I am happy to do 3.5.0 and 3.5.1 in more rapid
sequence, but I really would like to keep dependency and classpath changes
out of 3.5.0 and push them for 3.5.1 (where they are bugs / regressions) or
3.6.0 (which should be as soon as we think we are ready, not a year or
two's time


>
>
> MNG-5954,
>>>
>>
>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is low
>> risk to drop-in replacement with 3.3.9
>>
>
> Do not share, it is never read. I even asked on dev list and Jason
> replied, it is safe to be nuked.


If somebody else seconds, then it is agreed (unless we have an objector)...
just I'm not going to second it for 3.5.0


>
>
>
>> MNG-6029,
>>>
>>
>>
>> I'd second this for 3.5.1
>> I have concerns with introducing for 3.5.0 as it affects how the classpath
>> gets built and could cause behaviour differences between 3.3.9 and 3.5.0
>> (as it causes the test classpath to actually get resolved)
>>
>> -1 for 3.5.0 but I am open to change my position
>>
>
> It is actually two-fold, duplicate code and wrong scope. Fix has been
> there for seven months without causing any IT failures. I think is is a
> safe bet for an RC.


But it breaks my goal for 3.5.0... the duplicate code part is OK for
3.5.0... but the fixing the scope bug is why I remain -1. Perfectly fine
for 3.5.1


>
>
> MNG-6102,
>>>
>>
>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is low
>> risk to drop-in replacement with 3.3.9
>>
>
> This is change in behavior and not subject to a bugfix. The default
> behaves like before.


This does not affect dependency / classpath resolution, but we are growing
changes for 3.5.0 and I would like to try and keep the non
s/aether/resolver/g changes to a minimum. If you can find another seconder
it's in.


>
>
> MNG-6106,
>>
>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is low
>> risk to drop-in replacement with 3.3.9
>>
>
> This is actually a bug because maven.home can never be user.home/.m2



This does not affect dependency / classpath resolution, but we are growing
changes for 3.5.0 and I would like to try and keep the non
s/aether/resolver/g changes to a minimum. If you can find another seconder
it's in.


>
>
> MNG-6115,
>>>
>>
>>
>> We need to decide on colourised logs for 3.5.0 or 3.5.1
>>
>
> Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could also
> be squashed into MNG-3507.


It's a new feature for logging, but it doesn't add new APIs to the *core*
of maven. So I think we could put it in 3.5.1 if we decided our version
policy was "effects on plugin API / dependency resolution"

The squashed diff should be quite small, so I am fine with us adding it for
3.5.0... I just am not stepping up to sponsor it


>
>
> MNG-6136,
>>>
>>
>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is low
>> risk to drop-in replacement with 3.3.9
>>
>> MNG-6137,
>>>
>>
>>
>> I'd second this for 3.5.1 but I'm not objecting if others feel it is low
>> risk to drop-in replacement with 3.3.9
>>
>
> Rather 3.5 or 3.6, consider that the last Wagon release is quite old and
> currently, there duplicate dependencies on Maven's classpath as layed out
> in MNG-6137.


I don't see this being something that needs to wait for 3.6.0... 3.5.1
seems perfectly ok to me

>
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Michael Osipov

Am 2017-01-01 um 18:44 schrieb Guillaume Boué:

This is the list of JIRA issues that targets colourised logging / are
related to it:

MNG-3507 ANSI color logging for improved output visibilityThis
is the root JIRA issue.
MNG-3705 Expression: ${executedProject} doesn't work in reports
SVN revisions d4d7f4763f34e2c23e590ce02551943a1cad84e5 and
c6fb60b5482a12e3f94b74cd050ba46eddaa2423 are about it and actually
target MNG-3507.
MNG-6037 add gossip slf4j provider supportNote that the
colorization feature was removed from Gossip.
MNG-6038
use Gossip slf4j provider as default logging, since it supports
level colorizationWONTFIX
MNG-6041 Option -l does not disable colorized outputThose are
in-version fixes, to be squashed with MNG-3507.
MNG-6043 Colorization is disabled too late in batch mode
MNG-6046 upgrade JAnsi from 1.12 to 1.13
MNG-6093
create a slf4j-simple provider extension that supports level color
renderingThis supercedes MNG-6038 and adds colorization to the Slf4j
Provider.
MNG-6115
Add Jansi native library search path to our start scriptsThis
adds a system property to the launcher scripts. Should be safe to add
alone without impacts.


Please add if I forgot some. I hope it'll make deciding whether the
colorization feature, or parts of it, are added to 3.5.0 or later easier.


Already discussed with Hervé that some tickets created by me will be 
part of his work (already listed). Please also add commit: 
96a75579567efd52927f559ce811528c3e4429fc


Michael



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Michael Osipov

Am 2017-01-01 um 18:44 schrieb Guillaume Boué:


Le 01/01/2017 à 01:55, Michael Osipov a écrit :

I just went through the list my issues. Here is a safe list I would
merge/cherry-pick into new master:

FIX-3.5.0: MNG-5457,


Note: this is dependant upon MRESOLVER-2 (commit
https://git1-us-west.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=11b359e188f3b1d25bb6bda60195e7a47ca45bfc),
so it depends if this makes it in the resolver release after its reset.


I know, the issues have been linked properly.


MNG-5567,


This changes the classpath by adding ZIP files to it. I'd say this
should be FIX-3.5.1 instead.


This indeed changes behavior but behavioral changes should not be in a 
patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP 
files first-class citizens, we simply failed/forgot this here.


I still think that 3.5.0 is appropriate. Especially because there is a 
longstanding issue for packaging zip.



MNG-6136, MNG-6137


There is a commit about MRESOLVER-9 in tag 2.11 of Wagon:
https://git1-us-west.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=f244ece2eee01500e4b1bc334b8dcd35b47f9422.
I'm unsure whether it is safe to use this tag if MRESOLVER-9 doesn't
make it in the resolver release after its reset.


This commit can safely be dropped because it is necessary for changes in 
Maven 3.4.0. I can revert before pushing 2.11.


Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-02 Thread Michael Osipov

Am 2017-01-01 um 15:51 schrieb Stephen Connolly:

On 1 January 2017 at 00:55, Michael Osipov  wrote:


I just went through the list my issues. Here is a safe list I would
merge/cherry-pick into new master:

FIX-3.5.0:
MNG-5567,



Affects behaviour, I recommend 3.5.1 but I will not object if others feel
3.5.0


This indeed changes behavior but behavioral changes should not be in a 
patch version like 3.5.1, but in a minor. Moreover, Java supports ZIP 
files first-class citizens, we simply failed/forgot this here.


I still think that 3.5.0 is appropriate.


MNG-5954,



I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


Do not share, it is never read. I even asked on dev list and Jason 
replied, it is safe to be nuked.





MNG-6029,



I'd second this for 3.5.1
I have concerns with introducing for 3.5.0 as it affects how the classpath
gets built and could cause behaviour differences between 3.3.9 and 3.5.0
(as it causes the test classpath to actually get resolved)

-1 for 3.5.0 but I am open to change my position


It is actually two-fold, duplicate code and wrong scope. Fix has been 
there for seven months without causing any IT failures. I think is is a 
safe bet for an RC.



MNG-6102,



I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


This is change in behavior and not subject to a bugfix. The default 
behaves like before.



MNG-6106,


I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


This is actually a bug because maven.home can never be user.home/.m2


MNG-6115,



We need to decide on colourised logs for 3.5.0 or 3.5.1


Colorize is a new feature, not a bug fix. Either 3.5 or 3.6. It could 
also be squashed into MNG-3507.



MNG-6136,



I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


MNG-6137,



I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


Rather 3.5 or 3.6, consider that the last Wagon release is quite old and 
currently, there duplicate dependencies on Maven's classpath as layed 
out in MNG-6137.


Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
You should be able to edit. If not ping Hervé

Yes there are changes between 3.2.x and 3.3.9, what we want from 3.5.0 is
to make the only behaviour change be a no-op for switching aether for
resolver... after that 3.5.1 can fix bugs

On Sun 1 Jan 2017 at 22:52, Christian Schulte  wrote:

> Am 01/01/17 um 16:09 schrieb Stephen Connolly:
>
> > If you want to know the current status check
>
> > https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017
>
>
>
> Can I edit that page myself? User name is "schulte".


> Regarding the drop
>

> in replacement for 3.3.9: MNG-2199 was already working in Maven 3.2.2.
>
> Maven 3.3.9 isn't a drop in replacement for 3.2.2 itself so to say. I
>
> would propose MNG-2199 for the 3.6.0 scope then, however.
>
>
>
>
>
>
>
> -
>
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
> --
Sent from my phone


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Guillaume Boué

OK, thanks for confirming this.


Le 01/01/2017 à 23:44, Christian Schulte a écrit :

Am 01/01/17 um 18:44 schrieb Guillaume Boué:

There is a commit about MRESOLVER-9 in tag 2.11 of Wagon:
https://git1-us-west.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=f244ece2eee01500e4b1bc334b8dcd35b47f9422.
I'm unsure whether it is safe to use this tag if MRESOLVER-9 doesn't
make it in the resolver release after its reset.

Does not make a difference. Everything is resolved the same way as
before. It's just that the project can be build with MRESOLVER-9 in
place. It can be built the same way now even when MRESOLVER-9 is not
there.  Does not affect anything.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel 
antivirus Avast.
https://www.avast.com/antivirus


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Christian Schulte
Am 01/01/17 um 16:09 schrieb Stephen Connolly:
> If you want to know the current status check
> https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017

Can I edit that page myself? User name is "schulte". Regarding the drop
in replacement for 3.3.9: MNG-2199 was already working in Maven 3.2.2.
Maven 3.3.9 isn't a drop in replacement for 3.2.2 itself so to say. I
would propose MNG-2199 for the 3.6.0 scope then, however.



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Christian Schulte
Am 01/01/17 um 18:44 schrieb Guillaume Boué:
> 
> There is a commit about MRESOLVER-9 in tag 2.11 of Wagon: 
> https://git1-us-west.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=f244ece2eee01500e4b1bc334b8dcd35b47f9422.
>  
> I'm unsure whether it is safe to use this tag if MRESOLVER-9 doesn't 
> make it in the resolver release after its reset.

Does not make a difference. Everything is resolved the same way as
before. It's just that the project can be build with MRESOLVER-9 in
place. It can be built the same way now even when MRESOLVER-9 is not
there.  Does not affect anything.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Hervé BOUTEMY
Le dimanche 1 janvier 2017, 18:44:52 CET Guillaume Boué a écrit :
> This is the list of JIRA issues that targets colourised logging / are
> related to it:
> 
> MNG-3507  ANSI color logging for improved output visibility   This is 
> the
> root JIRA issue.
+1

> MNG-3705  Expression: ${executedProject} doesn't work in reports  SVN
> revisions d4d7f4763f34e2c23e590ce02551943a1cad84e5 and
> c6fb60b5482a12e3f94b74cd050ba46eddaa2423 are about it and actually
> target MNG-3507.
yes, this one was a typo :)

> MNG-6037  add gossip slf4j provider support   Note that the 
> colorization
> feature was removed from Gossip.
not really used any more: I don't know if anyone is interested

> MNG-6038
>   use Gossip slf4j provider as default logging, since it supports level
> colorization  WONTFIX
WONTFIX +1

> MNG-6041  Option -l does not disable colorized output Those are
> in-version fixes, to be squashed with MNG-3507.
+1

> MNG-6043  Colorization is disabled too late in batch mode
+1

> MNG-6046  upgrade JAnsi from 1.12 to 1.13
+1

> MNG-6093
>   create a slf4j-simple provider extension that supports level color
> rendering This supercedes MNG-6038 and adds colorization to the Slf4j
> Provider.
+1

> MNG-6115
>   Add Jansi native library search path to our start scripts   This 
> adds a
> system property to the launcher scripts. Should be safe to add alone
> without impacts.
+1
> 
> 
> Please add if I forgot some. I hope it'll make deciding whether the
> colorization feature, or parts of it, are added to 3.5.0 or later easier.
> 
> My personal take is that all of this could be integrated in 3.5.0 as it
> does not affect current 3.3.9 build behaviour (that I encountered, at
> least) and has a fair number of votes on JIRA.
+1

> The con of course is that
> it represents a complex addition.
not so complex: with the squash, it will look as simple as it is in the end :)

Regards,

Hervé

> 
> Guillaume
> 
> 
> ---
> L'absence de virus dans ce courrier électronique a été vérifiée par le
> logiciel antivirus Avast. https://www.avast.com/antivirus



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Guillaume Boué

This is the list of JIRA issues that targets colourised logging / are
related to it:

MNG-3507ANSI color logging for improved output visibility   This is 
the
root JIRA issue.
MNG-3705Expression: ${executedProject} doesn't work in reports  SVN
revisions d4d7f4763f34e2c23e590ce02551943a1cad84e5 and
c6fb60b5482a12e3f94b74cd050ba46eddaa2423 are about it and actually
target MNG-3507.
MNG-6037add gossip slf4j provider support   Note that the 
colorization
feature was removed from Gossip.
MNG-6038
use Gossip slf4j provider as default logging, since it supports level
colorizationWONTFIX
MNG-6041Option -l does not disable colorized output Those are
in-version fixes, to be squashed with MNG-3507.
MNG-6043Colorization is disabled too late in batch mode
MNG-6046upgrade JAnsi from 1.12 to 1.13
MNG-6093
create a slf4j-simple provider extension that supports level color
rendering   This supercedes MNG-6038 and adds colorization to the Slf4j
Provider.
MNG-6115
Add Jansi native library search path to our start scripts   This 
adds a
system property to the launcher scripts. Should be safe to add alone
without impacts.


Please add if I forgot some. I hope it'll make deciding whether the
colorization feature, or parts of it, are added to 3.5.0 or later easier.

My personal take is that all of this could be integrated in 3.5.0 as it
does not affect current 3.3.9 build behaviour (that I encountered, at
least) and has a fair number of votes on JIRA. The con of course is that
it represents a complex addition.

Guillaume


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel 
antivirus Avast.
https://www.avast.com/antivirus


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Guillaume Boué


Le 01/01/2017 à 01:55, Michael Osipov a écrit :
I just went through the list my issues. Here is a safe list I would 
merge/cherry-pick into new master:


FIX-3.5.0: MNG-5457, 


Note: this is dependant upon MRESOLVER-2 (commit 
https://git1-us-west.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=11b359e188f3b1d25bb6bda60195e7a47ca45bfc), 
so it depends if this makes it in the resolver release after its reset.


MNG-5567, 


This changes the classpath by adding ZIP files to it. I'd say this 
should be FIX-3.5.1 instead.



MNG-6106,


Seconded.


MNG-6136, MNG-6137


There is a commit about MRESOLVER-9 in tag 2.11 of Wagon: 
https://git1-us-west.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=f244ece2eee01500e4b1bc334b8dcd35b47f9422. 
I'm unsure whether it is safe to use this tag if MRESOLVER-9 doesn't 
make it in the resolver release after its reset.




To be transfered to someone else:
MNG-6043 can be merged into Hervé's MNG-3507.

Without issue id FIX-3.5.0:
MNG-   WONTFIX  Added some docs in CLIReporting Utils
NONERemove trailing whitespace
MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
#testGetMissingJarForced()
NONEFix checkstyle error
NONEUse static final values instead of literals
NONERemove non-existent m2 include in 
component.xml
NONELanguage style improvements for commit 
5dab4940c9a7d3b362bd2a8b078b183e4eb521bb

MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
to 2.10
MNG-   WONTFIX  Removing redundant test
MNG-   WONTFIX  Work around a rounding bug existed upto
Java 7
MNG-   WONTFIX  Remove ancient Subversion keywords
MNG-   WONTFIX  Use the proper term for char U+002D (-)
hyphen(-minus) instead of dash

Some of them will be squashed into into closely related commits, will 
have tickets created or are so trivial that they will be applied 
directly.


Drop: MNG-5976

Undecided:
MNG-5708: fixed by Christian's work
MNG-6049: Maybe for Christian, I just pulled PR and IT

Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel 
antivirus Avast.
https://www.avast.com/antivirus


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
If you want to know the current status check
https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017

On 31 December 2016 at 20:10, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> Here are the changes in current master since 3.3.9 (with some minor
> changes omitted)
>
> Issue ID   Target Version   Summary
>    ==   
> MNG-1577   WONTFIX  dependencyManagement does not work for
> transitive dependencies
> MNG-2199   WONTFIX  Support version ranges in parent elements
> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> directories to super POM
> MNG-3507   WONTFIX  added support for multi-lines error message
> with color
> MNG-3507   WONTFIX  ANSI Color logging for improved output
> visibility.
> MNG-3705   WONTFIX  fixed mojo execution id color display
> MNG-3825   WONTFIX  Dependencies with classifier should not
> always require a version.
> MNG-4345   WONTFIX  [regression] Plugin executions contributed
> by default lifecycle mapping execute after
> other plugin executions bound to the same
> phase"
> MNG-4347   WONTFIX  import-scoped dependencies of direct
> dependencies are not resolved using profile
> modifications from settings.xml
> MNG-4463   WONTFIX  Dependency management import should support
> version ranges.
> MNG-4645   WONTFIX  Move central repo definition out of Maven's
> core so it can be more easily changed.
> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> be manageable.
> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> in Maven 3
> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> to lifecycle (regression)
> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> version range is not correct in
> dependencyManagement definitions
> MNG-5457   WONTFIX  Show repository id when downloading or
> uploading from/to a remote repository
> MNG-5527   WONTFIX  Relocation does not work for imported poms
> MNG-5538   WONTFIX  mvn start script causes cygwin warning
> MNG-5567   WONTFIX  Zip files are not included in classpaths at
> all
> MNG-5600   WONTFIX  Dependency management import should support
> exclusions.
> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> scripts anymore
> MNG-5629   WONTFIX  ClosedChannelException from
> DefaultUpdateCheckManager.read
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5661   WONTFIX  Make MavenProject instances immutable after
> initial construction
> MNG-5670   WONTFIX  guard against
> ConcurrentModificationException
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> properly when using "&&"
> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> spaces - missing quotes
> MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
> implemented in other ways in the meantime.
> MNG-5836   WONTFIX  put $maven.home/conf/logging first in
> classpath to avoid extension jar overriding
> logging config
> MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
> /bin/bash functions Submitted by: Joseph
> Walton 
> MNG-5868   WONTFIX  Adding serval times the same artifact via
> MavenProjectHelper (attachArtifact) does not
> produce a failure
> MNG-5878   WONTFIX  added project.directory property to support
> module name != artifactId in every
>  

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
On 1 January 2017 at 04:42, Christian Schulte  wrote:

> Am 12/31/16 um 21:10 schrieb Stephen Connolly:
> > Here are the changes in current master since 3.3.9 (with some minor
> changes
> > omitted)
> >
> > Issue ID   Target Version   Summary
> >    ==   
> > MNG-1577   WONTFIX  dependencyManagement does not work for
> > transitive dependencies
>   ^
> FIX-3.6.0
>
> > MNG-2199   WONTFIX  Support version ranges in parent elements
>   ^
> FIX-3.5.0
>

-1: I propose FIX-3.5.1 as this makes it hard for 3.5.0 to be a drop in
behaviour replacement fort 3.3.9


>
> > MNG-4463   WONTFIX  Dependency management import should support
> > version ranges.
>   ^
> FIX-3.6.0
>
> > MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> > be manageable.
>   ^
> FIX-3.6.0
>
> > MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> > to lifecycle (regression)
>   ^
> FIX-3.5.0
>

-1: I propose FIX-3.5.1 as this makes it hard for 3.5.0 to be a drop in
behaviour replacement for 3.3.9


> > MNG-5527   WONTFIX  Relocation does not work for imported poms
>   ^
> FIX-3.6.0
>
> > MNG-5600   WONTFIX  Dependency management import should support
> > exclusions.
>   ^
> FIX-3.6.0
>
> > MNG-5629   WONTFIX  ClosedChannelException from
> > DefaultUpdateCheckManager.read
>   ^
> FIX-3.5.0
>

I'll second


>
> > MNG-5761   WONTFIX  Dependency management is not transitive.
>   ^
> FIX-3.6.0
>
> > MNG-5935   WONTFIX  Optional true getting lost in managed
> > dependencies when transitive
>   ^
> FIX-3.6.0
>
> > MNG-5958   WONTFIX  restore binary compatibility of
> > Lifecycle.setPhases
>   ^
> FIX-3.5.0
>

Already marked as agreed


>
> > MNG-5971   WONTFIX  Imported dependencies should be available to
> > inheritance processing
>   ^
> FIX-3.6.0
>
>
> > MNG-6023   WONTFIX  Upgrade of slf4j-simple to a version later
> > than 1.7.16 blocked by upstream issue.
>   ^
> FIX-3.5.0
>

Explain why we need to update the slf4j dependency in 3.5.0 and not 3.5.1


>
> That's a duplicate to the "Dependency updates" JIRA issue.
>
> > MNG-6049   WONTFIX  Add behavior to filter resolved version
> > ranges of an artifact
>   ^
> FIX-3.6.0
>
> I am not sure about the solution to this one currently on master. It
> adds an interface we already have in the resolver but do not expose in
> Maven core. Maybe this needs re-thinking. Better solution would be to
> allow core extensions to provide various components for the
> "RepositorySystemSession". Setup of the repository system currently is
> done in a static method. This would need to be changed to support core
> extensions.
>
> > MNG-6053   WONTFIX  guard against key without value
>   ^
> FIX-3.5.0
>
> > MNG-6053   WONTFIX  prevent NPE when copying System Properties
> > in MavenRepositorySystemUtils
>   ^
> FIX-3.5.0
>

I'll second this one


>
> > MNG-6073   WONTFIX  Addition of a core extension point to the
> > model builder supporting model finalization.
>   ^
> FIX-3.6.0
>
> > MNG-6074   WONTFIX  Maven should produce an error if no model
> > version has been set in a POM file used to
> > build an effective model.
>   ^
> FIX-3.5.0
>

-1: I propose WONTFIX or FIX-3.6.0 if the issue is changed to outputting a
warning rather than an error


>
> > MNG-6075   WONTFIX  Increase the model validation level to the
> > next minor level version.
>   ^
> FIX-3.6.0
>
> > MNG-6079   WONTFIX  3.4 regression: cannot override version of
> > a dependencyManagement in a submodule any
> > more
>   ^
> FIX-3.6.0
>
> > MNG-6105   WONTFIX  properties.internal.SystemProperties
> > .addSystemProperties() is not really
> > thread-safe
>   ^
> FIX-3.5.0
>

I'll second


>
> Related to MNG-6053.
>
> > MNG-6112   WONTFIX  Central repository in the 4.0.0 super POM
> > should declare update policy 'never'.
>   ^
> FIX-3.5.0
>

-1 for 3.5.0. I need to think some more about where this should land


>
> > MNG-6113   WONTFIX  Rename the 'Central Repository' to
> > 'Maven Central Repository' in the 4.0.0
> > super POM.
>   ^
> FIX-3.5.0
>

-1 for 3.5.0. I need to think some more about where this should land


>
> > MNG-6114   

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
On 1 January 2017 at 00:55, Michael Osipov  wrote:

> I just went through the list my issues. Here is a safe list I would
> merge/cherry-pick into new master:
>
> FIX-3.5.0:



> MNG-5457,


Should not affect behaviour: I'll second


> MNG-5567,


Affects behaviour, I recommend 3.5.1 but I will not object if others feel
3.5.0


> MNG-5579,


Note to self: This is a dup of MNG-6003


> MNG-5607,


I'd proposed this so marked as agreed unless we have an objector in the
next 3 days

MNG-5815,


I'd proposed this so marked as agreed unless we have an objector in the
next 3 days


> MNG-5954,


I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9

MNG-5963,


Marked as agreed unless we have an objector in the next 3 days


> MNG-5975,


Should not affect behaviour: I'll second


> MNG-5977,


Should not affect behaviour: I'll second


> MNG-6001,


Marked as agreed unless we have an objector in the next 3 days


> MNG-6003,


Marked as agreed unless we have an objector in the next 3 days


> MNG-6029,


I'd second this for 3.5.1
I have concerns with introducing for 3.5.0 as it affects how the classpath
gets built and could cause behaviour differences between 3.3.9 and 3.5.0
(as it causes the test classpath to actually get resolved)

-1 for 3.5.0 but I am open to change my position


> MNG-6081,
>

Marked as agreed unless we have an objector in the next 3 days


> MNG-6102,


I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9

MNG-6106,


I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


> MNG-6115,


We need to decide on colourised logs for 3.5.0 or 3.5.1


> MNG-6136,


I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


> MNG-6137,


I'd second this for 3.5.1 but I'm not objecting if others feel it is low
risk to drop-in replacement with 3.3.9


> MNG-6138
>

 Should not affect behaviour: I'll second


>
> To be transfered to someone else:
> MNG-6043 can be merged into Hervé's MNG-3507.
>
> Without issue id FIX-3.5.0:
> MNG-   WONTFIX  Added some docs in CLIReporting Utils
> NONERemove trailing whitespace
> MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
> #testGetMissingJarForced()
> NONEFix checkstyle error
> NONEUse static final values instead of literals
> NONERemove non-existent m2 include in component.xml
> NONELanguage style improvements for commit
> 5dab4940c9a7d3b362bd2a8b078b183e4eb521bb
> MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
> to 2.10
> MNG-   WONTFIX  Removing redundant test
> MNG-   WONTFIX  Work around a rounding bug existed upto
> Java 7
> MNG-   WONTFIX  Remove ancient Subversion keywords
> MNG-   WONTFIX  Use the proper term for char U+002D (-)
> hyphen(-minus) instead of dash
>
> Some of them will be squashed into into closely related commits, will have
> tickets created or are so trivial that they will be applied directly.
>
> Drop: MNG-5976
>
> Undecided:
> MNG-5708: fixed by Christian's work
> MNG-6049: Maybe for Christian, I just pulled PR and IT
>
> Michael
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
MNG-5962: I'll second that one
MNG-5958: I think this one is debatable as it stops 3.5.0 from being a
drop-in behaviour replacement of 3.3.9, but I don't feel strongly enough to
push it to 3.5.1
MNG-6117: Ditto for 5958, you'll need somebody to second this one for
3.5.0. I'll second it for 3.5.1

On 31 December 2016 at 22:12, Guillaume Boué  wrote:

>
> Le 31/12/2016 à 22:14, Stephen Connolly a écrit :
>
>> FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
>> MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
>> MNG-6003, MNG-6078
>>
>> I think colourised logging probably should be 3.5.x but I am open to the
>> idea of making it 3.5.0 as it *should* not affect the build behaviour.
>>
>> Do we have and seconders for the above?
>>
>
> I find the colorized logging really useful. Didn't encounter any issues
> with it (whether about build behaviour, or just visual behaviour) and it
> makes reading the logs in the console a lot easier. I'd mark this FIX-3.5.0
> (it spans a couple of JIRA issues, like MNG-3507, MNG-6041 and MNG-6046 at
> least).
>
>
>> Do we have anyone else proposing issues for 3.5.0?
>>
>
> MNG-5962, MNG-5958, MNG-6117.
>
> I noticed that some of those in the complete list of changes are marked as
> fixed for 3.3.9 or older versions on JIRA, like MNG-5923 or MNG-5670. Also
> noticed MNG-6070 which has a comment saying it shouldn't appear in release
> notes. Should they be removed from the list?
>
>
>> - Stephen
>>
>>
>> On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
>> stephen.alan.conno...@gmail.com> wrote:
>>
>> Here are the changes in current master since 3.3.9 (with some minor
>>> changes omitted)
>>>
>>> Issue ID   Target Version   Summary
>>>    ==   
>>> MNG-1577   WONTFIX  dependencyManagement does not work for
>>>  transitive dependencies
>>> MNG-2199   WONTFIX  Support version ranges in parent elements
>>> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
>>>  directories to super POM
>>> MNG-3507   WONTFIX  added support for multi-lines error message
>>>  with color
>>> MNG-3507   WONTFIX  ANSI Color logging for improved output
>>>  visibility.
>>> MNG-3705   WONTFIX  fixed mojo execution id color display
>>> MNG-3825   WONTFIX  Dependencies with classifier should not
>>>  always require a version.
>>> MNG-4345   WONTFIX  [regression] Plugin executions contributed
>>>  by default lifecycle mapping execute after
>>>  other plugin executions bound to the same
>>>  phase"
>>> MNG-4347   WONTFIX  import-scoped dependencies of direct
>>>  dependencies are not resolved using profile
>>>  modifications from settings.xml
>>> MNG-4463   WONTFIX  Dependency management import should support
>>>  version ranges.
>>> MNG-4645   WONTFIX  Move central repo definition out of Maven's
>>>  core so it can be more easily changed.
>>> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
>>>  be manageable.
>>> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
>>>  in Maven 3
>>> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
>>>  to lifecycle (regression)
>>> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
>>>  version range is not correct in
>>>  dependencyManagement definitions
>>> MNG-5457   WONTFIX  Show repository id when downloading or
>>>  uploading from/to a remote repository
>>> MNG-5527   WONTFIX  Relocation does not work for imported poms
>>> MNG-5538   WONTFIX  mvn start script causes cygwin warning
>>> MNG-5567   WONTFIX  Zip files are not included in classpaths at
>>>  all
>>> MNG-5600   WONTFIX  Dependency management import should support
>>>  exclusions.
>>> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
>>>  scripts anymore
>>> MNG-5629   WONTFIX  ClosedChannelException from
>>>  DefaultUpdateCheckManager.read
>>> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>>>  from Repo that contains a ${parameter}
>>> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>>>  from Repo that contains a ${parameter}
>>> MNG-5661   

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Michael Osipov

Am 2017-01-01 um 10:26 schrieb Stephen Connolly:

On 1 January 2017 at 00:55, Michael Osipov  wrote:


MNG-5963, MNG-6137



I couldn't find them in my list... note to self, double check... note to
michael, can you confirm


I distilled from your list, filtered git log and Jira roadmap.

* MNG-5963 is fixed and on agreed in your list.
* MNG-6137 is still open depends on MNG-6136 which is Wagon upgrade to 2.11.


Otherwise I have updated the wiki with your proposals (some of which were
seconds and moved  things into agreed (pending no objections from others in
the next 3 days)


Just checked, looks fine.

I will go on and create a few more tickets for the dandling stuff.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Michael Osipov

Am 2017-01-01 um 04:51 schrieb Christian Schulte:

Am 01/01/17 um 01:55 schrieb Michael Osipov:

Undecided:
MNG-5708: fixed by Christian's work


Should not be done in that release. Let's ship all bugfixes affecting
resolution together - not just one after the other. All or nothing. So
nothing.


I do agree, you are the expert. Moving to FIX-3.6.0, FIX-4.0.0?

Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
On 1 January 2017 at 00:55, Michael Osipov  wrote:

> MNG-5963, MNG-6137


I couldn't find them in my list... note to self, double check... note to
michael, can you confirm

Otherwise I have updated the wiki with your proposals (some of which were
seconds and moved  things into agreed (pending no objections from others in
the next 3 days)


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2017-01-01 Thread Stephen Connolly
We cannot update the JIRA issues until after we do the reset

On 1 January 2017 at 04:51, Christian Schulte  wrote:

> I think it would be easier if we just update the JIRA issues and set the
> version the issue will be shipped in. We already have a 3.5.0 version
> available. That will be the next Maven release? So we would need a 3.6.0
> version and a 4.0.0 version and a 5.0.0 version. Let 4.0.0 be the next
> major version in which all model version 4.0.0 features will be shipped.
> Let version 5.0.0 be the next major version shipping model version
> 5.0.0. Let's also create corresponding branches in the repositories so
> that exisiting commits can already be applied to theire final
> destination ready to be merged into master sometime in the future.
>
> Am 12/31/16 um 21:10 schrieb Stephen Connolly:
> > Here are the changes in current master since 3.3.9 (with some minor
> changes
> > omitted)
> >
> > Issue ID   Target Version   Summary
> >    ==   
> > MNG-1577   WONTFIX  dependencyManagement does not work for
> > transitive dependencies
> > MNG-2199   WONTFIX  Support version ranges in parent elements
> > MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> > directories to super POM
> > MNG-3507   WONTFIX  added support for multi-lines error message
> > with color
> > MNG-3507   WONTFIX  ANSI Color logging for improved output
> > visibility.
> > MNG-3705   WONTFIX  fixed mojo execution id color display
> > MNG-3825   WONTFIX  Dependencies with classifier should not
> > always require a version.
> > MNG-4345   WONTFIX  [regression] Plugin executions contributed
> > by default lifecycle mapping execute after
> > other plugin executions bound to the same
> > phase"
> > MNG-4347   WONTFIX  import-scoped dependencies of direct
> > dependencies are not resolved using profile
> > modifications from settings.xml
> > MNG-4463   WONTFIX  Dependency management import should support
> > version ranges.
> > MNG-4645   WONTFIX  Move central repo definition out of Maven's
> > core so it can be more easily changed.
> > MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> > be manageable.
> > MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> > in Maven 3
> > MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> > to lifecycle (regression)
> > MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> > version range is not correct in
> > dependencyManagement definitions
> > MNG-5457   WONTFIX  Show repository id when downloading or
> > uploading from/to a remote repository
> > MNG-5527   WONTFIX  Relocation does not work for imported poms
> > MNG-5538   WONTFIX  mvn start script causes cygwin warning
> > MNG-5567   WONTFIX  Zip files are not included in classpaths at
> > all
> > MNG-5600   WONTFIX  Dependency management import should support
> > exclusions.
> > MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> > scripts anymore
> > MNG-5629   WONTFIX  ClosedChannelException from
> > DefaultUpdateCheckManager.read
> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> > from Repo that contains a ${parameter}
> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> > from Repo that contains a ${parameter}
> > MNG-5661   WONTFIX  Make MavenProject instances immutable after
> > initial construction
> > MNG-5670   WONTFIX  guard against
> > ConcurrentModificationException
> > MNG-5761   WONTFIX  Dependency management is not transitive.
> > MNG-5761   WONTFIX  Dependency management is not transitive.
> > MNG-5761   WONTFIX  Dependency management is not transitive.
> > MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> > properly when using "&&"
> > MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> > spaces - missing quotes
> > MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
> > 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
What I marked FIX-3.6.0 could also be marked FIX-4.0.0. I cannot tell. I
would have made it part of 3.4.0 so better someone else decides that.


Am 01/01/17 um 05:42 schrieb Christian Schulte:
> Am 12/31/16 um 21:10 schrieb Stephen Connolly:
>> Here are the changes in current master since 3.3.9 (with some minor changes
>> omitted)
>>
>> Issue ID   Target Version   Summary
>>    ==   
>> MNG-1577   WONTFIX  dependencyManagement does not work for
>> transitive dependencies
>   ^
> FIX-3.6.0
> 
>> MNG-2199   WONTFIX  Support version ranges in parent elements
>   ^
> FIX-3.5.0
> 
>> MNG-4463   WONTFIX  Dependency management import should support
>> version ranges.
>   ^
> FIX-3.6.0
> 
>> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
>> be manageable.
>   ^
> FIX-3.6.0
> 
>> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
>> to lifecycle (regression)
>   ^
> FIX-3.5.0
> 
>> MNG-5527   WONTFIX  Relocation does not work for imported poms
>   ^
> FIX-3.6.0
> 
>> MNG-5600   WONTFIX  Dependency management import should support
>> exclusions.
>   ^
> FIX-3.6.0
> 
>> MNG-5629   WONTFIX  ClosedChannelException from
>> DefaultUpdateCheckManager.read
>   ^
> FIX-3.5.0
> 
>> MNG-5761   WONTFIX  Dependency management is not transitive.
>   ^
> FIX-3.6.0
> 
>> MNG-5935   WONTFIX  Optional true getting lost in managed
>> dependencies when transitive
>   ^
> FIX-3.6.0
> 
>> MNG-5958   WONTFIX  restore binary compatibility of
>> Lifecycle.setPhases
>   ^
> FIX-3.5.0
> 
>> MNG-5971   WONTFIX  Imported dependencies should be available to
>> inheritance processing
>   ^
> FIX-3.6.0
> 
> 
>> MNG-6023   WONTFIX  Upgrade of slf4j-simple to a version later
>> than 1.7.16 blocked by upstream issue.
>   ^
> FIX-3.5.0
> 
> That's a duplicate to the "Dependency updates" JIRA issue.
> 
>> MNG-6049   WONTFIX  Add behavior to filter resolved version
>> ranges of an artifact
>   ^
> FIX-3.6.0
> 
> I am not sure about the solution to this one currently on master. It
> adds an interface we already have in the resolver but do not expose in
> Maven core. Maybe this needs re-thinking. Better solution would be to
> allow core extensions to provide various components for the
> "RepositorySystemSession". Setup of the repository system currently is
> done in a static method. This would need to be changed to support core
> extensions.
> 
>> MNG-6053   WONTFIX  guard against key without value
>   ^
> FIX-3.5.0
> 
>> MNG-6053   WONTFIX  prevent NPE when copying System Properties
>> in MavenRepositorySystemUtils
>   ^
> FIX-3.5.0
> 
>> MNG-6073   WONTFIX  Addition of a core extension point to the
>> model builder supporting model finalization.
>   ^
> FIX-3.6.0
> 
>> MNG-6074   WONTFIX  Maven should produce an error if no model
>> version has been set in a POM file used to
>> build an effective model.
>   ^
> FIX-3.5.0
> 
>> MNG-6075   WONTFIX  Increase the model validation level to the
>> next minor level version.
>   ^
> FIX-3.6.0
> 
>> MNG-6079   WONTFIX  3.4 regression: cannot override version of
>> a dependencyManagement in a submodule any
>> more
>   ^
> FIX-3.6.0
> 
>> MNG-6105   WONTFIX  properties.internal.SystemProperties
>> .addSystemProperties() is not really
>> thread-safe
>   ^
> FIX-3.5.0
> 
> Related to MNG-6053.
> 
>> MNG-6112   WONTFIX  Central repository in the 4.0.0 super POM
>> should declare update policy 'never'.
>   ^
> FIX-3.5.0
> 
>> MNG-6113   WONTFIX  Rename the 'Central Repository' to
>> 'Maven Central Repository' in the 4.0.0
>> super POM.
>   ^
> FIX-3.5.0
> 
>> MNG-6114   WONTFIX  Profiles from the global settings should be
>> ordered before profiles from the user
>> settings.
>   ^
> FIX-3.5.0
> 
>> MNG-6135   WONTFIX  Maven plugins and core extensions are not
>> dependencies, they should be resolved the
>   ^
> FIX-3.6.0
> 
>> MNG-   WONTFIX  Updated to ensure 'MavenProject.
>> getManagedVersionMap()' consistently
>> returns an immutable map.
>   ^

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
I think it would be easier if we just update the JIRA issues and set the
version the issue will be shipped in. We already have a 3.5.0 version
available. That will be the next Maven release? So we would need a 3.6.0
version and a 4.0.0 version and a 5.0.0 version. Let 4.0.0 be the next
major version in which all model version 4.0.0 features will be shipped.
Let version 5.0.0 be the next major version shipping model version
5.0.0. Let's also create corresponding branches in the repositories so
that exisiting commits can already be applied to theire final
destination ready to be merged into master sometime in the future.

Am 12/31/16 um 21:10 schrieb Stephen Connolly:
> Here are the changes in current master since 3.3.9 (with some minor changes
> omitted)
> 
> Issue ID   Target Version   Summary
>    ==   
> MNG-1577   WONTFIX  dependencyManagement does not work for
> transitive dependencies
> MNG-2199   WONTFIX  Support version ranges in parent elements
> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> directories to super POM
> MNG-3507   WONTFIX  added support for multi-lines error message
> with color
> MNG-3507   WONTFIX  ANSI Color logging for improved output
> visibility.
> MNG-3705   WONTFIX  fixed mojo execution id color display
> MNG-3825   WONTFIX  Dependencies with classifier should not
> always require a version.
> MNG-4345   WONTFIX  [regression] Plugin executions contributed
> by default lifecycle mapping execute after
> other plugin executions bound to the same
> phase"
> MNG-4347   WONTFIX  import-scoped dependencies of direct
> dependencies are not resolved using profile
> modifications from settings.xml
> MNG-4463   WONTFIX  Dependency management import should support
> version ranges.
> MNG-4645   WONTFIX  Move central repo definition out of Maven's
> core so it can be more easily changed.
> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> be manageable.
> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> in Maven 3
> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> to lifecycle (regression)
> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> version range is not correct in
> dependencyManagement definitions
> MNG-5457   WONTFIX  Show repository id when downloading or
> uploading from/to a remote repository
> MNG-5527   WONTFIX  Relocation does not work for imported poms
> MNG-5538   WONTFIX  mvn start script causes cygwin warning
> MNG-5567   WONTFIX  Zip files are not included in classpaths at
> all
> MNG-5600   WONTFIX  Dependency management import should support
> exclusions.
> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> scripts anymore
> MNG-5629   WONTFIX  ClosedChannelException from
> DefaultUpdateCheckManager.read
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5661   WONTFIX  Make MavenProject instances immutable after
> initial construction
> MNG-5670   WONTFIX  guard against
> ConcurrentModificationException
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> properly when using "&&"
> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> spaces - missing quotes
> MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
> implemented in other ways in the meantime.
> MNG-5836   WONTFIX  put $maven.home/conf/logging first in
> classpath to avoid extension jar overriding
> logging config
> MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
Am 12/31/16 um 21:10 schrieb Stephen Connolly:
> Here are the changes in current master since 3.3.9 (with some minor changes
> omitted)
> 
> Issue ID   Target Version   Summary
>    ==   
> MNG-1577   WONTFIX  dependencyManagement does not work for
> transitive dependencies
  ^
FIX-3.6.0

> MNG-2199   WONTFIX  Support version ranges in parent elements
  ^
FIX-3.5.0

> MNG-4463   WONTFIX  Dependency management import should support
> version ranges.
  ^
FIX-3.6.0

> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> be manageable.
  ^
FIX-3.6.0

> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> to lifecycle (regression)
  ^
FIX-3.5.0

> MNG-5527   WONTFIX  Relocation does not work for imported poms
  ^
FIX-3.6.0

> MNG-5600   WONTFIX  Dependency management import should support
> exclusions.
  ^
FIX-3.6.0

> MNG-5629   WONTFIX  ClosedChannelException from
> DefaultUpdateCheckManager.read
  ^
FIX-3.5.0

> MNG-5761   WONTFIX  Dependency management is not transitive.
  ^
FIX-3.6.0

> MNG-5935   WONTFIX  Optional true getting lost in managed
> dependencies when transitive
  ^
FIX-3.6.0

> MNG-5958   WONTFIX  restore binary compatibility of
> Lifecycle.setPhases
  ^
FIX-3.5.0

> MNG-5971   WONTFIX  Imported dependencies should be available to
> inheritance processing
  ^
FIX-3.6.0


> MNG-6023   WONTFIX  Upgrade of slf4j-simple to a version later
> than 1.7.16 blocked by upstream issue.
  ^
FIX-3.5.0

That's a duplicate to the "Dependency updates" JIRA issue.

> MNG-6049   WONTFIX  Add behavior to filter resolved version
> ranges of an artifact
  ^
FIX-3.6.0

I am not sure about the solution to this one currently on master. It
adds an interface we already have in the resolver but do not expose in
Maven core. Maybe this needs re-thinking. Better solution would be to
allow core extensions to provide various components for the
"RepositorySystemSession". Setup of the repository system currently is
done in a static method. This would need to be changed to support core
extensions.

> MNG-6053   WONTFIX  guard against key without value
  ^
FIX-3.5.0

> MNG-6053   WONTFIX  prevent NPE when copying System Properties
> in MavenRepositorySystemUtils
  ^
FIX-3.5.0

> MNG-6073   WONTFIX  Addition of a core extension point to the
> model builder supporting model finalization.
  ^
FIX-3.6.0

> MNG-6074   WONTFIX  Maven should produce an error if no model
> version has been set in a POM file used to
> build an effective model.
  ^
FIX-3.5.0

> MNG-6075   WONTFIX  Increase the model validation level to the
> next minor level version.
  ^
FIX-3.6.0

> MNG-6079   WONTFIX  3.4 regression: cannot override version of
> a dependencyManagement in a submodule any
> more
  ^
FIX-3.6.0

> MNG-6105   WONTFIX  properties.internal.SystemProperties
> .addSystemProperties() is not really
> thread-safe
  ^
FIX-3.5.0

Related to MNG-6053.

> MNG-6112   WONTFIX  Central repository in the 4.0.0 super POM
> should declare update policy 'never'.
  ^
FIX-3.5.0

> MNG-6113   WONTFIX  Rename the 'Central Repository' to
> 'Maven Central Repository' in the 4.0.0
> super POM.
  ^
FIX-3.5.0

> MNG-6114   WONTFIX  Profiles from the global settings should be
> ordered before profiles from the user
> settings.
  ^
FIX-3.5.0

> MNG-6135   WONTFIX  Maven plugins and core extensions are not
> dependencies, they should be resolved the
  ^
FIX-3.6.0

> MNG-   WONTFIX  Updated to ensure 'MavenProject.
> getManagedVersionMap()' consistently
> returns an immutable map.
  ^
FIX-3.5.0

> MNG-   WONTFIX  Updated to ensure collections are immutable
> consistently.
  ^
FIX-3.5.0

> MNG-   WONTFIX  Updated to make the
> 'JavaDependencyContextRefiner' part of the
> dependency graph transformer lost in
> commit
> 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
Am 12/31/16 um 22:14 schrieb Stephen Connolly:
> FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
> MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
> MNG-6003, MNG-6078

MNG-5968 will require updates to the ITs due to the maven-plugin-plugin
no longer supporting Javadoc without description.






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
I'd also like to add FIX-3.5.0: MNG-2199

It was working in Maven 3.2.2 but got broken the next release. This went
unnoticed because the ITs were not correct. Back then I did not notice
that Maven does not fail the build if it cannot resolve a parent but
just logs a warning. The ITs did not check for the warning but instead
verified the build does not fail. So there would be one commit to the
core fixing the parent version ranges and one commit to the ITs fixing
the ITs so that they start checking for the warning message in the log
instead of asserting a successfull build.


Am 12/31/16 um 21:10 schrieb Stephen Connolly:
> Here are the changes in current master since 3.3.9 (with some minor changes
> omitted)
> 
> Issue ID   Target Version   Summary
>    ==   
> MNG-1577   WONTFIX  dependencyManagement does not work for
> transitive dependencies
> MNG-2199   WONTFIX  Support version ranges in parent elements
> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> directories to super POM
> MNG-3507   WONTFIX  added support for multi-lines error message
> with color
> MNG-3507   WONTFIX  ANSI Color logging for improved output
> visibility.
> MNG-3705   WONTFIX  fixed mojo execution id color display
> MNG-3825   WONTFIX  Dependencies with classifier should not
> always require a version.
> MNG-4345   WONTFIX  [regression] Plugin executions contributed
> by default lifecycle mapping execute after
> other plugin executions bound to the same
> phase"
> MNG-4347   WONTFIX  import-scoped dependencies of direct
> dependencies are not resolved using profile
> modifications from settings.xml
> MNG-4463   WONTFIX  Dependency management import should support
> version ranges.
> MNG-4645   WONTFIX  Move central repo definition out of Maven's
> core so it can be more easily changed.
> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> be manageable.
> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> in Maven 3
> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> to lifecycle (regression)
> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> version range is not correct in
> dependencyManagement definitions
> MNG-5457   WONTFIX  Show repository id when downloading or
> uploading from/to a remote repository
> MNG-5527   WONTFIX  Relocation does not work for imported poms
> MNG-5538   WONTFIX  mvn start script causes cygwin warning
> MNG-5567   WONTFIX  Zip files are not included in classpaths at
> all
> MNG-5600   WONTFIX  Dependency management import should support
> exclusions.
> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> scripts anymore
> MNG-5629   WONTFIX  ClosedChannelException from
> DefaultUpdateCheckManager.read
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5661   WONTFIX  Make MavenProject instances immutable after
> initial construction
> MNG-5670   WONTFIX  guard against
> ConcurrentModificationException
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> properly when using "&&"
> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> spaces - missing quotes
> MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
> implemented in other ways in the meantime.
> MNG-5836   WONTFIX  put $maven.home/conf/logging first in
> classpath to avoid extension jar overriding
> logging config
> MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
> 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
Am 01/01/17 um 01:55 schrieb Michael Osipov:
> Undecided:
> MNG-5708: fixed by Christian's work

Should not be done in that release. Let's ship all bugfixes affecting
resolution together - not just one after the other. All or nothing. So
nothing.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Dan Tran
I would like to add MNG-6084   WONTFIX   Support JSR 250 @PreDestory and
@PostContruct


On Sat, Dec 31, 2016 at 5:17 PM, Michael Osipov  wrote:

> Am 2017-01-01 um 02:11 schrieb Anton Tanasenko:
>
>> FIX-3.5.0:
>> MNG-   WONTFIX  Add a ProjectArtifactsCache similar to
>> PluginArtifactsCache
>> That's actually a https://issues.apache.org/jira/browse/MNG-6025
>>
>
> JIRA adjusted, thank you. Stephen, please update your list with MNG-6025.
>
>
> 2017-01-01 2:55 GMT+02:00 Michael Osipov :
>>
>> I just went through the list my issues. Here is a safe list I would
>>> merge/cherry-pick into new master:
>>>
>>> FIX-3.5.0: MNG-5457, MNG-5567, MNG-5579, MNG-5607, MNG-5815, MNG-5954,
>>> MNG-5963, MNG-5975, MNG-5977, MNG-6001, MNG-6003, MNG-6029, MNG-6081,
>>> MNG-6102, MNG-6106, MNG-6115, MNG-6136, MNG-6137, MNG-6138
>>>
>>> To be transfered to someone else:
>>> MNG-6043 can be merged into Hervé's MNG-3507.
>>>
>>> Without issue id FIX-3.5.0:
>>> MNG-   WONTFIX  Added some docs in CLIReporting Utils
>>> NONERemove trailing whitespace
>>> MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
>>> #testGetMissingJarForced()
>>> NONEFix checkstyle error
>>> NONEUse static final values instead of literals
>>> NONERemove non-existent m2 include in
>>> component.xml
>>> NONELanguage style improvements for commit
>>> 5dab4940c9a7d3b362bd2a8b078b183e4eb521bb
>>> MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
>>> to 2.10
>>> MNG-   WONTFIX  Removing redundant test
>>> MNG-   WONTFIX  Work around a rounding bug existed upto
>>> Java 7
>>> MNG-   WONTFIX  Remove ancient Subversion keywords
>>> MNG-   WONTFIX  Use the proper term for char U+002D (-)
>>> hyphen(-minus) instead of dash
>>>
>>> Some of them will be squashed into into closely related commits, will
>>> have
>>> tickets created or are so trivial that they will be applied directly.
>>>
>>> Drop: MNG-5976
>>>
>>> Undecided:
>>> MNG-5708: fixed by Christian's work
>>> MNG-6049: Maybe for Christian, I just pulled PR and IT
>>>
>>> Michael
>>>
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>>>
>>>
>>
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Michael Osipov

Am 2017-01-01 um 02:11 schrieb Anton Tanasenko:

FIX-3.5.0:
MNG-   WONTFIX  Add a ProjectArtifactsCache similar to
PluginArtifactsCache
That's actually a https://issues.apache.org/jira/browse/MNG-6025


JIRA adjusted, thank you. Stephen, please update your list with MNG-6025.


2017-01-01 2:55 GMT+02:00 Michael Osipov :


I just went through the list my issues. Here is a safe list I would
merge/cherry-pick into new master:

FIX-3.5.0: MNG-5457, MNG-5567, MNG-5579, MNG-5607, MNG-5815, MNG-5954,
MNG-5963, MNG-5975, MNG-5977, MNG-6001, MNG-6003, MNG-6029, MNG-6081,
MNG-6102, MNG-6106, MNG-6115, MNG-6136, MNG-6137, MNG-6138

To be transfered to someone else:
MNG-6043 can be merged into Hervé's MNG-3507.

Without issue id FIX-3.5.0:
MNG-   WONTFIX  Added some docs in CLIReporting Utils
NONERemove trailing whitespace
MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
#testGetMissingJarForced()
NONEFix checkstyle error
NONEUse static final values instead of literals
NONERemove non-existent m2 include in component.xml
NONELanguage style improvements for commit
5dab4940c9a7d3b362bd2a8b078b183e4eb521bb
MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
to 2.10
MNG-   WONTFIX  Removing redundant test
MNG-   WONTFIX  Work around a rounding bug existed upto
Java 7
MNG-   WONTFIX  Remove ancient Subversion keywords
MNG-   WONTFIX  Use the proper term for char U+002D (-)
hyphen(-minus) instead of dash

Some of them will be squashed into into closely related commits, will have
tickets created or are so trivial that they will be applied directly.

Drop: MNG-5976

Undecided:
MNG-5708: fixed by Christian's work
MNG-6049: Maybe for Christian, I just pulled PR and IT

Michael



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org









-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Anton Tanasenko
FIX-3.5.0:
MNG-   WONTFIX  Add a ProjectArtifactsCache similar to
PluginArtifactsCache
That's actually a https://issues.apache.org/jira/browse/MNG-6025

2017-01-01 2:55 GMT+02:00 Michael Osipov :

> I just went through the list my issues. Here is a safe list I would
> merge/cherry-pick into new master:
>
> FIX-3.5.0: MNG-5457, MNG-5567, MNG-5579, MNG-5607, MNG-5815, MNG-5954,
> MNG-5963, MNG-5975, MNG-5977, MNG-6001, MNG-6003, MNG-6029, MNG-6081,
> MNG-6102, MNG-6106, MNG-6115, MNG-6136, MNG-6137, MNG-6138
>
> To be transfered to someone else:
> MNG-6043 can be merged into Hervé's MNG-3507.
>
> Without issue id FIX-3.5.0:
> MNG-   WONTFIX  Added some docs in CLIReporting Utils
> NONERemove trailing whitespace
> MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
> #testGetMissingJarForced()
> NONEFix checkstyle error
> NONEUse static final values instead of literals
> NONERemove non-existent m2 include in component.xml
> NONELanguage style improvements for commit
> 5dab4940c9a7d3b362bd2a8b078b183e4eb521bb
> MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
> to 2.10
> MNG-   WONTFIX  Removing redundant test
> MNG-   WONTFIX  Work around a rounding bug existed upto
> Java 7
> MNG-   WONTFIX  Remove ancient Subversion keywords
> MNG-   WONTFIX  Use the proper term for char U+002D (-)
> hyphen(-minus) instead of dash
>
> Some of them will be squashed into into closely related commits, will have
> tickets created or are so trivial that they will be applied directly.
>
> Drop: MNG-5976
>
> Undecided:
> MNG-5708: fixed by Christian's work
> MNG-6049: Maybe for Christian, I just pulled PR and IT
>
> Michael
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Regards,
Anton.


Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Michael Osipov
I just went through the list my issues. Here is a safe list I would 
merge/cherry-pick into new master:


FIX-3.5.0: MNG-5457, MNG-5567, MNG-5579, MNG-5607, MNG-5815, MNG-5954, 
MNG-5963, MNG-5975, MNG-5977, MNG-6001, MNG-6003, MNG-6029, MNG-6081,

MNG-6102, MNG-6106, MNG-6115, MNG-6136, MNG-6137, MNG-6138

To be transfered to someone else:
MNG-6043 can be merged into Hervé's MNG-3507.

Without issue id FIX-3.5.0:
MNG-   WONTFIX  Added some docs in CLIReporting Utils
NONERemove trailing whitespace
MNG-   WONTFIX  Pass force=true to DefaultWagonManagerTest
#testGetMissingJarForced()
NONEFix checkstyle error
NONEUse static final values instead of literals
NONERemove non-existent m2 include in component.xml
NONELanguage style improvements for commit 
5dab4940c9a7d3b362bd2a8b078b183e4eb521bb

MNG-   WONTFIX  Update Maven Dependency Plugin in Super POM
to 2.10
MNG-   WONTFIX  Removing redundant test
MNG-   WONTFIX  Work around a rounding bug existed upto
Java 7
MNG-   WONTFIX  Remove ancient Subversion keywords
MNG-   WONTFIX  Use the proper term for char U+002D (-)
hyphen(-minus) instead of dash

Some of them will be squashed into into closely related commits, will 
have tickets created or are so trivial that they will be applied directly.


Drop: MNG-5976

Undecided:
MNG-5708: fixed by Christian's work
MNG-6049: Maybe for Christian, I just pulled PR and IT

Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Stephen Connolly
We need to figure out what is what. Also when making a proposal please
reply to the original message not previous proposals

On 31 December 2016 at 22:12, Guillaume Boué  wrote:

>
> Le 31/12/2016 à 22:14, Stephen Connolly a écrit :
>
>> FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
>> MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
>> MNG-6003, MNG-6078
>>
>> I think colourised logging probably should be 3.5.x but I am open to the
>> idea of making it 3.5.0 as it *should* not affect the build behaviour.
>>
>> Do we have and seconders for the above?
>>
>
> I find the colorized logging really useful. Didn't encounter any issues
> with it (whether about build behaviour, or just visual behaviour) and it
> makes reading the logs in the console a lot easier. I'd mark this FIX-3.5.0
> (it spans a couple of JIRA issues, like MNG-3507, MNG-6041 and MNG-6046 at
> least).
>
>
>> Do we have anyone else proposing issues for 3.5.0?
>>
>
> MNG-5962, MNG-5958, MNG-6117.
>
> I noticed that some of those in the complete list of changes are marked as
> fixed for 3.3.9 or older versions on JIRA, like MNG-5923 or MNG-5670. Also
> noticed MNG-6070 which has a comment saying it shouldn't appear in release
> notes. Should they be removed from the list?
>
>
>> - Stephen
>>
>>
>> On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
>> stephen.alan.conno...@gmail.com> wrote:
>>
>> Here are the changes in current master since 3.3.9 (with some minor
>>> changes omitted)
>>>
>>> Issue ID   Target Version   Summary
>>>    ==   
>>> MNG-1577   WONTFIX  dependencyManagement does not work for
>>>  transitive dependencies
>>> MNG-2199   WONTFIX  Support version ranges in parent elements
>>> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
>>>  directories to super POM
>>> MNG-3507   WONTFIX  added support for multi-lines error message
>>>  with color
>>> MNG-3507   WONTFIX  ANSI Color logging for improved output
>>>  visibility.
>>> MNG-3705   WONTFIX  fixed mojo execution id color display
>>> MNG-3825   WONTFIX  Dependencies with classifier should not
>>>  always require a version.
>>> MNG-4345   WONTFIX  [regression] Plugin executions contributed
>>>  by default lifecycle mapping execute after
>>>  other plugin executions bound to the same
>>>  phase"
>>> MNG-4347   WONTFIX  import-scoped dependencies of direct
>>>  dependencies are not resolved using profile
>>>  modifications from settings.xml
>>> MNG-4463   WONTFIX  Dependency management import should support
>>>  version ranges.
>>> MNG-4645   WONTFIX  Move central repo definition out of Maven's
>>>  core so it can be more easily changed.
>>> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
>>>  be manageable.
>>> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
>>>  in Maven 3
>>> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
>>>  to lifecycle (regression)
>>> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
>>>  version range is not correct in
>>>  dependencyManagement definitions
>>> MNG-5457   WONTFIX  Show repository id when downloading or
>>>  uploading from/to a remote repository
>>> MNG-5527   WONTFIX  Relocation does not work for imported poms
>>> MNG-5538   WONTFIX  mvn start script causes cygwin warning
>>> MNG-5567   WONTFIX  Zip files are not included in classpaths at
>>>  all
>>> MNG-5600   WONTFIX  Dependency management import should support
>>>  exclusions.
>>> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
>>>  scripts anymore
>>> MNG-5629   WONTFIX  ClosedChannelException from
>>>  DefaultUpdateCheckManager.read
>>> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>>>  from Repo that contains a ${parameter}
>>> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>>>  from Repo that contains a ${parameter}
>>> MNG-5661   WONTFIX  Make MavenProject instances immutable after
>>>  initial construction
>>> MNG-5670   WONTFIX  guard against
>>>

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Stephen Connolly
Here is the wiki page to track proposals

https://cwiki.apache.org/confluence/display/MAVEN/Roadmap+2017

On 31 December 2016 at 21:34, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> Apache Proverb: If it doesn't happen on a mailing list then it is only a
> rumour!
>
> I will keep track and summarise on cwiki, but we need proposals and
> seconds on the ML
>
> -Stephen
>
> On Sat 31 Dec 2016 at 21:26, Michael Osipov  wrote:
>
>> Am 2016-12-31 um 21:10 schrieb Stephen Connolly:
>>
>> > Here are the changes in current master since 3.3.9 (with some minor
>> changes
>>
>> > omitted)
>>
>> >
>>
>> > Issue ID   Target Version   Summary
>>
>> >    ==   =
>> ===
>>
>> > MNG-1577   WONTFIX  dependencyManagement does not work for
>>
>> > transitive dependencies
>>
>> > MNG-2199   WONTFIX  Support version ranges in parent elements
>>
>> > MNG-2478   WONTFIX  add "resources-filtered" filtered resource
>>
>> > directories to super POM
>>
>> > MNG-3507   WONTFIX  added support for multi-lines error message
>>
>> > with color
>>
>> > MNG-3507   WONTFIX  ANSI Color logging for improved output
>>
>> > visibility.
>>
>> > MNG-3705   WONTFIX  fixed mojo execution id color display
>>
>> > MNG-3825   WONTFIX  Dependencies with classifier should not
>>
>> > always require a version.
>>
>> > MNG-4345   WONTFIX  [regression] Plugin executions contributed
>>
>> > by default lifecycle mapping execute after
>>
>> > other plugin executions bound to the same
>>
>> > phase"
>>
>> > MNG-4347   WONTFIX  import-scoped dependencies of direct
>>
>> > dependencies are not resolved using profile
>>
>> > modifications from settings.xml
>>
>> > MNG-4463   WONTFIX  Dependency management import should support
>>
>> > version ranges.
>>
>> > MNG-4645   WONTFIX  Move central repo definition out of Maven's
>>
>> > core so it can be more easily changed.
>>
>> > MNG-5227   WONTFIX  The 'optional' flag of a dependency should
>>
>> > be manageable.
>>
>> > MNG-5297   WONTFIX  improved explanations on prerequisites.maven
>>
>> > in Maven 3
>>
>> > MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
>>
>> > to lifecycle (regression)
>>
>> > MNG-5368   WONTFIX  UnsupportedOperationException thrown when
>>
>> > version range is not correct in
>>
>> > dependencyManagement definitions
>>
>> > MNG-5457   WONTFIX  Show repository id when downloading or
>>
>> > uploading from/to a remote repository
>>
>> > MNG-5527   WONTFIX  Relocation does not work for imported poms
>>
>> > MNG-5538   WONTFIX  mvn start script causes cygwin warning
>>
>> > MNG-5567   WONTFIX  Zip files are not included in classpaths at
>>
>> > all
>>
>> > MNG-5600   WONTFIX  Dependency management import should support
>>
>> > exclusions.
>>
>> > MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
>>
>> > scripts anymore
>>
>> > MNG-5629   WONTFIX  ClosedChannelException from
>>
>> > DefaultUpdateCheckManager.read
>>
>> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>>
>> > from Repo that contains a ${parameter}
>>
>> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>>
>> > from Repo that contains a ${parameter}
>>
>> > MNG-5661   WONTFIX  Make MavenProject instances immutable after
>>
>> > initial construction
>>
>> > MNG-5670   WONTFIX  guard against
>>
>> > ConcurrentModificationException
>>
>> > MNG-5761   WONTFIX  Dependency management is not transitive.
>>
>> > MNG-5761   WONTFIX  Dependency management is not transitive.
>>
>> > MNG-5761   WONTFIX  Dependency management is not transitive.
>>
>> > MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
>>
>> > properly when using "&&"
>>
>> > MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
>>
>> > spaces - missing quotes
>>
>> > MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
>>
>> > implemented in other ways in the meantime.
>>
>> 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Guillaume Boué


Le 31/12/2016 à 22:14, Stephen Connolly a écrit :

FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
MNG-6003, MNG-6078

I think colourised logging probably should be 3.5.x but I am open to the
idea of making it 3.5.0 as it *should* not affect the build behaviour.

Do we have and seconders for the above?


I find the colorized logging really useful. Didn't encounter any issues 
with it (whether about build behaviour, or just visual behaviour) and it 
makes reading the logs in the console a lot easier. I'd mark this 
FIX-3.5.0 (it spans a couple of JIRA issues, like MNG-3507, MNG-6041 and 
MNG-6046 at least).




Do we have anyone else proposing issues for 3.5.0?


MNG-5962, MNG-5958, MNG-6117.

I noticed that some of those in the complete list of changes are marked 
as fixed for 3.3.9 or older versions on JIRA, like MNG-5923 or MNG-5670. 
Also noticed MNG-6070 which has a comment saying it shouldn't appear in 
release notes. Should they be removed from the list?


- Stephen


On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:


Here are the changes in current master since 3.3.9 (with some minor
changes omitted)

Issue ID   Target Version   Summary
   ==   
MNG-1577   WONTFIX  dependencyManagement does not work for
 transitive dependencies
MNG-2199   WONTFIX  Support version ranges in parent elements
MNG-2478   WONTFIX  add "resources-filtered" filtered resource
 directories to super POM
MNG-3507   WONTFIX  added support for multi-lines error message
 with color
MNG-3507   WONTFIX  ANSI Color logging for improved output
 visibility.
MNG-3705   WONTFIX  fixed mojo execution id color display
MNG-3825   WONTFIX  Dependencies with classifier should not
 always require a version.
MNG-4345   WONTFIX  [regression] Plugin executions contributed
 by default lifecycle mapping execute after
 other plugin executions bound to the same
 phase"
MNG-4347   WONTFIX  import-scoped dependencies of direct
 dependencies are not resolved using profile
 modifications from settings.xml
MNG-4463   WONTFIX  Dependency management import should support
 version ranges.
MNG-4645   WONTFIX  Move central repo definition out of Maven's
 core so it can be more easily changed.
MNG-5227   WONTFIX  The 'optional' flag of a dependency should
 be manageable.
MNG-5297   WONTFIX  improved explanations on prerequisites.maven
 in Maven 3
MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
 to lifecycle (regression)
MNG-5368   WONTFIX  UnsupportedOperationException thrown when
 version range is not correct in
 dependencyManagement definitions
MNG-5457   WONTFIX  Show repository id when downloading or
 uploading from/to a remote repository
MNG-5527   WONTFIX  Relocation does not work for imported poms
MNG-5538   WONTFIX  mvn start script causes cygwin warning
MNG-5567   WONTFIX  Zip files are not included in classpaths at
 all
MNG-5600   WONTFIX  Dependency management import should support
 exclusions.
MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
 scripts anymore
MNG-5629   WONTFIX  ClosedChannelException from
 DefaultUpdateCheckManager.read
MNG-5639   WONTFIX  Support resolution of Import Scope POMs
 from Repo that contains a ${parameter}
MNG-5639   WONTFIX  Support resolution of Import Scope POMs
 from Repo that contains a ${parameter}
MNG-5661   WONTFIX  Make MavenProject instances immutable after
 initial construction
MNG-5670   WONTFIX  guard against
 ConcurrentModificationException
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
 properly when using "&&"
MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
 spaces - 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Stephen Connolly
Christian, to avoid confusion, could you reply to the original message if
you are adding proposals... reply to proposals if you are seconding?

On 31 December 2016 at 21:31, Christian Schulte  wrote:

> Am 31.12.2016 um 22:14 schrieb Stephen Connolly:
> > FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
> > MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
> > MNG-6003, MNG-6078
> >
> > I think colourised logging probably should be 3.5.x but I am open to the
> > idea of making it 3.5.0 as it *should* not affect the build behaviour.
> >
> > Do we have and seconders for the above?
> >
> > Do we have anyone else proposing issues for 3.5.0?
>
> FIX-3.5.0: MNG-6112,MNG-6113
>
> >
> > - Stephen
> >
> >
> > On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
> > stephen.alan.conno...@gmail.com> wrote:
> >
> >> Here are the changes in current master since 3.3.9 (with some minor
> >> changes omitted)
> >>
> >> Issue ID   Target Version   Summary
> >>    ==   ==
> ==
> >> MNG-1577   WONTFIX  dependencyManagement does not work for
> >> transitive dependencies
> >> MNG-2199   WONTFIX  Support version ranges in parent elements
> >> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> >> directories to super POM
> >> MNG-3507   WONTFIX  added support for multi-lines error message
> >> with color
> >> MNG-3507   WONTFIX  ANSI Color logging for improved output
> >> visibility.
> >> MNG-3705   WONTFIX  fixed mojo execution id color display
> >> MNG-3825   WONTFIX  Dependencies with classifier should not
> >> always require a version.
> >> MNG-4345   WONTFIX  [regression] Plugin executions contributed
> >> by default lifecycle mapping execute after
> >> other plugin executions bound to the same
> >> phase"
> >> MNG-4347   WONTFIX  import-scoped dependencies of direct
> >> dependencies are not resolved using profile
> >> modifications from settings.xml
> >> MNG-4463   WONTFIX  Dependency management import should support
> >> version ranges.
> >> MNG-4645   WONTFIX  Move central repo definition out of Maven's
> >> core so it can be more easily changed.
> >> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> >> be manageable.
> >> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> >> in Maven 3
> >> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> >> to lifecycle (regression)
> >> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> >> version range is not correct in
> >> dependencyManagement definitions
> >> MNG-5457   WONTFIX  Show repository id when downloading or
> >> uploading from/to a remote repository
> >> MNG-5527   WONTFIX  Relocation does not work for imported poms
> >> MNG-5538   WONTFIX  mvn start script causes cygwin warning
> >> MNG-5567   WONTFIX  Zip files are not included in classpaths at
> >> all
> >> MNG-5600   WONTFIX  Dependency management import should support
> >> exclusions.
> >> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> >> scripts anymore
> >> MNG-5629   WONTFIX  ClosedChannelException from
> >> DefaultUpdateCheckManager.read
> >> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> >> from Repo that contains a ${parameter}
> >> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> >> from Repo that contains a ${parameter}
> >> MNG-5661   WONTFIX  Make MavenProject instances immutable after
> >> initial construction
> >> MNG-5670   WONTFIX  guard against
> >> ConcurrentModificationException
> >> MNG-5761   WONTFIX  Dependency management is not transitive.
> >> MNG-5761   WONTFIX  Dependency management is not transitive.
> >> MNG-5761   WONTFIX  Dependency management is not transitive.
> >> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> >> properly when using "&&"
> >> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> >> spaces - missing quotes
> >> 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Stephen Connolly
Apache Proverb: If it doesn't happen on a mailing list then it is only a
rumour!

I will keep track and summarise on cwiki, but we need proposals and seconds
on the ML

-Stephen

On Sat 31 Dec 2016 at 21:26, Michael Osipov  wrote:

> Am 2016-12-31 um 21:10 schrieb Stephen Connolly:
>
> > Here are the changes in current master since 3.3.9 (with some minor
> changes
>
> > omitted)
>
> >
>
> > Issue ID   Target Version   Summary
>
> >    ==   
>
> > MNG-1577   WONTFIX  dependencyManagement does not work for
>
> > transitive dependencies
>
> > MNG-2199   WONTFIX  Support version ranges in parent elements
>
> > MNG-2478   WONTFIX  add "resources-filtered" filtered resource
>
> > directories to super POM
>
> > MNG-3507   WONTFIX  added support for multi-lines error message
>
> > with color
>
> > MNG-3507   WONTFIX  ANSI Color logging for improved output
>
> > visibility.
>
> > MNG-3705   WONTFIX  fixed mojo execution id color display
>
> > MNG-3825   WONTFIX  Dependencies with classifier should not
>
> > always require a version.
>
> > MNG-4345   WONTFIX  [regression] Plugin executions contributed
>
> > by default lifecycle mapping execute after
>
> > other plugin executions bound to the same
>
> > phase"
>
> > MNG-4347   WONTFIX  import-scoped dependencies of direct
>
> > dependencies are not resolved using profile
>
> > modifications from settings.xml
>
> > MNG-4463   WONTFIX  Dependency management import should support
>
> > version ranges.
>
> > MNG-4645   WONTFIX  Move central repo definition out of Maven's
>
> > core so it can be more easily changed.
>
> > MNG-5227   WONTFIX  The 'optional' flag of a dependency should
>
> > be manageable.
>
> > MNG-5297   WONTFIX  improved explanations on prerequisites.maven
>
> > in Maven 3
>
> > MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
>
> > to lifecycle (regression)
>
> > MNG-5368   WONTFIX  UnsupportedOperationException thrown when
>
> > version range is not correct in
>
> > dependencyManagement definitions
>
> > MNG-5457   WONTFIX  Show repository id when downloading or
>
> > uploading from/to a remote repository
>
> > MNG-5527   WONTFIX  Relocation does not work for imported poms
>
> > MNG-5538   WONTFIX  mvn start script causes cygwin warning
>
> > MNG-5567   WONTFIX  Zip files are not included in classpaths at
>
> > all
>
> > MNG-5600   WONTFIX  Dependency management import should support
>
> > exclusions.
>
> > MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
>
> > scripts anymore
>
> > MNG-5629   WONTFIX  ClosedChannelException from
>
> > DefaultUpdateCheckManager.read
>
> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>
> > from Repo that contains a ${parameter}
>
> > MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>
> > from Repo that contains a ${parameter}
>
> > MNG-5661   WONTFIX  Make MavenProject instances immutable after
>
> > initial construction
>
> > MNG-5670   WONTFIX  guard against
>
> > ConcurrentModificationException
>
> > MNG-5761   WONTFIX  Dependency management is not transitive.
>
> > MNG-5761   WONTFIX  Dependency management is not transitive.
>
> > MNG-5761   WONTFIX  Dependency management is not transitive.
>
> > MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
>
> > properly when using "&&"
>
> > MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
>
> > spaces - missing quotes
>
> > MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
>
> > implemented in other ways in the meantime.
>
> > MNG-5836   WONTFIX  put $maven.home/conf/logging first in
>
> > classpath to avoid extension jar overriding
>
> > logging config
>
> > MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
>
> > /bin/bash functions Submitted by: Joseph
>
> > 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Christian Schulte
Am 31.12.2016 um 22:14 schrieb Stephen Connolly:
> FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
> MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
> MNG-6003, MNG-6078
> 
> I think colourised logging probably should be 3.5.x but I am open to the
> idea of making it 3.5.0 as it *should* not affect the build behaviour.
> 
> Do we have and seconders for the above?
> 
> Do we have anyone else proposing issues for 3.5.0?

FIX-3.5.0: MNG-6112,MNG-6113

> 
> - Stephen
> 
> 
> On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
> stephen.alan.conno...@gmail.com> wrote:
> 
>> Here are the changes in current master since 3.3.9 (with some minor
>> changes omitted)
>>
>> Issue ID   Target Version   Summary
>>    ==   
>> MNG-1577   WONTFIX  dependencyManagement does not work for
>> transitive dependencies
>> MNG-2199   WONTFIX  Support version ranges in parent elements
>> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
>> directories to super POM
>> MNG-3507   WONTFIX  added support for multi-lines error message
>> with color
>> MNG-3507   WONTFIX  ANSI Color logging for improved output
>> visibility.
>> MNG-3705   WONTFIX  fixed mojo execution id color display
>> MNG-3825   WONTFIX  Dependencies with classifier should not
>> always require a version.
>> MNG-4345   WONTFIX  [regression] Plugin executions contributed
>> by default lifecycle mapping execute after
>> other plugin executions bound to the same
>> phase"
>> MNG-4347   WONTFIX  import-scoped dependencies of direct
>> dependencies are not resolved using profile
>> modifications from settings.xml
>> MNG-4463   WONTFIX  Dependency management import should support
>> version ranges.
>> MNG-4645   WONTFIX  Move central repo definition out of Maven's
>> core so it can be more easily changed.
>> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
>> be manageable.
>> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
>> in Maven 3
>> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
>> to lifecycle (regression)
>> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
>> version range is not correct in
>> dependencyManagement definitions
>> MNG-5457   WONTFIX  Show repository id when downloading or
>> uploading from/to a remote repository
>> MNG-5527   WONTFIX  Relocation does not work for imported poms
>> MNG-5538   WONTFIX  mvn start script causes cygwin warning
>> MNG-5567   WONTFIX  Zip files are not included in classpaths at
>> all
>> MNG-5600   WONTFIX  Dependency management import should support
>> exclusions.
>> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
>> scripts anymore
>> MNG-5629   WONTFIX  ClosedChannelException from
>> DefaultUpdateCheckManager.read
>> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>> from Repo that contains a ${parameter}
>> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
>> from Repo that contains a ${parameter}
>> MNG-5661   WONTFIX  Make MavenProject instances immutable after
>> initial construction
>> MNG-5670   WONTFIX  guard against
>> ConcurrentModificationException
>> MNG-5761   WONTFIX  Dependency management is not transitive.
>> MNG-5761   WONTFIX  Dependency management is not transitive.
>> MNG-5761   WONTFIX  Dependency management is not transitive.
>> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
>> properly when using "&&"
>> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
>> spaces - missing quotes
>> MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
>> implemented in other ways in the meantime.
>> MNG-5836   WONTFIX  put $maven.home/conf/logging first in
>> classpath to avoid extension jar overriding
>> logging config
>> MNG-5837   WONTFIX  "mvn" script invokes 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Michael Osipov

Am 2016-12-31 um 21:10 schrieb Stephen Connolly:

Here are the changes in current master since 3.3.9 (with some minor changes
omitted)

Issue ID   Target Version   Summary
   ==   
MNG-1577   WONTFIX  dependencyManagement does not work for
transitive dependencies
MNG-2199   WONTFIX  Support version ranges in parent elements
MNG-2478   WONTFIX  add "resources-filtered" filtered resource
directories to super POM
MNG-3507   WONTFIX  added support for multi-lines error message
with color
MNG-3507   WONTFIX  ANSI Color logging for improved output
visibility.
MNG-3705   WONTFIX  fixed mojo execution id color display
MNG-3825   WONTFIX  Dependencies with classifier should not
always require a version.
MNG-4345   WONTFIX  [regression] Plugin executions contributed
by default lifecycle mapping execute after
other plugin executions bound to the same
phase"
MNG-4347   WONTFIX  import-scoped dependencies of direct
dependencies are not resolved using profile
modifications from settings.xml
MNG-4463   WONTFIX  Dependency management import should support
version ranges.
MNG-4645   WONTFIX  Move central repo definition out of Maven's
core so it can be more easily changed.
MNG-5227   WONTFIX  The 'optional' flag of a dependency should
be manageable.
MNG-5297   WONTFIX  improved explanations on prerequisites.maven
in Maven 3
MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
to lifecycle (regression)
MNG-5368   WONTFIX  UnsupportedOperationException thrown when
version range is not correct in
dependencyManagement definitions
MNG-5457   WONTFIX  Show repository id when downloading or
uploading from/to a remote repository
MNG-5527   WONTFIX  Relocation does not work for imported poms
MNG-5538   WONTFIX  mvn start script causes cygwin warning
MNG-5567   WONTFIX  Zip files are not included in classpaths at
all
MNG-5600   WONTFIX  Dependency management import should support
exclusions.
MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
scripts anymore
MNG-5629   WONTFIX  ClosedChannelException from
DefaultUpdateCheckManager.read
MNG-5639   WONTFIX  Support resolution of Import Scope POMs
from Repo that contains a ${parameter}
MNG-5639   WONTFIX  Support resolution of Import Scope POMs
from Repo that contains a ${parameter}
MNG-5661   WONTFIX  Make MavenProject instances immutable after
initial construction
MNG-5670   WONTFIX  guard against
ConcurrentModificationException
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
properly when using "&&"
MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
spaces - missing quotes
MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
implemented in other ways in the meantime.
MNG-5836   WONTFIX  put $maven.home/conf/logging first in
classpath to avoid extension jar overriding
logging config
MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
/bin/bash functions Submitted by: Joseph
Walton 
MNG-5868   WONTFIX  Adding serval times the same artifact via
MavenProjectHelper (attachArtifact) does not
produce a failure
MNG-5878   WONTFIX  added project.directory property to support
module name != artifactId in every
calculated URLs
MNG-5883   WONTFIX  Silence unnecessary legacy local repository
warning
MNG-5889   WONTFIX  adding logic that looks for the file argument
and starts the search for the .mvn directory
 

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Stephen Connolly
FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837,
MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967, MNG-5968, MNG-6001,
MNG-6003, MNG-6078

I think colourised logging probably should be 3.5.x but I am open to the
idea of making it 3.5.0 as it *should* not affect the build behaviour.

Do we have and seconders for the above?

Do we have anyone else proposing issues for 3.5.0?

- Stephen


On Sat 31 Dec 2016 at 20:10, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> Here are the changes in current master since 3.3.9 (with some minor
> changes omitted)
>
> Issue ID   Target Version   Summary
>    ==   
> MNG-1577   WONTFIX  dependencyManagement does not work for
> transitive dependencies
> MNG-2199   WONTFIX  Support version ranges in parent elements
> MNG-2478   WONTFIX  add "resources-filtered" filtered resource
> directories to super POM
> MNG-3507   WONTFIX  added support for multi-lines error message
> with color
> MNG-3507   WONTFIX  ANSI Color logging for improved output
> visibility.
> MNG-3705   WONTFIX  fixed mojo execution id color display
> MNG-3825   WONTFIX  Dependencies with classifier should not
> always require a version.
> MNG-4345   WONTFIX  [regression] Plugin executions contributed
> by default lifecycle mapping execute after
> other plugin executions bound to the same
> phase"
> MNG-4347   WONTFIX  import-scoped dependencies of direct
> dependencies are not resolved using profile
> modifications from settings.xml
> MNG-4463   WONTFIX  Dependency management import should support
> version ranges.
> MNG-4645   WONTFIX  Move central repo definition out of Maven's
> core so it can be more easily changed.
> MNG-5227   WONTFIX  The 'optional' flag of a dependency should
> be manageable.
> MNG-5297   WONTFIX  improved explanations on prerequisites.maven
> in Maven 3
> MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
> to lifecycle (regression)
> MNG-5368   WONTFIX  UnsupportedOperationException thrown when
> version range is not correct in
> dependencyManagement definitions
> MNG-5457   WONTFIX  Show repository id when downloading or
> uploading from/to a remote repository
> MNG-5527   WONTFIX  Relocation does not work for imported poms
> MNG-5538   WONTFIX  mvn start script causes cygwin warning
> MNG-5567   WONTFIX  Zip files are not included in classpaths at
> all
> MNG-5600   WONTFIX  Dependency management import should support
> exclusions.
> MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
> scripts anymore
> MNG-5629   WONTFIX  ClosedChannelException from
> DefaultUpdateCheckManager.read
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5639   WONTFIX  Support resolution of Import Scope POMs
> from Repo that contains a ${parameter}
> MNG-5661   WONTFIX  Make MavenProject instances immutable after
> initial construction
> MNG-5670   WONTFIX  guard against
> ConcurrentModificationException
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5761   WONTFIX  Dependency management is not transitive.
> MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
> properly when using "&&"
> MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
> spaces - missing quotes
> MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
> implemented in other ways in the meantime.
> MNG-5836   WONTFIX  put $maven.home/conf/logging first in
> classpath to avoid extension jar overriding
> logging config
> MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
> /bin/bash functions Submitted by: Joseph
> Walton 
> MNG-5868   WONTFIX  Adding 

[DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

2016-12-31 Thread Stephen Connolly
Here are the changes in current master since 3.3.9 (with some minor changes
omitted)

Issue ID   Target Version   Summary
   ==   
MNG-1577   WONTFIX  dependencyManagement does not work for
transitive dependencies
MNG-2199   WONTFIX  Support version ranges in parent elements
MNG-2478   WONTFIX  add "resources-filtered" filtered resource
directories to super POM
MNG-3507   WONTFIX  added support for multi-lines error message
with color
MNG-3507   WONTFIX  ANSI Color logging for improved output
visibility.
MNG-3705   WONTFIX  fixed mojo execution id color display
MNG-3825   WONTFIX  Dependencies with classifier should not
always require a version.
MNG-4345   WONTFIX  [regression] Plugin executions contributed
by default lifecycle mapping execute after
other plugin executions bound to the same
phase"
MNG-4347   WONTFIX  import-scoped dependencies of direct
dependencies are not resolved using profile
modifications from settings.xml
MNG-4463   WONTFIX  Dependency management import should support
version ranges.
MNG-4645   WONTFIX  Move central repo definition out of Maven's
core so it can be more easily changed.
MNG-5227   WONTFIX  The 'optional' flag of a dependency should
be manageable.
MNG-5297   WONTFIX  improved explanations on prerequisites.maven
in Maven 3
MNG-5359   WONTFIX  Declared execution in PluginMgmt gets bound
to lifecycle (regression)
MNG-5368   WONTFIX  UnsupportedOperationException thrown when
version range is not correct in
dependencyManagement definitions
MNG-5457   WONTFIX  Show repository id when downloading or
uploading from/to a remote repository
MNG-5527   WONTFIX  Relocation does not work for imported poms
MNG-5538   WONTFIX  mvn start script causes cygwin warning
MNG-5567   WONTFIX  Zip files are not included in classpaths at
all
MNG-5600   WONTFIX  Dependency management import should support
exclusions.
MNG-5607   WONTFIX  Don't use M2_HOME in mvn shell/command
scripts anymore
MNG-5629   WONTFIX  ClosedChannelException from
DefaultUpdateCheckManager.read
MNG-5639   WONTFIX  Support resolution of Import Scope POMs
from Repo that contains a ${parameter}
MNG-5639   WONTFIX  Support resolution of Import Scope POMs
from Repo that contains a ${parameter}
MNG-5661   WONTFIX  Make MavenProject instances immutable after
initial construction
MNG-5670   WONTFIX  guard against
ConcurrentModificationException
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5761   WONTFIX  Dependency management is not transitive.
MNG-5815   WONTFIX  "mvn.cmd" does not indicate failure
properly when using "&&"
MNG-5823   WONTFIX  mvnDebug doesn't work with M2_HOME with
spaces - missing quotes
MNG-5824   WONTFIX  Closes #49 because MNG-5824 has been
implemented in other ways in the meantime.
MNG-5836   WONTFIX  put $maven.home/conf/logging first in
classpath to avoid extension jar overriding
logging config
MNG-5837   WONTFIX  "mvn" script invokes /bin/sh but requires
/bin/bash functions Submitted by: Joseph
Walton 
MNG-5868   WONTFIX  Adding serval times the same artifact via
MavenProjectHelper (attachArtifact) does not
produce a failure
MNG-5878   WONTFIX  added project.directory property to support
module name != artifactId in every
calculated URLs
MNG-5883   WONTFIX  Silence unnecessary legacy local repository
warning
MNG-5889   WONTFIX  adding logic that looks for the file argument
and starts the search for the .mvn directory
at the location of the