Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-19 Thread Stephen Connolly
On Sun 19 Mar 2017 at 02:58, Christian Schulte wrote: > Branch name is MNG-6182 > > < > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/MNG-6182 > > > > Commit is > > < >

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Christian Schulte
Branch name is MNG-6182 Commit is Should I create a separate JIRA issue for this? Regards, --

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Stephen Connolly
On Sat 18 Mar 2017 at 21:58, Christian Schulte wrote: > Am 03/18/17 um 14:04 schrieb Stephen Connolly: > > Given that these new methods actually have implementations, could we see > > about having at least a unit test of the new code - since it will not be > > covered by any

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Christian Schulte
Am 03/18/17 um 14:04 schrieb Stephen Connolly: > Given that these new methods actually have implementations, could we see > about having at least a unit test of the new code - since it will not be > covered by any test. There would be an integration test for the code. Since nothing uses it, no

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Stephen Connolly
Given that these new methods actually have implementations, could we see about having at least a unit test of the new code - since it will not be covered by any test. If we have no test and no usage, then we could realistically replace the implementations with `throw new

Re: maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-10 Thread Stephen Connolly
Christian you need to be proactive and sort this out... FTR as release manager for Maven core 3.5.0 I have an easy answer to any decisions asked of me: my answer is Out! For example, If there is a S1/S2 bug in coloured logging, then either it gets fixed promptly or it is out. I will be brutal to

Re: maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-10 Thread Christian Schulte
Am 03/10/17 um 23:33 schrieb Christian Schulte: > Am 03/10/17 um 20:16 schrieb Robert Scholte: >> On Fri, 10 Mar 2017 16:47:45 +0100, Christian Schulte >> wrote: >> >>> Am 03/10/17 um 10:42 schrieb Robert Scholte: Having a closer look at this commit, I actually don't like

Re: maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-10 Thread Christian Schulte
Am 03/10/17 um 20:16 schrieb Robert Scholte: > On Fri, 10 Mar 2017 16:47:45 +0100, Christian Schulte > wrote: > >> Am 03/10/17 um 10:42 schrieb Robert Scholte: >>> Having a closer look at this commit, I actually don't like the idea that >>> ModelResolver now supports

Re: maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-10 Thread Robert Scholte
On Fri, 10 Mar 2017 16:47:45 +0100, Christian Schulte wrote: Am 03/10/17 um 10:42 schrieb Robert Scholte: Having a closer look at this commit, I actually don't like the idea that ModelResolver now supports versionRanges. IMO the version should always be specific *before*

Re: maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-10 Thread Christian Schulte
Am 03/10/17 um 10:42 schrieb Robert Scholte: > Having a closer look at this commit, I actually don't like the idea that > ModelResolver now supports versionRanges. > IMO the version should always be specific *before* resolving the model. > IIUC correctly this is required to supported

Re: maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-10 Thread Robert Scholte
Having a closer look at this commit, I actually don't like the idea that ModelResolver now supports versionRanges. IMO the version should always be specific *before* resolving the model. IIUC correctly this is required to supported version-ranges for managed dependencies, and that is also