Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Timothy Chen
On July 13, 2014, 11:45 p.m., Benjamin Hindman wrote: src/tests/health_check_tests.cpp, line 159 https://reviews.apache.org/r/23443/diff/1/?file=629112#file629112line159 I don't understand how changing to ASSERT from EXPECT would change the flakiness. Well currently the tests

Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/ --- (Updated July 14, 2014, 7:13 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 23091: unbundle picojson

2014-07-14 Thread Timothy St. Clair
On July 13, 2014, 8 a.m., Adam B wrote: Looks great. Almost identical to the boost version, so it must be right. :) Did you test configure make check with/without bundled picojson, with --enable_bundled=yes/no, and with/without system picojson installed? (or some relevant combination

Re: Review Request 23414: Unbundling of libev

2014-07-14 Thread Timothy St. Clair
On July 13, 2014, 8:44 a.m., Adam B wrote: LGTM. Did you test with/without in interesting combinations? Standard testing for it. I took special care around libev, as packagers will likely need to address the constraint that libev is a rebuild library. So make check will fail in

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-07-14 Thread Timothy St. Clair
On July 13, 2014, 8:35 a.m., Adam B wrote: src/Makefile.am, line 1074 https://reviews.apache.org/r/22994/diff/2/?file=618603#file618603line1074 Was this not needed for mesos_tests_CPPFLAGS before? Why is it needed now? B4 the tests files actually reconstructed the 3rdparty path

Review Request 23453: Unbundle glog

2014-07-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1170

Re: Review Request 23416: Fix health check command subprocess handling

2014-07-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23416/ --- (Updated July 14, 2014, 5:42 p.m.) Review request for mesos, Adam B, Benjamin

Re: Mesos language bindings in the wild

2014-07-14 Thread Tim St Clair
So I fear the fragmentation that can occur if we provide native bindings outside of the core, unless there is some mechanism for testing, a well established versioning scheme. IMHO, priority inversion on 'versioning' should come before bindings to ensure we adhere to policy. Thoughts?

Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Benjamin Hindman
On July 13, 2014, 11:45 p.m., Benjamin Hindman wrote: src/tests/health_check_tests.cpp, line 159 https://reviews.apache.org/r/23443/diff/1/?file=629112#file629112line159 I don't understand how changing to ASSERT from EXPECT would change the flakiness. Timothy Chen wrote:

Re: Review Request 22066: Added timeout to rescind unused offers

2014-07-14 Thread Kapil Arya
On July 9, 2014, 4:10 p.m., Niklas Nielsen wrote: Kapil, should we drop this in favor of https://reviews.apache.org/r/22796/? Sure. - Kapil --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 22980: Enable support for existing cgroups, don't always try to create.

2014-07-14 Thread Vinod Kone
On June 25, 2014, 10:09 p.m., Ian Downes wrote: src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 236 https://reviews.apache.org/r/22980/diff/1/?file=617510#file617510line236 Why would the cgroup already exist? The cgroup is based on the containerId which should be

Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Timothy Chen
On July 13, 2014, 11:45 p.m., Benjamin Hindman wrote: src/tests/health_check_tests.cpp, line 159 https://reviews.apache.org/r/23443/diff/1/?file=629112#file629112line159 I don't understand how changing to ASSERT from EXPECT would change the flakiness. Timothy Chen wrote:

Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/#review47733 --- Bad patch! Reviews applied: [23416] Failed command: git apply

Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/ --- (Updated July 14, 2014, 8:05 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 22980: Enable support for existing cgroups, don't always try to create.

2014-07-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22980/ --- (Updated July 14, 2014, 8:04 p.m.) Review request for mesos, Benjamin Hindman,

Re: 0.19.1

2014-07-14 Thread Benjamin Mahler
Will also pull in MESOS-1538 https://issues.apache.org/jira/browse/MESOS-1538 for this. On Wed, Jul 9, 2014 at 11:12 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: I've added it to the 0.19.1 list since it's trivial and helps those using S3. On Fri, Jul 4, 2014 at 12:52 PM, Tom

Build failed in Jenkins: mesos-reviewbot #1111

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot//changes Changes: [bmahler] Added CHANGELOG for 0.19.1. [bmahler] Updated the upgrades document for 0.18.2 and 0.19.1. -- [...truncated 214 lines...] 3rdparty/Makefile.am:130: but option

[GitHub] mesos pull request: Add Sailthru to the Powered by Mesos page

2014-07-14 Thread davelester
Github user davelester commented on the pull request: https://github.com/apache/mesos/pull/21#issuecomment-48945644 Thanks! I just committed this, but it looks like asfbot didn't close this when I committed your patch. Could you close this request? --- If your project is set up for

Re: Review Request 22981: enable co-mounting of cpu cpuacct for systemd

2014-07-14 Thread Vinod Kone
On June 27, 2014, 9:21 p.m., Vinod Kone wrote: src/linux/cgroups.cpp, lines 453-463 https://reviews.apache.org/r/22981/diff/1/?file=617552#file617552line453 I don't think this is going to work. First off, the cpushare isolator needs to be made aware of the co-mounted

Build failed in Jenkins: mesos-reviewbot #1112

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1112/ -- [...truncated 214 lines...] 3rdparty/Makefile.am:130: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:130: warning: source file '$(STOUT)/tests/set_tests.cpp' is in a subdirectory,

[VOTE] Release Apache Mesos 0.19.1 (rc1)

2014-07-14 Thread Benjamin Mahler
Hi all, Please vote on releasing the following candidate as Apache Mesos 0.19.1. 0.19.1 includes the following: Fixes a long standing critical bug in the JNI bindings that can lead to framework unregistration.

Re: Review Request 22981: enable co-mounting of cpu cpuacct for systemd

2014-07-14 Thread Timothy St. Clair
On June 27, 2014, 9:21 p.m., Vinod Kone wrote: src/linux/cgroups.cpp, lines 453-463 https://reviews.apache.org/r/22981/diff/1/?file=617552#file617552line453 I don't think this is going to work. First off, the cpushare isolator needs to be made aware of the co-mounted

Re: [VOTE] Release Apache Mesos 0.19.1 (rc1)

2014-07-14 Thread Timothy Chen
+1 (non-binding). Tim On Mon, Jul 14, 2014 at 2:32 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.19.1. 0.19.1 includes the following:

Re: Review Request 23443: Fix Health check tests and send healthy state on task kill

2014-07-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/#review47741 --- Patch looks great! Reviews applied: [23443] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #1113

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1113/changes

Review Request 23461: Added 'bool' return value to Containerizer::launch.

2014-07-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23461/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: MESOS-1527

Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.

2014-07-14 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23461/#review47742 --- Ship it! Ship It! - Ian Downes On July 14, 2014, 3:22 p.m.,

Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.

2014-07-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23461/ --- (Updated July 14, 2014, 10:29 p.m.) Review request for mesos, Ian Downes and

Review Request 23464: Properly iterate through composing containerizers.

2014-07-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23464/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: MESOS-1527

Review Request 23462: Added composing containerizer and --containerizers flag.

2014-07-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23462/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: MESOS-1527

Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.

2014-07-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23461/ --- (Updated July 14, 2014, 10:31 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 23464: Properly iterate through composing containerizers.

2014-07-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23464/ --- (Updated July 14, 2014, 10:31 p.m.) Review request for mesos, Ian Downes and

Build failed in Jenkins: mesos-reviewbot #1114

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1114/ -- [...truncated 215 lines...] 3rdparty/Makefile.am:130: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:130: warning: source file '$(STOUT)/tests/set_tests.cpp' is in a subdirectory,

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-14 Thread Zuyu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23216/ --- (Updated July 15, 2014, 12:11 a.m.) Review request for mesos, Benjamin

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-14 Thread Zuyu Zhang
On July 12, 2014, 12:08 a.m., Jie Yu wrote: src/examples/low_level_scheduler_pthread.cpp, lines 372-374 https://reviews.apache.org/r/23216/diff/3/?file=624436#file624436line372 You don't really need to protect 'framework' here. Although all callbacks are executed using async(),

Build failed in Jenkins: mesos-reviewbot #1115

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1115/ -- [...truncated 214 lines...] 3rdparty/Makefile.am:130: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:130: warning: source file '$(STOUT)/tests/set_tests.cpp' is in a subdirectory,

Re: Review Request 20504: Added 'process::unlink()' to simulate exited events in tests.

2014-07-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20504/ --- (Updated July 15, 2014, 12:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20507: Fixed master to reject completed frameworks from re-registering.

2014-07-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20507/ --- (Updated July 15, 2014, 12:38 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20507: Fixed master to reject completed frameworks from re-registering.

2014-07-14 Thread Vinod Kone
On April 23, 2014, 1:06 a.m., Adam B wrote: src/master/master.cpp, lines 1062-1068 https://reviews.apache.org/r/20507/diff/2/?file=563937#file563937line1062 Couldn't this also happen if a (misbehaving) framework completes/fails in any other way, then tries to re-register with the

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

2014-07-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23147/#review47751 --- Ship it! Thanks Alexandra, this looks good to me. I am ok with

Jenkins build is back to normal : mesos-reviewbot #1116

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1116/

Re: [VOTE] Release Apache Mesos 0.19.1 (rc1)

2014-07-14 Thread Vinod Kone
+1 (binding) Tested on OSX Mavericks w/ gcc-4.8 On Mon, Jul 14, 2014 at 2:35 PM, Timothy Chen tnac...@gmail.com wrote: +1 (non-binding). Tim On Mon, Jul 14, 2014 at 2:32 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi all, Please vote on releasing the following candidate as

Re: Review Request 23464: Properly iterate through composing containerizers.

2014-07-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23464/#review47757 --- Patch looks great! Reviews applied: [23461, 23462, 23464] All

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23216/#review47758 --- Ship it! Looks great! LGTM.

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23216/#review47759 --- Patch looks great! Reviews applied: [23216] All tests passed. -

Re: Review Request 20504: Added 'process::unlink()' to simulate exited events in tests.

2014-07-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20504/#review47762 --- Patch looks great! Reviews applied: [20504] All tests passed. -

Build failed in Jenkins: mesos-reviewbot #1120

2014-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1120/ -- [...truncated 254 lines...] 3rdparty/Makefile.am:130: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:130: warning: source file '$(STOUT)/tests/set_tests.cpp' is in a subdirectory,

Re: Build failed in Jenkins: mesos-reviewbot #1120

2014-07-14 Thread Vinod Kone
+Jake Jake, I thought all the Apache Ubuntu Jenkins slaves had libcurl installed? Has that changed? On Mon, Jul 14, 2014 at 8:44 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/mesos-reviewbot/1120/ --

[GitHub] mesos pull request: Add Sailthru to the Powered by Mesos page

2014-07-14 Thread adgaudio
Github user adgaudio closed the pull request at: https://github.com/apache/mesos/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Release Apache Mesos 0.19.1 (rc1)

2014-07-14 Thread Benjamin Hindman
+1, thanks Ben! On Mon, Jul 14, 2014 at 6:20 PM, Vinod Kone vinodk...@gmail.com wrote: +1 (binding) Tested on OSX Mavericks w/ gcc-4.8 On Mon, Jul 14, 2014 at 2:35 PM, Timothy Chen tnac...@gmail.com wrote: +1 (non-binding). Tim On Mon, Jul 14, 2014 at 2:32 PM, Benjamin Mahler