---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/#review53942
---
Patch looks great!
Reviews applied: [25819]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review53943
---
Bad patch!
Reviews applied: [25789, 25818]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
(Updated Sept. 19, 2014, 6:59 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review53945
---
Bad patch!
Reviews applied: [25789, 25818]
Failed command: make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53949
---
Mostly just style stuff, after a quick cleanup we'll get this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review53951
---
3rdparty/libprocess/include/process/help.hpp
+1
make check on OSX 10.9.5, clang 3.5 (Xcode 6)
-all tests passed
On Sep 19, 2014, at 3:03 AM, Vinod Kone vinodk...@gmail.com wrote:
+1 (binding)
sudo make check on CentOS 5.5 w/ gcc-4.8.2
On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote:
Hi all,
Please vote
+1 (binding)
On Friday, September 19, 2014, Till Toenshoff toensh...@me.com wrote:
+1
make check on OSX 10.9.5, clang 3.5 (Xcode 6)
-all tests passed
On Sep 19, 2014, at 3:03 AM, Vinod Kone vinodk...@gmail.com
javascript:_e(%7B%7D,'cvml','vinodk...@gmail.com'); wrote:
+1 (binding)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
(Updated Sept. 19, 2014, 4:08 p.m.)
Review request for mesos and Benjamin
+1 (binding)
Make check on centos5 and centos6 (gcc48)
On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote:
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.20.1.
0.20.1 includes the following:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review53965
---
Patch looks great!
Reviews applied: [25789, 25818]
All tests
+1 (non-binding)
Make check on Ubuntu 12.04 with gcc 4.6.3
On 19 September 2014 17:37, Tim Chen t...@mesosphere.io wrote:
+1 (non-binding)
Make check on Centos 5.5, docker tests all passed too.
Tim
On Fri, Sep 19, 2014 at 9:17 AM, Jie Yu yujie@gmail.com wrote:
+1 (binding)
Make
On Sept. 18, 2014, 12:56 p.m., Cody Maloney wrote:
m4/ax_cxx_compile_stdcxx_11.m4, line 76
https://reviews.apache.org/r/25448/diff/1/?file=682725#file682725line76
It would be good to probably have an assert or two here to ensure the
move worked.
assert(!p2);
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25448/
---
(Updated Sept. 19, 2014, 10:48 a.m.)
Review request for mesos, Benjamin
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote:
OK. I went through parts of this review but I have a bigger suggestion in
mind, before I get too much into the weeds.
I think it's worthwhile for you to write up a design doc similar to the
framework info doc w.r.t. updating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25218/#review53976
---
Ship it!
Ben, I'll commit this for you.
- Vinod Kone
On Aug.
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote:
OK. I went through parts of this review but I have a bigger suggestion in
mind, before I get too much into the weeds.
I think it's worthwhile for you to write up a design doc similar to the
framework info doc w.r.t. updating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25448/#review53984
---
Patch looks great!
Reviews applied: [25448]
All tests passed.
-
Hi everyone,
We have been iterating on a design for pluggable modules in Mesos lately
and wanted to get a last round of feedback before putting out patch sets.
Tim St Clair, Ben Hindman and I started the discussion (and work) on this
subsystem https://issues.apache.org/jira/browse/MESOS-1224 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 19, 2014, 6:37 p.m.)
Review request for mesos and Benjamin
On Sept. 19, 2014, 10:25 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 205
https://reviews.apache.org/r/25789/diff/4/?file=694225#file694225line205
At first I was expecting strings::join to just be variadic on
std::string (like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/
---
(Updated Sept. 19, 2014, 7:01 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review53993
---
src/tests/environment.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25844/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25843/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1821
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25843/#review54009
---
src/master/master.hpp
I'm sorry, but I'm still having a hard time understanding why this needs to
be dynamic.
If the mesos core is split into modules that are built as standalone
libraries (static) then at link time the right combination of libraries can
be bundled together to create the end result. If you want to get
The design was specifically tailored to allow non-modules to be used in lieu of
modules. So nothing has to be reimplemented as a module. There may be some
refactoring to abstract a class, though, but that’s usually a good idea anyway.
On Sep 19, 2014, at 1:03 PM, Dominic Hamon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25798/#review54017
---
Patch looks great!
Reviews applied: [25789, 25798]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/#review54018
---
3rdparty/libprocess/include/process/node.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25844/#review54020
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 19, 2014, 7:57 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 19, 2014, 4:40 p.m.)
Review request for mesos, Benjamin
On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/node.hpp, line 32
https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32
uint64_t?
start getting ipv6 support in... ;)
Still won't fit in ipv6 though :(
- Nikita
On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/node.hpp, line 32
https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32
uint64_t?
start getting ipv6 support in... ;)
Nikita Vetoshkin wrote:
Still won't fit
On Sept. 19, 2014, 1:32 p.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/node.hpp, line 32
https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32
uint64_t?
start getting ipv6 support in... ;)
Nikita Vetoshkin wrote:
Still won't fit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25843/#review54024
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/#review54030
---
Ship it!
Can you motivate it a bit in context of eventually
inline
- Original Message -
From: Dominic Hamon dha...@twopensource.com
To: dev dev@mesos.apache.org
Sent: Friday, September 19, 2014 3:03:52 PM
Subject: Re: Mesos Modules Design
I'm sorry, but I'm still having a hard time understanding why this needs to
be dynamic.
If the
Hi Dominic,
(response inlined)
On 19 September 2014 13:03, Dominic Hamon dha...@twopensource.com wrote:
I'm sorry, but I'm still having a hard time understanding why this needs to
be dynamic.
If the mesos core is split into modules that are built as standalone
libraries (static) then at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25843/#review54034
---
Patch looks great!
Reviews applied: [25844, 25843]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/
---
(Updated Sept. 19, 2014, 10:19 p.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 19, 2014, 10:27 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25819/#review54042
---
Ship it!
Thanks for updating the description on this one.
- Ben
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2118/changes
Changes:
[bmahler] Ignore terminal task resources in the Master's Framework struct.
[bmahler] Fixed an executor accounting bug in framework re-registration.
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54043
---
First pass
src/examples/test_module.cpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2119/changes
Changes:
[bmahler] Fixed an issue with colored output in post-reviews.py.
[niklas] Refactored Node class in libprocess.
--
[...truncated 1055 lines...]
checking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/#review54050
---
Patch looks great!
Reviews applied: [25847]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54045
---
Thanks Tim, this is looking really nice!
Appreciate the patience,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/
---
Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25785/#review54053
---
I think it's valuable to outline some guidelines for anybody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25866/
---
Review request for mesos, Adam B and Ben Mahler.
Bugs: MESOS-1081 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25867/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1668
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54063
---
Patch looks great!
Reviews applied: [25569]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54070
---
Patch looks great!
Reviews applied: [25858]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25866/#review54072
---
Bad patch!
Reviews applied: [25866]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/#review54073
---
Patch looks great!
Reviews applied: [25868]
All tests passed.
-
59 matches
Mail list logo
