Re: Review Request 32742: Added command logging for processes running in slave's cgroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/#review78611 --- Patch looks great! Reviews applied: [32742] All tests passed. -

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/ --- (Updated April 1, 2015, 10:36 p.m.) Review request for mesos, Jie Yu and Cong

Re: Review Request 32698: Used the argv version of subprocess for linux perf utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32698/#review78612 --- Ship it! src/linux/perf.cpp

Re: Review Request 32742: Added command logging for processes running in slave's cgroup.

On April 1, 2015, 9:15 p.m., Ben Mahler wrote: src/slave/slave.cpp, lines 250-263 https://reviews.apache.org/r/32742/diff/1/?file=912733#file912733line250 ostringstream? Have you considered just building a setstring and using strings::join(\n, commands) below? Then

Re: Review Request 32742: Added command logging for processes running in slave's cgroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/ --- (Updated April 1, 2015, 10:39 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 32558: Improve compile time of mesos by splitting flags

On March 27, 2015, 4:41 p.m., Timothy Chen wrote: src/slave/flags.cpp, line 29 https://reviews.apache.org/r/32558/diff/3/?file=907340#file907340line29 How about keeping the same style with namespaces? Just to be consistent with everywhere else in the code base. Cody Maloney

Re: Review Request 32742: Added command logging for processes running in slave's cgroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/#review78618 --- Ship it! src/slave/slave.cpp

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78619 --- Bad patch! Reviews applied: [32654] Failed command:

Re: Review Request 32558: Improve compile time of mesos by splitting flags

On March 27, 2015, 4:41 p.m., Timothy Chen wrote: src/slave/flags.cpp, line 29 https://reviews.apache.org/r/32558/diff/3/?file=907340#file907340line29 How about keeping the same style with namespaces? Just to be consistent with everywhere else in the code base. Cody Maloney

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78621 --- Ship it! Ship It! - Timothy Chen On March 31, 2015, 2:16 a.m.,

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 11 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

On April 1, 2015, 10:22 p.m., Jie Yu wrote: src/tests/port_mapping_tests.cpp, line 403 https://reviews.apache.org/r/32653/diff/3/?file=911841#file911841line403 60seconds might be too long. Probably change it to 15 seconds so that it's consistent with AWAIT_READY default. 60

Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 11 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

On April 1, 2015, 10:22 p.m., Jie Yu wrote: src/tests/port_mapping_tests.cpp, lines 405-406 https://reviews.apache.org/r/32653/diff/3/?file=911841#file911841line405 Please include stout/stopwatch.hpp Has this been resolved? - Jie

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- (Updated April 1, 2015, 11:07 p.m.) Review request for mesos, Chi Zhang, Ian

<    1   2