> On April 1, 2015, 10:22 p.m., Jie Yu wrote: > > src/tests/port_mapping_tests.cpp, line 403 > > <https://reviews.apache.org/r/32653/diff/3/?file=911841#file911841line403> > > > > 60seconds might be too long. Probably change it to 15 seconds so that > > it's consistent with AWAIT_READY default.
60 seconds is appropriate for some of these networking tests since when we have high packet losses, the tests can take some time to complete (I have often seen times in the 20-30 second range). - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78605 ----------------------------------------------------------- On April 1, 2015, 8:54 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32653/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 8:54 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Replace busy look on ready file with a more relaxed loop > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 > > Diff: https://reviews.apache.org/r/32653/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
