)
-
3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp
5f763e52a6a3d5a7cb38110ea650283b7a9fa789
Diff: https://reviews.apache.org/r/24700/diff/
Testing
---
* make check
* run master binary and send it SIGTERM signal with kill
Thanks,
Alexandra Sava
5f763e52a6a3d5a7cb38110ea650283b7a9fa789
Diff: https://reviews.apache.org/r/24700/diff/
Testing (updated)
---
* make check
* run master binary and send it SIGTERM signal with kill
Thanks,
Alexandra Sava
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50607
---
On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
>
> ---
>
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/#review50600
-------
On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote:
>
> ---
---
Thanks,
Alexandra Sava
2754/diff/
Testing
---
Thanks,
Alexandra Sava
7>
> >
> > How about taking a set of hostnames as the input to this method, that
> > way you can loop over the slaves a single time, doing lookups against the
> > host set.
> >
> > We need to be a bit careful here with N^2
--
src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b
src/master/master.hpp 7e7a75bd7e0fafc084ad2663c894e76e5fb35edd
src/master/master.cpp 896be5e8db45e819ce9f3a4e24c4017605283f12
Diff: https://reviews.apache.org/r/22754/diff/
Testing
-------
Thanks,
Alexandra Sava
rc/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0
src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01
Diff: https://reviews.apache.org/r/22754/diff/
Testing
---
Thanks,
Alexandra Sava
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47434
---
On July 11, 2014, 1:28 p.m., Alexandra Sava wrote:
>
>
8b329f6e27813776e0d2f2b56605d0eb
src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
Diff: https://reviews.apache.org/r/23147/diff/
Testing
---
Thanks,
Alexandra Sava
> On June 30, 2014, 6:44 a.m., Adam B wrote:
> > src/master/master.hpp, lines 852-854
> > <https://reviews.apache.org/r/23147/diff/1/?file=620067#file620067line852>
> >
> > // We mark a slave 'inactive' ...
> > bool active;
>
&
> On June 30, 2014, 4:13 p.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 4354
> > <https://reviews.apache.org/r/23147/diff/1/?file=620068#file620068line4354>
> >
> > have you considered renaming the metrics?
>
> Alexandra Sava wrote:
To reply, visit:
https://reviews.apache.org/r/23147/#review46985
-------
On July 7, 2014, 7:05 p.m., Alexandra Sava wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
lines 2927-2932
> > <https://reviews.apache.org/r/23147/diff/1/?file=620068#file620068line2927>
> >
> > // If this is a deactivated slave...
> > if (!slave->active) {
> > slave->active = true;
Please see the comment for
8b329f6e27813776e0d2f2b56605d0eb
src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827
src/webui/master/static/js/controllers.js
41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/23147
2754/diff/
Testing
---
Thanks,
Alexandra Sava
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review46964
---
On June 28, 2014, 4:19 p.m., Alexandra Sava wrote:
>
>
_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
Diff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
f42d2e43ce
Diff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
3ce
Diff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
605d0eb
src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827
src/webui/master/static/js/controllers.js
41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/23147/diff/
Testing
---
Thanks,
Alexandra Sava
08b2be8c6c
src/slave/slave.cpp ed3483ff1762d93837f328d1e647c490cf9e14c4
Diff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
/
Diffs
-
src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca
Diff: https://reviews.apache.org/r/22737/diff/
Testing
---
Thanks,
Alexandra Sava
ate review.
Diffs
-
src/master/http.cpp 5d869767cd3ed48aae1e702e8d014a37ef371123
src/master/master.hpp 286e2674df6e11f4c2915ed324fcc103532c
src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621
Diff: https://reviews.apache.org/r/22754/diff/
Testing
---
Thanks,
Alexandra Sava
9a73348abefe7aad4a64d4911836b6eba682a7ca
Diff: https://reviews.apache.org/r/22737/diff/
Testing
---
Thanks,
Alexandra Sava
9a73348abefe7aad4a64d4911836b6eba682a7ca
Diff: https://reviews.apache.org/r/22737/diff/
Testing
---
Thanks,
Alexandra Sava
---
Test to check the SIGUSR1 signal is properly delivered to the slave. The slave
should then shutdown.
Diffs
-
src/tests/slave_recovery_tests.cpp 9a73348abefe7aad4a64d4911836b6eba682a7ca
Diff: https://reviews.apache.org/r/22737/diff/
Testing
---
Thanks,
Alexandra Sava
lem is that in the handler (ex callWrapper) I can't do the dispatch
because I don't have the PID of the slave. That's why there's the whole thing
with the function object which stores the PID of the slave.
- Alexandra
-----
/
Testing
---
Thanks,
Alexandra Sava
005fc54759a4be1651f55249e4e8e1bafc2f73ce
src/tests/mesos.cpp 98a7c3895343b1bc84c13e54d12905de3b431338
src/tests/script.cpp 9f1be63e2c6538a3ae3fd8f39ad0ea1f66ee88a4
src/tests/slave_tests.cpp aaf509d1e0798928ab729704a42ec5aed18c11a2
Diff: https://reviews.apache.org/r/22722/diff/
Testing
---
Thanks,
Alexandra
[
https://issues.apache.org/jira/browse/MESOS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033555#comment-14033555
]
Alexandra Sava commented on MESOS-1475:
---
Hi,
Here is the review for the first
src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368
Diff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
iff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
his review relies on https://reviews.apache.org/r/21379/
Diffs
-
src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62
src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368
Diff: https://reviews.apache.org/r/22367/diff/
Testing
---
Thanks,
Alexandra Sava
ra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21379/#review44563
---
On June 8, 2014, 10:42 a.m., Alexandra Sava wrote:
>
>
d07717388cf62
src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62
src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
b8f3df
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
; sent from the Master to the Slave, but the master does not need to send a
> > 'signal' number to the slave, right?
>
> Alexandra Sava wrote:
> Yes it's true, but I tried removing the signal parameter from
> message.proto file (and also from where the p
ercome the lag of the health check timer (75 sec).
Diffs (updated)
-
src/slave/slave.hpp 769bd00f1464c9935416f044fd834e2187d83a6e
src/slave/slave.cpp a4b9570c0b4f1b56180888ef975add4c8c3cbee7
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
generated e-mail. To reply, visit:
https://reviews.apache.org/r/21379/#review43072
---
On May 18, 2014, 10:07 p.m., Alexandra Sava wrote:
>
> ---
> This
src/slave/slave.cpp 4a8adf0efdd9a230a1f91d8d944fc6145a26b7c4
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
src/slave/slave.cpp 3a4ae38e06a1c23daafebf5421d996e649a07ca5
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
996e649a07ca5
Diff: https://reviews.apache.org/r/21379/diff/
Testing
---
Thanks,
Alexandra Sava
lexandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20850/#review42438
---
On May 1, 2014, 11:09 a.m., Alexandra Sava wrote:
>
>
Hi guys,
Any feedback for my changes would be welcomed.
Thanks,
Alexandra
On 1 May 2014 14:16, Alexandra Sava wrote:
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20850/
>
> On April 29th, 2014, 7:18 p.m. UTC, *Ben M
ument. Also,
getLogFile already does what you said: it returns an Error when the level is
invalid (it never returns an Exit).
Yes I also think it is not ok to have an EXIT in getLogSeverity as long as it
is exposed in the header file. I changed that part as you suggested.
-
tps://reviews.apache.org/r/20850/diff/
Testing
---
Thanks,
Alexandra Sava
176e49a6a2aef13be44ff910144c7321c942345a
src/master/master.cpp f205dca43f10697862e3fd3f435f1127a9d0aecb
src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4
src/webui/master/static/js/controllers.js
4b8487e0c285f892ad352993c81637f38df1429f
Diff: https://reviews.apache.org/r/20850/diff/
Testing
---
Thanks,
Alexandra Sava
tps://reviews.apache.org/r/20850/diff/
Testing
---
Thanks,
Alexandra Sava
o disallow FATAL-only logging for now so that we
> don't have to do this special casing in the Master / Slave / webui?
>
> Or, if we want to keep FATAL-only logging as an option, we could update the
> "pailer" component of the webui show the underlying error from the bac
> > log file once the first log message occurs?
> >
> > Also, seems like this code could be cleaned up to be just:
> >
> > LOG(severity) << "Logging " << google::getLogSeverity(severity) << "
> > level start
at stderr
- the log file for INFO logs is accessible in the
browse
Thanks,
Alexandra Sava
Hi guys,
My name is Alexandra and I'm a Computer Science graduate from
Bucharest, Romania. I've been an open source enthusiast for more than
5 years, when I first installed on my pc a Linux distribution (Ubuntu
that is). I've been using it ever since because I like the fact that I
can configure it
hem what the valid values for this "logging_level" are? How are they
> > to know that they can specify "INFO", "WARNING", "ERROR", "FATAL"?
I think users will be able to see what flags/flags values Mesos supports
through documentation. Ho
displayed at stderr
- the log file for INFO logs is accessible in the
browse
Thanks,
Alexandra Sava
iff: https://reviews.apache.org/r/19580/diff/
Testing
---
Thanks,
Alexandra Sava
d" is the first message in the log file.
- Alexandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19357/#review38121
---
On March
is the
> > behavior if you don't have this?
>
> Alexandra Sava wrote:
> If you try to access the log file in the browser, you get the following
> message: 'FAILED TO INITIALIZE...RETRYING'
I'll mark this issue as dropped because without this change, &#x
Hi guys,
When you have some time, can you please give some feedback to the
updated changes[1]?
[1]https://reviews.apache.org/r/19357/
Thanks,
Alexandra
ble in the browser
5.Test5 - run master and slave with log_dir and quiet flags defined
- expected results: - no logs (just FATAL) are displayed at stderr
- the log file for INFO logs is accessible in the
browse
Thanks,
Alexandra Sava
l. To reply, visit:
https://reviews.apache.org/r/19357/#review37632
-------
On March 18, 2014, 5 p.m., Alexandra Sava wrote:
>
> ---
> This is an automatically generate
message. I will remove the case foar
FATAL level.
- Alexandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19357/#review37632
---
On March 18, 2014, 5 p.m., Alexandra Sava wrote:
>
> -
precedence)
- no log file is accessible in the browser
5.Test5 - run master and slave with log_dir and quiet flags defined
- expected results: - no logs (just FATAL) are displayed at stderr
- the log file for INFO logs is accessible in the
browse
Thanks,
uiet flags defined
- expected results: - no logs (just FATAL) are displayed at stderr
- the log file for INFO logs is accessible in the
browse
Thanks,
Alexandra Sava
[
https://issues.apache.org/jira/browse/MESOS-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandra Sava reassigned MESOS-1067:
-
Assignee: Alexandra Sava
> Specifying minimum logging level doesn
[
https://issues.apache.org/jira/browse/MESOS-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937052#comment-13937052
]
Alexandra Sava commented on MESOS-1067:
---
Hi guys,
Can you please assign
our name, can
> you point me to your JIRA profile?
>
>
> On Fri, Mar 14, 2014 at 5:10 PM, Alexandra Sava
> wrote:
>
>> Hi guys,
>>
>> I have a fix for MESOS-1067 ticket. Can you please add me to the
>> 'contributors' list and assign that ticket to
Hi guys,
I have a fix for MESOS-1067 ticket. Can you please add me to the
'contributors' list and assign that ticket to me (alexandra.sava is my
JIRA username)?
Thanks,
Alexandra
70 matches
Mail list logo
