Re: [Action Required] Stale Reviews

On Wed, Jun 29, 2016 at 9:25 AM, Joris Van Remoortere wrote: > Hello developers, > > Over the last year we've accumulated a significant review backlog. Over the > past month it has been floating around ~600 reviews. Why do you keep thinking the problem is on this side rather

Re: Welcome Anand and Joseph as new committers!

On Thu, Jun 9, 2016 at 2:00 PM, Vinod Kone wrote: > I'm happy to announce that the PMC has voted in *Anand Mazumdar *and *Joseph > Wu* as committers and members of PMC for the Apache Mesos project. Since both are from Mesosphere, so how did you make sure this process is

Re: Newbie to Mesos contributors

Hi, Sha It is not just for you, but I really have no reason to work with a community where my patches usually get delayed for months without any progress. I can show you dozens of samples if you want. Therefore I suggest everyone _not_ to work with this community. It is just complete a waste of

Re: MESOS-2516: Shepherd wanted

Hello, Alex On Mon, May 16, 2016 at 10:17 AM, Alex Rukletsov wrote: > Cong, > > it's strange that you project your frustrations—which are understandable > and may have good reasons—on the project as a whole. There are reasons why > things are done in the way they are done;

Re: MESOS-2516: Shepherd wanted

On Sat, May 14, 2016 at 12:22 PM, José Guilherme Vanz wrote: > If is always difficult to find I shepherd, change the approach can be a > good ideia. Maybe remove this burocracy of a shepherd and keep just the > review board and reviews. Once a new patch is uploaded the >

Re: MESOS-2516: Shepherd wanted

On Thu, May 12, 2016 at 8:54 PM, José Guilherme Vanz wrote: > Even I did not find a shepherd, I've uploaded a first version of the patch > in the review board. You are not alone. This is the biggest problem of this community which people here refuse to see, especially

Re: mesos git commit: Replaced CHECK with CHECK_READY.

On Sun, May 8, 2016 at 1:28 AM, Alex R wrote: > I agree that "atomic patches" (those that do one thing per patch) are a > good thing because they simplify navigating history, do blame and bisect. > But how to define that "one thing"? Some people would say, that a new If "one

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

On Tue, Mar 22, 2016 at 5:10 AM, Kevin Klues wrote: > This way it's easy to track the full set of release candidates, as well as > how they relate to previous release candidates, minor releases, and point > releases. There is no essential difference with the current approach

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

On Fri, Mar 18, 2016 at 4:59 PM, Kevin Klues wrote: > I respectfully disagree. > > The whole purpose of tags is to mark permanent things like releases, > whereas branches are designed as temporary lines of development that > come and go (and grow and shrink) dynamically all the

Re: Compile with CFLAGS=-DWITH_NETWORK_ISOLATOR

On Tue, Mar 22, 2016 at 6:21 AM, Jay Guo wrote: > > Also, does this work with OSX? Is there any equivalent library as libnl? No, netlink is a very specific and powerful feature on Linux, and it is one big reason why Linux is MUCH better than OSX on networking. See:

Re: Backport r/44230 to 0.27 branch

On Tue, Mar 15, 2016 at 2:39 PM, Jie Yu wrote: > Mesos currently has no notion of long term stable releases (i.e., LTS). I > think the consensus in the last community sync was to introduce LTS after > 1.0. You don't need LTS as kernel, even talking about short term stable

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

On Wed, Mar 16, 2016 at 11:56 AM, Joseph Wu <jos...@mesosphere.io> wrote: > Cong Wang, > > The tags are sync'd. See: https://github.com/apache/mesos/releases > > You might not have done: git pull --tags Yeah, I figured it out by myself too. This is why I hate tags

Re: Backport r/44230 to 0.27 branch

On Wed, Mar 16, 2016 at 11:57 AM, Zameer Manji wrote: > Cong brings up a good point here. Currently Mesos has a very aggressive > release cadence. This results in several questions as a cluster operator > and framework author. > >- What is the support from the

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

On Wed, Mar 16, 2016 at 11:49 AM, Cong Wang <cw...@twopensource.com> wrote: > On Mon, Mar 7, 2016 at 8:29 PM, Michael Park <mp...@apache.org> wrote: >> Please find the release at: >> https://dist.apache.org/repos/dist/release/mesos/0.27.2 >> >> It is

Re: Backport r/44230 to 0.27 branch

On Wed, Mar 16, 2016 at 5:19 PM, Vinod Kone wrote: > Cong, I understand your frustration with the review process and backports. > I've already created a ticket to track the latter. Would love your > input/feedback on it. > > Regarding the former, we understand the pain. Our

Re: Backport r/44230 to 0.27 branch

On Wed, Mar 16, 2016 at 11:58 AM, Jie Yu wrote: > > Currently, it's based on request. We definitely need to improve this part. It simply doesn't work, like many other review requests are burned or take 6+ months to merge. I am sure you need to improve that too, but after

Re: [RESULT][VOTE] Release Apache Mesos 0.27.2 (rc1)

On Mon, Mar 7, 2016 at 8:29 PM, Michael Park wrote: > Please find the release at: > https://dist.apache.org/repos/dist/release/mesos/0.27.2 > > It is recommended to use a mirror to download the release: > http://www.apache.org/dyn/closer.cgi > > The CHANGELOG for the release is

Re: Backport r/44230 to 0.27 branch

On Wed, Mar 16, 2016 at 2:21 PM, Jie Yu wrote: > I understand your frustration. I am curious what review/ticket are you > talking about, and who is the shepherd for your review/ticket? Why not check your backlog for your answer? Or do you need me to write a script to scan

Re: Backport r/44230 to 0.27 branch

On Wed, Mar 16, 2016 at 2:50 PM, Jie Yu wrote: >> >> Why not check your backlog for your answer? Or do you need me to write >> a script to scan all the pending review requests for you? > > > OK, i just looked at your pending patches: >

Re: Backport r/44230 to 0.27 branch

On Tue, Mar 15, 2016 at 5:17 PM, Jie Yu wrote: > commit 5278e5cc50544ed7af28b15a1acd2b2e96a15a47 > Author: Jojy Varghese > Date: Tue Mar 15 17:12:01 2016 -0700 > > Added support for FTS_SLNONE in rmdir. > > Review:

Re: Upgrade to clang-format-3.8

On Fri, Mar 18, 2016 at 10:19 AM, Yong Tang wrote: > Hi James > > My understanding is that there are two epic associated. One is the > clang-format integration that formatting whitespaces, multiple lines, etc. > Another is the clang-tidy integration that helps

Backport r/44230 to 0.27 branch

Hi, all I don't know what is the process to request for a backport for Mesos stable releases and how Mesos community cares about stable releases. But... please consider to backport the following patch to at least 0.27 branch: https://reviews.apache.org/r/44230/ It fixes a bug in our production

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

need to change as well. - Cong Wang On April 1, 2015, 9:19 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744

Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332)

://reviews.apache.org/r/32660/#comment127115 libnl has an API for getting these stats, rtnl_tc_get_stat(). - Cong Wang On March 31, 2015, 11:23 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 32219: Change default htb leaf qdisc to fq_codel

--- Manually started a container and fq_codel qdisc was successfully created. Thanks, Cong Wang

Review Request 32219: Change default htb leaf qdisc to fq_codel

, Cong Wang

Re: Review Request 31503: Add classid to Filter

On March 12, 2015, 2:02 a.m., Jie Yu wrote: Cong, I addressed the comments for you and try to commit. Looks like rtnl_u32_get_classid is not in libnl-3.2.25. That means we need a newer version of libnl for this to work! Cong Wang wrote: I have addressed your comments locally

Re: Review Request 31503: Add classid to Filter

On March 12, 2015, 2:02 a.m., Jie Yu wrote: Cong, I addressed the comments for you and try to commit. Looks like rtnl_u32_get_classid is not in libnl-3.2.25. That means we need a newer version of libnl for this to work! Cong Wang wrote: I have addressed your comments locally

Re: Review Request 31503: Add classid to Filter

/#review76195 --- On March 10, 2015, 11:26 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503

Re: Review Request 31870: Added an interface to get all IP packet filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31870/#review75975 --- Ship it! Ship It! - Cong Wang On March 9, 2015, 8:54 p.m., Jie

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

aebc528b12e4afdf49367aa01926c05fa37da0e0 Diff: https://reviews.apache.org/r/31505/diff/ Testing --- Manually start two mesos containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31503: Add classid to Filter

://reviews.apache.org/r/31503/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31504: Add a basic filter to match all packets

/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31503: (2/5) Add the FlowId action

/queueing/handle.hpp 2725d07 src/tests/routing_tests.cpp 3cda6ab Diff: https://reviews.apache.org/r/31503/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31502: (1/5) Add fq_codel qdisc for egress

src/linux/routing/queueing/fq_codel.hpp PRE-CREATION src/linux/routing/queueing/fq_codel.cpp PRE-CREATION src/tests/routing_tests.cpp 3cda6ab Diff: https://reviews.apache.org/r/31502/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31504: (3/5) Add a basic filter to match all packets

/routing/filter/basic.hpp PRE-CREATION src/linux/routing/filter/basic.cpp PRE-CREATION src/linux/routing/filter/filter.hpp a603d73 src/tests/routing_tests.cpp 59af083 Diff: https://reviews.apache.org/r/31504/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31501: (4/5) Add flowid to IP classifier

/routing/filter/ip.cpp 9d8639b744e6f54cabaa9c866c02fec83dbcdbfa Diff: https://reviews.apache.org/r/31501/diff/ Testing --- Tested together with the whole patchset. Thanks, Cong Wang

Re: Review Request 31504: (3/5) Add a basic filter to match all packets

, 6:32 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31504/ --- (Updated March 9, 2015, 6:32 p.m.) Review

Re: Review Request 31504: (3/5) Add a basic filter to match all packets

src/linux/routing/filter/basic.cpp PRE-CREATION src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba Diff: https://reviews.apache.org/r/31504/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31505: (5/5) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review75738 --- On March 9, 2015, 6:57 p.m., Cong Wang wrote

Re: Review Request 31502: (1/5) Add fq_codel qdisc for egress

: https://reviews.apache.org/r/31502/#review75740 --- On March 9, 2015, 6:28 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31501: (4/5) Add flowid to IP classifier

. Diffs (updated) - src/linux/routing/filter/ip.hpp a9afeb8 src/linux/routing/filter/ip.cpp f04c0dc Diff: https://reviews.apache.org/r/31501/diff/ Testing --- Tested together with the whole patchset. Thanks, Cong Wang

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

--- On March 4, 2015, 8:18 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated March 4

Re: Review Request 31505: (5/5) Add flow classifiers for fq_codel on egress

://reviews.apache.org/r/31505/diff/ Testing --- Manually start two mesos containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31870: Added an interface to get all IP packet filters.

On March 9, 2015, 10:46 p.m., Cong Wang wrote: src/linux/routing/filter/ip.hpp, line 202 https://reviews.apache.org/r/31870/diff/1/?file=889627#file889627line202 Since what you expose is the generic Filter, this API should be in filter/filter.hpp instead of filter/ip.hpp, even

Re: Review Request 31870: Added an interface to get all IP packet filters.

/#comment123099 Since what you expose is the generic Filter, this API should be in filter/filter.hpp instead of filter/ip.hpp, even though we only read IP filters in my case. - Cong Wang On March 9, 2015, 8:54 p.m., Jie Yu wrote

Re: Review Request 31499: (3/6) Add protocol into Filter

to the generic layer. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31499/#review75408 --- On March 4, 2015, 8:10 p.m., Cong Wang

Re: Review Request 31503: (2/6) Add the FlowId action

--- On March 4, 2015, 8:06 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/ --- (Updated

Re: Review Request 31503: (2/6) Add the FlowId action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review75243 --- On March 4, 2015, 8:06 p.m., Cong Wang wrote

Re: Review Request 31503: (2/6) Add the FlowId action

://reviews.apache.org/r/31503/#review75386 --- On March 4, 2015, 8:06 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503

Re: Review Request 31503: (2/6) Add the FlowId action

it. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review75243 --- On March 4, 2015, 8:06 p.m., Cong Wang wrote

Re: Review Request 31504: (4/6) Add a basic filter to match all packets

-CREATION src/linux/routing/filter/basic.cpp PRE-CREATION src/linux/routing/filter/filter.hpp a603d73 src/tests/routing_tests.cpp 59af083 Diff: https://reviews.apache.org/r/31504/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

, 2015, 8:18 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated March 4, 2015, 8:18 p.m

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated March 4, 2015, 8:18 p.m.) Review request

Re: Review Request 31499: (3/6) Add protocol into Filter

TryNothing encodebasic::Classifier(...) { rtnl_cls_set_protocol(cls.get(), classifier.protocol()); ... } ``` Cong Wang wrote: Our goal is not just to make basic filter work for my case, as we discussed, arp filter will eventually (after this patchset) move on top

Re: Review Request 31503: (2/6) Add the FlowId action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review75386 --- On March 4, 2015, 8:06 p.m., Cong Wang wrote: --- This is an automatically

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

--- On March 4, 2015, 8:18 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505

Re: Review Request 31499: (3/6) Add protocol into Filter

TryNothing encodebasic::Classifier(...) { rtnl_cls_set_protocol(cls.get(), classifier.protocol()); ... } ``` Cong Wang wrote: Our goal is not just to make basic filter work for my case, as we discussed, arp filter will eventually (after this patchset) move on top

Re: Review Request 31502: (1/6) Add fq_codel qdisc for egress

src/linux/routing/queueing/fq_codel.hpp PRE-CREATION src/linux/routing/queueing/fq_codel.cpp PRE-CREATION src/tests/routing_tests.cpp 3cda6ab Diff: https://reviews.apache.org/r/31502/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31503: (2/6) Add the FlowId action

/queueing/handle.hpp 2725d07 src/tests/routing_tests.cpp 3cda6ab Diff: https://reviews.apache.org/r/31503/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Review Request 31499: (3/6) Add protocol into Filter

/routing/filter/filter.hpp a603d73 src/linux/routing/filter/icmp.cpp 86bd67b src/linux/routing/filter/internal.hpp 8a6c0c0 src/linux/routing/filter/ip.cpp 922a732 Diff: https://reviews.apache.org/r/31499/diff/ Testing --- Run test cases. Thanks, Cong Wang

Re: Review Request 31504: (4/6) Add a basic filter to match all packets

/ Testing --- Run the testcase. Thanks, Cong Wang

Review Request 31501: (5/6) Add flowid to IP classifier

/ Testing --- Tested together with the whole patchset. Thanks, Cong Wang

Re: Review Request 31505: (6/6) Add flow classifiers for fq_codel on egress

://reviews.apache.org/r/31505/diff/ Testing --- Manually start two mesos containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31501: (5/6) Add flowid to IP classifier

--- On March 4, 2015, 8:16 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31501

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

/diff/ Testing --- Manually start two mesos containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74859 --- On March 2, 2015, 5:21 p.m., Cong Wang wrote

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- On March 2, 2015, 5:21 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505

Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74806 --- On Feb. 27, 2015, 9:39 p.m., Cong Wang wrote: --- This is an automatically

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

/diff/ Testing --- Manually start two mesos containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31503: (2/4) Add the Classifier action

--- On Feb. 27, 2015, 9:39 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503

Re: Review Request 31503: (2/4) Add the Classifier action

--- On Feb. 27, 2015, 9:39 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503

Re: Review Request 31504: (3/4) Add the default filter to match all packets

src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 Diff: https://reviews.apache.org/r/31504/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

-space. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review74648 --- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74457 --- On March 2, 2015, 5:21 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

, 2015, 9:38 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/ --- (Updated Feb. 27, 2015, 9:38 p.m

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

--- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

--- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/ --- (Updated Feb

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated March 2, 2015, 5:21 p.m.) Review

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

. To reply, visit: https://reviews.apache.org/r/31505/#review74396 --- On March 2, 2015, 5:21 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review74774 --- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote: --- This is an automatically generated e

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

qdisc. Maybe use a handle that's more unlikely to be picked (e.g., Handle(0x1, 0x800)) for now and add a TODO saying that we may want to expose the handle in the interfaces and instead let the user choose the handle. Cong Wang wrote: Root qdisc handle has to be X:0, so we

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review74389 --- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

--- On Feb. 27, 2015, 9:38 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

containers with netperf running side. Thanks, Cong Wang

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

/fq_codel.cpp PRE-CREATION src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 Diff: https://reviews.apache.org/r/31502/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 31503: (2/4) Add the Classifier action

/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260 src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2 src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 Diff: https://reviews.apache.org/r/31503/diff/ Testing --- Run the testcase. Thanks, Cong

Review Request 31503: (2/4) Add the Classifier action

922a732c3543a072674208b123fdfadbef2b15f2 src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 Diff: https://reviews.apache.org/r/31503/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Review Request 31502: (1/4) Add fq_codel qdisc for egress

://reviews.apache.org/r/31502/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Review Request 31504: (3/4) Add the default filter to match all packets

/diff/ Testing --- Run the testcase. Thanks, Cong Wang

Re: Review Request 30958: PortMappingIsolator: Remove ingress qdiscs on eth0 and lo after the last container exists.

://reviews.apache.org/r/30958/#comment118396 Unless I am on a wrong tree, why do you create this ingress qdisc again since we already do it in create()? Even if we really need it, you don't mention in subject or changelog. - Cong Wang On Feb. 13, 2015, 12:48 a.m., Chi Zhang wrote

Re: Review Request 30958: PortMappingIsolator: Remove ingress qdiscs on eth0 and lo after the last container exists.

On Feb. 13, 2015, 2:14 a.m., Cong Wang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, line 1622 https://reviews.apache.org/r/30958/diff/1/?file=862684#file862684line1622 Unless I am on a wrong tree, why do you create this ingress qdisc again since we already

Re: Review Request 25948: Routing: added support to obtain basic socket diagnosis information, using the inet-diag module from libnl3.

is not as flexible as v2, this is probably why Chi still got both IPv4 and IPv6 connections even if he specifies AF_INET. Anyway, we can always filter the dump by ourself, so not a big deal. - Cong Wang On Sept. 23, 2014, 6:57 p.m., Chi Zhang wrote

Re: Review Request 25512: Made sure IPv6 is disabled for port mapping network isolator.

exists in child script too since you did outside? - Cong Wang On Sept. 10, 2014, 6:26 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25512

Re: Review Request 24719: Added document for network monitoring.

/#comment88598 The first kernel commits (routing) listed here are not strictly needed since the bug can be workaround and mesos code already did. - Cong Wang On Aug. 15, 2014, 12:13 a.m., Jie Yu wrote: --- This is an automatically

Re: Review Request 23701: Generate u32 filter handle in user level to work around MESOS-1617.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23701/#review48254 --- Ship it! Ship It! - Cong Wang On July 18, 2014, 11:57 p.m., Jie

Re: Review Request 21594: port-range based network isolator for Linux

://reviews.apache.org/r/21594/#comment77739 You need to use the MTU of eth0 instead of just 1500. - Cong Wang On May 17, 2014, 12:08 a.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 21594: port-range based network isolator for Linux

://reviews.apache.org/r/21594/#comment77435 You probably want to remove this debug option. - Cong Wang On May 17, 2014, 12:08 a.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 20347: Added API for getting the default gateway.

/#comment73397 We should use AF_INET here, so that kernel will select IPv4 routes for us, and we will not need to check the family in the loop below. - Cong Wang On April 15, 2014, 1:35 a.m., Jie Yu wrote: --- This is an automatically

  1   2   >