Re: [VOTE] Move Apache Mesos to Attic

2021-04-06 Thread Till Toenshoff
> On 5. Apr 2021, at 19:58, Vinod Kone wrote: > > Hi folks, > > Based on the recent conversations > > on our mailing list, it seems to me that the majority

Re: Next Steps

2021-02-18 Thread Till Toenshoff
+1 to what Renan (and Benjamin) suggested.

Re: Subject: [VOTE] Release Apache Mesos 1.11.0 (rc1)

2020-11-18 Thread Till Toenshoff
+1 Build using Apple clang version 12.0.0 (clang-1200.0.32.27) and ran on macOS 11.0.1 (20B29). > On 17. Nov 2020, at 15:53, Andrei Sekretenko wrote: > > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 1.11.0. > > 1.11.0 includes the following: >

Re: Mesos on ssl

2019-04-11 Thread Till Toenshoff
The “unknown bug in libevent” was in fact a bug in libprocess (our layer on top of libevent). See https://issues.apache.org/jira/browse/MESOS-9265 for more. Even though we do bundle libevent 2.0.22, we don’t need to - Mesos >= 1.8.0 is

Re: Shut down modules@mesos mailing list ?

2019-01-21 Thread Till Toenshoff
Agreed. > On 20. Jan 2019, at 23:34, sebb wrote: > > The modules@ mailing list looks as though it is not needed and should > be shut down. > > It has had very few postings - none in 2018. > > Agreed? > > Sebb.

Libevent bundling ahead.

2018-09-11 Thread Till Toenshoff
Hey All, We are considering bundling/vendoring libevent 2.0.22 with upcoming releases of Mesos. Let me explain the motivation and then go into some details. Due to https://issues.apache.org/jira/browse/MESOS-7076, SSL builds Mesos stopped functioning on distributions that offer libevent 2.1.8

Re: RFC: update C++ style to require the "override" keyword

2018-07-09 Thread Till Toenshoff
+1 — that feature as saved us from nasty issues already when working on internal modules. > On Jul 9, 2018, at 8:43 AM, Zhitao Li wrote: > > +1 > > On Sun, Jul 8, 2018 at 10:55 PM Benjamin Bannier < > benjamin.bann...@mesosphere.io> wrote: > >> Hi James, >> >>> I’d like to propose that we

Shall we move SASL based CRAM-MD5 authentication out of libmesos?

2018-07-01 Thread Till Toenshoff
Dear fellow Apache Mesos developers, as you know, Apache Mesos supports authentication on various levels - among those is the RPC-style authentication allowing frameworks and agents to authenticate against the master. Even though this authentication interface has been modularized a long time

Re: [Proposal] Use jemalloc as default memory allocator for Mesos

2017-08-30 Thread Till Toenshoff
Ow, I forgot my actual vote :) +1 for using jemalloc +1 for making it non bundled +1 for using it by default if the configuration phase locates it > On Aug 25, 2017, at 3:28 PM, Benno Evers wrote: > > Hi Jeff, > > from looking around on the internet, it seems like

Re: [Proposal] Use jemalloc as default memory allocator for Mesos

2017-08-30 Thread Till Toenshoff
It appears that jemalloc does support Windows (64bit) See: https://github.com/jemalloc/jemalloc/blob/dev/msvc/ReadMe.txt tcmalloc on the other hand appears to only offer a minimal variant on Windows. See:

Re: [VOTE] Release Apache Mesos 1.1.3 (rc2)

2017-08-30 Thread Till Toenshoff
+1 Tested on internal CI as well as on macOS 10.12 and macOS 10.13 DP 8 using Apple’s clang (Xcode 8.3.3 and Xcode 9.0.0 beta 6). > On Aug 27, 2017, at 8:33 PM, Vinod Kone wrote: > > +1 (binding) > > Tested on ASF CI. The only red build was the known perf core dump

Re: Dropping support for Apple Clang

2017-08-10 Thread Till Toenshoff
Which version of Apple’s clang did you try for C++14? The latest version available is Apple LLVM version 9.0.0 (clang-900.0.22.8). > On Jul 29, 2017, at 2:38 AM, Michael Park wrote: > > I'd like to drop support for Apple Clang. > > With the C++14 upgrade, we'll be requiring

Re: [VOTE] Release Apache Mesos 1.1.2 (rc2)

2017-05-18 Thread Till Toenshoff
+1 Ran on internal CI. All failures I saw were well documented flaky tests. > On May 13, 2017, at 12:26 AM, Vinod Kone wrote: > > +1 (binding) > > Ran on ASF CI. The one configuration that is in "red" is due to a known flaky > issue with perf core dump during test

Re: [VOTE] Release Apache Mesos 1.1.2 (rc2)

2017-05-18 Thread Till Toenshoff
+1 Ran on internal CI. All failures I saw were well documented flaky tests. > On May 13, 2017, at 12:26 AM, Vinod Kone wrote: > > +1 (binding) > > Ran on ASF CI. The one configuration that is in "red" is due to a known > flaky issue with perf core dump during test suite

Re: [VOTE] Release Apache Mesos 1.2.1 (rc1)

2017-05-17 Thread Till Toenshoff
+1 Ran it through DC/OS builds and integration tests; https://github.com/dcos/dcos/pull/1530 => all green > On May 17, 2017, at 10:01 PM, Vinod Kone wrote: > > Ran it on ASF CI and saw some issues. > > Segfault in

Re: [VOTE] Release Apache Mesos 1.1.1 (rc2)

2017-03-07 Thread Till Toenshoff
+1 Tested on: - macOS 10.12.4 Beta (16E175b): ok - centos 6: mostly ok, MESOS-4736 - centos 7: internal CI issues on capabilities tests, otherwise fine - debian 8: mostly ok, MESOS-7213 - fedora 23: ok - ubuntu 12.04: mostly ok, MESOS-7218 - ubuntu 14.04: mostly ok, MESOS-7218 - ubuntu 16.04:

Re: [VOTE] Release Apache Mesos 1.1.1 (rc1)

2017-02-16 Thread Till Toenshoff
-1 for https://issues.apache.org/jira/browse/MESOS-7133 > On Feb 8, 2017, at 10:39 PM, Vinod Kone wrote: > > +1 (binding) > > Tested on ASF CI. > > Revision: 5d4c9962930c3f5c08e802caff40b670424cb091 >

Re: Hook Deprecation: slavePreLaunchDockerEnvironmentDecorator

2016-11-29 Thread Till Toenshoff
nst Mesos 1.1 will not work anymore with Mesos 1.2. > > On Tue, Nov 29, 2016 at 10:15 AM, Till Toenshoff <toensh...@me.com> wrote: > >> Hey Folks, >> >> we are removing the slave sided, docker specific hook callback ` >> slavePreLaunchDockerEnvironmentDecorator`

Re: [VOTE] Release Apache Mesos 1.0.2 (rc3)

2016-11-10 Thread Till Toenshoff
+1 Tested `make distcheck`: With SSL. MacOS 10.12.1 (16B2555) => OK With SSL and without. Centos 7 => OK Debian 8 => OK Fedora 23 => OK Ubuntu 14 => OK Ubuntu 12 => OK Ubuntu 15 => OK Ubuntu 16 => OK > On Nov 7, 2016, at 8:24 PM, Vinod Kone wrote: > > Hi all, > > >

[RESULT][VOTE] Release Apache Mesos 1.1.0 (rc3)

2016-11-10 Thread Till Toenshoff
Hi all, The vote for Mesos 1.1.0 (rc3) has passed with the following votes. +1 (Binding) -- Vinod Kone <vinodk...@apache.org> Alex Ruskletkow <a...@mesosphere.com> Till Toenshoff <toensh...@me.com> +1 (Non-binding) -

Re: [VOTE] Release Apache Mesos 1.1.0 (rc3)

2016-11-10 Thread Till Toenshoff
> Release/23/BUILDTOOL=autotools,COMPILER=clang,CONFIGURATION=--verbose, >>> ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A14.04, >>> label_exp=(docker%7C%7CHadoop)&&(!ubuntu-us1)/> >>> cmake >>> [image: Success] >>> <https://builds.apac

[VOTE] Release Apache Mesos 1.1.0 (rc3)

2016-11-04 Thread Till Toenshoff
Hi all, Please vote on releasing the following candidate as Apache Mesos 1.1.0. 1.1.0 includes the following: * [MESOS-2449] - **Experimental** support for launching a group of tasks via a new `LAUNCH_GROUP`

[VOTE] Release Apache Mesos 1.1.0 (rc2)

2016-10-31 Thread Till Toenshoff
Hi all, Please vote on releasing the following candidate as Apache Mesos 1.1.0. 1.1.0 includes the following: * [MESOS-2449] - **Experimental** support for launching a group of tasks via a new `LAUNCH_GROUP`

Re: [VOTE] Release Apache Mesos 1.1.0 (rc1)

2016-10-28 Thread Till Toenshoff
Quick update on RC2 - we are still waiting for one blocker - cut will follow the solution of MESOS-6497.

[VOTE] Release Apache Mesos 1.1.0 (rc1)

2016-10-18 Thread Till Toenshoff
Hi all, Please vote on releasing the following candidate as Apache Mesos 1.1.0. 1.1.0 includes the following: * [MESOS-2449] - **Experimental** support for launching a group of tasks via a new `LAUNCH_GROUP`

Re: 1.1.0 release

2016-10-14 Thread Till Toenshoff
as never been even called experimental. Joseph, is it time to do >> so? >> MESOS-898 CMake (never declared even experimental) Joseph >> >> Thanks in advance for cooperation, >> Till and AlexR >> >> On Fri, Oct 7, 2016 at 7:47 PM, Vinod Kone <vinodk

Re: A Plan for Mesos Community Syncs

2016-10-13 Thread Till Toenshoff
+1 - Thanks MPark! > On Oct 13, 2016, at 10:34 PM, Michael Park wrote: > > I would like to try to get the community syncs back on track. They have not > been organized well recently, and I would like to take ownership of being > the driver/host of the meetings. I think my

1.1.0 release

2016-10-07 Thread Till Toenshoff
Hi everyone! its us who will be the Release Managers for 1.1.0 - Alex and Till! We are planning to cut the next release (1.1.0) within three workdays - that would be Wednesday next week. So, if you have any patches that need to get into 1.1.0 make sure that either is already in the master

Re: I want to a contributor

2016-02-22 Thread Till Toenshoff
Hi Kreats, I have added you to the list of contributors in our JIRA - welcome to Mesos! best, Till > On Feb 22, 2016, at 10:05 AM, 周想想 wrote: > > Hi: > I’m a c++ programmer, and I want to be a contributor of mesos. > > Mesos is a great project, we have used

Re: are mesos package version names predictable?

2016-02-04 Thread Till Toenshoff
Hey Erik, those added values (e.g. “-0.2.190") come from Mesosphere's CI system which adds build-numbers (the last digit) and some more “noise" for those distribution packages. I will raise this issue internally and get back to you - hoping that we can get rid of these not so useful

Re: are mesos package version names predictable?

2016-02-04 Thread Till Toenshoff
For > reference, the purpose of this is to allow the storm-on-mesos project's > Dockerfile to have a configurable mesos version. > > - https://github.com/mesos/storm/pull/91 > > - Erik > > On Thu, Feb 4, 2016 at 1:51 PM, Till Toenshoff <toensh...@me.com> wrot

Re: [VOTE] Release Apache Mesos 0.27.0 (rc2)

2016-01-30 Thread Till Toenshoff
+1 Debian 8.2: configure && make check -> ok, sudo mesas-tests.sh -> two failures due to enabled swapping, one known flaky. configure —enable-ssl —enable-libevent && make check -> ok sudo mesas-tests.sh -> two failures due to enabled swapping, one known flaky, one more flaky test (now known as

[RESULT][VOTE] Release Apache Mesos 0.26.0 (rc5)

2015-12-16 Thread Till Toenshoff
Hi friends, The vote for Mesos 0.26.0 (rc5) has passed with the following votes. +1 (Binding) -- Joris Van Remoortere Brenden Matthews Benjamin Mahler Bernd Mathiske Till Toenshoff +1 (Non-binding) -- Alexander Rojas There were no 0

[VOTE] Release Apache Mesos 0.26.0 (rc5)

2015-12-10 Thread Till Toenshoff
Hi friends, we did unfortunately, once again run into an issue that needed immediate attention (see vote on rc4), hence we have to ask for another round of testing and voting of this newest release-candidate. The issue leading to this new release candidate was

Re: Can anyone help me understand the Mesos release model

2015-12-09 Thread Till Toenshoff
Alexander actually it spot on with his explanation. For the entire procedure, have a look at https://github.com/apache/mesos/blob/master/docs/release-guide.md . At some point in a release, we do a cut and that is our first

[VOTE] Release Apache Mesos 0.26.0 (rc4)

2015-12-07 Thread Till Toenshoff
Hi friends, we had noticed some discrepancies between the V0 API and the V1 API, hence we had to create a new release candidate even after the voting of 0.26.0-rc3 had officially ended. Sorry for that! Please vote on releasing the following candidate as Apache Mesos 0.26.0. The CHANGELOG for

[VOTE] Release Apache Mesos 0.26.0 (rc3)

2015-12-01 Thread Till Toenshoff
Hi friends, Please vote on releasing the following candidate as Apache Mesos 0.26.0. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.26.0-rc3

Re: can anyone shepherd MESOS-3725

2015-11-26 Thread Till Toenshoff
Done - sry for not noting your request any earlier. > On Nov 19, 2015, at 1:46 AM, James Peach wrote: > > Hi all, > > Can anyone shepherd https://issues.apache.org/jira/browse/MESOS-3725? > > thanks! > >

[VOTE] Release Apache Mesos 0.26.0 (rc1)

2015-11-13 Thread Till Toenshoff
Hi friends, Please vote on releasing the following candidate as Apache Mesos 0.26.0. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.26.0-rc1

Re: Add JIRA ticket# to `TODO`s in comments

2015-11-09 Thread Till Toenshoff
+1 in general for this proposal. Using JIRA for tracking TODO’s is great, especially for things like deprecation over/at releases. I am however unsure if *all* TODOs need to have a ticket assigned, so that is a detail we may want to discuss as well? > On Nov 9, 2015, at 9:55 AM, Alex Clemmer

Welcome Kapil as Mesos committer and PMC member!

2015-11-05 Thread Till Toenshoff
I'm happy to announce that Kapil Arya has been voted a Mesos committer and PMC member! Welcome Kapil, and thanks for all of your great contributions to the project so far! Looking forward to lots more of your contributions! Thanks Till

Re: Towards Mesos release 0.26.0

2015-11-05 Thread Till Toenshoff
As announced, we will be cutting the next release tomorrow, 6th of November. We currently have 130 blockers (as shown at https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12327111 ). If you have any

Re: Volunteer for next release

2015-10-01 Thread Till Toenshoff
That is awesome Joris - thanks a bunch :) > On Oct 1, 2015, at 6:05 PM, Joris Van Remoortere <jo...@mesosphere.io> wrote: > > +1 I can help triage with you :-) > > On Thu, Oct 1, 2015 at 1:44 AM, Till Toenshoff <toensh...@me.com> wrote: > >> Hi folks, >&g

Volunteer for next release

2015-10-01 Thread Till Toenshoff
Hi folks, Bernd and I would like to volunteer for managing the next release 0.26. The scope and ETA of 0.26 will be discussed today at the Mesos community sync - hence more details on this will follow shortly. Thanks, Bernd and Till

Re: Would like to be added as a contributor

2015-08-16 Thread Till Toenshoff
Hey Yong, added you as a contributor. Till On Aug 16, 2015, at 7:53 AM, Yong Feng fengyong...@gmail.com wrote: Forget to mention, my JIRA ID is luckyfengyong Thanks, Yong On Sat, Aug 15, 2015 at 10:25 AM, Yong Feng fengyong...@gmail.com wrote: Hi Team, I would like to be

Re: Request to be added to contributors list

2015-06-25 Thread Till Toenshoff
Hey Chen, I have added you as a contributor to our JIRA roles, you should be able to assign issues to yourself now. Till On Jun 25, 2015, at 7:58 AM, zhiwei zhiw...@gmail.com wrote: Hi, I had created an issue and want to assign to myself, can anyone help adding me to the contributors

Re: Style guide for std::move

2015-06-17 Thread Till Toenshoff
+1 for 1. “treat it like a deleted pointer” On Jun 12, 2015, at 4:21 PM, Alexander Rojas alexan...@mesosphere.io wrote: Hey guys, there have been questions on how to deal with std::move in the code. Right now our style guide says nothing about it, but there is no consensus in the

Re: Mesos Jira workflow

2015-06-10 Thread Till Toenshoff
Very helpful Marco… I like the idea of tightening our JIRA workflow. +1 removing “closed +1 “reviewable” back to in progress — to me this is a very helpful signal for longer lasting comment addressing +1 making sure that “accepted is the gatekeeper and includes assigning the maintainer as a

Re: [DISCUSS] Renaming Mesos Slave

2015-06-04 Thread Till Toenshoff
1. Mesos Worker [node/host/machine] 2. Mesos Worker [process] 3. No, master/worker seems to address the issue with less changes. 4. Begin using the new name ASAP, add a disambiguation to the docs, and change old references over time. Fixing the official name, even before changes are in

Re: Let mesos to run on arm64 servers

2015-06-01 Thread Till Toenshoff
Hey Robin, thanks for your patches, we definitely are interested in getting Mesos fully running on the ARM platform - so your work is highly welcome. In a long run, we are hoping to entirely get rid of bundling those dependencies with Mesos. One question that popped up immediately; did you

Re: Please add me to jira

2015-05-26 Thread Till Toenshoff
I have added you to the list of Mesos contributors - you should now be able to assign the ticket in question to yourself. On May 25, 2015, at 5:54 AM, baotiao baot...@gmail.com wrote: Hi guys I would like to solve the issue 2588, I have commented in the issue, so could you add me to

Re: Review Request 33058: Updated test-frameworks to support principal only credential.

2015-04-19 Thread Till Toenshoff
a179df5 src/examples/test_framework.cpp 9f4b53e Diff: https://reviews.apache.org/r/33058/diff/ Testing --- make check + functional testing using custom authentication modules not relying on a shared secrets. Thanks, Till Toenshoff

Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.

2015-04-17 Thread Till Toenshoff
://reviews.apache.org/r/33257/#comment130629 s/docker/the docker/ - Till Toenshoff On April 17, 2015, 7:07 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257

Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.

2015-04-17 Thread Till Toenshoff
On April 18, 2015, 2:55 a.m., Till Toenshoff wrote: One more tiny nit, the summary has a typo. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/#review80576

Review Request 33331: Added file headers section to the C++ style guide.

2015-04-17 Thread Till Toenshoff
--- see summary. Diffs - docs/mesos-c++-style-guide.md de1b93e Diff: https://reviews.apache.org/r/1/diff/ Testing --- N/A Thanks, Till Toenshoff

Review Request 33330: Fixed C++ style guide formatting.

2015-04-17 Thread Till Toenshoff
--- Enables syntax highlighting in markdown viewers. Diffs - docs/mesos-c++-style-guide.md de1b93e Diff: https://reviews.apache.org/r/0/diff/ Testing --- N/A Thanks, Till Toenshoff

Re: Review Request 33331: Added file headers section to the C++ style guide.

2015-04-17 Thread Till Toenshoff
: mesos-incubating Description --- see summary. Diffs - docs/mesos-c++-style-guide.md de1b93e Diff: https://reviews.apache.org/r/1/diff/ Testing --- N/A Thanks, Till Toenshoff

Re: Review Request 32058: Added protobuf-JSON validation

2015-04-16 Thread Till Toenshoff
https://reviews.apache.org/r/32058/#comment130182 Just as Vinod commented on the JIRA, we might want to do that differently - e.g. by adding a factory. - Till Toenshoff On March 16, 2015, 8:02 p.m., Akanksha Agrawal wrote

Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.

2015-04-16 Thread Till Toenshoff
you need it. - Till Toenshoff On April 16, 2015, 7:10 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-14 Thread Till Toenshoff
check Thanks, Till Toenshoff

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-14 Thread Till Toenshoff
. To reply, visit: https://reviews.apache.org/r/32850/#review80082 --- On April 14, 2015, 2:20 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-14 Thread Till Toenshoff
--- make check Thanks, Till Toenshoff

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-14 Thread Till Toenshoff
--- On April 15, 2015, 12:44 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-14 Thread Till Toenshoff
--- On April 15, 2015, 12:44 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-04-14 Thread Till Toenshoff
(updated) --- make distcheck (with and without CRAM-MD5 installed, Linux OSX) Thanks, Till Toenshoff

Re: Review Request 32536: Updated variable naming style.

2015-04-14 Thread Till Toenshoff
and helpful. - Till Toenshoff On March 26, 2015, 4:10 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32536

Re: Review Request 32001: Required a period in trailing comments in the style guide.

2015-04-14 Thread Till Toenshoff
/#comment129761 I actually think that MPark's draft fits very well. My suggestion would be: End each sentence within a comment with punctuation - this applies to incomplete sentences as well. Please note that we generally prefer periods. - Till Toenshoff On March 26, 2015, 1:08

Re: Review Request 32749: Add -Wno-unused-local-typedef for clang 3.6

2015-04-13 Thread Till Toenshoff
/#comment129646 This is a bit unusual. We haven't marked our branches that way so far but I kinda like it. - Till Toenshoff On April 13, 2015, 9:01 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 32748: libprocess: Add -Wno-unused-local-typedef for clang 3.6

2015-04-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32748/#review79956 --- Ship it! Ship It! - Till Toenshoff On April 13, 2015, 9:01 p.m

Re: Review Request 32747: libprocess: Place noreturn attribute correctly for C11

2015-04-13 Thread Till Toenshoff
are targetting libev specifically with this patch. - Till Toenshoff On April 13, 2015, 9:01 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32747

Re: Review Request 32995: Split up documentation for reporting bugs and submitting patches.

2015-04-09 Thread Till Toenshoff
/#comment128919 ...please review the Assign the JIRA issue to yourself before you start working on it. Not sure if this sentence makes any sense as is. - Till Toenshoff On April 9, 2015, 12:30 a.m., Ben Mahler wrote

Re: Review Request 32967: Cleaned upstyle and comments in modules.

2015-04-09 Thread Till Toenshoff
with org_apache_mesos_TestCpuIsolator as described by Kapil on the JIRA? My point here is that your other changes do not seem to add value or improve readablity. Same with the others as well, thanks! - Till Toenshoff On April 8, 2015, 8:05 p.m., Aditi Dixit wrote

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-09 Thread Till Toenshoff
://reviews.apache.org/r/32999/#comment128924 Should the link have a trailing slash as the others do? - Till Toenshoff On April 9, 2015, 12:30 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-03 Thread Till Toenshoff
/authentication/cram_md5/authenticatee.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32850/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-04-01 Thread Till Toenshoff
, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park, and Till Toenshoff. Bugs: mesos-708 https://issues.apache.org/jira/browse/mesos-708 Repository: mesos Description --- When serving a static file, libprocess returns the header `Last-Modified` which is used

Re: Review Request 31267: Added a test allocator module.

2015-04-01 Thread Till Toenshoff
to @tillt. Pass by pointer was introduced in Commit: 7ee3b7b672a4d8fee4fe4eb5f0aa2e7e3bf6b049 Review: https://reviews.apache.org/r/31253 Author: Till Toenshoff toensh...@me.com We generally avoid references when mutating on the callee side - that is a style descision which came from

Re: Review Request 31267: Added a test allocator module.

2015-04-01 Thread Till Toenshoff
to @tillt. Pass by pointer was introduced in Commit: 7ee3b7b672a4d8fee4fe4eb5f0aa2e7e3bf6b049 Review: https://reviews.apache.org/r/31253 Author: Till Toenshoff toensh...@me.com Till Toenshoff wrote: We generally avoid references when mutating on the callee side - that is a style

Re: Review Request 31267: Added a test allocator module.

2015-04-01 Thread Till Toenshoff
/#comment127331 Much better than the old variant - thanks for pointing this out! - Till Toenshoff On March 27, 2015, 4:26 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31268: Wired up test allocator to allocator tests.

2015-04-01 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review78512 --- Ship it! Ship It! - Till Toenshoff On March 27, 2015, 4:27 p.m

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-27 Thread Till Toenshoff
/cram_md5_authentication_tests.cpp 92a89c5 Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-27 Thread Till Toenshoff
/tests/cram_md5_authentication_tests.cpp 92a89c5 Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-27 Thread Till Toenshoff
On March 27, 2015, 10:46 p.m., Adam B wrote: Fix looks good to me. Buildbot, please take another look. ;) Vinod Kone wrote: Can you or @till let me know what the race and temporal issue here was? And how this fixes it? Till Toenshoff wrote: There was one major problem

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/#review77721 --- Ship it! Ship It! - Till Toenshoff On March 9, 2015, 11:09 a.m

Re: [VOTE] Release Apache Mesos 0.22.0 (rc4)

2015-03-25 Thread Till Toenshoff
+1 binding - make check tested on: - OSX 10.10.3 + gcc 4.9.2 - OSX 10.10.3 + clang 3.5 - Ubuntu 14.04 + gcc 4.4.7 On Mar 18, 2015, at 8:52 PM, Niklas Nielsen nik...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.22.0. 0.22.0

Re: Review Request 32105: Added operator to stout.flags.

2015-03-25 Thread Till Toenshoff
On March 25, 2015, 3:30 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 592-600 https://reviews.apache.org/r/32105/diff/4/?file=897000#file897000line592 How about breaking this up in order to avoid the ad-hoc `join` code?

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-25 Thread Till Toenshoff
/authentication/cram_md5/auxprop.hpp b894386 src/master/master.hpp 3c957ab src/master/master.cpp dccd7c6 src/tests/cram_md5_authentication_tests.cpp 92a89c5 Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 32105: Added operator to stout.flags.

2015-03-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77723 --- Ship it! Ship It! - Till Toenshoff On March 17, 2015, 12:25 a.m

Re: Review Request 30931: Added flags to logs at master and slave startup.

2015-03-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review77724 --- Ship it! Ship It! - Till Toenshoff On March 16, 2015, 3:20 p.m

Re: Review Request 32198: Added a not equal operator for json objects.

2015-03-25 Thread Till Toenshoff
On March 18, 2015, 5:36 p.m., Till Toenshoff wrote: 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, lines 252-263 https://reviews.apache.org/r/32198/diff/1/?file=898923#file898923line252 Right now, these tests appear a bit random to me. Can you explain the idea on why

Re: Review Request 32198: Added a not equal operator for json objects.

2015-03-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198/#review77726 --- Ship it! Ship It! - Till Toenshoff On March 23, 2015, 2:19 p.m

Re: Review Request 32403: Fixed Alloc/Dealloc mismatch in OsSendfileTest.sendfile.

2015-03-25 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32403/#review77722 --- Ship it! Ship It! - Till Toenshoff On March 23, 2015, 6:03 p.m

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-22 Thread Till Toenshoff
On March 11, 2015, 9:42 p.m., Vinod Kone wrote: src/master/master.cpp, lines 3858-3861 https://reviews.apache.org/r/27760/diff/23/?file=890575#file890575line3858 Send a FrameworkError message (instead of AuthenticationError) here to avoid retries? Till Toenshoff wrote

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-20 Thread Till Toenshoff
/#review76642 --- On March 12, 2015, 12:32 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-20 Thread Till Toenshoff
/cram_md5_authentication_tests.cpp 92a89c5 Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 32198: Added a not equal operator for json objects.

2015-03-18 Thread Till Toenshoff
nested variants? - Till Toenshoff On March 18, 2015, 10:46 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198

Re: Review Request 31539: Remove the checkpoint variable entirely from slave/flags.hpp.

2015-03-16 Thread Till Toenshoff
Maloney, and Till Toenshoff. Bugs: MESOS-2375 https://issues.apache.org/jira/browse/MESOS-2375 Repository: mesos Description --- As a number of tests rely on the checkpointing flag to be false, a few tests had to be adapted. Removed the following test as the tested logic

Re: Review Request 32034: Fixed unused comparisons on the == operator for TaskStatus.

2015-03-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32034/#review76350 --- Ship it! Ship It! - Till Toenshoff On March 13, 2015, 10:56 a.m

Review Request 31960: Added concurrency protection within the SASL auxprop plugin code.

2015-03-11 Thread Till Toenshoff
check Thanks, Till Toenshoff

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-11 Thread Till Toenshoff
/master/master.cpp dccd7c6 src/tests/cram_md5_authentication_tests.cpp 92a89c5 Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

2015-03-11 Thread Till Toenshoff
/cram_md5_authentication_tests.cpp 92a89c5 Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff

  1   2   3   4   5   6   7   8   >