Re: Getting write access to our GitHub repo

Filed: https://issues.apache.org/jira/browse/INFRA-16832 On Mon, Jul 23, 2018 at 6:11 PM Vinod Kone wrote: > Hi Benjamin, > > The main reason for moving to gitbox is to better avail GitHub integration > (i.e., closing stale PRs, directly merge from GH if wanted, lower barrier > for entry for

Re: Getting write access to our GitHub repo

Hi Benjamin, The main reason for moving to gitbox is to better avail GitHub integration (i.e., closing stale PRs, directly merge from GH if wanted, lower barrier for entry for newbies to contribute, better integration with CI etc). AFAICT, this will necessitate us having write access to our GH

Re: Getting write access to our GitHub repo

Hi Vinod, We (Jie, James, me) briefly discussed this topic and some implication over slack: * I mentioned I was surprised how a vote on _moving the project repo to ASF gitbox_ turned into _moving the project repo to Github_. * Jie mentioned that this would simplify (enable?) how we could close

Re: Getting write access to our GitHub repo

> > 1) Merge strategy on GH. I think we want to use the "rebase and merge > merges/#rebase-and-merge-your-pull-request-commits>" > strategy only (i.e., disable other strategies) to avoid merge commits. This > will be in parity with our RB

Re: Getting write access to our GitHub repo

Few things we need to finalize before the gitbox move. 1) Merge strategy on GH. I think we want to use the "rebase and merge " strategy only (i.e., disable other strategies) to avoid merge

Re: Getting write access to our GitHub repo

Vinod, can you start a VOTE thread per our discussion during the committer's meeting. On Sun, Jul 15, 2018 at 1:34 AM, Gastón Kleiman wrote: > On Wed, Jun 20, 2018 at 7:59 PM Vinod Kone wrote: > > > Hi folks, > > > > Looks like ASF now supports giving write > >

Re: Getting write access to our GitHub repo

On Wed, Jun 20, 2018 at 7:59 PM Vinod Kone wrote: > Hi folks, > > Looks like ASF now supports giving write > access to committers for their GitHub mirrors, which means we can merge PRs > directly on GitHub! > +1. Not only does it allow to merge PRs directly on

Re: Getting write access to our GitHub repo

That’s right. Reviewboard will still be supported after the move. Just makes GH side if things better. Thanks, Vinod > On Jun 23, 2018, at 4:48 AM, Chun-Hung Hsiao wrote: > > I also find GitHub hard to do code review. If we put multiple commits in a > PR where each commit has a specific

Re: Getting write access to our GitHub repo

IIUC this wouldn't necessarily rule out RB reviews just better support for Github PRs? On Fri, Jun 22, 2018 at 9:13 PM Andrew Schwartzmeyer < and...@schwartzmeyer.com> wrote: > GitHub PR code reviews have gotten _significantly_ better over the last > two years. You can actually open addressable

Re: Getting write access to our GitHub repo

GitHub PR code reviews have gotten _significantly_ better over the last two years. You can actually open addressable issues now (like ReviewBoard), and assign reviewers, and "officially" mark it as signed-off (ship-it) too. They used to suck so bad that I preferred inline email comments to

Re: Getting write access to our GitHub repo

> On Jun 22, 2018, at 7:34 PM, Jie Yu wrote: > > +1 > > Does this means we can add CI webhooks to the git repo? FWIW, I'm hugely -1 on doing code reviews on GitHub. I'm cautiously optimistic about other kinds of integration though. > On Thu, Jun 21, 2018 at 3:45 PM, James Peach wrote: >

Re: Getting write access to our GitHub repo

+1 Does this means we can add CI webhooks to the git repo? On Thu, Jun 21, 2018 at 3:45 PM, James Peach wrote: > > > > On Jun 20, 2018, at 7:58 PM, Vinod Kone wrote: > > > > Hi folks, > > > > Looks like ASF now supports giving write > > access to committers for

Re: Getting write access to our GitHub repo

> On Jun 20, 2018, at 7:58 PM, Vinod Kone wrote: > > Hi folks, > > Looks like ASF now supports giving write > access to committers for their GitHub mirrors, which means we can merge PRs > directly on GitHub! Are you proposing that we move to Github generally? >

Re: Getting write access to our GitHub repo

This could mean PRs that require CI to pass before check-ins! This would be fantastic... +1 On 06/20/2018 8:27 pm, Kapil Arya wrote: +1. On Wed, Jun 20, 2018 at 10:59 PM Vinod Kone wrote: Hi folks, Looks like ASF now supports giving write access to

Re: Getting write access to our GitHub repo

+1. On Wed, Jun 20, 2018 at 10:59 PM Vinod Kone wrote: > Hi folks, > > Looks like ASF now supports giving write > access to committers for their GitHub mirrors, which means we can merge PRs > directly on GitHub! > > FWICT, this requires us moving our repo to a new