Re: Replacing ad hoc virtualenvs for testing and linting with tox

> > I was just slightly worried because with every little thing that we add to > the list of requirements for submitting a patch we will lose a small > fraction of potential contributors, and wanted to make sure that this > decisions was weighted against this. Agreed. In that case I believe the

Re: Replacing ad hoc virtualenvs for testing and linting with tox

Hi Eric, you know more about the requirements of the CLI build and the python environment than me, so if you think this is the best way forward I have no objections. I was just slightly worried because with every little thing that we add to the list of requirements for submitting a patch we will

Re: Replacing ad hoc virtualenvs for testing and linting with tox

For the Apache Aurora project we solved the need for a virtualenv by using a wrapper-script that will bootstrap a virtualenv on demand. It only requires Python to be installed but no other packages. It works flawlessly on Mac and Linux. Maybe this idea is also useful for Mesos. Virtualenv

Re: Replacing ad hoc virtualenvs for testing and linting with tox

Hi Eric, Do I understand correctly that you want to require all developers to install tox so that it can be called from a post-commit hook to create a virtualenv in which it will then install pylint with all its dependencies and use that to lint the changed python files? Would it be possible to

Re: Replacing ad hoc virtualenvs for testing and linting with tox

Having distributed tox.ini files and being able to run tests for multiple environments will be helpful to develop the new Mesos CLI thus I support this change. Requiring developers to install tox is indeed the biggest concern with this change; however, this process should be straightforward as it

Re: Replacing ad hoc virtualenvs for testing and linting with tox

Tox works pretty well cross platform in dcos, so long as one uses python3 and the standard venv rather than pyenv. From: Benjamin Mahler Sent: Monday, January 8, 2018 7:03 PM To: dev Cc: Armand Grillet; Benno Evers; Kevin Klues Subject: Re:

Re: Replacing ad hoc virtualenvs for testing and linting with tox

+armand, benno, kevin On Fri, Jan 5, 2018 at 12:04 PM, Eric Chung wrote: > Hello mesos devs, > > I'd like to propose that we replace some of our bash scripts for building > ad hoc virtualenvs with tox , a > tool > for automating lifecycle

Replacing ad hoc virtualenvs for testing and linting with tox

Hello mesos devs, I'd like to propose that we replace some of our bash scripts for building ad hoc virtualenvs with tox , a tool for automating lifecycle management of virtualenvs using declarative configuration files. Specifically, virtualenvs created for