Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/ --- (Updated Nov. 6, 2014, 7:13 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review60162 --- Seems this one got stuck for a while now. The reasons appear to be f

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review57910 --- Patch looks great! Reviews applied: [26476] All tests passed. - M

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/ --- (Updated Oct. 22, 2014, 7:34 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 26476: Remove dynamic allocation from Option.

> On Oct. 16, 2014, 12:23 a.m., Ben Mahler wrote: > > A few higher level questions: > > > > (1) What motivated this? Concretely, which performance aspect of Mesos is > > this improving? In the past, we eliminated copies of our > > Option,Try,Future,Result family because we found that the copyi

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review56876 --- Patch looks great! Reviews applied: [26476] All tests passed. - M

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review56846 --- A few higher level questions: (1) What motivated this? Concretely,

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/ --- (Updated Oct. 15, 2014, 9:29 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review56798 --- High-level: LGTM Have a couple of nits and we should be good to go.

Re: Review Request 26476: Remove dynamic allocation from Option.

> On Oct. 9, 2014, 2:05 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 131 > > > > > > std::unique_ptr would also be an option as it can be moved on Option > > copy. W

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review55977 --- 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp

Re: Review Request 26476: Remove dynamic allocation from Option.

> On Oct. 9, 2014, 4:41 a.m., Jie Yu wrote: > > Flying by. You may wanna take a look at: > > https://github.com/facebook/folly/blob/master/folly/Optional.h > > > > Not sure if we can use unstricted union? Does g++44 supports that? According to https://gcc.gnu.org/projects/cxx0x.html unrestricte

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review55951 --- Flying by. You may wanna take a look at: https://github.com/facebook

Re: Review Request 26476: Remove dynamic allocation from Option.

> On Oct. 9, 2014, 3:45 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 131 > > > > > > This makes Option arbitrarily large which could be problematic where we > > copy

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review55945 --- 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp

Re: Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review55944 --- Patch looks great! Reviews applied: [26476] All tests passed. - M

Review Request 26476: Remove dynamic allocation from Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: meso