Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/ --- (Updated Feb. 25, 2015, 5:53 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

On Feb. 25, 2015, 6:43 p.m., Ben Mahler wrote: include/mesos/resources.hpp, lines 107-108 https://reviews.apache.org/r/30850/diff/3/?file=875892#file875892line107 Checkpointing seems like a mesos implementation detail, any reason you want it in resources.hpp? What about creating

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review74044 --- Ship it! include/mesos/resources.hpp

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/ --- (Updated Feb. 25, 2015, 8:48 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

On Feb. 12, 2015, 10:14 a.m., Michael Park wrote: src/slave/slave.cpp, lines 3520-3551 https://reviews.apache.org/r/30850/diff/2/?file=860896#file860896line3520 We have pretty much the same code in `master.hpp:766-785` with `totalResources` and `checkpointedResources` involved.

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review72127 --- src/slave/slave.cpp

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/ --- (Updated Feb. 11, 2015, 6:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/ --- (Updated Feb. 11, 2015, 6:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

On Feb. 11, 2015, 2:16 a.m., Ben Mahler wrote: src/slave/slave.cpp, lines 3537-3541 https://reviews.apache.org/r/30850/diff/1/?file=860552#file860552line3537 Is this stringify going to capture all of the disk information or do you want a JSON representation? Jie Yu wrote:

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review71895 --- src/slave/slave.cpp

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review71914 --- Patch looks great! Reviews applied: [30812, 30850] All tests

Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/ --- (Updated Feb. 10, 2015, 11:10 p.m.) Review request for mesos, Ben Mahler,

Review Request 30850: Added validation for checkpointed resources during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.