Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-04-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review79424 --- Ship it! Looks good. Before we can commit this, can you please

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-04-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review78626 --- Patch looks great! Reviews applied: [31914, 31915] All tests

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-04-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/ --- (Updated April 1, 2015, 10:28 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-04-01 Thread Chi Zhang
On March 17, 2015, 6:53 p.m., Ian Downes wrote: src/slave/containerizer/isolators/cgroups/mem.cpp, line 441 https://reviews.apache.org/r/31915/diff/1/?file=890842#file890842line441 if this conditional on limitSwap? Do you want it more explicit? If swap is not used, option will be

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-03-17 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review76770 --- include/mesos/mesos.proto

Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-03-10 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/ --- Review request for mesos and Ian Downes. Bugs: mesos-2104