Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-14 Thread Kapil Arya
On April 11, 2015, 4:11 a.m., Adam B wrote: Did you ever (manually?) Test for upgrade path? Sorry for not replying earlier. I tested manually with 0.22.0 and HEAD. I tried combinations of old/new pairs of master, slave and test-framework. I also tried Niklas's upgrade script

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review79798 --- Ship it! Did you ever (manually?) Test for upgrade path? - Adam B

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review79142 --- src/slave/slave.cpp

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/ --- (Updated April 7, 2015, 12:59 p.m.) Review request for mesos, Adam B and

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-07 Thread Kapil Arya
On April 7, 2015, 4:06 a.m., Adam B wrote: src/slave/slave.cpp, line 1108 https://reviews.apache.org/r/32583/diff/4/?file=914631#file914631line1108 If we're always making the copy, should we just pass `frameworkInfo_` by value and force the copy at the call-site? Then there's no

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/ --- (Updated April 3, 2015, 10:05 a.m.) Review request for mesos, Adam B and

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review78704 --- src/messages/messages.proto

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review78494 --- Should mention in the Description (commit message) that the new

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/ --- (Updated April 1, 2015, 3:34 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/ --- (Updated March 31, 2015, 4:28 p.m.) Review request for mesos, Adam B and