---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24569/#review50282
---
ben, can you commit this?
- Vinod Kone
On Aug. 11, 2014, 6:45
/#comment88125
Why loop through all validators and offers when one of them returns error?
Short circuting as did earlier seems fine to me, though a bit verbose.
src/master/master.cpp
https://reviews.apache.org/r/24576/#comment88126
CHECK_SOME?
- Vinod Kone
On Aug. 11, 2014, 11:32
/#comment88127
#include vector
src/common/http.cpp
https://reviews.apache.org/r/24515/#comment88128
why kill the new line?
- Vinod Kone
On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
---
This is an automatically generated e
/#comment88138
update the comment.
src/tests/reconciliation_tests.cpp
https://reviews.apache.org/r/24516/#comment88141
update the comment.
- Vinod Kone
On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote
filed https://issues.apache.org/jira/browse/MESOS-1698
On Tue, Aug 12, 2014 at 10:43 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2331/changes
Changes:
[benjamin.hindman] Add
filed https://issues.apache.org/jira/browse/MESOS-1699
On Wed, Aug 13, 2014 at 1:34 AM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2310/changes
Changes:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24657/#review50474
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 13, 2014, 5:48 p.m., Jie
/#comment88289
Hmm. I think the order is important for argv right?
e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1.
- Vinod Kone
On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/#review50484
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 13, 2014, 6:40 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50492
---
can you rebase?
- Vinod Kone
On Aug. 13, 2014, 7:28 p.m
://reviews.apache.org/r/24628/#comment88320
s/#On/# On/
Also, can you expand on the comment? It's not clear to me why you including
stdio.h here. Is it just a dummy?
Also, where is gtest typically located on system installations?
- Vinod Kone
On Aug. 13, 2014, 2:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/#review50517
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 13, 2014, 9:55 p.m
?
- Vinod Kone
On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086
,
Vinod Kone
/browse/MESOS-1698
Repository: mesos-git
Description
---
See summary.
Diffs
-
3rdparty/libprocess/3rdparty/stout/tests/main.cpp
0f1e9cbb2b869a53b979f138d3a89015f2bfbf56
Diff: https://reviews.apache.org/r/24675/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/24675/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/24667/#comment88392
by its messages you mean master's or frameworks'? i guess the latter? i'm
still a bit unclear on what the recommendation is here. can you expand on the
comment?
- Vinod Kone
On Aug. 13, 2014, 9:10 p.m., Jiang Yan Xu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24678/#review50529
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 13, 2014, 11:45 p.m
On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
src/tests/slave_tests.cpp, line 1254
https://reviews.apache.org/r/22313/diff/24/?file=653349#file653349line1254
Why are you failing the promise here? Don't you want to set it to
Nothing and then make sure that task doesn't launch
:14:25.621443 60969 sched.cpp:139] Version: 0.20.0
I0814 01:14:25.628525 60986 sched.cpp:235] New master detected at
master@127.0.0.1:5050
I0814 01:14:25.628746 60986 sched.cpp:243] No credentials provided. Attempting
to register without authentication
Thanks,
Vinod Kone
Thanks to Jake Farrell, we now have an upgraded RB server (1.6.x to 2.0.x)!
Apart from the UI flourishes, the thing I'm excited about is that this
should fix our long standing problem of review updates obliterating
depends on field!
Thanks again Jake for the quick turn around. Really appreciate
On Aug. 14, 2014, 4:10 a.m., Vinod Kone wrote:
LGTM. Go ahead and commit it. Thanks Time for your patience.
Tim*
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50547
patience.
- Vinod Kone
On Aug. 14, 2014, 1:21 a.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/#review50549
---
Ship it!
Feel free to commit this.
- Vinod Kone
On Aug. 14
On Thu, Aug 14, 2014 at 9:40 AM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
configure: error: conditional WITH_BUNDLED_DISTRIBUTE was never defined.
Usually this means the macro was only invoked conditionally.
@tim: can you take a look?
On Thu, Aug 14, 2014 at 11:16 AM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
Checking 503 files using filter
so src worked on linux but not on osx? how's that possible?
- Vinod Kone
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714
committing.
- Vinod Kone
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714
://reviews.apache.org/r/24667/#comment88511
s/implicitly/implicit/
docs/framework-rate-limiting.md
https://reviews.apache.org/r/24667/#comment88513
s/temporarily/temporary/
- Vinod Kone
On Aug. 14, 2014, 10:16 p.m., Jiang Yan Xu wrote
/23414/#comment88515
Just testing the unbundling stuff locally, and came across an issue with
libev.
I think you missed updating the CPPFLAGS when using prefix installed libev.
Also, shouldn't we be doing a AC_CHECK_LIB for libev?
- Vinod Kone
On July 11, 2014, 4:16 p.m
https://reviews.apache.org/r/24719/#comment88529
s/this is/these are/
docs/network-monitoring.md
https://reviews.apache.org/r/24719/#comment88530
give a random executor_id, executor_name and source instead of
aurora/thermos :)
- Vinod Kone
On Aug. 15, 2014, 12:13 a.m., Jie Yu
On Aug. 15, 2014, 1:18 a.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, lines 80-86
https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line80
I think you also forgot to plumb this through the configure.ac at the
root of the repo, like you did for other deps
/20983/#comment88555
what about LDFLAGS?
3rdparty/libprocess/configure.ac
https://reviews.apache.org/r/20983/#comment88556
We also need to AC_CHECK_LIB for the lib here.
- Vinod Kone
On May 5, 2014, 7:13 p.m., Timothy St. Clair wrote
Description
---
See summary.
Diffs
-
3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634
Diff: https://reviews.apache.org/r/24733/diff/
Testing
---
configured with prefix installation of libev and http parser.
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50708
---
Ship it!
LGTM. I'll let Tim give it a look over.
- Vinod Kone
. Attempting
to register without authentication
Thanks,
Vinod Kone
AC_CHECK_TOOL
is checking below?
src/zookeeper/zookeeper.hpp
https://reviews.apache.org/r/24734/#comment88603
reorder.
- Vinod Kone
On Aug. 15, 2014, 5:19 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply
On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, line 111
https://reviews.apache.org/r/24734/diff/3/?file=661496#file661496line111
should this be --with-http_parser? _ between http and parser.
Timothy St. Clair wrote:
why?
$ sudo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24687/#review50678
---
On Aug. 15, 2014, 5:42 p.m., Vinod Kone wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50769
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2014, 6:58 p.m., Jie
/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea
src/tests/main.cpp 442be5109a941fc1db5b183c8e00add44e0cab68
Diff: https://reviews.apache.org/r/24753/diff/
Testing
---
make check
Thanks,
Vinod Kone
my bad..fixed.
On Sat, Aug 16, 2014 at 10:36 AM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2057/changes
Changes:
[vinodkone] Moved
'mesos::internal::logging::installSignalFailureHandler()' to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24780/#review50836
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2014, 2:47 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24783/#review50840
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2014, 4:51 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24784/#review50841
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2014, 4:52 a.m., Jie
make check succeed on Centos 5.5 but failed on Python framework on OSX
Mavericks.
environment details:
➜ mesos-0.20.0 gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr
--with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 5.1 (clang-503.0.40)
/#comment88824
How about?
Helper function to extract the given number of ports from the ports
resource.
src/common/resources.cpp
https://reviews.apache.org/r/24810/#comment88825
Can you add a test(s) for this?
- Vinod Kone
On Aug. 18, 2014, 6:49 p.m., Zuyu Zhang wrote
://reviews.apache.org/r/24825/#comment88828
How about we do this cleanup as part of
https://issues.apache.org/jira/browse/MESOS-1582 instead of doing it here?
- Vinod Kone
On Aug. 18, 2014, 11:40 p.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24840/#review50987
---
Ship it!
Thanks Nikita. I'll get this committed shortly.
- Vinod
+1
make check passes on OSX Mavericks and CentOS 5.5
On Mon, Aug 18, 2014 at 11:26 PM, Jie Yu yujie@gmail.com wrote:
Hi all,
Please vote on releasing the following candidate as Apache Mesos 0.20.0.
NOTE: 0.20.0-rc1 has a bug on Mac (MESOS-1713) which is fixed in
0.20.0-rc2.
On Aug. 21, 2014, 5:34 p.m., Jie Yu wrote:
3rdparty/libprocess/src/process.cpp, line 1633
https://reviews.apache.org/r/24939/diff/1/?file=666217#file666217line1633
Remove the space after inet_ntoa.
inet_ntoa(addr.sin_addr)
great. mind also adding this to failed to
Hey Bhuvan,
The ShutdownFramework ACL is an example of authN/authZ of HTTP endpoint
(/shutdown) from a user perspective. Depending on what HTTP endpoints you
are planning to auth we could conceivably add more ACLs or add a generic
HTTP endpoint ACL. Of course this still doesn't give you sessions,
://reviews.apache.org/r/25033/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25043/#review51456
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 25, 2014, 10:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24902/#review51459
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 20, 2014, 6:21 p.m., Jie
d0676c55e3bb30bcc8e32b27c091080ec58b0c81
Diff: https://reviews.apache.org/r/25033/diff/
Testing
---
make check
Thanks,
Vinod Kone
/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87
Diff: https://reviews.apache.org/r/25055/diff/
Testing
---
tested locally.
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25053/#review51490
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 26, 2014, 1:56 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24877/#review51488
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 26, 2014, 1:56 a.m., Ben
---
On Aug. 26, 2014, 2:49 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25055
---
make check
Thanks,
Vinod Kone
,
Vinod Kone
32a24564ff460a9bc0d11bc02b7a5b29f599c57b
Diff: https://reviews.apache.org/r/25129/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/25169/#comment90470
Can we print the supported versions here. I think that will be helpful for
users.
configure.ac
https://reviews.apache.org/r/25169/#comment90471
can you rephrase this statement because there is no with-cxx11 arg anymore?
- Vinod Kone
On Aug. 28, 2014, 10:40
On Aug. 28, 2014, 11:30 p.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, line 518
https://reviews.apache.org/r/25169/diff/1/?file=671777#file671777line518
Can we print the supported versions here. I think that will be helpful
for users.
nm. i think we are getting away
://reviews.apache.org/r/25207/#comment90630
rephrase the comment.
src/master/hierarchical_allocator_process.hpp
https://reviews.apache.org/r/25207/#comment90631
revert to previous semantics here.
- Vinod Kone
On Aug. 29, 2014, 11:33 p.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/#review52046
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 2, 2014, 5:04 p.m., Jie
to that effect and log a warning? The reason we are doing a TODO and
warning instead of fixing ResourceUsageChecker is to give frameworks (e.g.,
Spark) time to update their code to adhere to these new semantics. We will
enforce this in the next release. Sounds good?
- Vinod Kone
On Sept. 2, 2014, 5:52 p.m
what is the error?
On Tue, Sep 2, 2014 at 12:00 PM, Tim St Clair tstcl...@redhat.com wrote:
Has something changed with review-board?
I'm not able to mark as submitted.
--
Cheers,
Timothy St. Clair
Red Hat Inc.
? vagrant?
docs/getting-started.md
https://reviews.apache.org/r/25272/#comment90818
end with period.
docs/getting-started.md
https://reviews.apache.org/r/25272/#comment90819
Is there no rpm for maven that one can install via yum?
- Vinod Kone
On Sept. 2, 2014, 8:58 p.m., Thomas
On Sept. 2, 2014, 9:05 p.m., Vinod Kone wrote:
im assuming you tested this on a stock centos6.5 box? vagrant?
Thomas Rampelberg wrote:
Yup, stock centos6.5 (base GCE image).
cool. committed this with a minor fix (s/Centos/CentOS/).
- Vinod
On Sept. 2, 2014, 5:53 p.m., Vinod Kone wrote:
src/master/hierarchical_allocator_process.hpp, lines 825-840
https://reviews.apache.org/r/25035/diff/2/?file=672690#file672690line825
I suggest to delete this comment altogether because frameworks can
utilize offers with either
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25306/#review52224
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 3, 2014, 5:41 p.m., Ben
/#comment90967
How about
... None of the enabled containerizers ( flags.containerizers )
could create;
- Vinod Kone
On Sept. 2, 2014, 9:10 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail
Can you add a comment on why you are doing a 'sed' here?
- Vinod Kone
On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25334
i'm likely missing context. what is this for?
- Vinod Kone
On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/#review52398
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 4, 2014, 9 p.m
/#comment91313
period at the end?
- Vinod Kone
On Sept. 5, 2014, 3:10 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25371
/etc/mesos looks straightforward to me.
On Fri, Sep 5, 2014 at 1:31 AM, Vetoshkin Nikita nikita.vetosh...@gmail.com
wrote:
Hi Tim!
Just took a quick look at other software.
Looks like things like Hadoop and Cassandra both keep there config in
/etc/hadoop and /etc/cassandra respectfully.
/#comment91462
Actually, you don't need testing::An here AFAICT. It is needed when you
have overloaded Mock methods (like Authorizer::authorize()).
- Vinod Kone
On Sept. 5, 2014, 3:10 a.m., Ben Mahler wrote:
---
This is an automatically
.
force re-registration.
is that not enough?
- Vinod Kone
On Sept. 5, 2014, 3:10 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373
that people are not
surprised by it. Also, do you know of anyone using/depending on it? If yes,
this probably needs to go through a deprecation cycle.
- Vinod Kone
On Sept. 8, 2014, 4:48 p.m., Timothy St. Clair wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/#review52669
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 9, 2014, 12:43 a.m
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote:
src/tests/cluster.hpp, line 597
https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597
Since you are cleaning up this code, I don't think this variable is
necessary anymore? Actually I don't know why it was used
On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote:
This probably needs a call out in the CHANGELOG so that people are not
surprised by it. Also, do you know of anyone using/depending on it? If yes,
this probably needs to go through a deprecation cycle.
Timothy St. Clair wrote
Hi folks,
I'm doing a webcast on Mesos this thursday (h/t Mesosphere) where I will
talk about some of the core features of Mesos (slave recovery,
authentication and authorization). At the end, we will have time for QA
for any and all questions related to Mesos.
More details:
/allocator_tests.cpp
https://reviews.apache.org/r/25035/#comment91851
Period at the end.
ditto. see comments in the previous test.
- Vinod Kone
On Sept. 6, 2014, 10:03 p.m., Martin Weindel wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25372/#review52775
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 9, 2014, 12:43 a.m
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote:
src/tests/cluster.hpp, line 597
https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597
Since you are cleaning up this code, I don't think this variable is
necessary anymore? Actually I don't know why it was used
/#comment92088
didn't realize that the leveldb we bundle has git files in it! isn't the
proper fix here to bundle a proper 'dist'ribution of leveldb instead of its git
tree?
- Vinod Kone
On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote
On Sept. 10, 2014, 5:26 p.m., Vinod Kone wrote:
3rdparty/Makefile.am, line 84
https://reviews.apache.org/r/25508/diff/1/?file=684613#file684613line84
didn't realize that the leveldb we bundle has git files in it! isn't
the proper fix here to bundle a proper 'dist'ribution
My guess is that your driver threw an exception while handling the
offerRescinded() callback which was detected by the JNI binding (IIRC
Mantis is a JVM framework?) causing it to abort the driver. Note that when
a driver aborts, it will send a DeactivateFrameworkMessage to the master
causing the
:26 p.m.)
Review request for mesos, Chi Zhang, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
---
See summary. Since we are not forwarding IPv6 packets, it doesn't make sense
to enable ipv6. By disabling IPv6, we won't get spamming kernel log warning
On Sept. 2, 2014, 7:50 p.m., Michael Park wrote:
Just something to note here, there's a bug in earlier GCC versions where
the access control of `= default`ed functions aren't enforced correctly.
e.g.
```
class Foo
{
private:
Foo() = default;
};
class Bar
---
make check
Thanks,
Vinod Kone
Hi folks,
We have a design doc up (attached to MESOS-1784
https://issues.apache.org/jira/browse/MESOS-1784) for properly updating
the FrameworkInfo.
The basic idea is to provide frameworks the ability update any fields of
their FrameworkInfo (e.g., 'user', 'failover_timeout') without having to
What you observed is expected because of the way the slave (specifically,
the status update manager) operates.
The status update manager only sends the next update for a task if a
previous update (if it exists) has been acked.
In your case, since TASK_RUNNING was not acked by the framework,
taken that the master
state could present the most recent known state if the status update
manager tried to send more than the front of the stream?
Taken very long timeouts, just waiting for those to disappear seems a bit
tedious and hogs the cluster.
Niklas
On 10 September 2014 17:18, Vinod
in cpplint.
- Vinod Kone
On Sept. 11, 2014, 3:36 a.m., Kamil Domanski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25526
On Sept. 9, 2014, 7:10 p.m., Vinod Kone wrote:
src/master/master.cpp, line 1901
https://reviews.apache.org/r/25035/diff/4/?file=682182#file682182line1901
I like these warnings.
Are you planning to get this in to 0.20.1 or 0.21.0 ? If the former,
can you add
1 - 100 of 3317 matches
Mail list logo
