[GitHub] metamodel pull request: FixedWidth EBCDIC support

2016-05-22 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/103#discussion_r64159744 --- Diff: fixedwidth/src/test/java/org/apache/metamodel/fixedwidth/FixedWidthConfigurationTest.java --- @@ -27,18 +27,18 @@ public void

[GitHub] metamodel pull request: FixedWidth EBCDIC support

2016-05-22 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/103#discussion_r64159697 --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java --- @@ -31,156 +31,261 @@ * Reader capable of

[GitHub] metamodel pull request: FixedWidth EBCDIC support

2016-05-20 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/103#discussion_r64030568 --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java --- @@ -103,6 +109,8 @@ public

[GitHub] metamodel pull request: FixedWidth EBCDIC support

2016-05-20 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/103#discussion_r64030560 --- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthConfiguration.java --- @@ -54,45 +56,49 @@ public FixedWidthConfiguration(int

[GitHub] metamodel pull request: FixedWidth EBCDIC support

2016-05-20 Thread LosD
Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/103#issuecomment-220587187 Travis failure seems unrelated (a failed Cassandra startup) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metamodel pull request: FixedWidth EBCDIC support

2016-05-20 Thread jhorcicka
GitHub user jhorcicka opened a pull request: https://github.com/apache/metamodel/pull/103 FixedWidth EBCDIC support METAMODEL-250 FixedWidth EBCDIC support * Refactoring of FixedWidthReader. * BufferedReader was replaced by BufferedInputStream (support for files