[GitHub] metron pull request #661: [METRON-1055] Small updates to Manual_Install_Cent...

2017-07-19 Thread lvets
GitHub user lvets opened a pull request: https://github.com/apache/metron/pull/661 [METRON-1055] Small updates to Manual_Install_CentOS6.md ## Contributor Comments This is a PR to METRON-1019. It includes small improvements to the CentOS 6 manual installation guide. No

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/636 +1 - great job --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] metron pull request #660: METRON-1054 Ambari Mpack Attempts to Kill Topologi...

2017-07-19 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/660 METRON-1054 Ambari Mpack Attempts to Kill Topologies That Are Not Run… The Ambari Metron MPack attempts to kill topologies that are not running. It also attempts to start topologies that are

[GitHub] metron issue #656: METRON-1050 Improve Docs of 'profile.period.duration'

2017-07-19 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/656 Hi @nickwallen , regarding problems with links: Item 5 in the header comments for site-book/bin/fix-md-dialect.py says: ``` 5. Relative links need to be re-written. ... as best we

[GitHub] metron pull request #658: METRON-1048 Removed SimpleHBaseEnrichmentWriterLog...

2017-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/657 I am closing this PR in favor of #658. This will not be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Relocate Docker

2017-07-19 Thread Nick Allen
Per this discussion, I opened https://github.com/apache/metron/pull/659. Please take a look when you get a chance. On Thu, Jul 13, 2017 at 1:49 PM, zeo...@gmail.com wrote: > I agree to moving it to a contrib or contrib-like area. > > Jon > > On Thu, Jul 13, 2017 at 12:38 PM

[GitHub] metron pull request #659: METRON-1053 Relocate Metron Docker

2017-07-19 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/659 METRON-1053 Relocate Metron Docker Having `metron-docker` at the top-level of the project seems to catch the attention of new users. Some then start using metron-docker to explore/try-out/demo

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 I added this endpoint to the README with the latest commit and also tested on full dev with Kerberos enabled. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #658: METRON-1048 Removed SimpleHBaseEnrichmentWriterLoggingTes...

2017-07-19 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/658 I'm fine with that, +1. I think we have an idea what the problem was so we'll know how to fix it if we ever run into it again. --- If your project is set up for it, you can reply to this email and

[GitHub] metron issue #658: METRON-1048 Removed SimpleHBaseEnrichmentWriterLoggingTes...

2017-07-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/658 @mmiklavc What do you think? Just want to make sure we have consensus from everyone that chimed in on #657. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-19 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r128300557 --- Diff: metron-interface/metron-alerts/scripts/start-dev.sh --- @@ -0,0 +1,19 @@ +#!/bin/bash +# +# Licensed to the Apache Software

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/636 What do you think @ottobackwards? Are you good with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/636 Ok, this appears to me like good infrastructure to base further index-oriented REST calls atop of. I'm +1; good job, @merrimanr ! --- If your project is set up for it, you can reply to this

[GitHub] metron issue #658: METRON-1048 Removed SimpleHBaseEnrichmentWriterLoggingTes...

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/658 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/657 I opened #658 to see if we have support for simply removing this set of tests. I find them unnecessary. Please review and vote on #658 whether you agree or disagree. Thanks --- If your

[GitHub] metron pull request #658: METRON-1048 Removed SimpleHBaseEnrichmentWriterLog...

2017-07-19 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/658 METRON-1048 Removed SimpleHBaseEnrichmentWriterLoggingTest Another alternative solution for METRON-1048. This simply removes the test itself. This set of tests simply test whether specific log

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/657 Nevermind, LoggerFactory is static. For what it's worth, adding `org.mockito.Mockito.reset(logger);` to setUp() worked for me. --- If your project is set up for it, you can reply to this email

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/657 Why not just move line 60 (`logger = mock(Logger.class);`) to the setup method? Since you're testing interactions with this mock it would be better to have a new one for every test. --- If

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 Have you been able to try this? Is there any other feedback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metron pull request #656: METRON-1050 Improve Docs of 'profile.period.durati...

2017-07-19 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/656#discussion_r128226967 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -137,15 +137,20 @@ This section will describe the steps required to get your first "Hello,

[GitHub] metron pull request #656: METRON-1050 Improve Docs of 'profile.period.durati...

2017-07-19 Thread MohanDV
Github user MohanDV commented on a diff in the pull request: https://github.com/apache/metron/pull/656#discussion_r128193518 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -137,15 +137,20 @@ This section will describe the steps required to get your first "Hello,