[GitHub] metron issue #779: METRON-1218: Metron REST should return better error messa...

2017-09-28 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/779 +1 this one bit me today and this fixes it; great job! ---

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/694 ---

[GitHub] metron pull request #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/778 ---

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/779 METRON-1218: Metron REST should return better error messages ## Contributor Comments This PR improves the error handling in the REST app and adds logging to failed searches in the

[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/778 looks good, nice clean couple of PR's on this. Great job ---

[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/778 No problem. Just added a commit that mentions the MPack in the README. Let me know if that works. ---

[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/778 @merrimanr, I think you should update the alerts-ui readme to reflect the installation. I'm still +1 so you don't have to wait after you do that though ---

[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/778 +1 on review. Ran up in full dev, started normally, data in the ui. Also able to stop and start. Nice work ---

Error message when changing riskLevelRules

2017-09-28 Thread Laurens Vets
I have the following riskLevelRules: "riskLevelRules": [ { "name": "Not WORK", "comment": "Checks whether the field is_work is true or false.", "rule": "is_work == false", "score": 20, "reason": "FORMAT('%s

Re: [DISCUSS] How should Management UI save changes?

2017-09-28 Thread Laurens Vets
Maybe change the text on the button on the primary panel to "write" instead of "save"? Also, I want wider child panels in the management UI if at all possible. Especially the "RAW JSON" feels cramped. On 2017-09-20 14:37, Ryan Merriman wrote: Recently @nickwallen brought up some good points

[GitHub] metron pull request #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/778 METRON-1208: MPack for Alerts UI ## Contributor Comments The PR completes the MPack for Alerts UI. This can be verified in full dev by spinning up full dev and navigating to the Alerts UI

[DISCUSS] Is there a reason for separate Management & Alerts UIs?

2017-09-28 Thread Laurens Vets
As the subject says, is there a specific reason to have the Management & Alerts UI separate? Having another option under "Operations" called "Alerts" in the Management UI seems to make more sense to me... If it's because they are called Management UI and Alerts UI, maybe we should make it

[GitHub] metron pull request #777: METRON-1207: Make RPMs for Alerts UI

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/777 ---

[GitHub] metron issue #777: METRON-1207: Make RPMs for Alerts UI

2017-09-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/777 +1 by inspection, LGTM ---

[GitHub] metron issue #767: METRON-1196 Increment master version number to 0.4.2 for ...

2017-09-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/767 ```bash metron-analytics/metron-profiler-client/README.md:364:[root@node1 0.4.1]# bin/stellar -z node1:2181 metron-analytics/metron-profiler/README.md:26:

Re: [DISCUSS] How should Management UI save changes?

2017-09-28 Thread Michael Miklavcic
Do we have any screen mockups/pdfs that can be shared? It might be easier for the community to discuss. On Wed, Sep 20, 2017 at 3:37 PM, Ryan Merriman wrote: > Recently @nickwallen brought up some good points about the usability of the > Management UI here: >

[GitHub] metron pull request #776: METRON-1215: Fix link to RPMs chapter

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/776 ---

[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter

2017-09-28 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/776 Yes, it is, not sure how that happened. Probably too many tabs. ---

[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter

2017-09-28 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/776 @DimDroll Thanks for creating the Jira. It's a pretty small thing, but it helps keep everything consistent and makes it easy to compile and search on during releases, etc. ---

[GitHub] metron issue #775: [METRON-1214] rpm build fails due to npm absence in Docke...

2017-09-28 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/775 Do we need to ensure we're picking this from the right repos? We should probably use the nodesource rpm repo rather than relying on the centos build, which is a very very old version, and

[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter

2017-09-28 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/776 @simonellistonball Is that comment meant for https://github.com/apache/metron/pull/775? I think you're on the wrong PR ---

[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter

2017-09-28 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/776 Do we need to ensure we're picking this from the right repos? We should probably use the nodesource rpm repo rather than relying on the centos build, which is a very very old version, and

[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter

2017-09-28 Thread DimDroll
Github user DimDroll commented on the issue: https://github.com/apache/metron/pull/776 @justinleet, sure, done: https://issues.apache.org/jira/browse/METRON-1215 I thought for such minor change jira case would be overkill :) ---

[GitHub] metron issue #776: Fix link to RPMs chapter

2017-09-28 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/776 @DimDroll Can you put the jira number at the front of the PR name like the other PRs have please? ---

[GitHub] metron issue #776: Fix link to RPMs chapter

2017-09-28 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/776 +1, was able to see it work in Github's view. Thanks a lot for the fix. ---