GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/806
METRON-1262: Unable to add comment for a alert in a meta-alert
## Contributor Comments
This PR fixes a bug in the ElasticsearchMetaalertDao class (description is
in the Jira). I verified it
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/802
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/802
+1, thanks for this, it's good stuff
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/802
Feedback has been addressed. Take another look when you get a chance.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145532292
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user as22323 commented on the issue:
https://github.com/apache/metron/pull/754
Just an FYI: This PR is to simply change "control_path =
~/.ssh/ansible-ssh-%%C"(in ../amazon-ec2/ansible.cfg) to "control_path =
~/.ssh/ansbile-ssh-%%h-%%r" to allow linux systems to deploy to
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/805
Okay, I just spun up full-dev and followed my testing instructions - all
looks good to me. This is ready for a review.
---
I was hesitant to believe Ryan that this was a compiler issue, but I
upgraded my compiler on CentOS 6 to 4.9.2 and the build worked on the
first try... Lesson learned: Never question Ryan again!
How to upgrade compiler on CentOS 6:
$ sudo yum install centos-release-scl
$ sudo yum install
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
https://github.com/nickwallen/metron-commit-stuff/blob/master/checkout-pr
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145431927
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/805
Right @justinleet I've done that in the past as well, this is me just being
lazy and not wanting to look up the PR # when drafting my instructions =)
That said, those instructions don't
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/805
It's actually easier than this to pull in a PR, for future reference
```
git fetch upstream pull/805/head:METRON-1261
git checkout METRON-1261
```
Assuming upstream is
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
Maybe we should have the checkout-pr script in the metron repo?
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145427376
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145424998
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/805
As usual, I really love your test scripts. Well done, @JonZeolla !
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145423988
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145424237
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/785#discussion_r145423853
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/util/ParserIndex.java
---
@@ -0,0 +1,92 @@
+/**
+ * Licensed to the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/805
# Testing
1. Create a working directory and pull in this PR
```
mkdir ~/metron-1261
git clone https://github.com/apache/metron ~/metron-1261/metron
cd
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/800#discussion_r145415334
--- Diff: metron-interface/metron-rest/README.md ---
@@ -112,42 +112,42 @@ The following configures the application for MySQL:
1. Install MySQL if not
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/805
METRON-1261: Apply bro security patch
## Contributor Comments
This should update the version of bro that is auto-installed by
full-dev/quick-dev, and update some manual instructions for
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145393297
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145378015
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145372604
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -177,15 +178,18
25 matches
Mail list logo
