[GitHub] metron pull request #826: METRON-1291: Kafka produce REST endpoint does not ...

2017-11-02 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/826 METRON-1291: Kafka produce REST endpoint does not work in a Kerberized cluster ## Contributor Comments This PR adds Kerberos support to the

[GitHub] metron pull request #821: METRON-1281: Remove hard-coded indices from the Al...

2017-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/821 ---

Re: [APACHE COMMITER QUESTION] PR’s from organization’s as opposed to ‘people’

2017-11-02 Thread larry mccay
Interesting question. I share your concern there and think it would be reasonable to ask for it to be re-contributed by an individual. Preferably, such that an Apache account can have it assigned to them. However, I haven't switched Apache Knox to accepting PR's yet and not sure what others do

[GitHub] metron issue #803: Metron-1252: Build ui for grouping alerts into meta alert...

2017-11-02 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/803 @merrimanr Looks like the following rest-api's are not working as expected - When a meta alert is created and when we try to group by an IP address(ip_dst_addr/ip_src_addr) the IP address is

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/825 Looks like there is a [bug](https://stackoverflow.com/questions/40984882/mockito-and-powermock-methodnotfoundexception-being-thrown) in the powermock version inherited by this module. Latest

[APACHE COMMITER QUESTION] PR’s from organization’s as opposed to ‘people’

2017-11-02 Thread Otto Fowler
I have reviewed and approved https://github.com/apache/metron/pull/822, but I’m not sure about committing it. The submitter is an organizational github account, not a ‘person’. There is no way to verify the submitter, no email etc at the moment. How should this be handled?

[GitHub] metron issue #822: METRON-1288 Update so it installs java8

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/822 +1 Thanks for the contribution ---

[GitHub] metron issue #821: METRON-1281: Remove hard-coded indices from the Alerts UI

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/821 @merrimanr nice work! +1 by inspection ---

[GitHub] metron pull request #825: METRON-1290: Only first 10 alerts are update when ...

2017-11-02 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/825 METRON-1290: Only first 10 alerts are update when a MetaAlert status is changed to inactive ## Contributor Comments This PR fixes a small bug in the ElasticsearchMetaAlertDao that only

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r148531977 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -0,0 +1,75 @@ +package

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r148532449 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -0,0 +1,75 @@ +package

[GitHub] metron issue #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/823 Also not the ## For Documentation related changes section of the template. You should verify the readme changes before pushing ---

[GitHub] metron issue #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/823 Please note from the PR submit template above ```bash mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` You should run this before pushing. ---

[GitHub] metron issue #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/823 Stellar functions need to be documented in the metron-stellar/stellar-common/README.md Please document these new functions ---

[GitHub] metron issue #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/823 All the code files in the project need to have the apache lic. header at the top. The two files you have created do not have that, and cannot be accepted without it. What you need to