Re: [DISCUSS] Upcoming Release

2017-11-17 Thread Ryan Merriman
Makes sense now. Thanks Matt. > On Nov 17, 2017, at 4:25 PM, Matt Foley wrote: > > Hi Ryan, > Yes and no. The last release (see > https://dist.apache.org/repos/dist/release/metron/ ) was 0.4.1, announced on > 9/19. > Immediately after that we bumped the of builds

[GitHub] metron-bro-plugin-kafka pull request #3: METRON-813: Migrate metron-bro-plug...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron-bro-plugin-kafka/pull/3 ---

[GitHub] metron-bro-plugin-kafka issue #3: METRON-813: Migrate metron-bro-plugin-kafk...

2017-11-17 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/3 +1 This works great @JonZeolla . This is a really nice enhancement. I tested by manually installing Bro and using bro-pkg to install our plugin. Everything works exactly as I

Re: [DISCUSS] Upcoming Release

2017-11-17 Thread Matt Foley
Hi Ryan, Yes and no. The last release (see https://dist.apache.org/repos/dist/release/metron/ ) was 0.4.1, announced on 9/19. Immediately after that we bumped the of builds from master branch, per https://issues.apache.org/jira/browse/METRON-1196 . This is consistent with the Release

Re: [DISCUSS] Upcoming Release

2017-11-17 Thread Nick Allen
Our last release was 0.4.1, so the next would be at least 0.4.2. We recently have been keeping master at the next presumed release version. On Fri, Nov 17, 2017 at 4:59 PM, Ryan Merriman wrote: > Matt, > > I think we are currently on version 0.4.2. If that is the case

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151801296 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -132,6 +132,30 @@

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151799957 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -132,6 +132,30 @@

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151798907 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java --- @@ -96,6 +96,11 @@ public

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151799462 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java --- @@ -96,6 +96,11 @@ public

Re: [DISCUSS] Upcoming Release

2017-11-17 Thread Ryan Merriman
Matt, I think we are currently on version 0.4.2. If that is the case would the next version be 0.4.3? Ryan On Fri, Nov 17, 2017 at 3:31 PM, Matt Foley wrote: > (With release manager hat on) > > The community has proposed a release of Metron in the near future, > focusing on

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/843 METRON-1319: Column Metadata REST service should use default indices on empty input ## Contributor Comments This PR adjusts the Column Metadata REST service to use a list of default indices

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151794206 --- Diff: scripts/init.bro --- @@ -18,11 +18,20 @@ module Kafka; export { - const topic_name: string = "bro" -

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151793309 --- Diff: scripts/Bro/Kafka/logs-to-kafka.bro --- @@ -14,32 +14,37 @@ # See the License for the specific language governing

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151791732 --- Diff: scripts/Bro/Kafka/logs-to-kafka.bro --- @@ -14,32 +14,37 @@ # See the License for the specific language governing

Re: [DISCUSS] Upcoming Release

2017-11-17 Thread Matt Foley
(With release manager hat on) The community has proposed a release of Metron in the near future, focusing on Meta-alerts running in Elasticsearch. Congrats on getting so many of the below already done. At this point, only METRON-1252, and the discussion of how to handle joint release of the

[GitHub] metron issue #803: Metron-1252: Build ui for grouping alerts into meta alert...

2017-11-17 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/803 Hi @iraghumitra - I'd like to see your work get in ASAP. Can you merge with master when you get a chance? Also, I think you need to make some updates based on recent PRs that have

Re: [DISCUSS] Upcoming Release

2017-11-17 Thread Nick Allen
I just wanted to send an update on where we are at. We've gotten a lot done here recently as you can see below. ✓ DONE (1) First, METRON-1289 needs to go in. This one was a fairly big effort and I am hearing that we are pretty close. ✓ DONE (2) METRON-1294 fixes an issue in how field types

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/832 ---

[GitHub] metron issue #832: METRON-1301 Sorting on Triage Score Unexpectedly Filters ...

2017-11-17 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/832 Thanks for all the reviews, guys. Going to commit now. ---

[GitHub] metron issue #832: METRON-1301 Sorting on Triage Score Unexpectedly Filters ...

2017-11-17 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/832 +1 worked as advertised. Thanks @nickwallen! ---

[GitHub] metron issue #832: METRON-1301 Sorting on Triage Score Unexpectedly Filters ...

2017-11-17 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/832 +1 by inspection. Looks great! ---

[GitHub] metron issue #832: METRON-1301 Sorting on Triage Score Unexpectedly Filters ...

2017-11-17 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/832 Spun this up on full dev, and saw that sorting worked as expected in the UI. This worked both when no groupings were selected and also when drilling down (e.g. grouping by ip_dst_addr and

[GitHub] metron pull request #827: METRON-1294: IP addresses are not formatted correc...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/827 ---

[GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...

2017-11-17 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/827 Great, thanks for the update. +1 ---

[GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...

2017-11-17 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/827 @nickwallen The parameter name is preexisting and I'm fine with leaving that. Would you be okay with changing the descriptions in the README and annotations? That should be a nonintrusive

[GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...

2017-11-17 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/827 @justinleet I think that's a good find. I'd suggest we fix this issue on a subsequent PR after we get this and #832 merged. On #832, the refactoring will make it much easier to unit test a fix

[GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...

2017-11-17 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/827 I ran a request giving sensors: ``` curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '["snort", "bro"]'

[GitHub] metron pull request #826: METRON-1291: Kafka produce REST endpoint does not ...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/826 ---