[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread anandsubbu
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159361598 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,134 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/869 +1, pending Travis. Good job, this should be really helpful! ---

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159330127 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,134 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159327372 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,134 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159327218 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,134 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron issue #831: METRON-1302: Split up Indexing Topology into batch and ra...

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/831 I ran this up in full dev and everything worked as advertised. I only noticed a couple minor issues and left comments for those. I also am a little confused by the ra/batch vs es/hdfs

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159324176 --- Diff: metron-deployment/packaging/ambari/metron-mpack/README.md --- @@ -0,0 +1,94 @@ + + +This provides a Management Pack (MPack)

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2018-01-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r159322924 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/hdfs.properties.j2 --- @@

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159322553 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,134 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2018-01-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r159321881 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/integration/IndexingIntegrationTest.java --- @@ -197,9 +140,7 @@

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159317149 --- Diff: metron-deployment/packaging/ambari/metron-mpack/README.md --- @@ -0,0 +1,94 @@ + + +This provides a Management Pack (MPack)

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159316935 --- Diff: metron-deployment/packaging/ambari/metron-mpack/README.md --- @@ -0,0 +1,94 @@ + + +This provides a Management Pack (MPack)

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/622 There was a lot of good discussion on this, but I find it hard to summarize completely the positions of everyone including @mattf-horton and @cestella. Here is my attempt in trying to do that.

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159314084 --- Diff: metron-deployment/README.md --- @@ -1,175 +1,129 @@ -# Overview -This set of playbooks can be used to deploy an Ambari-managed Hadoop

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/869 +1 Thanks ---

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159284348 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,132 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159284273 --- Diff: metron-deployment/README.md --- @@ -1,175 +1,129 @@ -# Overview -This set of playbooks can be used to deploy an Ambari-managed Hadoop

Re: [DISCUSS] Removing Markdown files from rat exclusion

2018-01-02 Thread Matt Foley
Bravo. On 1/2/18, 8:43 AM, "Justin Leet" wrote: The PR is merged into master, and all relevant PRs have a comment noting that adding the header is required. As a reminder, this means Apache headers are required on all markdown files and this will be

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread anandsubbu
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159280034 --- Diff: metron-deployment/README.md --- @@ -15,178 +15,132 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the

[GitHub] metron pull request #885: METRON-1384 Increment master version number to 0.4...

2018-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/885 ---

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/869 Ok, @ottobackwards. I'll take a hack at that. ---

[GitHub] metron pull request #886: METRON-1385: Missing "properties" in index templat...

2018-01-02 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/886 METRON-1385: Missing "properties" in index template causes ElasticsearchColumnMetadataDao.getColumnMetadata to fail ## Contributor Comments A bug was recently discovered that causes a NPE

[GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/840#discussion_r159273549 --- Diff: pom.xml --- @@ -159,7 +159,7 @@ ${global_surefire_version}

[GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/840#discussion_r159266301 --- Diff: metron-deployment/other-examples/manual-install/Manual_Install_CentOS6.md --- @@ -441,7 +441,7 @@ Client - Kibana: * Set

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159268214 --- Diff: metron-deployment/README.md --- @@ -1,175 +1,129 @@ -# Overview -This set of playbooks can be used to deploy an Ambari-managed Hadoop

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/869 https://github.com/apache/metron/tree/master/metron-deployment/packaging/docker/ansible-docker ---

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/869 The ansible-docker image can be used for this. ---

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159266396 --- Diff: metron-deployment/README.md --- @@ -1,175 +1,129 @@ -# Overview -This set of playbooks can be used to deploy an Ambari-managed Hadoop

[GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/840#discussion_r159265938 --- Diff: metron-deployment/README.md --- @@ -1,3 +1,16 @@ +# Metron Deployment --- End diff -- As a heads up, #883 is in now, so this

Re: [DISCUSS] Removing Markdown files from rat exclusion

2018-01-02 Thread Justin Leet
The PR is merged into master, and all relevant PRs have a comment noting that adding the header is required. As a reminder, this means Apache headers are required on all markdown files and this will be enforced by rat. On Sat, Dec 30, 2017 at 8:33 AM, Justin Leet wrote:

[GitHub] metron pull request #883: METRON-1381: Add Apache license to MD files and re...

2018-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/883 ---

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/883 +1 ---

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159261149 --- Diff: metron-deployment/README.md --- @@ -1,175 +1,129 @@ -# Overview -This set of playbooks can be used to deploy an Ambari-managed Hadoop

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/869 Do those instructions exist somewhere before this PR ? That sounds like new functionality or am I misunderstanding your request? ---

[GitHub] metron issue #885: METRON-1384 Increment master version number to 0.4.3 for ...

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/885 I'll take care of getting this merged now. ---

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2018-01-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/883 I'm +1 ---

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/869 Can we have a section on `How dow I build everything with docker` with instructions for the ansible docker container? ---

[GitHub] metron issue #885: METRON-1384 Increment master version number to 0.4.3 for ...

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/885 I'm +1 by inspection, since Nick built the code base. Thanks for taking care of this! ---

[GitHub] metron issue #885: METRON-1384 Increment master version number to 0.4.3 for ...

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/885 +1 Thanks, Matt! Manually reviewed the changes and built the code base. All remaining references to 0.4.2 are part of step-by-step instructions where the version does not

[GitHub] metron pull request #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/869#discussion_r159246961 --- Diff: metron-deployment/README.md --- @@ -1,175 +1,129 @@ -# Overview -This set of playbooks can be used to deploy an Ambari-managed Hadoop

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/869 @justinleet Is that a +1 then? @ottobackwards What are your thoughts on this PR? Is this an incremental improvement that we can merge? ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/857 @justinleet I believe @iraghumitra is still working on the SELENIUM_PROMISE_MANAGER change proposed above but I will defer to him. ---

[GitHub] metron issue #883: METRON-1381: Add Apache license to MD files and remove th...

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/883 @nickwallen @ottobackwards I'm going to (possibly annoyingly) ping again and use the excuse that the holidays are over. ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/857 @merrimanr @mmiklavc @iraghumitra What are the next steps towards being able to have this stable? It sounds like there was some playing around with versions, and that there may be some more

[GitHub] metron issue #858: METRON-1344: Externalize the infrastructural components u...

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/858 @cestella are you good with merging this in to the feature branch? I believe I addressed your comments. ---

[GitHub] metron issue #789: METRON-1233: Remove description of Global configuration f...

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/789 @DimDroll Is this still relevant with Mike's comment about #791? ---

[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 @merrimanr Can you deconflict this? This is otherwise ready for review, but it just needs to happen, right? ---

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/622 @nickwallen I haven't been following this discussion, but it seems like a useful feature / enhancement that's been hanging out awhile after active discussion petered out. What are the next steps

[GitHub] metron issue #869: METRON-1362 Improve Metron Deployment README

2018-01-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/869 @nickwallen Thanks for adding that. I'm good with it. ---

Re: [DISCUSS] Resources for how to contribute to Apache Metron

2018-01-02 Thread Otto Fowler
Bump Anyone have any thoughts? On December 20, 2017 at 10:37:03, Casey Stella (ceste...@gmail.com) wrote: That's really good feedback, Jon. I agree that we have a significant barrier to get to the point of tinkering. Full-dev really wasn't intended to be that entry point; it's more of a way to