[GitHub] metron pull request #888: METRON-1389: Zeppelin notebook import does not wor...

2018-01-09 Thread anandsubbu
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/888#discussion_r160591890 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py --- @@

[GitHub] metron pull request #872: METRON-1366: Add an entropy stellar function

2018-01-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/872#discussion_r160532240 --- Diff: metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/informationtheory/InformationTheoryUtil.java --- @@ -0,0 +1,52 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2018-01-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r160530273 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java --- @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2018-01-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r160529767 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java --- @@

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/884 I think creating the /interpreters/stellar/x.json creates the entry? I just tried again, ( new mvn install , new site file ) and I checked the interpreter log: INFO

[GitHub] metron issue #893: METRON-1393: Fix bro Elasticsearch template

2018-01-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/893 +1 by inspection, thanks for the fix! ---

[GitHub] metron pull request #880: METRON-1379: Add an OBJECT_GET stellar function

2018-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/880 ---

[GitHub] metron issue #872: METRON-1366: Add an entropy stellar function

2018-01-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/872 @justinleet I think that was just an alternative implementation with streams rather than explicit loops. I interpreted it as not a suggested change, but a cool new way to compute entropy. ---

[GitHub] metron issue #893: METRON-1393: Fix bro Elasticsearch template

2018-01-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/893 +1, ran it up, tried it out with the new template and both queries worked as expected. ---

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/884 > I didn't have to 'create' the stellar interpreter after starting, there was already an entry, I think from the site config That does not (should not) happen. It should only be there

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2018-01-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r160511065 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java --- @@ -0,0

[GitHub] metron issue #879: METRON-1378: Create a summarizer

2018-01-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/879 Just following up, I have migrated the mapping of existing data to a template in the instructions and the type mismatch for `ip_dst_addr` is no longer an issue. The PR as it currently stands has

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/884 1. When I type something in the notebook and hit run. At least I think that is when I get the error. It may happen when selecting the interpreter for the notebook. 2. Yes

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/884 > @ottobackwards : I am getting exceptions starting the stellar interpreter I have never seen this. I need more context unfortunately. 1. What do you mean by "starting the

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/884 > @ottobackwards : In the zeppelin site file, there is already a zeppelin.interpreters property, which in a comma separated list of class names. Is it right to create a new property vs. adding to

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/884 > Is there a 'supported' or tested version of zeppelin? I have 0.7.3 installed locally. 0.7.3 is what the unit tests and what my manual testing have used. I added this to the

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Here are my thoughts on your responses. 1. I think we're in agreement. This is how this PR currently works. 2. No, saved searches are currently stored client-side. I think the plan

[GitHub] metron issue #891: METRON-1282 creating a new topic using the rest end point...

2018-01-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/891 @MohanDV this is a good start and will be a nice feature to have. I have a couple suggestions. First, can we move this to it's own function/endpoint? I think this would be useful for

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/853 To respond to the questions in the description (and maybe kick off conversation, especially if anyone disagrees) + add my own thoughts. In no particular order. @merrimanr Let me know if

[GitHub] metron issue #889: METRON-1390: Swagger UI for "Web Security Config" Control...

2018-01-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/889 +1 by inspection. Thanks @MohanDV! ---

[GitHub] metron issue #893: METRON-1393: Fix bro Elasticsearch template

2018-01-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/893 # Testing ## Set Up Base Data We're going to set up a bit of base data. Retrieve the current list of indices so we know where to put our data ``` curl

[GitHub] metron pull request #893: METRON-1393: Fix bro Elasticsearch template

2018-01-09 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/893 METRON-1393: Fix bro Elasticsearch template ## Contributor Comments Addresses https://issues.apache.org/jira/browse/METRON-1393 String types in the bro_index.template breaks the

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Done ---

[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...

2018-01-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 I spun up master and this also occurs there. I'll create a JIRA for it. +1, thanks for the improvement! ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/853 @merrimanr Can you deconflict this? ---

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2018-01-09 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/metron/pull/865 ---

[GitHub] metron pull request #865: METRON-1212 The bundle System and Maven Plugin (Fe...

2018-01-09 Thread ottobackwards
GitHub user ottobackwards reopened a pull request: https://github.com/apache/metron/pull/865 METRON-1212 The bundle System and Maven Plugin (Feature Branch) This PR contains the Bundle system and Maven Plugin. The bundle system and the plugin are adapted from the Apache

[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...

2018-01-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/786 This happens intermittently for me. An error in the dev tools when hitting `http://node1:4200/api/v1/storm/parser/start/bro` is: ``` (failed) net::ERR_EMPTY_RESPONSE ```

[GitHub] metron pull request #892: METRON-1392 Fix a test case to expect an Exception...

2018-01-09 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/892 METRON-1392 Fix a test case to expect an Exception when replication factor more than number of brokers while creating topic ## Contributor Comments Fix a test case to expect an Exception when