Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/853
+1 by inspection
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
I knew what you meant :)
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/946
ah, crap, looked at the wrong setting. That's what I meant instead of
`storm.library.path`
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
We could probably leverage this guy here
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171624949
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
-
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/946
@mmiklavc Yeah, I think that's the approach, however, there's a snag.
Storm requires us to create uber jars, so probably what we want to do is have
users actually put the xpath transport client on
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/946
@mmiklavc I agree, as long as the user themselves is setting it up, I
believe that would solve the license problem. At least from my understanding
of things.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
@simonellistonball It looks like they are not explicitly bundling the
X-Pack client. Rather, they're expecting the user to provide the jar file
manually on the classpath and then dynamically
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/946
Should we consider a dual client in the same project similar to the
approach in
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171620565
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
-
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171619920
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
-
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171618015
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
-
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171617250
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
-
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171614360
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
-
Github user wardbekker commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171599970
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
---
@@ -111,19 +111,24 @@
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171596212
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
---
@@ -111,19 +111,24 @@
GitHub user wardbekker opened a pull request:
https://github.com/apache/metron/pull/946
METRON-1465:Support for Elasticsearch X-pack
## Contributor Comments
[Please place any comments here. A description of the problem/enhancement,
how to reproduce the issue, your testing
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/853
Sorry, I'll try to get back to this today
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
Any other feedback @ottobackwards or is this ready to go?
---
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/934
---
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/945
Are we losing anything by moving the scheme from Range to Trie types?,
repeating my comment on
https://github.com/apache/metron/pull/922:
Given that our use case is heavily
21 matches
Mail list logo
