[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-08-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/620 +1 by inspection, great job @iraghumitra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #666: METRON-1051: Enable the ability to update indexed message...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/666 Alright, I think all of the concerns thus far are addressed. Let me know if I missed anything @justinleet , et al --- If your project is set up for it, you can reply to this email and have your

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131249786 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131246467 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,99 @@ public

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131217265 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,99 @@ public

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131174351 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,99 @@ public

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131173765 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,99 @@ public

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131172968 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131172518 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchUpdateIntegrationTest.java

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131172237 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchUpdateIntegrationTest.java

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131170639 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,99 @@ public

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 +1 by inspection, this is good work, @ottobackwards Sorry for jumping to conclusions! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 hah no, a JIRA will be necessary ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 Yeah, I'm totally ok with this now. Really sorry about jumping to the wrong conclusion; I saw the errors in the aftermath of the math PR that got in this morning and jumped to the wrong conclusion

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 Ok, wait, I think I might've misunderstood. This `DefaultVariableResolver` is just being used for tests, validation and Lambda functions now, is that correct? I think I'm ok

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r131148105 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,63

[GitHub] metron pull request #677: METRON-1073: Add option to limit fields returned f...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/677#discussion_r131133901 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -81,8 +82,14 @@ public

[GitHub] metron pull request #677: METRON-1073: Add option to limit fields returned f...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/677#discussion_r131133808 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -81,8 +82,14 @@ public

[GitHub] metron pull request #677: METRON-1073: Add option to limit fields returned f...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/677#discussion_r131133566 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -81,8 +82,14 @@ public

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131129176 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,100 @@ public

[GitHub] metron pull request #666: METRON-1051: Enable the ability to update indexed ...

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/666#discussion_r131128726 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -102,15 +128,100 @@ public

[GitHub] metron issue #666: METRON-1051: Enable the ability to update indexed message...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/666 @justinleet yeah, I'll add javadoc to `IndexDao` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #666: METRON-1051: Enable the ability to update indexed message...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/666 Just a brief note about the `TableProvider` business. We had cut and pasted a mock HTableProvider through several of our projects. In order to test the `HBaseDao`, I needed yet another

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-03 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r131099946 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,63

[GitHub] metron issue #641: METRON-539: added HASH function for stellar.

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/641 Ok, I'm +1 on this by inspection as soon as we have the conflict resolved. Great job, @jjmeyer0 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron issue #650: METRON-1038: Stellar should have a better collection of b...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/650 Committed, but I wanted to make a comment about the BiFunction. Honestly, I like the notion of providing candy for 2-arg functions like we did for single-arg functions. I think it'll make

[GitHub] metron issue #666: METRON-1051: Enable the ability to update indexed message...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/666 Ok, architectural coverage is mentioned here, so I think this is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130886124 --- Diff: metron-stellar/stellar-common/README.md --- @@ -101,58 +101,69 @@ In the core language functions, we support basic functional programming

[GitHub] metron issue #650: METRON-1038: Stellar should have a better collection of b...

2017-08-02 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/650 Ok, I reacted to @mattf-horton and @justinleet 's comments: * adjusted some naming and made the documentation match up * adjusted the `ROUND` documentation to indicate half-up rounding

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130883191 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/MathOperations.java --- @@ -0,0 +1,66

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130883151 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/MathOperations.java --- @@ -0,0 +1,66

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130883104 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/math/StellarMathFunction.java --- @@ -0,0 +1,64

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130880080 --- Diff: metron-stellar/stellar-common/README.md --- @@ -613,6 +684,12 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130880007 --- Diff: metron-stellar/stellar-common/README.md --- @@ -581,6 +634,24 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130880027 --- Diff: metron-stellar/stellar-common/README.md --- @@ -581,6 +634,24 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130879927 --- Diff: metron-stellar/stellar-common/README.md --- @@ -110,6 +110,8 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130879898 --- Diff: metron-stellar/stellar-common/README.md --- @@ -110,6 +110,8 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130879867 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -19,45 +19,179

[GitHub] metron issue #666: METRON-1051: Enable the ability to update indexed message...

2017-08-02 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/666 Testing Instructions beyond the normal smoke test (i.e. letting data flow through to the indices and checking them). # Preliminaries Set an environment variable to indicate

[GitHub] metron issue #599: METRON-975: Normalize logging and switch to common idiom ...

2017-08-01 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/599 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-27 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r129871944 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,86 @@ +# Ambari Management Pack Development +Typically, Ambari Management Pack

[GitHub] metron issue #673: METRON-1069: Ambari MPack documentation around developmen...

2017-07-27 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/673 Also, I'd like to see a small section about best practices that people should consider when they're adding properties, such as: * If you're adding a new table or topic based on your property

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-27 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r129865954 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,86 @@ +# Ambari Management Pack Development +Typically, Ambari Management Pack

[GitHub] metron pull request #643: METRON-1026: threatintel_taxii_load.sh throws exce...

2017-07-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/643#discussion_r129532376 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/taxii/TaxiiLoader.java --- @@ -165,6 +167,19 @@ public

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-25 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 @mattf-horton Would this approach require scans on read in the critical path? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-25 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 @mattf-horton Wouldn't you have to use the serial number to retrieve profiles? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron issue #451: METRON-157: Added CEF Parser

2017-07-25 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/451 Hey @Ravi0204 you might have better luck sending an email to the Metron user@ list with that question. This PR is closed and the range of people paying attention to it is constrained

[GitHub] metron issue #650: METRON-1038: Stellar should have a better collection of b...

2017-07-25 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/650 Any comments or review here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-25 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/622#discussion_r129252984 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java --- @@ -0,0 +1,402

[GitHub] metron pull request #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-25 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/622#discussion_r129252678 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java --- @@ -0,0 +1,402

[GitHub] metron pull request #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-25 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/622#discussion_r129252112 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/DecodableRowKeyBuilder.java --- @@ -0,0 +1,402

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 I want to point out that I am also in favor of an audit log for the profiler, but I don't think it's a complete solution for the batch analytics use-case. --- If your project is set up

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 Also, while we're in here, is there a strong reason why the prefixed hash is so large? It's just there for uniformity of distribution, correct? I'd propose a non-cryptographic hash

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 So, in my mind the feature here is the enablement of batch analytics on the profiles. To that end, I'm in general in favor of a decodable row key. I think that the question really isn't a ToC

[GitHub] metron issue #614: METRON-992: Create performance tuning guide

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/614 +1 by inspection; this is right on the money and a good first pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-19 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/636 Ok, this appears to me like good infrastructure to base further index-oriented REST calls atop of. I'm +1; good job, @merrimanr ! --- If your project is set up for it, you can reply

[GitHub] metron issue #641: METRON-539: added HASH function for stellar.

2017-07-18 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/641 I just want to chime in and say thanks for the contribution @jjmeyer0 !. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] metron issue #654: METRON-1044: Disabled writers are not acking messages

2017-07-18 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/654 +1 by inspection. This is a big miss when I added writer disabling, so thanks for the cleanup @merrimanr . As a follow-up, we might consider turning acking on by default in the indexing topology

[GitHub] metron issue #652: METRON-1039: Add ZIP function to Stellar

2017-07-18 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/652 @jjmeyer0 I don't have a problem with it, but can you cite any previous work (i.e. another language) that works that way? The question I would have is, should each arg be exploded as separate args

[GitHub] metron issue #651: METRON-1037 Added POWER function

2017-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/651 @mattf-horton Actually, `**` and `math.exp()` are different; the first being an arbitrary power function and the later presuming that we're taking a power of `e` (i.e. `e**x == exp(x)` ). I did

[GitHub] metron issue #653: METRON-1040 Create Installation Instructions for the Prof...

2017-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/653 Exactly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron issue #653: METRON-1040 Create Installation Instructions for the Prof...

2017-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/653 Cool, can we get a blurb about adjusting configs to conform to your system, etc. at the end of this? If so, I'm +1. --- If your project is set up for it, you can reply to this email and have your

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/636 Bear with me, @merrimanr, I am going to submit a PR with the DAO abstraction I was talking about so we can hash it out. I started it in collaboration with @justinleet to ensure the ideas

[GitHub] metron issue #649: METRON-1035 Added SUM to the rules triage aggregation doc...

2017-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/649 +1 by inspection, nice work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #651: METRON-1037 Added POWER function

2017-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/651#discussion_r127263511 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -60,4 +60,38 @@ public boolean

[GitHub] metron issue #650: METRON-1038: Stellar should have a better collection of b...

2017-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/650 Ok, I broke this abstraction out a bit and made it easier to add non-single-arg functions (a la POW, which is a separate PR by @simonellistonball ). I also went ahead and added `ROUND` and `EXP

[GitHub] metron pull request #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/652#discussion_r127247191 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/FunctionalFunctionsTest.java --- @@ -24,13 +24,124

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r127242712 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -25,17 +25,39 @@ import

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r127242100 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -25,17 +25,39 @@ import

[GitHub] metron pull request #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/652#discussion_r127227967 --- Diff: metron-stellar/stellar-common/README.md --- @@ -711,6 +713,18 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-07-13 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/650 METRON-1038: Stellar should have a better collection of basic math operations ## Contributor Comments At the moment the math functions are woefully incomplete. We should add at least

[GitHub] metron issue #639: METRON-1013 add command line verification to stellar shel...

2017-07-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/639 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/636 I just want to follow-up with something a bit more concrete suggestions. I think the beginnings of an abstraction are there. You pulled out a bunch of utility methods from `ElasticsearchWriter

[GitHub] metron issue #621: METRON-1001: Allow metron to ingest parser metadata along...

2017-07-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/621 @justinleet any other comments or concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #636: METRON-1022: Elasticsearch REST endpoint

2017-07-10 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/636 This is good work! Thanks, Ryan. We desperately need this abstraction. I think the confusion may be that this PR is the general abstraction as well as a concrete implementation for one index. I

[GitHub] metron issue #520: METRON-833: Update MaaS documentation to explain how it i...

2017-07-10 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/520 Deconflicted; thanks for the patience. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #608: METRON-986 Enhance Fastcapa to Support Intel X520

2017-07-07 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/608 That sounds good; can you create a follow-on JIRA to investigate how to make the properties specified at run-time rather than as macros in code? --- If your project is set up for it, you can reply

[GitHub] metron issue #608: METRON-986 Enhance Fastcapa to Support Intel X520

2017-07-07 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/608 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron pull request #550: METRON-890: Intermittent unit test errors in shutt...

2017-07-07 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron issue #621: METRON-1001: Allow metron to ingest parser metadata along...

2017-07-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/621 Merging master in to get the unit tests to run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r125007939 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -61,6 +62,7

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124998536 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -61,6 +62,7

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124922443 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -148,6 +150,15 @@ public

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124921605 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -148,6 +150,15 @@ public

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124921122 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -61,6 +62,7

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/624 Oh, we should also spin this up on full-dev and ensure that any of the changes to the pom files didn't screw anything up. --- If your project is set up for it, you can reply to this email and have

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124842566 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java --- @@ -0,0 +1,168 @@ +/** --- End

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124821374 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java --- @@ -0,0 +1,168 @@ +/** --- End

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124821164 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java --- @@ -0,0 +1,168 @@ +/** --- End

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/624 The final commits are intended to migrate the parser integration tests into a driver that just executes the bolt without storm or kafka. This should save minutes of time and set us up for new

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/624 The commits `6824ca9` through `1c98ae4` above represent the following: * `ProfilerHBaseClientTest` (using mock HTable rather than hbase) * `HBaseClientTest` (deletes contents, rather than

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-27 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/624 I submitted PRs against this branch to incorporate the suggested changes above for: * Selective shading for non-leaf projects to cut the build times dramatically. * `TaxiiIntegrationTest

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-26 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-26 Thread cestella
GitHub user cestella reopened a pull request: https://github.com/apache/metron/pull/621 METRON-1001: Allow metron to ingest parser metadata along with data ## Contributor Comments Currently, we only ingest data in Metron. Often, there is valuable metadata constructed up-stream

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-26 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-26 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-26 Thread cestella
GitHub user cestella reopened a pull request: https://github.com/apache/metron/pull/621 METRON-1001: Allow metron to ingest parser metadata along with data ## Contributor Comments Currently, we only ingest data in Metron. Often, there is valuable metadata constructed up-stream

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-23 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/624 If you succeed here, you'll be my best friend. We're drowning in integration test drama over here. :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-23 Thread cestella
GitHub user cestella reopened a pull request: https://github.com/apache/metron/pull/621 METRON-1001: Allow metron to ingest parser metadata along with data ## Contributor Comments Currently, we only ingest data in Metron. Often, there is valuable metadata constructed up-stream

[GitHub] metron pull request #621: METRON-1001: Allow metron to ingest parser metadat...

2017-06-23 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

<    1   2   3   4   5   6   7   8   >