Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
+1. The issues I was seeing where a problem in my own code ( surprise
right? ). This fix is correct and appropriate for the scope it seeks to
address. It is really good work.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Just pushed out a small change to support parameter substitution in the
metron_temp_grok_path parameter. I verified this in full dev as well. I also
verified the temporary files are being
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
question - can the rest service delete these temp files? From full_dev?
I am seeing an issue where rest cannot delete files it creates because the
permissions don't match the parent
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
+1 by inspection, @merrimanr I would run this up in full dev one more time
after your last change to make sure nothing wacky goes on with ambari and
ambari format().
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Please see https://issues.apache.org/jira/browse/METRON-1150 for a
description of why this is needed. Let me know if that isn't clear enough or
you need more info.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
I'm going to throw a quick review at this. I do not want to hold it back,
but this is the place to ask questions. I want to understand these things for
comparison
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/729
I'm guessing it probably doesn't replace the changes in the feature branch,
especially if it remove the need for temp path. I'm looking at this as the fix
until that branch comes in, honestly.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
The fix in 777 removes the need for a temp path/ temp file for this. If
this resolves in the mean time that is great, but I'm not sure that it will
replace what is in the feature branch.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/729
Thanks for the submission, this looks good.
Regarding this also living in 777, I think this is worth bringing in on its
own, given the nature of the fix.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
Now that there is a feature branch there should be.
This is the commit that has grok working with hdfs, obviously based on 777.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Is it possible to submit smaller PRs for fixes like these that you've
already done? I'm sure there are several like this in your feature branch that
are valuable. It would also make it easier to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/729
This is also fixed in the feature branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Is `/apps/metron/patterns/tmp` a reasonable place to keep temporary grok
files? Is there another location that would be better?
---
If your project is set up for it, you can reply to this email
13 matches
Mail list logo
