Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/795
+1 It looks great. Thanks!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
Alright, changes included. Did I miss anything @nickwallen ?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
Alright, great reviews. I think I have reacted to the comments; let me
know if I missed anything.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/795
I tested this thoroughly and everything works as expected. I made one
small comment that I feel is optional. This is an awesome PR. +1
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
Looks ok. I also ran it in my personal travis and the tests stabilized
with the latest commit.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
I'm going to close and reopen this a few times to see if the instability in
the tests are worked out.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/795
TESTING PLAN
# Preliminaries
Setup some environment variables for convenience:
* `export METRON_HOME=/usr/metron/0.4.1`
* `export ZOOKEEPER=node1:2181`
* `export
