Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Great. I will get this PR merged. I am glad to see that this one is ready
to go.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
I agree. I'm fine with going ahead with this, but I'd like to see end to
end stability being addressed as the next UI priority, which I believe
@iraghumitra is already doing some work on.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I agree with @nickwallen. I think we're good to merge this as long as e2e
tests are being addressed in a separate PR. +1
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
+1
I'd like to see sign-off from at least one other committer (if not more)
before this gets merged.
I previously outlined the manual functional testing that I performed. All
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra Can you describe how you install Node/NPM on your development
box? I want to install using the same mechanism (and versions) and see if I
can get the e2e tests all working like you.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Just a quick update... I was working with @iraghumitra yesterday on getting
the e2e tests to pass for me. It seems that with older versions of NPM the
tests do pass, but then only various shades
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen This is unfortunate I am not seeing these failures
Spec started
login to application
â should display error message for invalid credentials
â should
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra Are all these e2e tests passing for you? I am still getting
failures. I manually truncated the `metron_updates` table before running them
also.
```
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Added the test case for searching an alert inside meta-alert.
Also took the liberty to fix the timezone issue it was a one-liner.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
Most of the functional tests worked for me as well. I was able to get the
e2e tests to pass after several runs with the exception of a time picker test
that I believe is due to a timezone issue
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
IMHO I think the functionality is good on this PR. There are 3 functional
tests that failed, but they are minor and can be addressed after we get this PR
in.
My only hold-up right now
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen can you raise a jira to track this. I guess even if we are able
to reproduce I highly doubt if it is bcoz of changes in this PR.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I agree, unless I'm missing something, it seems like a bug with
recent searches, since you didn't say searches were weird during the initial
attempts.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet @iraghumitra I am glad that no one else can reproduce. I will
work on trying to get a set of steps to reproduce this. Let's not worry about
this on the current PR.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen That looks wicked can you share your manual steps that lead to
this?
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I haven't been able to get into the same sort of state, but I
know you've used/tested the UI more than me. Do you know a repeatable way to
reproduce this? Or have you been able to
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Something seems to be wrong with saved searches. When I run through a
manual test script of creating metaalerts, deleting and navigating, most (if
not all) of my saved searches are these giant
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Thanks for
https://github.com/iraghumitra/incubator-metron/pull/5. It was a pretty
significant issue. I merged the fix ð
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
> I am not refreshing on purpose. If I refresh the UI after any operation
users would lose the current context and see new alerts (If available).
Ok @iraghumitra. Since you have a valid
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I am not refreshing on purpose. If I refresh the UI after any
operation users would lose the current context and see new alerts (If
available). If you think this is not a major
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Hi @iraghumitra - The UI does not refresh itself after a metaalert is
deleted. If this is something easy to fix, let's tackle it. Otherwise, I can
create a JIRA to track this and we can fix it
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I noticed that when I am running e2e test's, the comments that were added
in the previous run are still visible at times. The e2e tests delete's all the
comments that it added and the only way
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet Thanks for taking time to test the PR. I was using an incorrect
index to find the alert to delete when I implemented the new API's I fixed it
now. Also added tests for all the issues
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet my bad. The search query to fetch all the alerts in a group was
returning a nested object since I was passing 'source: type' twice in the
fields. I don't know why I was getting a
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet my bad. The search query to fetch all the alerts in a group was
returning a nested object since I was passing 'source: type' twice in the
fields. I don't know why I was getting a
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I've verified the bug reported by Justin happens when you create a meta
alert from a group that is nested by more than 1 level. Creating a meta alert
from a top level group works.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
That's weird @justinleet . The create request is working for me. I'll
mess with it some more and try to replicate what you are seeing.
I am seeing a separate issue on the REST UI side.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra looks like the new API isn't being used quite right.
Sample from the dev tools
```
{
"alerts": [
{
"guid":
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
Merged the PR with master and used new API's for creating meta-alerts.
Please feel free to review and let me know the feedback.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra I see that you merged some changes. Is this ready to test?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Hi @iraghumitra - I'd like to see your work get in ASAP. Can you merge
with master when you get a chance?
Also, I think you need to make some updates based on recent PRs that have
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Looks like the following rest-api's are not working as expected
- When a meta alert is created and when we try to group by an IP
address(ip_dst_addr/ip_src_addr) the IP address is
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
Yes HBase is running. The first set of status tests are working (they
would not if HBase were down).
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr is HBase running these errors are typically seen when HBase is
down.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr METRON-1272 has broken few of our assertions and these are
cascaded failures bcoz of them. I am working on fixing them.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I am consistently getting these e2e test failures:
```
1) meta-alerts workflow should have all the steps for meta alerts workflow
- Error: Timeout - Async callback was not invoked
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I had to force push the last merge since I was facing issues with github.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I added a single test case which covers the entire workflow of meta-alert.
I couldn't think of a way to decompose it into smaller cases without making
them dependent on each other. Any
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
I was testing #811 along with the changes in this PR and noted an issue.
It appears that the UI does not refresh itself after a meta-alert is created.
1. First, I isolate 10 alerts with
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
Potentially we want to expose some abstraction for the ES options for
missing field sorting (that I admittedly don't know exist in Solr).
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I just submitted a
[PR](https://github.com/iraghumitra/incubator-metron/pull/3) against this PR
that addresses all of the bugs reported above except 1:
- when metaalerts and alerts are in
Github user james-sirota commented on the issue:
https://github.com/apache/metron/pull/803
You should not have empty meta alerts. That does not make sense
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I did an initial review of this and I see several things we need to work
through. It's a pretty significant feature so that's not surprising. I know
there are some other PRs being worked on that
43 matches
Mail list logo
