[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2018-02-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/863 My +1 still stands on this and this PR has been up for quite some time. I will merge by EOD unless there are any additional concerns. ---

[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2018-01-11 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/863 Are all questions on required fields resolved per @cestella's comments/clarification? ---

[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2017-12-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/863 Actually, I don't think `original_string` is required past the parser topology. For instance, profiler messages into enrichment do not have `original_string`. ---

[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2017-12-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/863 The minimum required fields, as far as I can see right now are source.type, original_string and timestamp. Given the use case for this is something that has skipped the parser topology, we

[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2017-12-13 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/863 I would like to hear feedback from @ottobackwards on other required fields but this looks good to me otherwise. ---