[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/824 ---

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-15 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r151203066 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/MetaAlertController.java --- @@ -60,5 +63,37 @@ ) throws

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150998084 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -138,9 +142,17 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150995571 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -138,9 +142,17 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150994812 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -138,9 +142,17 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150892216 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150889867 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150887809 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150874132 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150872247 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150868283 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150867558 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150866003 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150854643 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150644110 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java --- @@ -200,4 +207,23 @@ public

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-13 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150641377 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java --- @@ -200,4 +207,23 @@ public

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150628792 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/MetaAlertController.java --- @@ -60,5 +63,37 @@ ) throws

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150638251 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java --- @@ -200,4 +207,23 @@ public

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-10 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150239607 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/MetaAlertController.java --- @@ -60,5 +63,37 @@ ) throws

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150239332 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -256,59 +256,91 @@ public

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-10 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150230733 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -256,59 +256,91 @@ public

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149423305 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/IndexDao.java --- @@ -65,6 +65,8 @@ */ Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149422318 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java --- @@ -29,6 +29,7 @@ public static final String

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149423194 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -121,13 +121,16 @@ public synchronized

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149423571 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/IndexDao.java --- @@ -65,6 +65,8 @@ */ Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-01 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/824 METRON-1289: Alert fields are lost when a MetaAlert is created ## Contributor Comments This PR fixes a bug in the ElasticsearchMetaAlertDao that incorrectly updates the included alerts. To