Re: Site-book broken in master

2018-12-20 Thread Michael Miklavcic
Thanks Otto. Moving this discussion to a DISCUSS thread and closing out the PR now. On Thu, Dec 20, 2018 at 11:00 AM Otto Fowler wrote: > https://github.com/oasp/asciidoc-link-checker > > > On December 20, 2018 at 12:59:39, Otto Fowler (ottobackwa...@gmail.com) > wrote: > > +1 for merging a

Re: Site-book broken in master

2018-12-20 Thread Otto Fowler
https://github.com/oasp/asciidoc-link-checker On December 20, 2018 at 12:59:39, Otto Fowler (ottobackwa...@gmail.com) wrote: +1 for merging a fix. On December 20, 2018 at 12:43:57, Michael Miklavcic ( michael.miklav...@gmail.com) wrote: Thanks for the feedback Otto. I'm not too familiar

Re: Site-book broken in master

2018-12-20 Thread Otto Fowler
+1 for merging a fix. On December 20, 2018 at 12:43:57, Michael Miklavcic ( michael.miklav...@gmail.com) wrote: Thanks for the feedback Otto. I'm not too familiar with our infrastructure afa impact of switching to ascii doc, but I think it's worth considering if it allows us to have a

Re: Site-book broken in master

2018-12-20 Thread Michael Miklavcic
Thanks for the feedback Otto. I'm not too familiar with our infrastructure afa impact of switching to ascii doc, but I think it's worth considering if it allows us to have a consistent rendering markdown that's easy to use. Automated link testing is a good idea. I wonder if Cypress could do that

Re: Site-book broken in master

2018-12-19 Thread Otto Fowler
What would help is an automated test the tests all the links as well. On December 19, 2018 at 19:55:03, Michael Miklavcic ( michael.miklav...@gmail.com) wrote: I'd also like to submit a call for suggestions for making this process simpler. I think we've made some excellent progress towards

Re: Site-book broken in master

2018-12-19 Thread Otto Fowler
Maybe we should consider ascii doc, it shows in github, and can generate multiple formats. On December 19, 2018 at 22:49:26, Otto Fowler (ottobackwa...@gmail.com) wrote: What would help is an automated test the tests all the links as well. On December 19, 2018 at 19:55:03, Michael Miklavcic

Re: Site-book broken in master

2018-12-19 Thread Michael Miklavcic
I'd also like to submit a call for suggestions for making this process simpler. I think we've made some excellent progress towards getting an html-generated version of our documentation, but it's also proving to be somewhat error-prone. Github and Doxia have different expectations as to

Re: Site-book broken in master

2018-12-19 Thread Michael Miklavcic
Fix is out in this PR: https://github.com/apache/metron/pull/1309 Jira: https://issues.apache.org/jira/browse/METRON-1950 It ended up being a bit bigger than I hoped because we had some remaining incompatibilities between our Github markdown and the Doxia-expected formatting. This caused a