[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 *[bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java, line 117 at r2](https://reviewable.io:443/reviews/apache/metr

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 *[bundles-lib/src/main/java/org/apache/metron/bundles/VFSBundleClassLoader.java, line 174 at r2](https://reviewable.io:443/reviews/apache/metron/530#-Kr

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 *[bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java, line 255 at r2](https://reviewable.io:443/reviews/apache/metron/530#-Kr7wzD

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 *[bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java, line 43 at r2](https://reviewable.io:443/reviews/apache/metro

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 @JonZeolla Thanks for the review! There are several questions in the description that I think need to fall out of the review, one of them is where or how to document this. Any ideas

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/667 @cestella are we all set with the changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 I have refactored the BundleThreadContextClassLoader, and removed the mechanics around initializing it. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/690 Some ideas: * Where should the doc for this go? * I would suggest under [here](https://github.com/apache/metron/tree/master/metron-stellar/stellar-common#stellar-shell). * Do we w

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132856076 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java --- @@ -208,6 +240,12 @@ public void

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132855988 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + * License

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132855925 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + * License

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132856045 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/common/utils/EpochUtilsTest.java --- @@ -0,0 +1,50 @@ +/** + * Lic

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132855961 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + * License

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132855920 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + * License

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-13 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/692 Also, I did notice a couple of things when poking around that probably fit best into some new JIRAs that I at least wanted to mention here: * It's somewhat unintuitive that we count [starting at

[GitHub] metron pull request #693: METRON-739 Create Local Profile Runner

2017-08-13 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/693 METRON-739 Create Local Profile Runner Troubleshooting issues when programming against a live stream of data can be difficult. This is the primary reason that drove the creation of the REPL. S