See inline.
> Now, Laurens, two question for you: First, please confirm: Are you setting
> the value of masters_also_are_datanodes via the masters_also_are_datanodes
> field in the Ambari configuration GUI? Or directly editing files?
I'm using Ambari to edit the configuration. However, I h
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/752
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/734
@merrimanr Are you still +1 after the most recent changes before I commit
this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/439
If we are not working on this, maybe we can close the PR and resubmit
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/668
There are conflicts with this PR, can we get them resolved?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/737#discussion_r138506984
--- Diff:
metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.ts
---
@@ -409,12 +403,17 @@ export class
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/737#discussion_r138506828
--- Diff:
metron-interface/metron-config/src/app/sensors/sensor-parser-config-readonly/sensor-parser-config-readonly.component.spec.ts
---
@@ -301,7 +
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/750
Looks great. Just a couple of nits, but otherwise LGTM +1.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/750#discussion_r138506239
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -60,7 +60,7 @@ functions can be used from everywhere where Stellar is
used.
* Desc
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/750#discussion_r138506017
--- Diff:
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/StellarStatisticsFunctions.java
---
@@ -141,8 +141,21 @@ publi
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/751
+1 by inspection. This is good stuff @cestella!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/752
thanks @justinleet
---
We are using Elasticsearch version 2.3.3.
https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-node.html
is very clear that the value of node.data in 2.3 should be either “true” or
“false” (as the Boolean, not a quoted string).
The default (and necessary) value of node.master
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/752
I'm +1 by inspection, assuming all goes well with Travis. The changes
outside of a pure merge look pretty minor
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/752
METRON-1136 [Feature Branch] Merge master 9/12
This PR merges master as of this time 9/12, and fixes any merge issues.
## Testing
This is a non-regression check
[ ] Builds
At the very least, the value provided by default seems to have changed to a
"1" instead of "true" without the tooltip having been updated to match.
[image: Inline image 1]
On Tue, Sep 12, 2017 at 4:00 PM, Michael Miklavcic <
michael.miklav...@gmail.com> wrote:
> I think this is our default setup
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/748
Thanks. We are still testing so I'll hold off on committing it. I think we
found some other items to address.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/748
Oh man, after looking at this it dawns on me that a dependency tree
analyzer for the Ambari role command order would be extremely useful.
+1 by inspection. Thanks for fixing this @nickwallen
I think this is our default setup for full dev. It's only a 1-node VM, so
I'm pretty sure that it would not work otherwise. I'm spinning up full dev
now and will look into it also.
On Tue, Sep 12, 2017 at 3:04 PM, Laurens Vets wrote:
> https://issues.apache.org/jira/browse/METRON-1181
>
> I'll
https://issues.apache.org/jira/browse/METRON-1181
I'll also spin up a full-dev environment and see what happens there.
On 2017-09-10 21:50, Matt Foley wrote:
Laurens, please open a jira. Altho it may seem obvious, please
include full repro.
This may be a showstopper, as it presumably (?) preve
+1 (binding)
Deployed to Full Dev and AWS successfully.
On Sun, Sep 10, 2017 at 10:30 PM zeo...@gmail.com wrote:
> +1 (binding)
>
> - Verified the signature
> - Verified all hashes
> - mvn -q -T 2C surefire:test@unit-tests && mvn -q
> surefire:test@integration-tests && mvn -q test --projects
>
I have no idea how this happened, but it is fixed now.
- I've removed Ambari Metrics and reinstalled it again on a different
host.
- Rebooted all Metron nodes
After this, the login works again.
On 2017-09-12 08:15, Laurens Vets wrote:
This seems to be related to Ambari Metrics somehow which
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/727
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/727
+1 by inspection, great job!
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/751
METRON-1180: Make Stellar Shell accept zookeeper quorum as a CSV list and
not require a port
## Contributor Comments
ZK Quora do not require a port (it defaults to 2181) and it may be a comma
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/749
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/746
+1 by inspection. Thanks @JonZeolla
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/750
METRON-1179: Make STATS_ADD to take a list
## Contributor Comments
While we can add multiple values in `STATS_ADD` via `STATS_ADD(s, 1, 2,
3)`, but it'd be nice also to support `STATS_ADD(s, [1
This seems to be related to Ambari Metrics somehow which I've put in
Maintenance Mode because it's not working. Can I safely delete Ambari
Metrics to see whether this is indeed the problem?
On 2017-09-11 16:21, Laurens Vets wrote:
Hi list,
I have a strange issue suddenly... Ambari lets me log
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/727
+1 by inspection
---
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/727
Thanks very much @ottobackwards !
@nickwallen , pushed latest commit with the functions renamed. Please have
a look.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/749
I spun this up in full dev and it worked as expected. Thanks for the
contribution. +1
---
I have a couple of PR’s either on or related to the feature branch, and it
would be nice
if I could get a review.
Ryan is reviewing 749 already.
I would like to get these straight, so I can take master ( with RC 4 ) and
resolve the grok handling conflicts etc
and prepare my UI for Extensions PR.
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/727
Hi @nickwallen thank you. Sure, I see value in simplifying the naming. How
does `TO_JSON_OBJECT`, `TO_JSON_MAP` and `TO_JSON_LIST` sound?
---
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138362926
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(var.l
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138362754
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(var.l
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138362883
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(var.l
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138362796
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -506,29 +506,27 @@ public Objec
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138362605
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(var.l
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/727
I have not reviewed the code, but I definitely like the functionality
@anandsubbu . What do you think about simplifying the name to `TO_JSON` or
something like that?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138315063
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(va
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138315393
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(va
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138314713
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(va
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138314605
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -506,29 +506,27 @@ public Ob
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138315823
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(va
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/727#discussion_r138315694
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java
---
@@ -550,4 +548,90 @@ else if(va
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/727
@ottobackwards and @cestella please have a look at the latest commit.
---
47 matches
Mail list logo
