Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/762
The latest commit merges in master and addresses your feedback
@iraghumitra. I solved the issue in my previous comment by pausing anytime a
checkbox is checked and resuming when all checkboxes
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/771
METRON-1204: UI does not time out after being idle, but stops functioning
## Contributor Comments
This fix was verified running the Alerts UI against full dev. To test this
fix, spin up full
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/681#discussion_r140489936
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -251,6 +251,142 @@ public
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/757
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/762
@merrimanr I uncovered the issue when I was trying to integrate METRON-1189
to METRON-1123. I handled it in PR #768, the fix is to empty the selection list
whenever we get new data. This would
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/681
@cestella and @mattf-horton Do we care about the Infinity cases and
presumably an `IS_INFINITE()` in this PR, or are we okay with holding off until
a follow on is made?
Other than that
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/681
I'm on the side of holding off for an eventual follow-on regarding that
question, for the record.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/681
done
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/769
+1 by inspection. Thanks!
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/757
Merged in master for extremely minor deconflict of `rest_commands.py` for
imports added on the same line.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/681
@ottobackwards Could you deconflict this? It seems like semantic
conversation died down and hopefully we're at least mostly set since `IS_NAN()`
got added.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/681#discussion_r140493668
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -251,6 +251,142 @@ public
For the life of me, I can’t see where the actual score is set into the
rule, besides the stellar functions.
I am looking at the ThreatTriageProcessor::apply method.
Does anyone know how the score gets set?
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/770
Even if CI succeeds, please hold off on merging, I suspect that integration
tests may be a bit too timing dependent.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/770
@nickwallen Updated the PR. The integration tests's initial doc check can
be timing sensitive, which was masked by the bogus `Thread.sleep` in the
`ElasticsearchDao`. Updated the test to
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/770
METRON-1202: ElasticsearchDao Has extraneous sleep call
## Contributor Comments
Less sleep and pointless test call, more performance.
Spin it up. Issue a patch, make sure it's not
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/770
+1 (assuming CI success)
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/770
+1 Looks good.
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/770
---
19 matches
Mail list logo
