[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141797749 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private HttpStatus

[GitHub] metron issue #779: METRON-1218: Metron REST should return better error messa...

2017-09-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/779 sorry, one small nit. ---

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141840699 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141844398 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141861097 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141862571 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141869253 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

Re: [DISCUSS] Meta alert Elasticsearch new template requirement ramifications

2017-09-29 Thread Justin Leet
I put up a preliminary PR at https://github.com/apache/metron/pull/780. As noted there, this should almost certainly be under a different heading, and possibly a different README, so feel free to chime in on that. Primary goal is to make sure the content makes sense and get adjustments as needed.

[GitHub] metron pull request #781: METRON-1052:

2017-09-29 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/781 METRON-1052: ## Contributor Comments This is a follow-on to METRON-539. Currently we have Stellar functions to perform cryptographic hashing operations. It would be useful to expand this to

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/768 I don't understand how this is not picking up the management pack integration for alerts? I don't see it in ambari ---

[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...

2017-09-29 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/771 @ottobackwards should we push that as a follow up issue for now rather than expanding the scope of this PR? ---

Re: [DISCUSS] Meta alert Elasticsearch new template requirement ramifications

2017-09-29 Thread Otto Fowler
We can also consider this when thinking about creating parsers with archetypes that contain ‘default’ elasticsearch templates. On September 29, 2017 at 10:00:03, Justin Leet (justinjl...@gmail.com) wrote: As part of building a backend for meta-alerts (

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141860594 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-09-29 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/768 @ottobackwards Done please have a look ... ---

[DISCUSS] Meta alert Elasticsearch new template requirement ramifications

2017-09-29 Thread Justin Leet
As part of building a backend for meta-alerts ( https://github.com/apache/metron/pull/734), there's an additional requirement for the Elasticsearch templates for new sensors. Although seemingly minor, this should be called out explicitly because of the wider implications of leaving it out of ANY

[GitHub] metron issue #775: [METRON-1214] rpm build fails due to npm absence in Docke...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/775 How would you reproduce this? I have not been seeing failures. ---

[GitHub] metron pull request #781: METRON-1052: Add forensic similarity hash function...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/781#discussion_r141931953 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java --- @@ -0,0 +1,203 @@ +/* + *

[GitHub] metron pull request #781: METRON-1052: Add forensic similarity hash function...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/781#discussion_r141933534 --- Diff: metron-stellar/stellar-common/pom.xml --- @@ -51,6 +52,11 @@ --- End diff -- Yep, added

[GitHub] metron pull request #781: METRON-1052: Add forensic similarity hash function...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/781#discussion_r141919312 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java --- @@ -0,0 +1,203 @@ +/*

[GitHub] metron pull request #781: METRON-1052: Add forensic similarity hash function...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/781#discussion_r141920133 --- Diff: metron-stellar/stellar-common/pom.xml --- @@ -51,6 +52,11 @@ --- End diff -- Does

[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/771 This brings up the issue with having 'split' these uis. They have common things that we shouldn't have to duplicate in each application. ---

[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/771 definitely ---

[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...

2017-09-29 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/771 +1 works as described ... ---

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141971685 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private HttpStatus

[GitHub] metron pull request #681: METRON-1079 Add NaN as a keyword in STELLAR langua...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/681 ---

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141968868 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141971177 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private HttpStatus

[GitHub] metron issue #681: METRON-1079 Add NaN as a keyword in STELLAR language

2017-09-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/681 me too, +1 ---

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-09-29 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/768 @ottobackwards can u check it now I merged master again looks like mpack is in now. ---

[GitHub] metron pull request #781: METRON-1052: Add forensic similarity hash function...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/781#discussion_r141944809 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java --- @@ -0,0 +1,203 @@ +/* + *

[GitHub] metron issue #781: METRON-1052: Add forensic similarity hash functions to St...

2017-09-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/781 Let me write up a step-by-step use-case doc and I'll call this one done. ---

[GitHub] metron issue #781: METRON-1052: Add forensic similarity hash functions to St...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/781 +1 by inspection, really nice. ---

[GitHub] metron issue #681: METRON-1079 Add NaN as a keyword in STELLAR language

2017-09-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/681 Yeah, I'm ok with that. ---

[GitHub] metron issue #781: METRON-1052: Add forensic similarity hash functions to St...

2017-09-29 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/781 FUZZY_SCORE and BLOOM_*. Is it worth trying to unify these similarity-recognizers with similarity hash, or are they too far apart in terms of expected use patterns? ---

[GitHub] metron issue #781: METRON-1052: Add forensic similarity hash functions to St...

2017-09-29 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/781 Altho I suppose the "Locality-Sensitive" part of TLSH means it operates at word level instead of byte or character level? ---

Re: [DISCUSS] Meta alert Elasticsearch new template requirement ramifications

2017-09-29 Thread Rita McKissick
Hi Justin, I am adding the nested “alert" field requirement to the product documentation, and I had a question: * If the user opts to use the default configuration, will they still need to add the nested “alert” field? When I’m finished with the documentation, I’ll send you a link to make

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141974727 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron issue #781: METRON-1052: Add forensic similarity hash functions to St...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/781 Ok, I have not worked through the doc, but it looks good to me. I can stop thinking about how this relates to FUZZY_SCORE. ---

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/768 I cannot get this to vagrant up: > MANY OF THESE -> metron-config.noarch: E: script-without-shebang /usr/metron/0.4.1/web/expressjs/node_modules/repeat-string/package.json

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141975467 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-09-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/768 Let me be more clear, sorry. Vagrant up doesn't work. If I do ```bash % metron-deployment> mvn package -DskipTests -P build-rpms ``` I get these errors in the

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141991874 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private HttpStatus