Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
There are also shuffle groupings in the enrichment and profiler topologies.
Do we want to update those too?
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/952
I'm having trouble understanding what this PR actually does. I see that
package-lock.json was removed and yarn.lock was added. Is that all that's
needed to switch to yarn? Do we need to also
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
although it should work with npm as well, cause then it will use the
package.json to install the dependencies.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172934046
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172936489
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/952
I think we are on board with switching to yarn so no concerns there. There
was a discussion on it but if anyone now feels differently, speak up.
Sounds like we still have a lot of work to
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
Yes this is the right way to switch to yarn.
Yes we have install yarn locally.
I did not know that we have so much dependency on npm. But for me it was
hard to add new
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
---
Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172932830
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172937150
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user xyztdanid4 closed the pull request at:
https://github.com/apache/metron/pull/955
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/956
METRON-1474 Add normalizecss
## Contributor Comments
This PR adds normalizecss to the frontend projects. It is useful to bridge
the differences between browsers.
## Pull
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/957
METRON-1482: Update REST to work with Solr
## Contributor Comments
This PR updates the REST start script to properly include the correct
indexing jar on the classpath depending on the
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
I still see a SHUFFLE grouping (spout -> enrichmentSplit) in the legacy
enrichment topology flux file. Maybe we end up switching to the new enrichment
topology so not important in that case.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
@wardbekker Did you test this with Kibana by chance? I'm seeing
authentication exceptions in the Kibana UI. Looks like we need additional steps
for it to work -
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172927486
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172927751
--- Diff: metron-interface/metron-alerts/package.json ---
@@ -27,8 +27,8 @@
"core-js": "^2.4.1",
"font-awesome": "^4.7.0",
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@simonellistonball I am not sure. Probably no.
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/955
METRON-1474 Add normalizecss
THIS IS WIP. FIRST #952 SHOULD BE MERGED.
## Contributor Comments
This PR adds normalizecss to the frontend projects. It is useful to bridge
the differences
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/952
Have the dependencies, License and Notices files been updated?
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/944
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172858774
--- Diff: metron-interface/metron-alerts/package-lock.json ---
@@ -1,6427 +0,0 @@
-{
--- End diff --
I suspect the build failure is due to
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/955
Have the dependencies, License and Notices files been updated?
---
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/953
Have the dependencies, License and Notices files been updated?
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/940
---
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/951
@ottobackwards
In my next PR the build tool will change to yarn. So package.json will be
gone soon, and replaced by yarn.lock which is smaller of course.
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/952
Metron-1480 Add yarn as default build tool for the frontend
Updated the build tool to yarn for the frontend project to avoid npm
instability during dependency adding.
### For all
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/951
@ottobackwards
I am not sure, but the I guess this is the normal way of locking
dependencies.
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/953
Metron 1472 Add stylelint support
THIS IS WIP. FIRST #952 SHOULD MERGED.
Added support for stylelint to be able to validate scss syntax.
## Pull Request Checklist
Thank
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/951
Why are there so many changes to the package locks vs. to the package files
themselves?
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/954
METRON-1478 Move type definitions to dev-dependencies
## Contributor Comments
Types definitions should not be in dependencies. I moved them to
dev-dependencies.
## Pull Request
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/945
@merrimanr you ran this up in Solr 5.5 as well as 6.6, right? If so, then
I'm content with the change and give a +1 pending (other than holding for an
answer to Simon's question, which I was
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/945
To be fair, my question is probably just as appropriate on a discuss thread
and a separate ticket out of said thread if it comes to it.
---
Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172879403
--- Diff: metron-interface/metron-alerts/package-lock.json ---
@@ -1,6427 +0,0 @@
-{
--- End diff --
I think that was the problem!
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/947#discussion_r172866140
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java
---
@@ -89,29 +91,25 @@ public void
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/947#discussion_r172870992
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/JoinBolt.java
---
@@ -89,29 +91,25 @@ public void prepare(Map
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/947
+1 LGTM
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/951
Metron-1479 Introduce editorconfig, and format all of the code in alerts
and config projects
It is necessary to use editorconfig, code should be look like the same in
all files.
###
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/947
---
39 matches
Mail list logo
