[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults

2017-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/547 ok, I tried this and was flumoxed by nonexistent directories or files: - cat << EOF >> /usr/share/bro/site/local.bro ( bro/site doesn't exist ) - sed -i 's/eth0/tap0/g' /usr/et

[GitHub] metron pull request #598: METRON-974 Document How to Run Stellar REPL From S...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #598: METRON-974 Document How to Run Stellar REPL From Source C...

2017-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/598 +1, followed the steps --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] metron pull request #601: METRON-977: metron-statistics enrichment example u...

2017-05-31 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/601 METRON-977: metron-statistics enrichment example uses old indexing syntax https://issues.apache.org/jira/browse/METRON-977 Doc fix to reflect the new syntax for enrichment and indexing json

[GitHub] metron pull request #507: METRON-819: Document kafka console producer parame...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-31 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/507 +1 look great. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: METRON-777

2017-05-31 Thread Justin Leet
I know I'd like people (probably myself included) to start digging in. I'm in a bit of the same boat where I'll have to do some work (a lot?) to familiarize myself better with everything to properly review it, but hopefully if we have a few sets of eyes looking at it we'll get everything squared a

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-31 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/507 I'm +1, by inspection. I think this covers it. I'll let @nickwallen double check if there's anything else. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/507 Ok, I grabbed the latest master branch and force pushed out a new commit with the doc changes to this branch. @nickwallen @justinleet can you take a peek at this and see if there isn't anyt

[GitHub] metron pull request #595: METRON-964: Add logging in JoinBolt for unexpected...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

METRON-777

2017-05-31 Thread zeo...@gmail.com
I was wondering, is anybody planning to or currently taking a look at Metron 777? I think this is a great contribution and very important to improving the usability of the platform (along with some of it's follow on PRs). I would be happy to help with functional testing and security static code a

[GitHub] metron pull request #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEX...

2017-05-31 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/600 METRON-976 KafkaUtils doesn't handle SASL_PLAINTEXT ## Contributor Comments Used @cestella's original implementation before I apparently foolishly assumed we'd get Java compliant URIs. See:

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/507 @justinleet - I'm changing this entirely per @nickwallen's comments about the jaas file. Coming shortly. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron issue #577: METRON-746: Build Custom Checkstyle and IDE formatting se...

2017-05-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/577 @justinleet nothing in particular - what I noticed was that auto-formatting would format me right into breaking the checkstyle checks. I'd like to figure out how to get the two working consistently.

[GitHub] metron issue #599: METRON-975: Normalize logging and switch to common idiom ...

2017-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/599 I will give you real imaginary money to rebase this onto METRON-777 so I don't have to port ;) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] metron pull request #572: METRON-633: Create better logging for HbaseEnrichm...

2017-05-31 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/572#discussion_r119442810 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java --- @@ -169,16 +188,19 @@ pu

[GitHub] metron issue #572: METRON-633: Create better logging for HbaseEnrichmentWrit...

2017-05-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/572 Agreed with @justinleet about switching away from isDebugEnabled(). Except for instances where you're doing something that has a fair amount of overhead in evaluating the pre-formatted strings, usin

[GitHub] metron pull request #599: METRON-975: Normalize logging and switch to common...

2017-05-31 Thread mmiklavc
GitHub user mmiklavc reopened a pull request: https://github.com/apache/metron/pull/599 METRON-975: Normalize logging and switch to common idiom with SLF4J https://issues.apache.org/jira/browse/METRON-975 We currently have a mixture of logging approaches scattered throughout

[GitHub] metron issue #599: METRON-975: Normalize logging and switch to common idiom ...

2017-05-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/599 Kick Travis - rest api test failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #599: METRON-975: Normalize logging and switch to common...

2017-05-31 Thread mmiklavc
Github user mmiklavc closed the pull request at: https://github.com/apache/metron/pull/599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] metron pull request #599: METRON-975: Normalize logging and switch to common...

2017-05-31 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/599 METRON-975: Normalize logging and switch to common idiom with SLF4J https://issues.apache.org/jira/browse/METRON-975 We currently have a mixture of logging approaches scattered throughout t

[GitHub] metron issue #526: Metron-846: Add E2E tests for metron management ui

2017-05-31 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/526 Yeah got busy with other stuff I will jump on to this ASAIC --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #572: METRON-633: Create better logging for HbaseEnrichmentWrit...

2017-05-31 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/572 Can you use parameterized messages for the various log statements or `logger.isDebugEnabled()`, rather than constructing the strings every time? The common case is for this to not be run, so I'd