[GitHub] metron pull request #676: METRON-1072: Cleanup Maven build warnings

2017-08-01 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/676 METRON-1072: Cleanup Maven build warnings https://issues.apache.org/jira/browse/METRON-1072 ## Contributor Comments This one is pretty straightforward. Our build outputs a large am

[GitHub] metron pull request #662: METRON-1056: Get field types from Elasticsearch

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #662: METRON-1056: Get field types from Elasticsearch

2017-08-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/662 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] metron pull request #662: METRON-1056: Get field types from Elasticsearch

2017-08-01 Thread james-sirota
Github user james-sirota commented on a diff in the pull request: https://github.com/apache/metron/pull/662#discussion_r130675495 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/IndexingDaoIntegrationTest.java --- @@ -27,28 +28,32 @@ imp

[GitHub] metron pull request #628: METRON-1011 Enforce submission of 4 params Stellar...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron pull request #599: METRON-975: Normalize logging and switch to common...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #599: METRON-975: Normalize logging and switch to common idiom ...

2017-08-01 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/599 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] metron pull request #675: METRON-379 STELLAR can differentiate between a val...

2017-08-01 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/675 METRON-379 STELLAR can differentiate between a value passed as null and a value not passed That being that there IS a variable at all vs. there is a variable, and its value is NULL.

[GitHub] metron issue #674: METRON-681 CSVConverter should trim key and values

2017-08-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/674 @basvdl please be sure to take care of the jira --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] metron pull request #674: METRON-681 CSVConverter should trim key and values

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #674: METRON-681 CSVConverter should trim key and values

2017-08-01 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/674 +1, looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

Re: Java Code style is now Google Java Style Guide

2017-08-01 Thread Justin Leet
The wiki at Development Guidelines has been updated, please take a look and if any updates are required, feel free to reply and I'll update the page. Justin On Mon, Jul 31, 2017 at 10:23 PM, Justin Leet wrote: > Hi all,